From nobody Thu Dec 25 10:53:16 2025 Received: from mail-wm1-f45.google.com (mail-wm1-f45.google.com [209.85.128.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BA70A5665 for ; Thu, 18 Jan 2024 02:51:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.45 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705546309; cv=none; b=makS9VyNqNU5TXIT4ytnILol0qKSH3Joxr1hdX8PqRiZd8TVF5bkgX3iLOBpR7v6XSmPT7QC3faKcbfdPSgkirTNI/T6EhsahgqlLkHFlxfoHSVwx3Y9zV0seOF/gMOSO7lqtwvlSBILvg9XvP3LvL/OTVWmTE8TsCplWuaKTOk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705546309; c=relaxed/simple; bh=HHNvB7NqaX4iGz7NhjxGduwMzlm/JxAKon+6MvQQ7tQ=; h=Received:DKIM-Signature:X-Google-DKIM-Signature: X-Gm-Message-State:X-Google-Smtp-Source:X-Received:Received:From: To:Cc:Subject:Date:Message-ID:X-Mailer:In-Reply-To:References: MIME-Version:Content-Type:X-Mailer:X-Developer-Signature: X-Developer-Key:Content-Transfer-Encoding; b=kI7TA55ArcpF2Y9y0xt+YSky+h//kppO/khaJu5NSQ6yuo1bjkQQkYqI+F4CANyrM0cqsjL1iIyzvmPpJT4C1g7IWS4cr/EKOg5mDOuFaldtkFL7lnmKtr1/8Z9UJnojTSAk2AfkQLF6fBjMOIk6ldeBPIph8kP6aHu2+pdDRms= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=arista.com; spf=pass smtp.mailfrom=arista.com; dkim=pass (2048-bit key) header.d=arista.com header.i=@arista.com header.b=ib315mbV; arc=none smtp.client-ip=209.85.128.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=arista.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arista.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=arista.com header.i=@arista.com header.b="ib315mbV" Received: by mail-wm1-f45.google.com with SMTP id 5b1f17b1804b1-40e779f030aso1483915e9.0 for ; Wed, 17 Jan 2024 18:51:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arista.com; s=google; t=1705546305; x=1706151105; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=zhoYD3VTX6Mw3R+QWgSNnaN7EGj7heKEidij6gCGH3I=; b=ib315mbVRv3Bunh0vpyiLCp2/A25bKOgoyaSZhTqUF6S0i6rY8BPMGccT2/EhgBCjJ TGlTGea+4/1I4bJuQeq2+NR0F95swbCfDeW6EvAUvy7SRcPRlUd4mzxpNXN304ccjuHk umLKark19Czyyt4ctwq2Kt3I6R+Fe58t8RJIyZPRpTCow7PHzt+4g3NVkHKxcMFgPNId zBN4iXQqVTMZSruaQakT6P24zXxAqOlunna+yFtNf087gMSca7GDN9pw1glPy9KOOrWN wg39fnJzz3adMwncb0S1Mr7Q7b5xdIb/M9zcZLLciugWJJwfdsJ+GlaszVCu3qoLcrOv 4BjA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705546305; x=1706151105; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=zhoYD3VTX6Mw3R+QWgSNnaN7EGj7heKEidij6gCGH3I=; b=SVRGldKxlTnm1FRxXMh3foDI6a9NlY9XVy7piC5iWtDamh+0H6IuTE/xPEz0qaXGJp OR1+esvx2pu3kNgmt2lkoQMxVEg6EKUbKh/Twczxboaf0TlReZK9Bx947pVROs+n9Fmx 6SYZWn4uGNaefwQeB0hL4Y06JSlrcszykf3QkSj/cfqwTZ4eu0FPAZvXVHzSTKiAtI4K Kk0EhDduRnkHtZPcu4tGMkrFiYElT2mg2Cfp6F1KhfpnnEjh+30GoQAdjv433TR14N2W X+XpbD8LPd51JyHIwAUI27b4IlpqbG/uFb4FieR10J86fgUV1wJREUPN3QymkkKIoPTH 5d7w== X-Gm-Message-State: AOJu0YwE0ry+I6WX/8XQGmr1WGCkXh/67hhOSLBCqZyXlNZ1X4ys3Csf P46c673mu8Q/M5xRfeD3HFF1eRuJcw5j7V0IW/7luUL1ovvpDDmuMn9vC1ENtg== X-Google-Smtp-Source: AGHT+IEarBwiy9S11+P1dfRevomL/EXd2tiBkN8AThfBc9EBa9ZMEtemzQOwx5lFVlSszCObFRDvsQ== X-Received: by 2002:a05:600c:1c98:b0:40e:47d7:45fe with SMTP id k24-20020a05600c1c9800b0040e47d745femr1066290wms.12.1705546305046; Wed, 17 Jan 2024 18:51:45 -0800 (PST) Received: from Mindolluin.ire.aristanetworks.com ([217.173.96.166]) by smtp.gmail.com with ESMTPSA id z15-20020a5d440f000000b0033664ffaf5dsm2868219wrq.37.2024.01.17.18.51.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Jan 2024 18:51:44 -0800 (PST) From: Dmitry Safonov To: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Shuah Khan , Dmitry Safonov <0x7f454c46@gmail.com> Cc: Dmitry Safonov , Mohammad Nassiri , netdev@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 1/3] selftests/net: Argument value mismatch when calling verify_counters() Date: Thu, 18 Jan 2024 02:51:34 +0000 Message-ID: <20240118-tcp-ao-test-key-mgmt-v1-1-3583ca147113@arista.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240118-tcp-ao-test-key-mgmt-v1-0-3583ca147113@arista.com> References: <20240118-tcp-ao-test-key-mgmt-v1-0-3583ca147113@arista.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" X-Mailer: b4 0.13-dev-b6b4b X-Developer-Signature: v=1; a=ed25519-sha256; t=1705546294; l=1291; i=dima@arista.com; s=20231212; h=from:subject:message-id; bh=kVnh27dlnNFLZT4j7XCBS7k2UYRkwKA/47jZVeTJqxM=; b=DvIQceG0/yFC+BI053HeWIerRGCMYN+ne8Heal2yoDlufaZ4By8K3WCQrn12pdLnYBQWgmadn ktHF1H3C665BcIpL2kiiQ7Nf1k53nYH27ZIaIz1rxnkRePR3/c12/TT X-Developer-Key: i=dima@arista.com; a=ed25519; pk=hXINUhX25b0D/zWBKvd6zkvH7W2rcwh/CH6cjEa3OTk= Content-Transfer-Encoding: quoted-printable From: Mohammad Nassiri The end_server() function only operates in the server thread and always takes an accept socket instead of a listen socket as its input argument. To align with this, invert the boolean values used when calling verify_counters() within the end_server() function. Fixes: 3c3ead555648 ("selftests/net: Add TCP-AO key-management test") Signed-off-by: Mohammad Nassiri Link: https://lore.kernel.org/all/934627c5-eebb-4626-be23-cfb134c01d1a@aris= ta.com/ [amended 'Fixes' tag and carried-over to lkml] Signed-off-by: Dmitry Safonov --- tools/testing/selftests/net/tcp_ao/key-management.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/testing/selftests/net/tcp_ao/key-management.c b/tools/te= sting/selftests/net/tcp_ao/key-management.c index c48b4970ca17..f6a9395e3cd7 100644 --- a/tools/testing/selftests/net/tcp_ao/key-management.c +++ b/tools/testing/selftests/net/tcp_ao/key-management.c @@ -843,7 +843,7 @@ static void end_server(const char *tst_name, int sk, synchronize_threads(); /* 4: verified =3D> closed */ close(sk); =20 - verify_counters(tst_name, true, false, begin, &end); + verify_counters(tst_name, false, true, begin, &end); synchronize_threads(); /* 5: counters */ } =20 --=20 2.43.0 From nobody Thu Dec 25 10:53:16 2025 Received: from mail-wr1-f54.google.com (mail-wr1-f54.google.com [209.85.221.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0A0F179CD for ; Thu, 18 Jan 2024 02:51:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.54 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705546310; cv=none; b=oUGBHGeUwFJy6mJK89kWQu77SKWuaZKS1U5DgP23emVl15XQkiK9elKuUL3mihP2ZypzEaksv4whkF0Fs8ywg4pu3DnLCn8fGnc6vY2SxF+4A1yseytMguTCFJmyC8x5QtjIBjhrosPLhcKA3DCiYVjnqb+xkHYphYciOhWHct0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705546310; c=relaxed/simple; bh=QZKaym8nFiRV9Re87RifRE/NGc2FIS+/ruqdmA8E/9Y=; h=Received:DKIM-Signature:X-Google-DKIM-Signature: X-Gm-Message-State:X-Google-Smtp-Source:X-Received:Received:From: To:Cc:Subject:Date:Message-ID:X-Mailer:In-Reply-To:References: MIME-Version:Content-Type:X-Mailer:X-Developer-Signature: X-Developer-Key:Content-Transfer-Encoding; b=Y0Fe3QRt5M8hXpG+TuSRDiDqX7brnBZi9Q3vfifiuc7FzdqVdv2rporkA2PX/6hn86w7Iba3jrcdMHLUsk74gfqZNTI/dG1zcO0L4SKFVMX4Bscixr+WJ6njU2kPUA1+1kz3mb+i1oJmFpC9Qune4gY8ucgvxn6zFPyBuqFiAqo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=arista.com; spf=pass smtp.mailfrom=arista.com; dkim=pass (2048-bit key) header.d=arista.com header.i=@arista.com header.b=RnaUryu9; arc=none smtp.client-ip=209.85.221.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=arista.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arista.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=arista.com header.i=@arista.com header.b="RnaUryu9" Received: by mail-wr1-f54.google.com with SMTP id ffacd0b85a97d-336c9acec03so9657703f8f.2 for ; Wed, 17 Jan 2024 18:51:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arista.com; s=google; t=1705546307; x=1706151107; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=QfduzUl6xeBtvtYJDyMTI1tDFj6QysY3Ss5eP9VLuq4=; b=RnaUryu9WJX+yexQ0bSf7o1a5cJbb3V+Ka1nrWiWSGu9to5m9tqaxoajm4yi/Hayzg uEKUUtd/WEOB3AyKTn6JL43sj6UY9yOgw6CGI6beTQPSMCIEZ0Kb+Tnn+DC4W1VYNxpg ULjYwcdo89pKQCzyxvtbv3dkV0/DgH6O684v/qNIc3swsqYe4gbaOiwfGKX5ITxmuY2V eJyKUjpRvP12EOXvzeABWNViAmFUHVFS9ETpq7SEQELuOlCznwHysZZ9IKWufhjuoEgp ippkf5jn4tITxqcFer/RRUvThMWHq4PzuyeUXFFN6VubjXtk2chJf0GaP0CV0UnMPstW mOdA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705546307; x=1706151107; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=QfduzUl6xeBtvtYJDyMTI1tDFj6QysY3Ss5eP9VLuq4=; b=H8mOO6Q8cm6XYy2ZnRCa4W/cZr/gl2AEqRwj1cNH7SrNQ5BWWn/bl/FBjLtEkDFfa6 Pep55l5o5D6Nf9cSM+Vn6WtCabWpFElQ2VLXBMyj2KIJJtOYbmIz8wY/pslo4z5NhpwS /5KmRjrWdu08MyfAyPChYRdLOYhBkcbc14C9IBVqD+XzuKuT8oAEbWYQprqJqWaLnbdm yLyFWbvtM30ZdKXjUi+V8qDrzvZ0LRIAGCGlSrX+lvBrK34Vz6IhrYKptvtZTQEeyzH8 r94QuAraGQY0IST6gvnNGicENafYLM5kN3DaxBKMxxTdNHsbsxkuCJDyJaUkDzzEWjyD VgNw== X-Gm-Message-State: AOJu0Yxyx1s39gGLNJ/EzuCGSCZxEyd/gPs1woNNikreIGzQbe5eRJ2W tqDlHNBClSN4v2DfnnTxy4YrNIiCa/5htaP/xwlMYU0OG422ywrOyfynpLIFgQ== X-Google-Smtp-Source: AGHT+IGm/R0MFqUoxs0sZnObB5pC5VwXCcB30vH4BNIs+FZOGPs6Y6wipK+yotRTeskn8mg4aUbhtA== X-Received: by 2002:adf:cd85:0:b0:337:be02:b9a4 with SMTP id q5-20020adfcd85000000b00337be02b9a4mr74557wrj.106.1705546307343; Wed, 17 Jan 2024 18:51:47 -0800 (PST) Received: from Mindolluin.ire.aristanetworks.com ([217.173.96.166]) by smtp.gmail.com with ESMTPSA id z15-20020a5d440f000000b0033664ffaf5dsm2868219wrq.37.2024.01.17.18.51.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Jan 2024 18:51:46 -0800 (PST) From: Dmitry Safonov To: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Shuah Khan , Dmitry Safonov <0x7f454c46@gmail.com> Cc: Dmitry Safonov , Mohammad Nassiri , netdev@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 2/3] selftests/net: Rectify key counters checks Date: Thu, 18 Jan 2024 02:51:35 +0000 Message-ID: <20240118-tcp-ao-test-key-mgmt-v1-2-3583ca147113@arista.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240118-tcp-ao-test-key-mgmt-v1-0-3583ca147113@arista.com> References: <20240118-tcp-ao-test-key-mgmt-v1-0-3583ca147113@arista.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" X-Mailer: b4 0.13-dev-b6b4b X-Developer-Signature: v=1; a=ed25519-sha256; t=1705546294; l=5702; i=dima@arista.com; s=20231212; h=from:subject:message-id; bh=QZKaym8nFiRV9Re87RifRE/NGc2FIS+/ruqdmA8E/9Y=; b=/L7fiuJ8pvO/Z7wlLHp2COBc8azS99uMQ8onBu9cjtNPemIMx1K/wiGBQ+XXKz4wm4HJrkVUg gzvxJJ/nJ8kDBcItyklbYDH+MU/L4UN18UKMbWpKDv8q2AcgKvJwmOo X-Developer-Key: i=dima@arista.com; a=ed25519; pk=hXINUhX25b0D/zWBKvd6zkvH7W2rcwh/CH6cjEa3OTk= Content-Transfer-Encoding: quoted-printable As the names of (struct test_key) members didn't reflect whether the key was used for TX or RX, the verification for the counters was done incorrectly for asymmetrical selftests. Rename these with _tx appendix and fix checks in verify_counters(). While at it, as the checks are now correct, introduce skip_counters_checks, which is intended for tests where it's expected that a key that was set with setsockopt(sk, IPPROTO_TCP, TCP_AO_INFO, ...) might had no chance of getting used on the wire. Fixes the following failures, exposed by the previous commit: > not ok 51 server: Check current !=3D rnext keys set before connect(): Cou= nter pkt_good was expected to increase 0 =3D> 0 for key 132:5 > not ok 52 server: Check current !=3D rnext keys set before connect(): Cou= nter pkt_good was not expected to increase 0 =3D> 21 for key 137:10 > > not ok 63 server: Check current flapping back on peer's RnextKey request:= Counter pkt_good was expected to increase 0 =3D> 0 for key 132:5 > not ok 64 server: Check current flapping back on peer's RnextKey request:= Counter pkt_good was not expected to increase 0 =3D> 40 for key 137:10 Cc: Mohammad Nassiri Fixes: 3c3ead555648 ("selftests/net: Add TCP-AO key-management test") Signed-off-by: Dmitry Safonov --- .../testing/selftests/net/tcp_ao/key-management.c | 44 ++++++++++++------= ---- 1 file changed, 25 insertions(+), 19 deletions(-) diff --git a/tools/testing/selftests/net/tcp_ao/key-management.c b/tools/te= sting/selftests/net/tcp_ao/key-management.c index f6a9395e3cd7..24e62120b792 100644 --- a/tools/testing/selftests/net/tcp_ao/key-management.c +++ b/tools/testing/selftests/net/tcp_ao/key-management.c @@ -417,9 +417,9 @@ struct test_key { matches_vrf : 1, is_current : 1, is_rnext : 1, - used_on_handshake : 1, - used_after_accept : 1, - used_on_client : 1; + used_on_server_tx : 1, + used_on_client_tx : 1, + skip_counters_checks : 1; }; =20 struct key_collection { @@ -609,16 +609,14 @@ static int key_collection_socket(bool server, unsigne= d int port) addr =3D &this_ip_dest; sndid =3D key->client_keyid; rcvid =3D key->server_keyid; - set_current =3D key->is_current; - set_rnext =3D key->is_rnext; + key->used_on_client_tx =3D set_current =3D key->is_current; + key->used_on_server_tx =3D set_rnext =3D key->is_rnext; } =20 if (test_add_key_cr(sk, key->password, key->len, *addr, vrf, sndid, rcvid, key->maclen, key->alg, set_current, set_rnext)) test_key_error("setsockopt(TCP_AO_ADD_KEY)", key); - if (set_current || set_rnext) - key->used_on_handshake =3D 1; #ifdef DEBUG test_print("%s [%u/%u] key: { %s, %u:%u, %u, %u:%u:%u:%u (%u)}", server ? "server" : "client", i, collection.nr_keys, @@ -640,22 +638,22 @@ static void verify_counters(const char *tst_name, boo= l is_listen_sk, bool server for (i =3D 0; i < collection.nr_keys; i++) { struct test_key *key =3D &collection.keys[i]; uint8_t sndid, rcvid; - bool was_used; + bool rx_cnt_expected; =20 + if (key->skip_counters_checks) + continue; if (server) { sndid =3D key->server_keyid; rcvid =3D key->client_keyid; - if (is_listen_sk) - was_used =3D key->used_on_handshake; - else - was_used =3D key->used_after_accept; + rx_cnt_expected =3D key->used_on_client_tx; } else { sndid =3D key->client_keyid; rcvid =3D key->server_keyid; - was_used =3D key->used_on_client; + rx_cnt_expected =3D key->used_on_server_tx; } =20 - test_tcp_ao_key_counters_cmp(tst_name, a, b, was_used, + test_tcp_ao_key_counters_cmp(tst_name, a, b, + rx_cnt_expected ? TEST_CNT_KEY_GOOD : 0, sndid, rcvid); } test_tcp_ao_counters_free(a); @@ -916,9 +914,8 @@ static int run_client(const char *tst_name, unsigned in= t port, current_index =3D nr_keys - 1; if (rnext_index < 0) rnext_index =3D nr_keys - 1; - collection.keys[current_index].used_on_handshake =3D 1; - collection.keys[rnext_index].used_after_accept =3D 1; - collection.keys[rnext_index].used_on_client =3D 1; + collection.keys[current_index].used_on_client_tx =3D 1; + collection.keys[rnext_index].used_on_server_tx =3D 1; =20 synchronize_threads(); /* 3: accepted =3D> send data */ if (test_client_verify(sk, msg_sz, msg_nr, TEST_TIMEOUT_SEC)) { @@ -1059,7 +1056,16 @@ static void check_current_back(const char *tst_name,= unsigned int port, test_error("Can't change the current key"); if (test_client_verify(sk, msg_len, nr_packets, TEST_TIMEOUT_SEC)) test_fail("verify failed"); - collection.keys[rotate_to_index].used_after_accept =3D 1; + /* There is a race here: between setting the current_key with + * setsockopt(TCP_AO_INFO) and starting to send some data - there + * might have been a segment received with the desired + * RNext_key set. In turn that would mean that the first outgoing + * segment will have the desired current_key (flipped back). + * Which is what the user/test wants. As it's racy, skip checking + * the counters, yet check what are the resulting current/rnext + * keys on both sides. + */ + collection.keys[rotate_to_index].skip_counters_checks =3D 1; =20 end_client(tst_name, sk, nr_keys, current_index, rnext_index, &tmp); } @@ -1089,7 +1095,7 @@ static void roll_over_keys(const char *tst_name, unsi= gned int port, } verify_current_rnext(tst_name, sk, -1, collection.keys[i].server_keyid); - collection.keys[i].used_on_client =3D 1; + collection.keys[i].used_on_server_tx =3D 1; synchronize_threads(); /* verify current/rnext */ } end_client(tst_name, sk, nr_keys, current_index, rnext_index, &tmp); --=20 2.43.0 From nobody Thu Dec 25 10:53:16 2025 Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C386C9474 for ; Thu, 18 Jan 2024 02:51:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.42 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705546312; cv=none; b=m/i5nXtlty9XWV/nkQQGWamTzwIygGfsuW+19J2rOvqPGq7ddM/tajaIsXSL/Rol/pcPgqRpKQLkxOrCuSrbLEZGKj8Cgile17lvyQdobKs2qSO98mjhgUCoc634XU/LB6TneuVkpzu6KwLhsnK+04pklhrcgoo7zUhN84OBNus= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705546312; c=relaxed/simple; bh=qeZ3tY/o44baRhR6QAmQ3u7Ui4fQMK8qYGmLuQSHVR4=; h=Received:DKIM-Signature:X-Google-DKIM-Signature: X-Gm-Message-State:X-Google-Smtp-Source:X-Received:Received:From: To:Cc:Subject:Date:Message-ID:X-Mailer:In-Reply-To:References: MIME-Version:Content-Type:X-Mailer:X-Developer-Signature: X-Developer-Key:Content-Transfer-Encoding; b=j+bLEHpK3FiVWinWRUPxb1kn5ZkDcsiuHQ1zYCtv9Y5zLS5FI2KS1UFJF0nsA3ZbkIC5rqfVe5wBwfcBTmtJBM+2wEfnnY11UAOIl7oq1gvza32IQsH+s0RPv3ux8SbyhVnny+cQPM53/nxR0d4XPT6MtlEjPPrEILxNpfF+2vs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=arista.com; spf=pass smtp.mailfrom=arista.com; dkim=pass (2048-bit key) header.d=arista.com header.i=@arista.com header.b=GCy8msPQ; arc=none smtp.client-ip=209.85.128.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=arista.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arista.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=arista.com header.i=@arista.com header.b="GCy8msPQ" Received: by mail-wm1-f42.google.com with SMTP id 5b1f17b1804b1-40e90163be1so1611155e9.1 for ; Wed, 17 Jan 2024 18:51:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arista.com; s=google; t=1705546309; x=1706151109; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=3o3JIW0lMFFX9linU1Dr7QEV8ZT+tiEVZq+1/7eCMH8=; b=GCy8msPQX4RwUoFlDWaO2h4HYSplkrqpQIvPaS5AgnuN38X+8ggV3Fl9JapMsW0ALt 4iNNlnkLpubt9kwLMmMM9Qwpx8NDO0cgNYhO44zv5ovoyxpK2OarrJbej3cPfSZA6kUd 1T/4/zexLh8ySXUtCSHxUK4M6hhj2AY5FbFJ6+Efn4mOi1Izg7veck6QecMLTBnDFPx6 8/mKFiHwXE+sG6jPEEWV5ziQkzmDMUtGIUEdQqVYSAJeP444PkhYWpe1E4Z/pxkt8/GN vQbs/bEb6kcWXylE/QYeaoGhKX9S3xuFloH8hWpFS0l8E+183q7FW40eAq73PGLjr2ZW CKyA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705546309; x=1706151109; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=3o3JIW0lMFFX9linU1Dr7QEV8ZT+tiEVZq+1/7eCMH8=; b=mnjlo8JPzBAThW9w8wkGitCP51eDoLAdI4ExbCh7na7eJA/LRsqxKYS6YBRkq2YCUQ tEIeTxzudci7U9xf78K2YVA3qC0u4O+uq/uidE1Q03/KAWnmxQfNHpAtisJHFiXW30Lz +H04ZAzMyBc1cFldlaj+NwgHyxm7hwa8zxi0cFIp13XXpk2IT0VlToOOUTBQ0zfid7w0 j1zNg8ANKBz6A2mA/Gkpc9alBaLStCdVLPL6nT8J2bZbr0OJcqLCTmis6tLToAuz4f6O OGhnmsa2pE1noswm4KGTPD3w33UTgpndMlEdwKWO2sFr40/UFSNqAajNaZxp3zQ86v9F 0F4g== X-Gm-Message-State: AOJu0YygqtBA2TlhHq++oL1Om+zIJvfavfQHYAj0zSiGE3CP5D3L++vE EM7ejgGcTMnGa7rX9EdjRsJ2njozZej7mCTLMDqAgpompfTuwCVLhezXiOY2PA== X-Google-Smtp-Source: AGHT+IGTP8bDonVO2FTMnOfmYmhTkXA7oZIjIWi56IdHYCM3+hcb2Gwh7mTQIsxRTHcK1mpkziqCEQ== X-Received: by 2002:a1c:4b14:0:b0:40e:47bf:f332 with SMTP id y20-20020a1c4b14000000b0040e47bff332mr41977wma.97.1705546309242; Wed, 17 Jan 2024 18:51:49 -0800 (PST) Received: from Mindolluin.ire.aristanetworks.com ([217.173.96.166]) by smtp.gmail.com with ESMTPSA id z15-20020a5d440f000000b0033664ffaf5dsm2868219wrq.37.2024.01.17.18.51.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Jan 2024 18:51:48 -0800 (PST) From: Dmitry Safonov To: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Shuah Khan , Dmitry Safonov <0x7f454c46@gmail.com> Cc: Dmitry Safonov , Mohammad Nassiri , netdev@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 3/3] selftests/net: Clean-up double assignment Date: Thu, 18 Jan 2024 02:51:36 +0000 Message-ID: <20240118-tcp-ao-test-key-mgmt-v1-3-3583ca147113@arista.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240118-tcp-ao-test-key-mgmt-v1-0-3583ca147113@arista.com> References: <20240118-tcp-ao-test-key-mgmt-v1-0-3583ca147113@arista.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" X-Mailer: b4 0.13-dev-b6b4b X-Developer-Signature: v=1; a=ed25519-sha256; t=1705546294; l=958; i=dima@arista.com; s=20231212; h=from:subject:message-id; bh=qeZ3tY/o44baRhR6QAmQ3u7Ui4fQMK8qYGmLuQSHVR4=; b=nB5WMfppjsBWtpYlDmqyc73zjVS9nEfgidteoRQ0/Rfb/dLrknlixH1oNA964bflYfHGG2n2a /PKkERTk0U/BI8T0dEMYZie22fblu4GxYKvI1gJlXBlW4Qmnysso9RP X-Developer-Key: i=dima@arista.com; a=ed25519; pk=hXINUhX25b0D/zWBKvd6zkvH7W2rcwh/CH6cjEa3OTk= Content-Transfer-Encoding: quoted-printable Yeah, copy'n'paste typo. Fixes: 3c3ead555648 ("selftests/net: Add TCP-AO key-management test") Reported-by: Nassiri, Mohammad Closes: https://lore.kernel.org/all/DM6PR04MB4202BC58A9FD5BDD24A16E8EC56F2@= DM6PR04MB4202.namprd04.prod.outlook.com/ Signed-off-by: Dmitry Safonov --- tools/testing/selftests/net/tcp_ao/lib/sock.c | 1 - 1 file changed, 1 deletion(-) diff --git a/tools/testing/selftests/net/tcp_ao/lib/sock.c b/tools/testing/= selftests/net/tcp_ao/lib/sock.c index c75d82885a2e..923a9bb4f1ca 100644 --- a/tools/testing/selftests/net/tcp_ao/lib/sock.c +++ b/tools/testing/selftests/net/tcp_ao/lib/sock.c @@ -377,7 +377,6 @@ int test_get_tcp_ao_counters(int sk, struct tcp_ao_coun= ters *out) =20 key_dump[0].nkeys =3D nr_keys; key_dump[0].get_all =3D 1; - key_dump[0].get_all =3D 1; err =3D getsockopt(sk, IPPROTO_TCP, TCP_AO_GET_KEYS, key_dump, &key_dump_sz); if (err) { --=20 2.43.0