From nobody Tue Dec 16 17:00:26 2025 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 01BD117743 for ; Mon, 15 Jan 2024 14:34:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 3A047150C; Mon, 15 Jan 2024 06:35:29 -0800 (PST) Received: from e126645.arm.com (e126645.nice.arm.com [10.34.100.129]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id B64623F6C4; Mon, 15 Jan 2024 06:34:40 -0800 (PST) From: Pierre Gondois To: linux-kernel@vger.kernel.org Cc: Shrikanth Hegde , Pierre Gondois , Ingo Molnar , Peter Zijlstra , Juri Lelli , Vincent Guittot , Dietmar Eggemann , Steven Rostedt , Ben Segall , Mel Gorman , Daniel Bristot de Oliveira , Valentin Schneider , Huang Ying Subject: [PATCH v2 2/3] sched/fair: Use rq in idle_cpu_without() Date: Mon, 15 Jan 2024 15:34:25 +0100 Message-Id: <20240115143427.1820628-3-pierre.gondois@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20240115143427.1820628-1-pierre.gondois@arm.com> References: <20240115143427.1820628-1-pierre.gondois@arm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" idle_cpu_without() could receive a 'struct rq' instead of a CPU number to avoid converting the CPU number to a 'struct rq' two times. Indeed update_sg_wakeup_stats() already makes the conversion. idle_cpu_without() is also renamed to idle_rq_without() to match the input parameter. Reviewed-by: Shrikanth Hegde Signed-off-by: Pierre Gondois --- kernel/sched/fair.c | 16 +++++++--------- 1 file changed, 7 insertions(+), 9 deletions(-) diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index d7a3c63a2171..97d9e0d32337 100644 --- a/kernel/sched/fair.c +++ b/kernel/sched/fair.c @@ -10105,23 +10105,21 @@ static unsigned int task_running_on_cpu(int cpu, = struct task_struct *p) } =20 /** - * idle_cpu_without - would a given CPU be idle without p ? - * @cpu: the processor on which idleness is tested. + * idle_rq_without - would a given rq be idle without p ? + * @rq: the rq on which idleness is tested. * @p: task which should be ignored. * - * Return: 1 if the CPU would be idle. 0 otherwise. + * Return: 1 if the rq would be idle. 0 otherwise. */ -static int idle_cpu_without(int cpu, struct task_struct *p) +static int idle_rq_without(struct rq *rq, struct task_struct *p) { - struct rq *rq =3D cpu_rq(cpu); - if (rq->curr !=3D rq->idle && rq->curr !=3D p) return 0; =20 /* * rq->nr_running can't be used but an updated version without the * impact of p on cpu must be used instead. The updated nr_running - * be computed and tested before calling idle_cpu_without(). + * be computed and tested before calling idle_rq_without(). */ =20 #ifdef CONFIG_SMP @@ -10166,9 +10164,9 @@ static inline void update_sg_wakeup_stats(struct sc= hed_domain *sd, sgs->sum_nr_running +=3D nr_running; =20 /* - * No need to call idle_cpu_without() if nr_running is not 0 + * No need to call idle_rq_without() if nr_running is not 0 */ - if (!nr_running && idle_cpu_without(i, p)) + if (!nr_running && idle_rq_without(rq, p)) sgs->idle_cpus++; =20 /* Check if task fits in the CPU */ --=20 2.25.1