From nobody Tue Dec 16 17:00:26 2025 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 977FF17F3 for ; Mon, 15 Jan 2024 14:34:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 8ADF8FEC; Mon, 15 Jan 2024 06:35:26 -0800 (PST) Received: from e126645.arm.com (e126645.nice.arm.com [10.34.100.129]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 13F2E3F6C4; Mon, 15 Jan 2024 06:34:37 -0800 (PST) From: Pierre Gondois To: linux-kernel@vger.kernel.org Cc: Shrikanth Hegde , Pierre Gondois , Ingo Molnar , Peter Zijlstra , Juri Lelli , Vincent Guittot , Dietmar Eggemann , Steven Rostedt , Ben Segall , Mel Gorman , Daniel Bristot de Oliveira , Valentin Schneider , Huang Ying Subject: [PATCH v2 1/3] sched/topology: Annotate RCU pointers properly Date: Mon, 15 Jan 2024 15:34:24 +0100 Message-Id: <20240115143427.1820628-2-pierre.gondois@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20240115143427.1820628-1-pierre.gondois@arm.com> References: <20240115143427.1820628-1-pierre.gondois@arm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Cleanup RCU-related spare errors by annotating RCU pointers. sched_domains_numa_distance: error: incompatible types in comparison expression (different address spaces): int [noderef] __rcu * int * sched_domains_numa_masks: error: incompatible types in comparison expression (different address spaces): struct cpumask **[noderef] __rcu * struct cpumask *** The cast to (void *) adds the following sparse warning: warning: cast removes address space '__rcu' of expression but this should be normal. Fixes: 0fb3978b0aac ("sched/numa: Fix NUMA topology for systems with CPU-le= ss nodes") Signed-off-by: Pierre Gondois --- kernel/sched/topology.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/kernel/sched/topology.c b/kernel/sched/topology.c index 10d1391e7416..2a2da9b33e31 100644 --- a/kernel/sched/topology.c +++ b/kernel/sched/topology.c @@ -1542,8 +1542,8 @@ static int sched_domains_numa_levels; static int sched_domains_curr_level; =20 int sched_max_numa_distance; -static int *sched_domains_numa_distance; -static struct cpumask ***sched_domains_numa_masks; +static int __rcu *sched_domains_numa_distance; +static struct cpumask ** __rcu *sched_domains_numa_masks; #endif =20 /* @@ -1988,8 +1988,8 @@ void sched_init_numa(int offline_node) =20 static void sched_reset_numa(void) { - int nr_levels, *distances; - struct cpumask ***masks; + int nr_levels, __rcu *distances; + struct cpumask ** __rcu *masks; =20 nr_levels =3D sched_domains_numa_levels; sched_domains_numa_levels =3D 0; @@ -2003,7 +2003,7 @@ static void sched_reset_numa(void) int i, j; =20 synchronize_rcu(); - kfree(distances); + kfree((void *)distances); for (i =3D 0; i < nr_levels && masks; i++) { if (!masks[i]) continue; @@ -2011,7 +2011,7 @@ static void sched_reset_numa(void) kfree(masks[i][j]); kfree(masks[i]); } - kfree(masks); + kfree((void *)masks); } if (sched_domain_topology_saved) { kfree(sched_domain_topology); --=20 2.25.1