From nobody Fri Dec 26 11:41:11 2025 Received: from smtp-relay-internal-0.canonical.com (smtp-relay-internal-0.canonical.com [185.125.188.122]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3DBE042044 for ; Mon, 8 Jan 2024 12:10:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=canonical.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=canonical.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=canonical.com header.i=@canonical.com header.b="oZgET+09" Received: from mail-lf1-f71.google.com (mail-lf1-f71.google.com [209.85.167.71]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-0.canonical.com (Postfix) with ESMTPS id B14F83F5A7 for ; Mon, 8 Jan 2024 12:10:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1704715819; bh=AZ1e4DQplobEkYb2oelZJP/g6uMuj6ixR2NKn4USgqo=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=oZgET+09Ka8MNP9uDRDSiEXoBiVx6GYwnMHXNDL4GQCvAdtU6ymuhi9QMZobpNiLI y1ek8B3KBeTZsMv6+8Ks72uRfZCg4wtlJezxSwDVrM35BRcg/jtf+xCloGAJzR6X6z +6xcfcmko6NoOhs4lLGqR7TiSKPxzySaPUpzAERXy+22ef1l8OFK0/3UEYGggcRehO E0GDqXmEwpqBocf/8ihFCUoiA62p2Tp90+5IJhkIe4hBNWne+pXHJ0izdMAIIb8i0z OLoVaSAU5ObfDlMaLWu+Zg/BwHqwa9SXQVv2JJTIARsfe5hKzFDxWRceft2BaXmE0K kuDSLTFwAhlig== Received: by mail-lf1-f71.google.com with SMTP id 2adb3069b0e04-50e69fc4574so1186636e87.3 for ; Mon, 08 Jan 2024 04:10:19 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704715819; x=1705320619; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=AZ1e4DQplobEkYb2oelZJP/g6uMuj6ixR2NKn4USgqo=; b=Fj8acP8ib5UaP0sP7BgP0+I+uqGmHp9CYtmB2TnGbp8W8cgbGpZpvdTU1Rfo7rcJX3 E/Wpzl5VhLftfoL+eGicPVNwC0xb99j2TgG9yAie+3zgRLMJ+4qgt7Z8hHv7681taoVl aY/4CzicZT8G9drPjRLRJFa0RAAc4avLZelMsp9mf9eduUuftihAIGNw01wA0I36sDmD Pwm7+p9KcBCrAO5pkngdVEf6tyr0OB/Nkq23UdOlW4LnZ4DD7RemlQkg3PDybxHNov6G TTIfVKvV+jb8qfkpuev57PVkczDi7E7yFiRCrrhfUPyTkBOkFTJ5+DL6/f2JOt76eW2h MNRg== X-Gm-Message-State: AOJu0YwZLp9Bd+TocWeie+ow7o+/azBzZkEnL8JKnmZACAou+BiP+SZw mX+VuWB565vp2PDffRDyyUDDU33l8MRfC7kycN6K/PXqKZbG5RcZwLnudXFhu9513aOyPksFuCv hHZ41vgkhkauzRxYEtflLmfvBXw8cCj1Y1WwLoiNwcVaOwkeE X-Received: by 2002:ac2:44a8:0:b0:50e:7c6e:b411 with SMTP id c8-20020ac244a8000000b0050e7c6eb411mr1194731lfm.103.1704715819058; Mon, 08 Jan 2024 04:10:19 -0800 (PST) X-Google-Smtp-Source: AGHT+IG7Nzn++Vuip8dKLKr2jYqNsa9FafczX9ul7wwW/1w2B0tbqsqXsHCty5yPcFNCQXD2vOYw2Q== X-Received: by 2002:ac2:44a8:0:b0:50e:7c6e:b411 with SMTP id c8-20020ac244a8000000b0050e7c6eb411mr1194719lfm.103.1704715818859; Mon, 08 Jan 2024 04:10:18 -0800 (PST) Received: from localhost.localdomain ([91.64.72.41]) by smtp.gmail.com with ESMTPSA id fi21-20020a056402551500b005578b816f20sm1767959edb.29.2024.01.08.04.10.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Jan 2024 04:10:17 -0800 (PST) From: Alexander Mikhalitsyn To: mszeredi@redhat.com Cc: brauner@kernel.org, stgraber@stgraber.org, linux-fsdevel@vger.kernel.org, Seth Forshee , Miklos Szeredi , Amir Goldstein , Bernd Schubert , Alexander Mikhalitsyn , linux-kernel@vger.kernel.org Subject: [PATCH v1 7/9] fs/fuse: drop idmap argument from __fuse_get_acl Date: Mon, 8 Jan 2024 13:08:22 +0100 Message-Id: <20240108120824.122178-8-aleksandr.mikhalitsyn@canonical.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240108120824.122178-1-aleksandr.mikhalitsyn@canonical.com> References: <20240108120824.122178-1-aleksandr.mikhalitsyn@canonical.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" We don't need to have idmap in the __fuse_get_acl as we don't have any use for it. In the current POSIX ACL implementation, idmapped mounts are taken into account on the userspace/kernel border (see vfs_set_acl_idmapped_mnt() and vfs_posix_acl_to_xattr()). Cc: Christian Brauner Cc: Seth Forshee Cc: Miklos Szeredi Cc: Amir Goldstein Cc: Bernd Schubert Cc: Signed-off-by: Alexander Mikhalitsyn Reviewed-by: Christian Brauner --- fs/fuse/acl.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/fs/fuse/acl.c b/fs/fuse/acl.c index 3d192b80a561..3a3cd88bd3d7 100644 --- a/fs/fuse/acl.c +++ b/fs/fuse/acl.c @@ -12,7 +12,6 @@ #include =20 static struct posix_acl *__fuse_get_acl(struct fuse_conn *fc, - struct mnt_idmap *idmap, struct inode *inode, int type, bool rcu) { int size; @@ -74,7 +73,7 @@ struct posix_acl *fuse_get_acl(struct mnt_idmap *idmap, if (fuse_no_acl(fc, inode)) return ERR_PTR(-EOPNOTSUPP); =20 - return __fuse_get_acl(fc, idmap, inode, type, false); + return __fuse_get_acl(fc, inode, type, false); } =20 struct posix_acl *fuse_get_inode_acl(struct inode *inode, int type, bool r= cu) @@ -90,8 +89,7 @@ struct posix_acl *fuse_get_inode_acl(struct inode *inode,= int type, bool rcu) */ if (!fc->posix_acl) return NULL; - - return __fuse_get_acl(fc, &nop_mnt_idmap, inode, type, rcu); + return __fuse_get_acl(fc, inode, type, rcu); } =20 int fuse_set_acl(struct mnt_idmap *idmap, struct dentry *dentry, --=20 2.34.1