From nobody Mon Feb 9 05:45:03 2026 Received: from smtp-relay-internal-1.canonical.com (smtp-relay-internal-1.canonical.com [185.125.188.123]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 210F12E825 for ; Fri, 5 Jan 2024 15:21:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=canonical.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=canonical.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=canonical.com header.i=@canonical.com header.b="OTdPdfL4" Received: from mail-lf1-f72.google.com (mail-lf1-f72.google.com [209.85.167.72]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-1.canonical.com (Postfix) with ESMTPS id 6BF6F3F2C4 for ; Fri, 5 Jan 2024 15:21:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1704468112; bh=va+R088LK5HPp976U93J7EMukikDVxpd8L8bbCz8s64=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=OTdPdfL4vD88WxjnXOS8DD5iLwX3e7wWdtD9P7YoHSs1fdFhDNnavWmqVxPpN1WFY 1e/HX1qtjoL5zaazt2OVcRyNuv4zf326Jxt9x6h5h4laoPbsBsQsOjo6+tItU9efXr EZ30cCCUq2/QRcfzxnxQeuQCeBchjnGRv4e21dXc+e12Chv74bpRS6gJwUOkCptgkk doMjxd8YPN8X6ZPiAVKNqouxH7qOBvY/nS2hYODZJv5Kuny7x97FN0P58jNCkeO/7n Vgt1+r7cR3wPD1cpNSxNgp+JAkYMew5tPVUXJ8X42piKf2cq9CAmKZyyFqvK3zzHdk mteQyU0dq+yvg== Received: by mail-lf1-f72.google.com with SMTP id 2adb3069b0e04-50e7b5c3582so1407195e87.1 for ; Fri, 05 Jan 2024 07:21:52 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704468111; x=1705072911; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=va+R088LK5HPp976U93J7EMukikDVxpd8L8bbCz8s64=; b=cRfvuUZul0qefSokn2an+sdJVPz3qlZ6Ni/sktbzoPNvFB1U0hy/6WFrRmvWxVwtKN zm8OAmdUu2ZOWdY6rcnYkPgHgRPD9G1hxyEmjD8CX6M/GhjP5CMETkmWJK5AhnIPcad7 2iPqZTWHjWkIT3bp+wuAB1ulqs0qyvCNrMhFDha7txXFF8GuP2Kn7NPzO2mpN86nEx8q vxsudgx6ppgwpmcKb/rtEfTef11zIe3rhLYBy9eekc5rCJEjUx/tnIxtNwrhPWJLP17n bMDWJOsmqPx5nQTOS0yRgja8firke7yC/xSYO3prwiYCEDf6xglpEmTcJj98OrAJd7hW c47Q== X-Gm-Message-State: AOJu0Yw/TDXMT8+NSQMjUsGhKA/PWMeGfLU9RiOaDOUGgU7nFn/vy9Jy apLzPyasRZdWDrC56qjTn0caHHo7yWak42tEgfQwKKpGqLiaycz9WXrJd4Ug5aLwc08Tgj0T2fH /CoSbQDJfbCrhuLvrragqMR4SZDIeyj03YPg2sdHiTMnQWgEPhZ18CQ7n X-Received: by 2002:a05:6512:6c7:b0:50e:4375:712 with SMTP id u7-20020a05651206c700b0050e43750712mr1334021lff.16.1704468111588; Fri, 05 Jan 2024 07:21:51 -0800 (PST) X-Google-Smtp-Source: AGHT+IE2/T4cw9Nt8HWcefUxCTnHCLrQ/5/WQYn6R+9zUBE3oW/gttm32aQ4NbV3GZMIq02etobbVg== X-Received: by 2002:a05:6512:6c7:b0:50e:4375:712 with SMTP id u7-20020a05651206c700b0050e43750712mr1334017lff.16.1704468111287; Fri, 05 Jan 2024 07:21:51 -0800 (PST) Received: from amikhalitsyn.lan ([91.64.72.41]) by smtp.gmail.com with ESMTPSA id i23-20020a170906115700b00a298adde5a1sm345630eja.189.2024.01.05.07.21.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Jan 2024 07:21:50 -0800 (PST) From: Alexander Mikhalitsyn To: mszeredi@redhat.com Cc: Alexander Mikhalitsyn , Miklos Szeredi , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v1 1/3] fuse: fix typo for fuse_permission comment Date: Fri, 5 Jan 2024 16:21:27 +0100 Message-Id: <20240105152129.196824-2-aleksandr.mikhalitsyn@canonical.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240105152129.196824-1-aleksandr.mikhalitsyn@canonical.com> References: <20240105152129.196824-1-aleksandr.mikhalitsyn@canonical.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Found by chance while working on support for idmapped mounts in fuse. Cc: Miklos Szeredi Cc: Cc: Signed-off-by: Alexander Mikhalitsyn --- fs/fuse/dir.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/fuse/dir.c b/fs/fuse/dir.c index d19cbf34c634..6f5f9ff95380 100644 --- a/fs/fuse/dir.c +++ b/fs/fuse/dir.c @@ -1485,7 +1485,7 @@ static int fuse_perm_getattr(struct inode *inode, int= mask) * * 1) Local access checking ('default_permissions' mount option) based * on file mode. This is the plain old disk filesystem permission - * modell. + * model. * * 2) "Remote" access checking, where server is responsible for * checking permission in each inode operation. An exception to this --=20 2.34.1 From nobody Mon Feb 9 05:45:03 2026 Received: from smtp-relay-internal-1.canonical.com (smtp-relay-internal-1.canonical.com [185.125.188.123]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1DDE62E849 for ; Fri, 5 Jan 2024 15:21:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=canonical.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=canonical.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=canonical.com header.i=@canonical.com header.b="jeLTI0B/" Received: from mail-ej1-f71.google.com (mail-ej1-f71.google.com [209.85.218.71]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-1.canonical.com (Postfix) with ESMTPS id A75683F154 for ; Fri, 5 Jan 2024 15:21:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1704468118; bh=lY3Wm0rqUAhsDJUxSGP7DuG2vuWegRTpE6t0VrqtHps=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=jeLTI0B/iGD4kYv1X6OzcLyIqcUp9pAx63SDlbSVBTrPjzAMsGIMXLWcuk5rdBm81 XOmLAGFOynjdiHiWnc4yUjZsGXM5xsGwx+qhd6heNdbSlAiUO6ULewRMlwvcKd1MuJ gCkOMqg3pnnXgZrSA71kRR1um5A1qpJD8azBFvBGDKpnNx/6fBClFWSzlffVMeBiu7 gYG/OqLeEEmDZDx5L5DXMa2e+viiujjU/7296/n3KgKeCJ4NKj9Yfpog0HtU+6K6oY Lk3d8/8f0sQJtgeYlp1wqYVxCM+OOwK9++JWj+8uFFwcq1r6AfgEAum0M5QoJYUbyL 4sY7XEAIxvByw== Received: by mail-ej1-f71.google.com with SMTP id a640c23a62f3a-a2336591d48so72624866b.3 for ; Fri, 05 Jan 2024 07:21:58 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704468116; x=1705072916; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=lY3Wm0rqUAhsDJUxSGP7DuG2vuWegRTpE6t0VrqtHps=; b=YDeDMNX7vhnc+IdV7GaJKazm/gkEqfI/RcWEPWAM6XlUHewL+LsZ2/i1uLOknmUO5m bLvx31K1QYniWjALqC9kH50ZhaK3ioHWwjLplaRHYCDoLwHMMsQQv/6Jlc51Mi69SD6f R7ZVyv654nCVwzHaiVnMEj0M5rbrZPmOLcu/Agt2TAkuP1nRknwWgLjaS0UYMY2GU42k m/vmng+Gm6/dOhU7VnnBzizb7O1obxckgVjwlnyeUhC/ALdcfAVIySxirAl04GEzaRtz lkG3nOWLRmxZqEwUqoOXNukXYEBs+jXPWKTiYWIk/474hHOqYrlQsrtXDXZSmos/LqHQ 2hjA== X-Gm-Message-State: AOJu0Yw+XhD7ZyHvD2bXAZ/5kHU/jdxySFht0JsOXsGJ7BGf4NxUKmr/ arBYLV04jmEh0bFQTnjMaXikL88Y/2bP77284Bp+C2zsSmT+X11u3+J57Kp3vyvHD0uEYaM3b1x MV8khPfE4dn94L5I9aevTFiHXfkJZfkY8gss1h5aWU659xT4o X-Received: by 2002:a17:906:270b:b0:a28:e451:b023 with SMTP id z11-20020a170906270b00b00a28e451b023mr1093669ejc.145.1704468116335; Fri, 05 Jan 2024 07:21:56 -0800 (PST) X-Google-Smtp-Source: AGHT+IGQY4isbmkx0ezLO2LhTLTYXcX8Thqdvs1vKKmu4JjT/DRJLBcJ+3Na9NmK4+yNkl3jyGF0vg== X-Received: by 2002:a17:906:270b:b0:a28:e451:b023 with SMTP id z11-20020a170906270b00b00a28e451b023mr1093664ejc.145.1704468116100; Fri, 05 Jan 2024 07:21:56 -0800 (PST) Received: from amikhalitsyn.lan ([91.64.72.41]) by smtp.gmail.com with ESMTPSA id i23-20020a170906115700b00a298adde5a1sm345630eja.189.2024.01.05.07.21.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Jan 2024 07:21:55 -0800 (PST) From: Alexander Mikhalitsyn To: mszeredi@redhat.com Cc: Alexander Mikhalitsyn , Miklos Szeredi , Amir Goldstein , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v1 2/3] fuse: use GFP_KERNEL_ACCOUNT for allocations in fuse_dev_alloc Date: Fri, 5 Jan 2024 16:21:28 +0100 Message-Id: <20240105152129.196824-3-aleksandr.mikhalitsyn@canonical.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240105152129.196824-1-aleksandr.mikhalitsyn@canonical.com> References: <20240105152129.196824-1-aleksandr.mikhalitsyn@canonical.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" fuse_dev_alloc() is called from the process context and it makes sense to properly account allocated memory to the kmemcg as these allocations are for long living objects. Cc: Miklos Szeredi Cc: Amir Goldstein Cc: Cc: Signed-off-by: Alexander Mikhalitsyn --- fs/fuse/inode.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/fs/fuse/inode.c b/fs/fuse/inode.c index 2a6d44f91729..b8636b5e79dc 100644 --- a/fs/fuse/inode.c +++ b/fs/fuse/inode.c @@ -1415,11 +1415,11 @@ struct fuse_dev *fuse_dev_alloc(void) struct fuse_dev *fud; struct list_head *pq; =20 - fud =3D kzalloc(sizeof(struct fuse_dev), GFP_KERNEL); + fud =3D kzalloc(sizeof(struct fuse_dev), GFP_KERNEL_ACCOUNT); if (!fud) return NULL; =20 - pq =3D kcalloc(FUSE_PQ_HASH_SIZE, sizeof(struct list_head), GFP_KERNEL); + pq =3D kcalloc(FUSE_PQ_HASH_SIZE, sizeof(struct list_head), GFP_KERNEL_AC= COUNT); if (!pq) { kfree(fud); return NULL; --=20 2.34.1 From nobody Mon Feb 9 05:45:03 2026 Received: from smtp-relay-internal-1.canonical.com (smtp-relay-internal-1.canonical.com [185.125.188.123]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A85083173E for ; Fri, 5 Jan 2024 15:22:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=canonical.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=canonical.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=canonical.com header.i=@canonical.com header.b="UE8vaO1I" Received: from mail-ed1-f71.google.com (mail-ed1-f71.google.com [209.85.208.71]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-1.canonical.com (Postfix) with ESMTPS id F32EF3F468 for ; Fri, 5 Jan 2024 15:22:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1704468121; bh=3ehRu/Zuzjv9SF1nMloRA0oZhzJAyfoaCoaYcJRfDMg=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=UE8vaO1Ix0h0HypNFxX3xnrcJENd2rJTrb8XVFzVrxiuDQKZqr/t6KO/eCv/49seL gD2zmqSJXsRDDZU5dbx9zVJRMD6mK6eNFBa5pUO5Q7Sx45Zle0TeF1RYRo3APFRe1P zXa2cX2I5tSw09U7ZSzhYj7xrUtYhxMT3l07dpcYBGTJIpU8xsqcScIp4OIDUr3+Tt lKKZf8OC2oWvw67tQsakjKfZwhBRC3Tq5HgOiKKMTZtsvQPLM9R5oCdCA/DlbhA0nQ knrq4Gn1MJSz6OeuagpPjszITc3XAJx1Xg7aDWr/UkAOwBT5tnWRFbbINfXLWwwXSD 51u4bgTrRtHCg== Received: by mail-ed1-f71.google.com with SMTP id 4fb4d7f45d1cf-556415459d2so983322a12.0 for ; Fri, 05 Jan 2024 07:22:00 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704468120; x=1705072920; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=3ehRu/Zuzjv9SF1nMloRA0oZhzJAyfoaCoaYcJRfDMg=; b=d+VQYJlbbB2RJwOjLsUhFMQuVnb1SbX2yCc3QJcOkKJPHvqRaewlDLKRkCqyXosqKx LtzaiZijK9xm1T3qBP+s5zXUnM0iDvm/flD1Bci2ZS/G4KbOZn0oYag58xgWvrnfK6Y6 751pMxBLYT8axQjLRHFCXcP29y2npbDhPIb/+1LM28kWu4G6PueZNK8coLAK+Lh/0fXL p2rEoZF8areEeh/4DcxOaF27zkgy2eSltQ7VTjX+TjdwkyDIQ1mWTYFlSBMVMF/5S4Ku Onx4FWT0wUUGzMtMN9yen1RwBJhWJvRinAQvfiNWG4xHpfDDo+u5yTKO5i1lSVG6oGbM gu4Q== X-Gm-Message-State: AOJu0YwYyPNzaAf66U+e37KtXvq0UebwdfYvQ6FTuj1J27s8ONOSgIVG ZNhg1Y2wIiTo1RD628+TunA3gTn7DaY5IEXEwYpHPDMUmQUMNPBT2GeMCrnr1jS2Of3hNMgStw6 h1HuRKxkNv6/j515D2jz7oR1Wh9NC6XWPA5HEgA/jsz48nTxcR3x1Mpgy X-Received: by 2002:a17:906:e0d8:b0:a27:6e73:a248 with SMTP id gl24-20020a170906e0d800b00a276e73a248mr773799ejb.68.1704468120505; Fri, 05 Jan 2024 07:22:00 -0800 (PST) X-Google-Smtp-Source: AGHT+IE1Qf95Xc1DtQrvYbmkcZs/ajyvnuK5OKpFVhctUoOgo9efyvmBIthHb9SYj+TsVGtv7sYLnA== X-Received: by 2002:a17:906:e0d8:b0:a27:6e73:a248 with SMTP id gl24-20020a170906e0d800b00a276e73a248mr773791ejb.68.1704468120298; Fri, 05 Jan 2024 07:22:00 -0800 (PST) Received: from amikhalitsyn.lan ([91.64.72.41]) by smtp.gmail.com with ESMTPSA id i23-20020a170906115700b00a298adde5a1sm345630eja.189.2024.01.05.07.21.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Jan 2024 07:21:59 -0800 (PST) From: Alexander Mikhalitsyn To: mszeredi@redhat.com Cc: Alexander Mikhalitsyn , Christian Brauner , Miklos Szeredi , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v1 3/3] fuse: __kuid_val/__kgid_val helpers in fuse_fill_attr_from_inode() Date: Fri, 5 Jan 2024 16:21:29 +0100 Message-Id: <20240105152129.196824-4-aleksandr.mikhalitsyn@canonical.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240105152129.196824-1-aleksandr.mikhalitsyn@canonical.com> References: <20240105152129.196824-1-aleksandr.mikhalitsyn@canonical.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" For the sake of consistency, let's use these helpers to extract {u,g}id_t values from k{u,g}id_t ones. There are no functional changes, just to make code cleaner. Cc: Christian Brauner Cc: Miklos Szeredi Cc: Cc: Signed-off-by: Alexander Mikhalitsyn Reviewed-by: Christian Brauner --- fs/fuse/inode.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/fs/fuse/inode.c b/fs/fuse/inode.c index b8636b5e79dc..ab824a8908b7 100644 --- a/fs/fuse/inode.c +++ b/fs/fuse/inode.c @@ -1489,8 +1489,8 @@ static void fuse_fill_attr_from_inode(struct fuse_att= r *attr, .ctimensec =3D ctime.tv_nsec, .mode =3D fi->inode.i_mode, .nlink =3D fi->inode.i_nlink, - .uid =3D fi->inode.i_uid.val, - .gid =3D fi->inode.i_gid.val, + .uid =3D __kuid_val(fi->inode.i_uid), + .gid =3D __kgid_val(fi->inode.i_gid), .rdev =3D fi->inode.i_rdev, .blksize =3D 1u << fi->inode.i_blkbits, }; --=20 2.34.1