From nobody Fri Dec 26 19:27:10 2025 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id BEF4935283; Thu, 4 Jan 2024 17:15:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 579921007; Thu, 4 Jan 2024 09:16:34 -0800 (PST) Received: from e129166.arm.com (unknown [10.57.88.128]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id E43673F64C; Thu, 4 Jan 2024 09:15:45 -0800 (PST) From: Lukasz Luba To: linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, rafael@kernel.org Cc: lukasz.luba@arm.com, dietmar.eggemann@arm.com, rui.zhang@intel.com, amit.kucheria@verdurent.com, amit.kachhap@gmail.com, daniel.lezcano@linaro.org, viresh.kumar@linaro.org, len.brown@intel.com, pavel@ucw.cz, mhiramat@kernel.org, qyousef@layalina.io, wvw@google.com Subject: [PATCH v6 21/23] PM: EM: Remove old table Date: Thu, 4 Jan 2024 17:15:51 +0000 Message-Id: <20240104171553.2080674-22-lukasz.luba@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20240104171553.2080674-1-lukasz.luba@arm.com> References: <20240104171553.2080674-1-lukasz.luba@arm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Remove the old EM table which wasn't able to modify the data. Clean the unneeded function and refactor the code a bit. Signed-off-by: Lukasz Luba --- include/linux/energy_model.h | 2 -- kernel/power/energy_model.c | 46 ++++++------------------------------ 2 files changed, 7 insertions(+), 41 deletions(-) diff --git a/include/linux/energy_model.h b/include/linux/energy_model.h index 4a39825d3479..dd8a69bdf0d0 100644 --- a/include/linux/energy_model.h +++ b/include/linux/energy_model.h @@ -53,7 +53,6 @@ struct em_perf_table { =20 /** * struct em_perf_domain - Performance domain - * @table: List of performance states, in ascending order * @em_table: Pointer to the runtime modifiable em_perf_table * @nr_perf_states: Number of performance states * @flags: See "em_perf_domain flags" @@ -69,7 +68,6 @@ struct em_perf_table { * field is unused. */ struct em_perf_domain { - struct em_perf_state *table; struct em_perf_table __rcu *em_table; int nr_perf_states; unsigned long flags; diff --git a/kernel/power/energy_model.c b/kernel/power/energy_model.c index 1257b8fea9fc..79877d8975d5 100644 --- a/kernel/power/energy_model.c +++ b/kernel/power/energy_model.c @@ -285,17 +285,6 @@ static int em_compute_costs(struct device *dev, struct= em_perf_state *table, return 0; } =20 -static int em_allocate_perf_table(struct em_perf_domain *pd, - int nr_states) -{ - pd->table =3D kcalloc(nr_states, sizeof(struct em_perf_state), - GFP_KERNEL); - if (!pd->table) - return -ENOMEM; - - return 0; -} - /** * em_dev_update_perf_domain() - Update runtime EM table for a device * @dev : Device for which the EM is to be updated @@ -337,24 +326,6 @@ int em_dev_update_perf_domain(struct device *dev, } EXPORT_SYMBOL_GPL(em_dev_update_perf_domain); =20 -static int em_create_runtime_table(struct em_perf_domain *pd) -{ - struct em_perf_table __rcu *table; - int table_size; - - table =3D em_allocate_table(pd); - if (!table) - return -ENOMEM; - - /* Initialize runtime table with existing data */ - table_size =3D sizeof(struct em_perf_state) * pd->nr_perf_states; - memcpy(table->state, pd->table, table_size); - - rcu_assign_pointer(pd->em_table, table); - - return 0; -} - static int em_create_perf_table(struct device *dev, struct em_perf_domain = *pd, struct em_perf_state *table, struct em_data_callback *cb, @@ -415,6 +386,7 @@ static int em_create_pd(struct device *dev, int nr_stat= es, struct em_data_callback *cb, cpumask_t *cpus, unsigned long flags) { + struct em_perf_table __rcu *em_table; struct em_perf_domain *pd; struct device *cpu_dev; int cpu, ret, num_cpus; @@ -441,17 +413,15 @@ static int em_create_pd(struct device *dev, int nr_st= ates, =20 pd->nr_perf_states =3D nr_states; =20 - ret =3D em_allocate_perf_table(pd, nr_states); - if (ret) + em_table =3D em_allocate_table(pd); + if (!em_table) goto free_pd; =20 - ret =3D em_create_perf_table(dev, pd, pd->table, cb, flags); + ret =3D em_create_perf_table(dev, pd, em_table->state, cb, flags); if (ret) goto free_pd_table; =20 - ret =3D em_create_runtime_table(pd); - if (ret) - goto free_pd_table; + rcu_assign_pointer(pd->em_table, em_table); =20 if (_is_cpu_device(dev)) for_each_cpu(cpu, cpus) { @@ -464,7 +434,7 @@ static int em_create_pd(struct device *dev, int nr_stat= es, return 0; =20 free_pd_table: - kfree(pd->table); + kfree(em_table); free_pd: kfree(pd); return -EINVAL; @@ -635,7 +605,7 @@ int em_dev_register_perf_domain(struct device *dev, uns= igned int nr_states, =20 dev->em_pd->flags |=3D flags; =20 - em_cpufreq_update_efficiencies(dev, dev->em_pd->table); + em_cpufreq_update_efficiencies(dev, dev->em_pd->em_table->state); =20 em_debug_create_pd(dev); dev_info(dev, "EM: created perf domain\n"); @@ -672,8 +642,6 @@ void em_dev_unregister_perf_domain(struct device *dev) mutex_lock(&em_pd_mutex); em_debug_remove_pd(dev); =20 - kfree(dev->em_pd->table); - em_free_table(dev->em_pd->em_table); =20 kfree(dev->em_pd); --=20 2.25.1