From nobody Fri Dec 19 17:00:29 2025 Received: from gofer.mess.org (gofer.mess.org [88.97.38.141]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A1BA5156C4; Fri, 22 Dec 2023 10:47:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=mess.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=mess.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=mess.org header.i=@mess.org header.b="llKWctkZ"; dkim=pass (2048-bit key) header.d=mess.org header.i=@mess.org header.b="fo8v5dvS" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=mess.org; s=2020; t=1703242021; bh=S3TdkYP2WghBFHy35jL/ROGvth6643mc86CxxDgb1U8=; h=From:To:Cc:Subject:Date:From; b=llKWctkZv4YXmaxVOF9OKSKxzPicte/5tLmA3UC+X1dm+y4jaf4hqqUOYgpeLb+Cf 8F/6mX7rcEqJbiFxwn8hBKr6XfbOatNC9Nvgjn469N1E/hDI6e+O+/XsQ0jOVAfbo/ HpJphrAmKk0xtTPRY6FhzZlzoy7MPzGNVVIWlyNCUt8dy854xoeAFHQnRS9B9Eun9h /Ckc2R9ELoCqZNB0bL8J4I4V1ItuREUYYhaRL0xwOJb6SR/PammSO+wVSYh+yNfFqL 8BMMQvbRz7jzh5Qijo87HbFdKLG3x7nV9g3EDq1wp4wbHPFIl+5vWSKe3zPZibAgkb 2tRMZrsr2l4tQ== Received: by gofer.mess.org (Postfix, from userid 501) id C424B1009FC; Fri, 22 Dec 2023 10:47:01 +0000 (GMT) X-Spam-Level: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=mess.org; s=2020; t=1703242019; bh=S3TdkYP2WghBFHy35jL/ROGvth6643mc86CxxDgb1U8=; h=From:To:Cc:Subject:Date:From; b=fo8v5dvSUCgr8MIUEOxgdZZeY146rwQuo9A8VEI4kkJCThHrjjsN/3OROrZnDrsEz jxqjs8Tmc1fcYma2x+rAAKUmvMQowixuUVuQoUEC4nL+95fVw5jyMvabXmji1mUtqn Z6ENDQUsCF7XGNZXaVKNzHKcjCoXflFdR5nzywpo4zB9T0PUka+6SB0hLi2KvtAE6h GhS8hmA9Iy28/tDj8nM3ivCyLgjW9Z2hLOqIxn3SMccgWnmQSz07VgUQSZo2hE6O3K i/entkExxaVWEP60GtBZK+pYRiTxU0QK9gcMCxAQOl/fjpnkiDJrOK/qj0jTBneegu mfzJxGUDy4/gg== Received: from localhost.localdomain (bigcore.local [IPv6:2a02:8011:d000:212:ca7f:54ff:fe51:14d6]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by gofer.mess.org (Postfix) with ESMTPSA id CDA5C1000CC; Fri, 22 Dec 2023 10:46:59 +0000 (GMT) From: Sean Young To: Thierry Reding , =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= , Florian Fainelli , Broadcom internal kernel review list , Ray Jui , Scott Branden Cc: Sean Young , linux-pwm@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH] pwm: bcm2835: Duplicate call to clk_rate_exclusive_put in error path Date: Fri, 22 Dec 2023 10:46:51 +0000 Message-ID: <20231222104651.167821-1-sean@mess.org> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable devm_add_action_or_reset() already calls the action in the error case. Reported-by: Uwe Kleine-K=C3=B6nig Closes: https://lore.kernel.org/linux-pwm/fuku3b5ur6y4k4refd3vmeoenzjo6mwe3= b3gtel34rhhhtvnsa@w4uktgbqsc3w/ Signed-off-by: Sean Young Reviewed-by: Uwe Kleine-K=C3=B6nig --- drivers/pwm/pwm-bcm2835.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/pwm/pwm-bcm2835.c b/drivers/pwm/pwm-bcm2835.c index 307c0bd5f885..283cf27f25ba 100644 --- a/drivers/pwm/pwm-bcm2835.c +++ b/drivers/pwm/pwm-bcm2835.c @@ -160,10 +160,8 @@ static int bcm2835_pwm_probe(struct platform_device *p= dev) =20 ret =3D devm_add_action_or_reset(&pdev->dev, devm_clk_rate_exclusive_put, pc->clk); - if (ret) { - clk_rate_exclusive_put(pc->clk); + if (ret) return ret; - } =20 pc->rate =3D clk_get_rate(pc->clk); if (!pc->rate) --=20 2.43.0