From nobody Fri Dec 19 17:01:12 2025 Received: from relay5-d.mail.gandi.net (relay5-d.mail.gandi.net [217.70.183.197]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0951C77B2D; Thu, 21 Dec 2023 18:01:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="VyH2yd6j" Received: by mail.gandi.net (Postfix) with ESMTPSA id 031711C0014; Thu, 21 Dec 2023 18:01:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1703181666; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=h/OcM575L8jfFrXX7VS5ua1XDSMjSEzffW/tbXnntiI=; b=VyH2yd6jgkQerMi4KTWgfHqLztMfSWsKsUpetFQzgZGycFFvcdutjL/CCXb5HJOv8E3LIk wjZ7aw82tUPnOTtd/d44oloODjD1it13YaHZ/dWfuYYnLAiYZ0xPWu0fpJBEyp8SmAIzd1 3Qo5eD00lmTLuJ7sHY0nI8erKmiSdGhYLd3iny+VD11Vq6+zYSUXOr8/EjRJCBaFkaAIkA jHZBh6bG6cIMm+kytQvI88DU2xR2tSr2xcnbiZomH4DJ9GAgtlGmwkHQ2x+Ct6P6S2HoKL +tIUlvy+JXQW7yUrls9cB7yoUuqPg8in5y6vtdT1VUoxZsMOrtvGy8sAkfipqA== From: Maxime Chevallier To: davem@davemloft.net Cc: Maxime Chevallier , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, thomas.petazzoni@bootlin.com, Andrew Lunn , Jakub Kicinski , Eric Dumazet , Paolo Abeni , Russell King , linux-arm-kernel@lists.infradead.org, Christophe Leroy , Herve Codina , Florian Fainelli , Heiner Kallweit , Vladimir Oltean , =?UTF-8?q?K=C3=B6ry=20Maincent?= , Jesse Brandeburg , Jonathan Corbet , =?UTF-8?q?Marek=20Beh=C3=BAn?= , Piergiorgio Beruto , Oleksij Rempel , =?UTF-8?q?Nicol=C3=B2=20Veronese?= , Simon Horman Subject: [PATCH net-next v5 11/13] net: ethtool: cable-test: Target the command to the requested PHY Date: Thu, 21 Dec 2023 19:00:44 +0100 Message-ID: <20231221180047.1924733-12-maxime.chevallier@bootlin.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20231221180047.1924733-1-maxime.chevallier@bootlin.com> References: <20231221180047.1924733-1-maxime.chevallier@bootlin.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-GND-Sasl: maxime.chevallier@bootlin.com Content-Type: text/plain; charset="utf-8" Cable testing is a PHY-specific command. Instead of targeting the command towards dev->phydev, use the request to pick the targeted PHY. Signed-off-by: Maxime Chevallier Reviewed-by: Andrew Lunn --- V5: Added Andrew's R-b V4: No changes V3: No changes V2: New patch net/ethtool/cabletest.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/net/ethtool/cabletest.c b/net/ethtool/cabletest.c index 06a151165c31..6b00d0800f23 100644 --- a/net/ethtool/cabletest.c +++ b/net/ethtool/cabletest.c @@ -69,7 +69,7 @@ int ethnl_act_cable_test(struct sk_buff *skb, struct genl= _info *info) return ret; =20 dev =3D req_info.dev; - if (!dev->phydev) { + if (!req_info.phydev) { ret =3D -EOPNOTSUPP; goto out_dev_put; } @@ -85,12 +85,12 @@ int ethnl_act_cable_test(struct sk_buff *skb, struct ge= nl_info *info) if (ret < 0) goto out_rtnl; =20 - ret =3D ops->start_cable_test(dev->phydev, info->extack); + ret =3D ops->start_cable_test(req_info.phydev, info->extack); =20 ethnl_ops_complete(dev); =20 if (!ret) - ethnl_cable_test_started(dev->phydev, + ethnl_cable_test_started(req_info.phydev, ETHTOOL_MSG_CABLE_TEST_NTF); =20 out_rtnl: @@ -321,7 +321,7 @@ int ethnl_act_cable_test_tdr(struct sk_buff *skb, struc= t genl_info *info) return ret; =20 dev =3D req_info.dev; - if (!dev->phydev) { + if (!req_info.phydev) { ret =3D -EOPNOTSUPP; goto out_dev_put; } @@ -342,12 +342,12 @@ int ethnl_act_cable_test_tdr(struct sk_buff *skb, str= uct genl_info *info) if (ret < 0) goto out_rtnl; =20 - ret =3D ops->start_cable_test_tdr(dev->phydev, info->extack, &cfg); + ret =3D ops->start_cable_test_tdr(req_info.phydev, info->extack, &cfg); =20 ethnl_ops_complete(dev); =20 if (!ret) - ethnl_cable_test_started(dev->phydev, + ethnl_cable_test_started(req_info.phydev, ETHTOOL_MSG_CABLE_TEST_TDR_NTF); =20 out_rtnl: --=20 2.43.0