From nobody Fri Sep 20 08:33:40 2024 Received: from mail-io1-f48.google.com (mail-io1-f48.google.com [209.85.166.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 510124B5CA for ; Wed, 20 Dec 2023 23:55:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="UoatwZ4i" Received: by mail-io1-f48.google.com with SMTP id ca18e2360f4ac-7b798e6f702so8431739f.2 for ; Wed, 20 Dec 2023 15:55:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1703116510; x=1703721310; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=pRvpMTwdfOti1O2FiABGEbKxnsSHcyKdzfu7EEJhob4=; b=UoatwZ4iml1hN1QxLiYWvS5o5aZ8KsYbpWuj2St8UO820yw4ti1xYKe+M3+hWqXAWG E9Lq3PNJgEWxozl3VGkcaxtNTVTEtbJpL4KYN3BoTCobgrm2vj2HIblbGIJ//Se/MGvQ hh/WzI4eznFLsxooAHAgtzZNl0Fykkxb3GLcQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1703116510; x=1703721310; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=pRvpMTwdfOti1O2FiABGEbKxnsSHcyKdzfu7EEJhob4=; b=c/Gc2G2q+hkDkpFMvhIb09e6/gA/5l1fRehE8Pz+o11O5L/GENApG7wwmy7VXNOEF4 6KDFi+bseKR1Kd9rDdD0Xl6bJwu0UnhrPWf3lqN4md1NK+1nqwhtShdMd/LgJXciGB+M 9j3gBnyDYvc65B2pcsLIPZCLRZh0LAgmjRNh8utftsbyNJ4K9C5/O+smuKhz19qXy80T jnrqq0jVCHSAB+U0iDzdo1ugxpfQrtTjmCh532mkCNJkCX8y9r65AB93IaEhsQC3dsZf yU5+UGdAZH8dx7pwNu11fGGzawemnf4ztbl7GnJqCPDdCHtUAirEPCjsvF0sWW4HbFh2 qqPg== X-Gm-Message-State: AOJu0YzB9eV/DQfyNKxCZhSGsBo+BKVoAT/wpq2ESIWCJm6t4jkcIzAQ U4FOQmM4iHiqXmTk+jicemXGAyvvbaqebiK4fik= X-Google-Smtp-Source: AGHT+IG+XWPItl49/At9uM5COVFdcWHUAZiiVDu/MVuO968/qb/IMfBKb9s1EXBx+2bgz7sUHvkYUw== X-Received: by 2002:a05:6602:2bed:b0:7ba:86c3:d975 with SMTP id d13-20020a0566022bed00b007ba86c3d975mr151496ioy.26.1703116510370; Wed, 20 Dec 2023 15:55:10 -0800 (PST) Received: from markhas1.lan (71-218-50-136.hlrn.qwest.net. [71.218.50.136]) by smtp.gmail.com with ESMTPSA id bp22-20020a056638441600b0046b39a6f404sm177805jab.17.2023.12.20.15.55.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 Dec 2023 15:55:09 -0800 (PST) From: Mark Hasemeyer To: LKML Cc: AngeloGioacchino Del Regno , Krzysztof Kozlowski , Tzung-Bi Shih , Raul Rangel , Konrad Dybcio , Andy Shevchenko , Rob Herring , Sudeep Holla , Mark Hasemeyer , Conor Dooley , Krzysztof Kozlowski , Rob Herring , devicetree@vger.kernel.org Subject: [PATCH v2 03/22] Documentation: devicetree: Clarify wording for wakeup-source property Date: Wed, 20 Dec 2023 16:54:17 -0700 Message-ID: <20231220165423.v2.3.I1016a45ac9e8daf8a9ebc9854ab90ec3542e7c30@changeid> X-Mailer: git-send-email 2.43.0.472.g3155946c3a-goog In-Reply-To: <20231220235459.2965548-1-markhas@chromium.org> References: <20231220235459.2965548-1-markhas@chromium.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The wording in the current documentation is a little strong. The intention was not to fix any particular interrupt as wakeup capable but leave those details to the device. It wasn't intended to enforce any rules as what can be or can't be a wakeup interrupt. Soften the wording to not mandate that the 'wakeup-source' property be used, and clarify what it means when an interrupt is marked (or not marked) for wakeup. Link: https://lore.kernel.org/all/ZYAjxxHcCOgDVMTQ@bogus/ Link: https://lore.kernel.org/all/CAL_Jsq+MYwOG40X26cYmO9EkZ9xqWrXDi03MaRfx= nV-+VGkXWQ@mail.gmail.com/ Signed-off-by: Mark Hasemeyer --- Changes in v2: -New patch .../bindings/power/wakeup-source.txt | 18 +++++++++++------- 1 file changed, 11 insertions(+), 7 deletions(-) diff --git a/Documentation/devicetree/bindings/power/wakeup-source.txt b/Do= cumentation/devicetree/bindings/power/wakeup-source.txt index 697333a56d5e2..75bc20b95688f 100644 --- a/Documentation/devicetree/bindings/power/wakeup-source.txt +++ b/Documentation/devicetree/bindings/power/wakeup-source.txt @@ -3,16 +3,20 @@ Specifying wakeup capability for devices =20 Any device nodes ---------------- -Nodes that describe devices which has wakeup capability must contain an +Nodes that describe devices which have wakeup capability may contain a "wakeup-source" boolean property. =20 -Also, if device is marked as a wakeup source, then all the primary -interrupt(s) can be used as wakeup interrupt(s). +If the device is marked as a wakeup-source, interrupt wake capability depe= nds +on the device specific "interrupt-names" property. If no interrupts are la= beled +as wake capable, then it is up to the device to determine which interrupts= can +wake the system. =20 -However if the devices have dedicated interrupt as the wakeup source -then they need to specify/identify the same using device specific -interrupt name. In such cases only that interrupt can be used as wakeup -interrupt. +However if a device has a dedicated interrupt as the wakeup source, then it +needs to specify/identify it using a device specific interrupt name. In su= ch +cases only that interrupt can be used as a wakeup interrupt. + +While various legacy interrupt names exist, new devices should use "wakeup= " as +the canonical interrupt name. =20 List of legacy properties and respective binding document --------------------------------------------------------- --=20 2.43.0.472.g3155946c3a-goog