From nobody Sat Dec 27 11:01:24 2025 Received: from m15.mail.163.com (m15.mail.163.com [45.254.50.219]) by smtp.subspace.kernel.org (Postfix) with ESMTP id E6350208A5; Wed, 20 Dec 2023 10:34:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=163.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=163.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=163.com header.i=@163.com header.b="Up1r4dwn" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:Subject:Date:Message-Id:MIME-Version; bh=Z0swl vC0MCYVh5hNtI+/mhkIaiC3hDyw+jzAaT3KLfQ=; b=Up1r4dwnZs6SMYokmOeYl 09xtjYed3sk323KRWTra8EeSrcaIWnrlRxGGCFV68Rs2zYbs5hDUGT94KzxhzQqb iUZAGtroLzJfMICytuqeNAVG9fNYWrL8DZxhIO03Ov1H6DbDoRdpn4XeZ4k6oSfo oicbnc8ilbi1ZRpf7+K8lw= Received: from ProDesk.. (unknown [58.22.7.114]) by zwqz-smtp-mta-g0-0 (Coremail) with SMTP id _____wCXnyMCw4JlbFzLGA--.15074S2; Wed, 20 Dec 2023 18:33:41 +0800 (CST) From: Andy Yan To: heiko@sntech.de Cc: jbx6244@gmail.com, krzysztof.kozlowski+dt@linaro.org, robh+dt@kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, david.wu@rock-chips.com, Andy Yan Subject: [PATCH] Revert "ARM: dts: rockchip: restyle emac nodes" Date: Wed, 20 Dec 2023 18:33:34 +0800 Message-Id: <20231220103334.2665543-1-andyshrk@163.com> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-CM-TRANSID: _____wCXnyMCw4JlbFzLGA--.15074S2 X-Coremail-Antispam: 1Uf129KBjvJXoWxuw48Gr1fCFWkWrW3urW5GFg_yoW3GFWfpw nxArZ7Xrs7Wr4Fg398J34DJrs8Aw4qkwsY9rs7Cr4rJF1I93s7tr17Krn3ua42qrW5A3yI 9r4fCr92ywsrXw7anT9S1TB71UUUUUUqnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDUYxBIdaVFxhVjvjDU0xZFpf9x07jrxhdUUUUU= X-CM-SenderInfo: 5dqg52xkunqiywtou0bp/xtbBEAdMXmVOBEAhLQAAsm Content-Type: text/plain; charset="utf-8" From: Andy Yan When try to run rk3036 kylin board with mainline, I found the emac ethernet probe failed: [ 2.324583] loop: module loaded [ 2.328435] SPI driver spidev has no spi_device_id for rockchip,spidev [ 2.338688] tun: Universal TUN/TAP device driver, 1.6 [ 2.345397] rockchip_emac 10200000.ethernet: no regulator found [ 2.351892] rockchip_emac 10200000.ethernet: ARC EMAC detected with id: = 0x7fd02 [ 2.359331] rockchip_emac 10200000.ethernet: IRQ is 43 [ 2.364719] rockchip_emac 10200000.ethernet: MAC address is now e6:58:d6= :ec:d9:7c [ 2.396993] mdio_bus Synopsys MII Bus: mdio has invalid PHY address [ 2.403306] mdio_bus Synopsys MII Bus: scan phy mdio at address 0 [ 2.508656] rockchip_emac 10200000.ethernet: of_phy_connect() failed [ 2.516334] rockchip_emac 10200000.ethernet: failed to probe arc emac (-= 19) This reverts commit 1dabb74971b3 ("ARM: dts: rockchip: restyle emac nodes") make emac on rk3036 kylin board probe right again: [ 1.920385] CAN device driver interface [ 1.925499] rockchip_emac 10200000.ethernet: no regulator found [ 1.932535] rockchip_emac 10200000.ethernet: ARC EMAC detected with id: = 0x7fd02 [ 1.940735] rockchip_emac 10200000.ethernet: IRQ is 42 [ 1.946743] rockchip_emac 10200000.ethernet: MAC address is now 96:7d:4f= :0a:69:b3 [ 2.581340] rockchip_emac 10200000.ethernet: connected to Generic PHY ph= y with id 0xffffc816 [ 2.592560] e1000e: Intel(R) PRO/1000 Network Driver [ 2.598136] e1000e: Copyright(c) 1999 - 2015 Intel Corporation. Fixes: 1dabb74971b3 ("ARM: dts: rockchip: restyle emac nodes") Signed-off-by: Andy Yan --- arch/arm/boot/dts/rockchip/rk3036-evb.dts | 16 ++++++---------- arch/arm/boot/dts/rockchip/rk3036-kylin.dts | 16 ++++++---------- arch/arm/boot/dts/rockchip/rk3036.dtsi | 2 ++ .../boot/dts/rockchip/rk3066a-marsboard.dts | 17 +++++++---------- .../boot/dts/rockchip/rk3066a-rayeager.dts | 15 +++++---------- .../boot/dts/rockchip/rk3188-radxarock.dts | 19 ++++++++----------- arch/arm/boot/dts/rockchip/rk3xxx.dtsi | 2 ++ 7 files changed, 36 insertions(+), 51 deletions(-) diff --git a/arch/arm/boot/dts/rockchip/rk3036-evb.dts b/arch/arm/boot/dts/= rockchip/rk3036-evb.dts index becdc0b664bf..94216f870b57 100644 --- a/arch/arm/boot/dts/rockchip/rk3036-evb.dts +++ b/arch/arm/boot/dts/rockchip/rk3036-evb.dts @@ -15,20 +15,16 @@ memory@60000000 { }; =20 &emac { - phy =3D <&phy0>; - phy-reset-duration =3D <10>; /* millisecond */ - phy-reset-gpios =3D <&gpio2 RK_PC6 GPIO_ACTIVE_LOW>; /* PHY_RST */ pinctrl-names =3D "default"; pinctrl-0 =3D <&emac_xfer>, <&emac_mdio>; - status =3D "okay"; + phy =3D <&phy0>; + phy-reset-gpios =3D <&gpio2 RK_PC6 GPIO_ACTIVE_LOW>; /* PHY_RST */ + phy-reset-duration =3D <10>; /* millisecond */ =20 - mdio { - #address-cells =3D <1>; - #size-cells =3D <0>; + status =3D "okay"; =20 - phy0: ethernet-phy@0 { - reg =3D <0>; - }; + phy0: ethernet-phy@0 { + reg =3D <0>; }; }; =20 diff --git a/arch/arm/boot/dts/rockchip/rk3036-kylin.dts b/arch/arm/boot/dt= s/rockchip/rk3036-kylin.dts index 67e1e04139e7..e817eba8c622 100644 --- a/arch/arm/boot/dts/rockchip/rk3036-kylin.dts +++ b/arch/arm/boot/dts/rockchip/rk3036-kylin.dts @@ -80,20 +80,16 @@ &acodec { }; =20 &emac { - phy =3D <&phy0>; - phy-reset-duration =3D <10>; /* millisecond */ - phy-reset-gpios =3D <&gpio2 RK_PC6 GPIO_ACTIVE_LOW>; /* PHY_RST */ pinctrl-names =3D "default"; pinctrl-0 =3D <&emac_xfer>, <&emac_mdio>; - status =3D "okay"; + phy =3D <&phy0>; + phy-reset-gpios =3D <&gpio2 RK_PC6 GPIO_ACTIVE_LOW>; /* PHY_RST */ + phy-reset-duration =3D <10>; /* millisecond */ =20 - mdio { - #address-cells =3D <1>; - #size-cells =3D <0>; + status =3D "okay"; =20 - phy0: ethernet-phy@0 { - reg =3D <0>; - }; + phy0: ethernet-phy@0 { + reg =3D <0>; }; }; =20 diff --git a/arch/arm/boot/dts/rockchip/rk3036.dtsi b/arch/arm/boot/dts/roc= kchip/rk3036.dtsi index 78686fc72ce6..e240b89b0b35 100644 --- a/arch/arm/boot/dts/rockchip/rk3036.dtsi +++ b/arch/arm/boot/dts/rockchip/rk3036.dtsi @@ -228,6 +228,8 @@ emac: ethernet@10200000 { compatible =3D "rockchip,rk3036-emac"; reg =3D <0x10200000 0x4000>; interrupts =3D ; + #address-cells =3D <1>; + #size-cells =3D <0>; rockchip,grf =3D <&grf>; clocks =3D <&cru HCLK_MAC>, <&cru SCLK_MACREF>, <&cru SCLK_MAC>; clock-names =3D "hclk", "macref", "macclk"; diff --git a/arch/arm/boot/dts/rockchip/rk3066a-marsboard.dts b/arch/arm/bo= ot/dts/rockchip/rk3066a-marsboard.dts index f6e8d49a02ef..e3d6f0e81330 100644 --- a/arch/arm/boot/dts/rockchip/rk3066a-marsboard.dts +++ b/arch/arm/boot/dts/rockchip/rk3066a-marsboard.dts @@ -150,21 +150,18 @@ vcc28_cif: regulator@12 { #include "../tps65910.dtsi" =20 &emac { + status =3D "okay"; + phy =3D <&phy0>; phy-supply =3D <&vcc_rmii>; + pinctrl-names =3D "default"; pinctrl-0 =3D <&emac_xfer>, <&emac_mdio>, <&phy_int>; - status =3D "okay"; - - mdio { - #address-cells =3D <1>; - #size-cells =3D <0>; =20 - phy0: ethernet-phy@0 { - reg =3D <0>; - interrupt-parent =3D <&gpio1>; - interrupts =3D ; - }; + phy0: ethernet-phy@0 { + reg =3D <0>; + interrupt-parent =3D <&gpio1>; + interrupts =3D ; }; }; =20 diff --git a/arch/arm/boot/dts/rockchip/rk3066a-rayeager.dts b/arch/arm/boo= t/dts/rockchip/rk3066a-rayeager.dts index 29d8e5bf88f5..096616324c2d 100644 --- a/arch/arm/boot/dts/rockchip/rk3066a-rayeager.dts +++ b/arch/arm/boot/dts/rockchip/rk3066a-rayeager.dts @@ -142,20 +142,15 @@ &cpu1 { }; =20 &emac { - phy =3D <&phy0>; - phy-supply =3D <&vcc_rmii>; pinctrl-names =3D "default"; pinctrl-0 =3D <&emac_xfer>, <&emac_mdio>, <&rmii_rst>; + phy =3D <&phy0>; + phy-supply =3D <&vcc_rmii>; status =3D "okay"; =20 - mdio { - #address-cells =3D <1>; - #size-cells =3D <0>; - - phy0: ethernet-phy@0 { - reg =3D <0>; - reset-gpios =3D <&gpio1 RK_PD6 GPIO_ACTIVE_LOW>; - }; + phy0: ethernet-phy@0 { + reg =3D <0>; + reset-gpios =3D <&gpio1 RK_PD6 GPIO_ACTIVE_LOW>; }; }; =20 diff --git a/arch/arm/boot/dts/rockchip/rk3188-radxarock.dts b/arch/arm/boo= t/dts/rockchip/rk3188-radxarock.dts index 118deacd38c4..239d2ec37fdc 100644 --- a/arch/arm/boot/dts/rockchip/rk3188-radxarock.dts +++ b/arch/arm/boot/dts/rockchip/rk3188-radxarock.dts @@ -126,21 +126,18 @@ vsys: vsys-regulator { }; =20 &emac { - phy =3D <&phy0>; - phy-supply =3D <&vcc_rmii>; + status =3D "okay"; + pinctrl-names =3D "default"; pinctrl-0 =3D <&emac_xfer>, <&emac_mdio>, <&phy_int>; - status =3D "okay"; =20 - mdio { - #address-cells =3D <1>; - #size-cells =3D <0>; + phy =3D <&phy0>; + phy-supply =3D <&vcc_rmii>; =20 - phy0: ethernet-phy@0 { - reg =3D <0>; - interrupt-parent =3D <&gpio3>; - interrupts =3D ; - }; + phy0: ethernet-phy@0 { + reg =3D <0>; + interrupt-parent =3D <&gpio3>; + interrupts =3D ; }; }; =20 diff --git a/arch/arm/boot/dts/rockchip/rk3xxx.dtsi b/arch/arm/boot/dts/roc= kchip/rk3xxx.dtsi index cb4e42ede56a..17e89d30de78 100644 --- a/arch/arm/boot/dts/rockchip/rk3xxx.dtsi +++ b/arch/arm/boot/dts/rockchip/rk3xxx.dtsi @@ -193,6 +193,8 @@ emac: ethernet@10204000 { compatible =3D "snps,arc-emac"; reg =3D <0x10204000 0x3c>; interrupts =3D ; + #address-cells =3D <1>; + #size-cells =3D <0>; =20 rockchip,grf =3D <&grf>; =20 --=20 2.34.1