From nobody Fri Dec 19 09:45:03 2025 Received: from mail-ot1-f50.google.com (mail-ot1-f50.google.com [209.85.210.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2DF074BA8D for ; Sun, 17 Dec 2023 23:55:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=darkphysics.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=darkphysics.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=darkphysics.net header.i=@darkphysics.net header.b="lza6wNKF" Received: by mail-ot1-f50.google.com with SMTP id 46e09a7af769-6d9d4193d94so2207552a34.3 for ; Sun, 17 Dec 2023 15:55:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=darkphysics.net; s=google; t=1702857328; x=1703462128; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=eXLxevf4aUXA3wWWgPdFXar5eXPkWv3zOFKTufedNbo=; b=lza6wNKFNCQ4iqr9yt039GW22fEhUKCUgIzk4Pv07tXWYB0aohFLuS82OrKtR6gQN5 pUWMbAZ9Ds9N3Wk2pyzQuyhA+fEpRBRFmwsZWTRe+L7qqRVds4sk0o0PxQKUVTluZDeB NdmKHAvcVqZ0b4UeQP/nk3pLPU62YCFNi2oxFe6rQ0p3/7e5Y3vsncjovbb5zSDJvO7C IWfO1RKfE8NWDt++x5OVVaZzGjowrI1GvvI8luhthge1lkor2u+wLDQ+3FqS954rDD6x GxTIr1NI4lfhKYf0Xs6ZnqJJISJn+/W3L5J5kpQ5sDu1oY/NX+Dy7gBdZFnQkiLMxHRS ZHvQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702857328; x=1703462128; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=eXLxevf4aUXA3wWWgPdFXar5eXPkWv3zOFKTufedNbo=; b=t0BUh8Ej6NV7gA7sbAojIrLuk/nquHO5wb/4+t1hNaOFjoWYRrHxQcDQOQ/1MF9drG mszHml3+9ITkifAqRsnAYsEZXoS5tEl+k7wxriHpaiYYJJHT/mr06nRW0G7AWeBZ0Cfg C+xSXlxurTG//dP6LlFAIZGjTXAFjKU0A+MrOtszHblku27rPl8G4R+Eo4sPfVWdOBeo VWMVGNuOQl4wpMVJ/kAElzlPibaYgTyQNgbjBh709rhl4tAj8rsv6bePVKRemGWO6b6L GcNuUtOU/tOEmqexA505fenYP+HVt7GamMVStPKq2I5oFwfENq9eI5wVUei5P5b5oTNY 4MNA== X-Gm-Message-State: AOJu0YznSN1yeNwzMiPJUAtn9h6m3mOk+2UFPKDggwnQY34VE+vt04H+ aCw1BkvgDa3N47FdLYwpMNLVRw== X-Google-Smtp-Source: AGHT+IFoDEcFFi84M0TkMIePMPCmlNMXHemUSrGClgJxG96jTzzaqKgtRjJRCgD8WpaQ+GxXtCuDbA== X-Received: by 2002:a05:6358:e48b:b0:172:d78b:d2eb with SMTP id by11-20020a056358e48b00b00172d78bd2ebmr1473446rwb.10.1702857328274; Sun, 17 Dec 2023 15:55:28 -0800 (PST) Received: from oatmeal.darkphysics (c-76-146-178-2.hsd1.wa.comcast.net. [76.146.178.2]) by smtp.gmail.com with ESMTPSA id f11-20020a17090aec8b00b0028ae8284840sm9036176pjy.10.2023.12.17.15.55.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 17 Dec 2023 15:55:27 -0800 (PST) From: Tree Davies To: gregkh@linuxfoundation.org, philipp.g.hortmann@gmail.com, anjan@momi.ca Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Tree Davies Subject: [PATCH 5/6] Staging: rtl8192e: Rename variable TxRxSelect Date: Sun, 17 Dec 2023 15:55:19 -0800 Message-Id: <20231217235520.30377-6-tdavies@darkphysics.net> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20231217235520.30377-1-tdavies@darkphysics.net> References: <20231217235520.30377-1-tdavies@darkphysics.net> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Rename variable TxRxSelect to tx_rx_select to fix checkpatch warning Avoid CamelCase. Signed-off-by: Tree Davies --- drivers/staging/rtl8192e/rtl819x_BAProc.c | 18 ++++++++--------- drivers/staging/rtl8192e/rtl819x_TSProc.c | 24 +++++++++++------------ drivers/staging/rtl8192e/rtllib.h | 4 ++-- 3 files changed, 23 insertions(+), 23 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl819x_BAProc.c b/drivers/staging/rt= l8192e/rtl819x_BAProc.c index 2fd54312c04f..b816f94336f0 100644 --- a/drivers/staging/rtl8192e/rtl819x_BAProc.c +++ b/drivers/staging/rtl8192e/rtl819x_BAProc.c @@ -125,7 +125,7 @@ static struct sk_buff *rtllib_ADDBA(struct rtllib_devic= e *ieee, u8 *dst, =20 static struct sk_buff *rtllib_DELBA(struct rtllib_device *ieee, u8 *dst, struct ba_record *ba, - enum tr_select TxRxSelect, u16 reason_code) + enum tr_select tx_rx_select, u16 reason_code) { union delba_param_set del_ba_param_set; struct sk_buff *skb =3D NULL; @@ -139,7 +139,7 @@ static struct sk_buff *rtllib_DELBA(struct rtllib_devic= e *ieee, u8 *dst, =20 memset(&del_ba_param_set, 0, 2); =20 - del_ba_param_set.field.initiator =3D (TxRxSelect =3D=3D TX_DIR) ? 1 : 0; + del_ba_param_set.field.initiator =3D (tx_rx_select =3D=3D TX_DIR) ? 1 : 0; del_ba_param_set.field.tid =3D ba->ba_param_set.field.tid; =20 skb =3D dev_alloc_skb(len + sizeof(struct ieee80211_hdr_3addr)); @@ -199,12 +199,12 @@ static void rtllib_send_ADDBARsp(struct rtllib_device= *ieee, u8 *dst, } =20 static void rtllib_send_DELBA(struct rtllib_device *ieee, u8 *dst, - struct ba_record *ba, enum tr_select TxRxSelect, + struct ba_record *ba, enum tr_select tx_rx_select, u16 reason_code) { struct sk_buff *skb; =20 - skb =3D rtllib_DELBA(ieee, dst, ba, TxRxSelect, reason_code); + skb =3D rtllib_DELBA(ieee, dst, ba, tx_rx_select, reason_code); if (skb) softmac_mgmt_xmit(skb, ieee); else @@ -486,9 +486,9 @@ void rtllib_ts_init_add_ba(struct rtllib_device *ieee, = struct tx_ts_record *ts, =20 void rtllib_ts_init_del_ba(struct rtllib_device *ieee, struct ts_common_info *ts_common_info, - enum tr_select TxRxSelect) + enum tr_select tx_rx_select) { - if (TxRxSelect =3D=3D TX_DIR) { + if (tx_rx_select =3D=3D TX_DIR) { struct tx_ts_record *ts =3D (struct tx_ts_record *)ts_common_info; =20 @@ -497,14 +497,14 @@ void rtllib_ts_init_del_ba(struct rtllib_device *ieee, (ts->tx_admitted_ba_record.b_valid) ? (&ts->tx_admitted_ba_record) : (&ts->tx_pending_ba_record), - TxRxSelect, DELBA_REASON_END_BA); - } else if (TxRxSelect =3D=3D RX_DIR) { + tx_rx_select, DELBA_REASON_END_BA); + } else if (tx_rx_select =3D=3D RX_DIR) { struct rx_ts_record *ts =3D (struct rx_ts_record *)ts_common_info; if (rx_ts_delete_ba(ieee, ts)) rtllib_send_DELBA(ieee, ts_common_info->addr, &ts->rx_admitted_ba_record, - TxRxSelect, DELBA_REASON_END_BA); + tx_rx_select, DELBA_REASON_END_BA); } } =20 diff --git a/drivers/staging/rtl8192e/rtl819x_TSProc.c b/drivers/staging/rt= l8192e/rtl819x_TSProc.c index ad4d9e4c9b63..43b1e70b218b 100644 --- a/drivers/staging/rtl8192e/rtl819x_TSProc.c +++ b/drivers/staging/rtl8192e/rtl819x_TSProc.c @@ -171,14 +171,14 @@ void rtllib_ts_init(struct rtllib_device *ieee) =20 static struct ts_common_info *SearchAdmitTRStream(struct rtllib_device *ie= ee, u8 *addr, u8 TID, - enum tr_select TxRxSelect) + enum tr_select tx_rx_select) { u8 dir; bool search_dir[4] =3D {0}; struct list_head *psearch_list; struct ts_common_info *pRet =3D NULL; =20 - if (TxRxSelect =3D=3D TX_DIR) { + if (tx_rx_select =3D=3D TX_DIR) { search_dir[DIR_UP] =3D true; search_dir[DIR_BI_DIR] =3D true; search_dir[DIR_DIRECT] =3D true; @@ -188,7 +188,7 @@ static struct ts_common_info *SearchAdmitTRStream(struc= t rtllib_device *ieee, search_dir[DIR_DIRECT] =3D true; } =20 - if (TxRxSelect =3D=3D TX_DIR) + if (tx_rx_select =3D=3D TX_DIR) psearch_list =3D &ieee->Tx_TS_Admit_List; else psearch_list =3D &ieee->Rx_TS_Admit_List; @@ -225,7 +225,7 @@ static void MakeTSEntry(struct ts_common_info *ts_commo= n_info, u8 *addr, } =20 bool rtllib_get_ts(struct rtllib_device *ieee, struct ts_common_info **ppT= S, - u8 *addr, u8 TID, enum tr_select TxRxSelect, bool bAddNewTs) + u8 *addr, u8 TID, enum tr_select tx_rx_select, bool bAddNewTs) { u8 UP =3D 0; struct qos_tsinfo tspec; @@ -265,7 +265,7 @@ bool rtllib_get_ts(struct rtllib_device *ieee, struct t= s_common_info **ppTS, } } =20 - *ppTS =3D SearchAdmitTRStream(ieee, addr, UP, TxRxSelect); + *ppTS =3D SearchAdmitTRStream(ieee, addr, UP, tx_rx_select); if (*ppTS) return true; =20 @@ -274,21 +274,21 @@ bool rtllib_get_ts(struct rtllib_device *ieee, struct= ts_common_info **ppTS, return false; } =20 - pUnusedList =3D (TxRxSelect =3D=3D TX_DIR) ? + pUnusedList =3D (tx_rx_select =3D=3D TX_DIR) ? (&ieee->Tx_TS_Unused_List) : (&ieee->Rx_TS_Unused_List); =20 - pAddmitList =3D (TxRxSelect =3D=3D TX_DIR) ? + pAddmitList =3D (tx_rx_select =3D=3D TX_DIR) ? (&ieee->Tx_TS_Admit_List) : (&ieee->Rx_TS_Admit_List); =20 - Dir =3D ((TxRxSelect =3D=3D TX_DIR) ? DIR_UP : DIR_DOWN); + Dir =3D ((tx_rx_select =3D=3D TX_DIR) ? DIR_UP : DIR_DOWN); =20 if (!list_empty(pUnusedList)) { (*ppTS) =3D list_entry(pUnusedList->next, struct ts_common_info, List); list_del_init(&(*ppTS)->List); - if (TxRxSelect =3D=3D TX_DIR) { + if (tx_rx_select =3D=3D TX_DIR) { struct tx_ts_record *tmp =3D container_of(*ppTS, struct tx_ts_record, @@ -321,11 +321,11 @@ bool rtllib_get_ts(struct rtllib_device *ieee, struct= ts_common_info **ppTS, } =20 static void RemoveTsEntry(struct rtllib_device *ieee, - struct ts_common_info *pTs, enum tr_select TxRxSelect) + struct ts_common_info *pTs, enum tr_select tx_rx_select) { - rtllib_ts_init_del_ba(ieee, pTs, TxRxSelect); + rtllib_ts_init_del_ba(ieee, pTs, tx_rx_select); =20 - if (TxRxSelect =3D=3D RX_DIR) { + if (tx_rx_select =3D=3D RX_DIR) { struct rx_reorder_entry *pRxReorderEntry; struct rx_ts_record *ts =3D (struct rx_ts_record *)pTs; =20 diff --git a/drivers/staging/rtl8192e/rtllib.h b/drivers/staging/rtl8192e/r= tllib.h index d8da772b0f39..870720a12a48 100644 --- a/drivers/staging/rtl8192e/rtllib.h +++ b/drivers/staging/rtl8192e/rtllib.h @@ -1778,13 +1778,13 @@ void rtllib_ts_init_add_ba(struct rtllib_device *ie= ee, struct tx_ts_record *ts, u8 policy, u8 overwrite_pending); void rtllib_ts_init_del_ba(struct rtllib_device *ieee, struct ts_common_info *ts_common_info, - enum tr_select TxRxSelect); + enum tr_select tx_rx_select); void rtllib_ba_setup_timeout(struct timer_list *t); void rtllib_tx_ba_inact_timeout(struct timer_list *t); void rtllib_rx_ba_inact_timeout(struct timer_list *t); void rtllib_reset_ba_entry(struct ba_record *ba); bool rtllib_get_ts(struct rtllib_device *ieee, struct ts_common_info **ppT= S, u8 *addr, - u8 TID, enum tr_select TxRxSelect, bool bAddNewTs); + u8 TID, enum tr_select tx_rx_select, bool bAddNewTs); void rtllib_ts_init(struct rtllib_device *ieee); void TsStartAddBaProcess(struct rtllib_device *ieee, struct tx_ts_record *pTxTS); --=20 2.39.2