From nobody Fri Dec 19 02:16:11 2025 Received: from m12.mail.163.com (m12.mail.163.com [220.181.12.199]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 7481045BE8 for ; Sun, 17 Dec 2023 14:43:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=163.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=163.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=163.com header.i=@163.com header.b="c4s2eGx8" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:Subject:Date:Message-Id:MIME-Version; bh=tfEK8 34hFhHWJL3vUn8/GMuXyS9juv8wssBC4nzLML0=; b=c4s2eGx8Fwq9hYgGuVbTN fGEKBAkhZXLaLljjFpTvE5DnrPB8pm+P+hqxFDuNNaGO06FjvzQNhwcGkBG3/qEJ ceP6XZpEnwMmiL8eFuN7J7oaNmNI7pUX4D1D+cVv4thLfXnslDVGILgYontbkxxT jFm+9fzeEELK5fBVv8SGOI= Received: from ubuntu.lan (unknown [120.229.19.33]) by zwqz-smtp-mta-g5-0 (Coremail) with SMTP id _____wB3f0JABX9l13BJCA--.53408S2; Sun, 17 Dec 2023 22:27:14 +0800 (CST) From: Junwen Wu To: mingo@redhat.com, peterz@infradead.org, juri.lelli@redhat.com, vincent.guittot@linaro.org, bsegall@google.com, vschneid@redhat.com Cc: mgorman@suse.de, bristot@redhat.com, linux-kernel@vger.kernel.org, Junwen Wu Subject: [PATCH v2] sched/debug: Update print_task format in sched_debug node Date: Sun, 17 Dec 2023 14:27:10 +0000 Message-Id: <20231217142710.771888-1-wudaemon@163.com> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-CM-TRANSID: _____wB3f0JABX9l13BJCA--.53408S2 X-Coremail-Antispam: 1Uf129KBjvJXoWxGr43XF1ftF4fJw1xtrykGrg_yoW5GF1fpw nxAF13Jr4DXw1Ygw17ArykZr15Kry8t34UWrn7Ar18JF10y345Kr17tr1xtry5Gryxtw1a qFs8tr17G3WDXrUanT9S1TB71UUUUUUqnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDUYxBIdaVFxhVjvjDU0xZFpf9x0piNzV8UUUUU= X-CM-SenderInfo: 5zxgtvxprqqiywtou0bp/xtbBlA5JbVgi4+fJZQAAss Content-Type: text/plain; charset="utf-8" For the sched_debug interface, print_task function has output sum_exec_runtime twice, and the promt message not align with the output, so optimize the output. Signed-off-by: Junwen Wu --- V1 -> V2: fix compile error kernel/sched/debug.c | 25 ++++++++++++++++--------- 1 file changed, 16 insertions(+), 9 deletions(-) diff --git a/kernel/sched/debug.c b/kernel/sched/debug.c index 4580a450700e..342a2a942d51 100644 --- a/kernel/sched/debug.c +++ b/kernel/sched/debug.c @@ -579,13 +579,12 @@ print_task(struct seq_file *m, struct rq *rq, struct = task_struct *p) else SEQ_printf(m, " %c", task_state_to_char(p)); =20 - SEQ_printf(m, "%15s %5d %9Ld.%06ld %c %9Ld.%06ld %9Ld.%06ld %9Ld.%06ld %9= Ld %5d ", + SEQ_printf(m, "%15s %5d %9Ld.%06ld %c %9Ld.%06ld %9Ld.%06ld %9Ld %5d ", p->comm, task_pid_nr(p), SPLIT_NS(p->se.vruntime), entity_eligible(cfs_rq_of(&p->se), &p->se) ? 'E' : 'N', SPLIT_NS(p->se.deadline), SPLIT_NS(p->se.slice), - SPLIT_NS(p->se.sum_exec_runtime), (long long)(p->nvcsw + p->nivcsw), p->prio); =20 @@ -596,10 +595,10 @@ print_task(struct seq_file *m, struct rq *rq, struct = task_struct *p) SPLIT_NS(schedstat_val_or_zero(p->stats.sum_block_runtime))); =20 #ifdef CONFIG_NUMA_BALANCING - SEQ_printf(m, " %d %d", task_node(p), task_numa_group_id(p)); + SEQ_printf(m, " %d %d", task_node(p), task_numa_group_id(p)); #endif #ifdef CONFIG_CGROUP_SCHED - SEQ_printf_task_group_path(m, task_group(p), " %s") + SEQ_printf_task_group_path(m, task_group(p), " %s") #endif =20 SEQ_printf(m, "\n"); @@ -611,11 +610,19 @@ static void print_rq(struct seq_file *m, struct rq *r= q, int rq_cpu) =20 SEQ_printf(m, "\n"); SEQ_printf(m, "runnable tasks:\n"); - SEQ_printf(m, " S task PID tree-key switches prio" - " wait-time sum-exec sum-sleep\n"); - SEQ_printf(m, "-------------------------------------------------------" - "------------------------------------------------------\n"); - + SEQ_printf(m, " S task PID tree-key deadlin= e" + " slice switches prio" + " wait-time sum-exec sum-sleep sum-block" +#ifdef CONFIG_NUMA_BALANCING + " node_id" +#endif +#ifdef CONFIG_CGROUP_SCHED + " group\n" +#endif + ); + SEQ_printf(m, "----------------------------------------------------------= -------" + "--------------------------------------------------------------------" + "------------------------------------------\n"); rcu_read_lock(); for_each_process_thread(g, p) { if (task_cpu(p) !=3D rq_cpu) --=20 2.34.1