From nobody Fri Dec 19 08:04:02 2025 Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 66DC618ED2 for ; Sat, 16 Dec 2023 12:52:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=fastmail.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=fastmail.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=fastmail.org header.i=@fastmail.org header.b="V+nA7giY"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="9VZbmV49" Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id 885635C0163; Sat, 16 Dec 2023 07:52:29 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Sat, 16 Dec 2023 07:52:29 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastmail.org; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to; s=fm2; t=1702731149; x= 1702817549; bh=eQS8EaoNWpSN2ocsnTg2aIeyec3HLRleleGCcF4RJis=; b=V +nA7giY69FIg+/AN0ctXXmyqO5O7j8W5IcGQc4xGfo1rJ2489wr3Bi01zmBpp1k/ B/OdaGt+sIqus4GKLA6IrkZ0iefi8YDe8Wgn9jKILtdDz7py3c8p/2kREzmHZRPC KLctsZtAvThgN5kdYY1p3bZjPJ8Zy2dsJABEwQLF4YwQUVgVydz510bUahKScEnv btVdob6TwI3/eqflrZWShXgiB7w+MIHbIbNSF5qeTtSh5L6TnlV05EgHbd71uk1A GYbW4sWoVXzAB0irhxqZo+ciDgN92kja7ixcQds7u1BrfjzshaAbHz5eOiJXnqwk gmxH/ZlOVZbnMhKOJ/lXA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1702731149; x= 1702817549; bh=eQS8EaoNWpSN2ocsnTg2aIeyec3HLRleleGCcF4RJis=; b=9 VZbmV49unnPxR49EdIEE3e/pvqP5s7FX/YBP1w5tCFbvZ4G4gZ6bm7NO+zl+mD/Y n5Oqpj5a/RZI7hfh+/r6PirJ0tKyLXQApEmerGZGIX/x/8aXqiDIfP8kTwwQldbx 46FP+/NEGLxRD8Ie5YkUyN3ZKp8h2EK6w7bfIxZZeXRl9XLz9TrPYWpifp3gT+Sk 0xPe63xpb1kAU+yuLnEF+rT8bwvOtdnZvDO1oQSau0Uo/jeMUChfF9Ossw1q2iol zX6XmWyELjbNYK6x7g9/7lzyw202wiArDogVkCBbCyKUAyPxmFSV7RQ32g1NOuCN 4EBCmRrE4M5kGUteUbzpA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrvddtgedggeeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefhvfevufffkffojghfggfgsedtke ertdertddtnecuhfhrohhmpefirghrhicutfhoohhkrghrugcuoehgrghrhihrohhokhgr rhgusehfrghsthhmrghilhdrohhrgheqnecuggftrfgrthhtvghrnhepkeeuvdffueduke egieeuffejhefgkeetfeehueelfeduuefgveellefhfefgjedvnecuvehluhhsthgvrhfu ihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepghgrrhihrhhoohhkrghrugesfh grshhtmhgrihhlrdhorhhg X-ME-Proxy: Feedback-ID: ifd194980:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat, 16 Dec 2023 07:52:28 -0500 (EST) From: Gary Rookard To: gregkh@linuxfoundation.org, philipp.g.hortmann@gmail.com Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Gary Rookard Subject: [PATCH v3 1/4] staging: rtl8192e: rename variable pHT Date: Sat, 16 Dec 2023 07:53:00 -0500 Message-ID: <20231216125303.3404-2-garyrookard@fastmail.org> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20231216125303.3404-1-garyrookard@fastmail.org> References: <20231216125303.3404-1-garyrookard@fastmail.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Coding style issue, checkpatch Avoid CamelCase, rename it. pHT -> ht Signed-off-by: Gary Rookard --- v3: Corrects versioning. v2: Corrections to make applicable. v1: Not applicable, conflicting line numbers, code change drivers/staging/rtl8192e/rtl819x_HTProc.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl819x_HTProc.c b/drivers/staging/rt= l8192e/rtl819x_HTProc.c index 90a9356d78ca..29c3d33bf5a6 100644 --- a/drivers/staging/rtl8192e/rtl819x_HTProc.c +++ b/drivers/staging/rtl8192e/rtl819x_HTProc.c @@ -230,17 +230,17 @@ void ht_reset_iot_setting(struct rt_hi_throughput *ht= _info) void ht_construct_capability_element(struct rtllib_device *ieee, u8 *pos_h= t_cap, u8 *len, u8 is_encrypt, bool assoc) { - struct rt_hi_throughput *pHT =3D ieee->ht_info; + struct rt_hi_throughput *ht =3D ieee->ht_info; struct ht_capab_ele *pCapELE =3D NULL; =20 - if (!pos_ht_cap || !pHT) { + if (!pos_ht_cap || !ht) { netdev_warn(ieee->dev, "%s(): posHTCap and ht_info are null\n", __func__); return; } memset(pos_ht_cap, 0, *len); =20 - if ((assoc) && (pHT->ePeerHTSpecVer =3D=3D HT_SPEC_VER_EWC)) { + if ((assoc) && (ht->ePeerHTSpecVer =3D=3D HT_SPEC_VER_EWC)) { static const u8 EWC11NHTCap[] =3D { 0x00, 0x90, 0x4c, 0x33 }; =20 memcpy(pos_ht_cap, EWC11NHTCap, sizeof(EWC11NHTCap)); @@ -289,16 +289,16 @@ void ht_construct_capability_element(struct rtllib_de= vice *ieee, u8 *pos_ht_cap, pCapELE->ASCap =3D 0; =20 if (assoc) { - if (pHT->iot_action & HT_IOT_ACT_DISABLE_MCS15) + if (ht->iot_action & HT_IOT_ACT_DISABLE_MCS15) pCapELE->MCS[1] &=3D 0x7f; =20 - if (pHT->iot_action & HT_IOT_ACT_DISABLE_MCS14) + if (ht->iot_action & HT_IOT_ACT_DISABLE_MCS14) pCapELE->MCS[1] &=3D 0xbf; =20 - if (pHT->iot_action & HT_IOT_ACT_DISABLE_ALL_2SS) + if (ht->iot_action & HT_IOT_ACT_DISABLE_ALL_2SS) pCapELE->MCS[1] &=3D 0x00; =20 - if (pHT->iot_action & HT_IOT_ACT_DISABLE_RX_40MHZ_SHORT_GI) + if (ht->iot_action & HT_IOT_ACT_DISABLE_RX_40MHZ_SHORT_GI) pCapELE->ShortGI40Mhz =3D 0; =20 if (ieee->GetHalfNmodeSupportByAPsHandler(ieee->dev)) { --=20 2.41.0 From nobody Fri Dec 19 08:04:02 2025 Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0F50F1EA80 for ; Sat, 16 Dec 2023 12:52:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=fastmail.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=fastmail.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=fastmail.org header.i=@fastmail.org header.b="T3P0vze0"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="H3LqYgDl" Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id 40C105C019A; Sat, 16 Dec 2023 07:52:31 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Sat, 16 Dec 2023 07:52:31 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastmail.org; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to; s=fm2; t=1702731151; x= 1702817551; bh=dMfBiLPrDQcW9AnWXKU6GAIV/OVOatyWhTRd7GzOOQo=; b=T 3P0vze07dq1lpT4CLkC9bM1Fi5zE7tTFZJcjBe+Prk3WqsCfjqONC4oBxElnHOIr KizvOZ0hkLuop0aPO6WxOMf+2wF+Equ6+N09rMlXNjvIOsQWBmsNb+kSC34Z9Ed/ cnLPeSjw44hMZvrH8AvG89JqO1l1T42SHrw8J32t8yCYlLZMcOWgzE67VqvJ4uOe NYj2jTfnmOPdr/RXJAonNR/chOBSqko3/1pzAzqpUuuPvUNPugUJ/mr0IT6oXp9w aCAY7KCK796TawZcYO9+4fj1mJsP54Nz75zV2YLGq7y8AJlQc1SDMKYR7EwoHhhc kULaOQiRPAMFcEeNBctbA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1702731151; x= 1702817551; bh=dMfBiLPrDQcW9AnWXKU6GAIV/OVOatyWhTRd7GzOOQo=; b=H 3LqYgDlhKgS6QSGonArr7ez8tiXRxrx8mwcm0inmPcTA1i8Ce0FF9u8TnlSRPrxv OGRIJ6l0oni8UZFwj8Ojta3Kn64+Gbu3Vh3wqDalkcUV8VJvbOZRJAxN4o1kDvEb eNb37p+j3vYc9t6N9XH686V/0PQMumGtNsNaI5d/xUchXTXnhV1SnB64VX9jv6A5 sAoFpmZjESex+auoS5x4eDZ5+qdCYEuOk3obPG345UP/zRmw5Imh/fgBULz7kL6x bO1rsrL4hq5FdW+XWjBv1vKYF8uohN17RB3ja8Y9oqNGSxmA/dO585BjzaC/dqYn Mb2nmTtpMLouQ2HViwWPA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrvddtgedggeeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefhvfevufffkffojghfggfgsedtke ertdertddtnecuhfhrohhmpefirghrhicutfhoohhkrghrugcuoehgrghrhihrohhokhgr rhgusehfrghsthhmrghilhdrohhrgheqnecuggftrfgrthhtvghrnhepkeeuvdffueduke egieeuffejhefgkeetfeehueelfeduuefgveellefhfefgjedvnecuvehluhhsthgvrhfu ihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepghgrrhihrhhoohhkrghrugesfh grshhtmhgrihhlrdhorhhg X-ME-Proxy: Feedback-ID: ifd194980:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat, 16 Dec 2023 07:52:30 -0500 (EST) From: Gary Rookard To: gregkh@linuxfoundation.org, philipp.g.hortmann@gmail.com Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Gary Rookard Subject: [PATCH v3 2/4] staging: rtl8192e: rename variable pCapELE Date: Sat, 16 Dec 2023 07:53:01 -0500 Message-ID: <20231216125303.3404-3-garyrookard@fastmail.org> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20231216125303.3404-1-garyrookard@fastmail.org> References: <20231216125303.3404-1-garyrookard@fastmail.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Coding style issue, checkpatch Avoid CamelCase, rename it. pCapELE -> cap_ele Signed-off-by: Gary Rookard --- v3: Corrects versioning. v2: Corrections to make applicable. v1: Not applicable, conflicting line numbers, code change. drivers/staging/rtl8192e/rtl819x_HTProc.c | 64 +++++++++++------------ 1 file changed, 32 insertions(+), 32 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl819x_HTProc.c b/drivers/staging/rt= l8192e/rtl819x_HTProc.c index 29c3d33bf5a6..8d9037130424 100644 --- a/drivers/staging/rtl8192e/rtl819x_HTProc.c +++ b/drivers/staging/rtl8192e/rtl819x_HTProc.c @@ -231,7 +231,7 @@ void ht_construct_capability_element(struct rtllib_devi= ce *ieee, u8 *pos_ht_cap, u8 *len, u8 is_encrypt, bool assoc) { struct rt_hi_throughput *ht =3D ieee->ht_info; - struct ht_capab_ele *pCapELE =3D NULL; + struct ht_capab_ele *cap_ele =3D NULL; =20 if (!pos_ht_cap || !ht) { netdev_warn(ieee->dev, @@ -244,66 +244,66 @@ void ht_construct_capability_element(struct rtllib_de= vice *ieee, u8 *pos_ht_cap, static const u8 EWC11NHTCap[] =3D { 0x00, 0x90, 0x4c, 0x33 }; =20 memcpy(pos_ht_cap, EWC11NHTCap, sizeof(EWC11NHTCap)); - pCapELE =3D (struct ht_capab_ele *)&pos_ht_cap[4]; + cap_ele =3D (struct ht_capab_ele *)&pos_ht_cap[4]; *len =3D 30 + 2; } else { - pCapELE =3D (struct ht_capab_ele *)pos_ht_cap; + cap_ele =3D (struct ht_capab_ele *)pos_ht_cap; *len =3D 26 + 2; } =20 - pCapELE->AdvCoding =3D 0; + cap_ele->AdvCoding =3D 0; if (ieee->GetHalfNmodeSupportByAPsHandler(ieee->dev)) - pCapELE->ChlWidth =3D 0; + cap_ele->ChlWidth =3D 0; else - pCapELE->ChlWidth =3D 1; + cap_ele->ChlWidth =3D 1; =20 - pCapELE->MimoPwrSave =3D 3; - pCapELE->GreenField =3D 0; - pCapELE->ShortGI20Mhz =3D 1; - pCapELE->ShortGI40Mhz =3D 1; + cap_ele->MimoPwrSave =3D 3; + cap_ele->GreenField =3D 0; + cap_ele->ShortGI20Mhz =3D 1; + cap_ele->ShortGI40Mhz =3D 1; =20 - pCapELE->TxSTBC =3D 1; - pCapELE->RxSTBC =3D 0; - pCapELE->DelayBA =3D 0; - pCapELE->MaxAMSDUSize =3D (MAX_RECEIVE_BUFFER_SIZE >=3D 7935) ? 1 : 0; - pCapELE->DssCCk =3D 1; - pCapELE->PSMP =3D 0; - pCapELE->LSigTxopProtect =3D 0; + cap_ele->TxSTBC =3D 1; + cap_ele->RxSTBC =3D 0; + cap_ele->DelayBA =3D 0; + cap_ele->MaxAMSDUSize =3D (MAX_RECEIVE_BUFFER_SIZE >=3D 7935) ? 1 : 0; + cap_ele->DssCCk =3D 1; + cap_ele->PSMP =3D 0; + cap_ele->LSigTxopProtect =3D 0; =20 netdev_dbg(ieee->dev, "TX HT cap/info ele BW=3D%d MaxAMSDUSize:%d DssCCk:%d\n", - pCapELE->ChlWidth, pCapELE->MaxAMSDUSize, pCapELE->DssCCk); + cap_ele->ChlWidth, cap_ele->MaxAMSDUSize, cap_ele->DssCCk); =20 if (is_encrypt) { - pCapELE->MPDUDensity =3D 7; - pCapELE->MaxRxAMPDUFactor =3D 2; + cap_ele->MPDUDensity =3D 7; + cap_ele->MaxRxAMPDUFactor =3D 2; } else { - pCapELE->MaxRxAMPDUFactor =3D 3; - pCapELE->MPDUDensity =3D 0; + cap_ele->MaxRxAMPDUFactor =3D 3; + cap_ele->MPDUDensity =3D 0; } =20 - memcpy(pCapELE->MCS, ieee->reg_dot11ht_oper_rate_set, 16); - memset(&pCapELE->ExtHTCapInfo, 0, 2); - memset(pCapELE->TxBFCap, 0, 4); + memcpy(cap_ele->MCS, ieee->reg_dot11ht_oper_rate_set, 16); + memset(&cap_ele->ExtHTCapInfo, 0, 2); + memset(cap_ele->TxBFCap, 0, 4); =20 - pCapELE->ASCap =3D 0; + cap_ele->ASCap =3D 0; =20 if (assoc) { if (ht->iot_action & HT_IOT_ACT_DISABLE_MCS15) - pCapELE->MCS[1] &=3D 0x7f; + cap_ele->MCS[1] &=3D 0x7f; =20 if (ht->iot_action & HT_IOT_ACT_DISABLE_MCS14) - pCapELE->MCS[1] &=3D 0xbf; + cap_ele->MCS[1] &=3D 0xbf; =20 if (ht->iot_action & HT_IOT_ACT_DISABLE_ALL_2SS) - pCapELE->MCS[1] &=3D 0x00; + cap_ele->MCS[1] &=3D 0x00; =20 if (ht->iot_action & HT_IOT_ACT_DISABLE_RX_40MHZ_SHORT_GI) - pCapELE->ShortGI40Mhz =3D 0; + cap_ele->ShortGI40Mhz =3D 0; =20 if (ieee->GetHalfNmodeSupportByAPsHandler(ieee->dev)) { - pCapELE->ChlWidth =3D 0; - pCapELE->MCS[1] =3D 0; + cap_ele->ChlWidth =3D 0; + cap_ele->MCS[1] =3D 0; } } } --=20 2.41.0 From nobody Fri Dec 19 08:04:02 2025 Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2964E2C6B1 for ; Sat, 16 Dec 2023 12:52:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=fastmail.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=fastmail.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=fastmail.org header.i=@fastmail.org header.b="rocDuHnO"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="Nq2FC3xK" Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 5350A5C0163; Sat, 16 Dec 2023 07:52:33 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Sat, 16 Dec 2023 07:52:33 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastmail.org; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to; s=fm2; t=1702731153; x= 1702817553; bh=nrDaEyK3uHpFn43oapnxQCxO4x4R9W7b3A/LUpl+n70=; b=r ocDuHnOBD+x8v7lPmJ/VuMPmAH29oDmhL6diKF6iuVSSs6VVZ2gKC7OFRP5FTmS2 O/ehunHkY7msmgUJ5SJOBIH6wTVKdwMJhAO59OITfDoXADy+bGrD/GMgVZ8wJEuD uesh9R4bNmldpX5PlpoInQmkLIfASeDsK2vMXwOXOBLYPTdwrbSNaR3xdw97kCLo sURViXEV5lC5Sgnvtlp3pfWHjLaDHtK1CKvB9a970bQJFFQ30d15vyonkz3zhg7J Xbg+ZuEd3/xVu0ke8xfqEbPqIojb4fPhKc6FiBt9JU5/N/6AIV0Uk7lfLRItMFDf 6uWbMYHNdPrUBzaiKlyBg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1702731153; x= 1702817553; bh=nrDaEyK3uHpFn43oapnxQCxO4x4R9W7b3A/LUpl+n70=; b=N q2FC3xKNWARpGKPnvftppZHTg7oyOJYhp9ijbwAqMNTTMWfk67nCtD3fOV+/bsjc b/wru/zYZpd2hUPlkOXWLlzv9f95aMUliMNxqZq7F5jVoES35oMCwd+WptI4k4Yr BXl/gUFXA5eBQbhE0M5J/HanASSCEsr0+KTO6Bzofo6ADSul+xz3ocTIgDHqt+qh X9Antu1rKKLkmj3fx+yzapYk2vyfcxAInMZBxfo4Az6ITneZtyImxKqbgVRpa3Yk /0t1nEcOZm7OmTnGc2vFKKGDsaQpwI79TReZGz5qzBRLjjjOtJGUCxo6dX0+bNGI kW6Nn5iBwZgyhSDhEEAag== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrvddtgedggeeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefhvfevufffkffojghfggfgsedtke ertdertddtnecuhfhrohhmpefirghrhicutfhoohhkrghrugcuoehgrghrhihrohhokhgr rhgusehfrghsthhmrghilhdrohhrgheqnecuggftrfgrthhtvghrnhepkeeuvdffueduke egieeuffejhefgkeetfeehueelfeduuefgveellefhfefgjedvnecuvehluhhsthgvrhfu ihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepghgrrhihrhhoohhkrghrugesfh grshhtmhgrihhlrdhorhhg X-ME-Proxy: Feedback-ID: ifd194980:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat, 16 Dec 2023 07:52:32 -0500 (EST) From: Gary Rookard To: gregkh@linuxfoundation.org, philipp.g.hortmann@gmail.com Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Gary Rookard Subject: [PATCH v3 3/4] staging: rtl8192e: rename variable HTGetHighestMCSRate Date: Sat, 16 Dec 2023 07:53:02 -0500 Message-ID: <20231216125303.3404-4-garyrookard@fastmail.org> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20231216125303.3404-1-garyrookard@fastmail.org> References: <20231216125303.3404-1-garyrookard@fastmail.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Coding style issue, checkpatch Avoid CamelCase, rename it. HTGetHighestMCSRate -> ht_get_highest_mcs_rate Signed-off-by: Gary Rookard --- v3: Corrects versioning v2: Corrections to make applicable. v1: Not applicable, conflicting line numbers, code change. drivers/staging/rtl8192e/rtl819x_HTProc.c | 4 ++-- drivers/staging/rtl8192e/rtllib.h | 2 +- drivers/staging/rtl8192e/rtllib_wx.c | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl819x_HTProc.c b/drivers/staging/rt= l8192e/rtl819x_HTProc.c index 8d9037130424..6c1af19d67d2 100644 --- a/drivers/staging/rtl8192e/rtl819x_HTProc.c +++ b/drivers/staging/rtl8192e/rtl819x_HTProc.c @@ -357,7 +357,7 @@ static u8 ht_pick_mcs_rate(struct rtllib_device *ieee, = u8 *pOperateMCS) return true; } =20 -u8 HTGetHighestMCSRate(struct rtllib_device *ieee, u8 *pMCSRateSet, +u8 ht_get_highest_mcs_rate(struct rtllib_device *ieee, u8 *pMCSRateSet, u8 *pMCSFilter) { u8 i, j; @@ -493,7 +493,7 @@ void ht_on_assoc_rsp(struct rtllib_device *ieee) HTFilterMCSRate(ieee, pPeerHTCap->MCS, ieee->dot11ht_oper_rate_set); =20 pMcsFilter =3D MCS_FILTER_ALL; - ieee->HTHighestOperaRate =3D HTGetHighestMCSRate(ieee, + ieee->HTHighestOperaRate =3D ht_get_highest_mcs_rate(ieee, ieee->dot11ht_oper_rate_set, pMcsFilter); ieee->HTCurrentOperaRate =3D ieee->HTHighestOperaRate; diff --git a/drivers/staging/rtl8192e/rtllib.h b/drivers/staging/rtl8192e/r= tllib.h index b4413cfcb17e..966a62cfcfde 100644 --- a/drivers/staging/rtl8192e/rtllib.h +++ b/drivers/staging/rtl8192e/rtllib.h @@ -1763,7 +1763,7 @@ void HTResetSelfAndSavePeerSetting(struct rtllib_devi= ce *ieee, struct rtllib_network *pNetwork); void HT_update_self_and_peer_setting(struct rtllib_device *ieee, struct rtllib_network *pNetwork); -u8 HTGetHighestMCSRate(struct rtllib_device *ieee, u8 *pMCSRateSet, +u8 ht_get_highest_mcs_rate(struct rtllib_device *ieee, u8 *pMCSRateSet, u8 *pMCSFilter); extern u8 MCS_FILTER_ALL[]; extern u16 MCS_DATA_RATE[2][2][77]; diff --git a/drivers/staging/rtl8192e/rtllib_wx.c b/drivers/staging/rtl8192= e/rtllib_wx.c index a37250de7ba3..f92ec0faf4d5 100644 --- a/drivers/staging/rtl8192e/rtllib_wx.c +++ b/drivers/staging/rtl8192e/rtllib_wx.c @@ -134,7 +134,7 @@ static inline char *rtl819x_translate_scan(struct rtlli= b_device *ieee, ((ht_cap->ShortGI40Mhz) ? 1 : 0) : ((ht_cap->ShortGI20Mhz) ? 1 : 0); =20 - max_mcs =3D HTGetHighestMCSRate(ieee, ht_cap->MCS, + max_mcs =3D ht_get_highest_mcs_rate(ieee, ht_cap->MCS, MCS_FILTER_ALL); rate =3D MCS_DATA_RATE[is40M][isShortGI][max_mcs & 0x7f]; if (rate > max_rate) --=20 2.41.0 From nobody Fri Dec 19 08:04:02 2025 Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7C2832E40D for ; Sat, 16 Dec 2023 12:52:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=fastmail.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=fastmail.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=fastmail.org header.i=@fastmail.org header.b="suYW2ldL"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="as9fC/I4" Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id CDD115C019A; Sat, 16 Dec 2023 07:52:34 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Sat, 16 Dec 2023 07:52:34 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastmail.org; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to; s=fm2; t=1702731154; x= 1702817554; bh=S2oZrM9VplF7tk9wf9xKeyfGCtTRYHncJ+U5R2mrlVI=; b=s uYW2ldL6k8LFZW/cv5VqJ84gJHwfsMlhUwhoDqDGzKtMuhwN5df94B/C9ruut5FD u/OlrFToo+NvzepEWDWtJF+OUqmmMx5Q84lOrEItxKlIoHOFpxNKaQpPPYC4+qKn 04txfG+RY1fCOp6TP2bmm2O+rO36nesyR3Y2WSDXlr9ls1S9RAA1gCfgd7QOVCMb W5HjVCwr6/rm4TQbPnGktO34Qpks5g3yvTx/BwHBq59zng5U9E8QDRVfwZqKoWIr aPYgzTDVz8RsFVwAmoNXPKl09PVN12B0cJQwLyrlirUAokXpP4Rxeme5NS8Tn1P1 peHWLkfJtjko/wuyGCvhA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1702731154; x= 1702817554; bh=S2oZrM9VplF7tk9wf9xKeyfGCtTRYHncJ+U5R2mrlVI=; b=a s9fC/I4KRQpEkBuqNM2sEBBOkmqSAx8AQjRHgk1to83SFDqHdfOZ8sKLgddp4pMf MiDZNg4BdIGqrbylaHMKWp7ih/2LV8eI9OZRYbbMXGhSV3xiRZYRJL86w55sOHsz KGFi4HDNYOvpdGYAYpPyHuLBfLnBBvmi1N/UKpBXNt3apgqBHObH+3dyR4qSwX4F Ak1zGBbxoMcLS9PjDetUMjhOpQNw0/wovl+WMcJrZefWtQTiBUQxq64SGSZwMEr/ rbYZGDDR8X9dOkv9R6pJdUmArR+iYsFwM0urGXo31CUuk7q7pYuUrq25YiFIGMLj lIhxIqUoSOVClCOoaadSg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrvddtgedggeeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefhvfevufffkffojghfggfgsedtke ertdertddtnecuhfhrohhmpefirghrhicutfhoohhkrghrugcuoehgrghrhihrohhokhgr rhgusehfrghsthhmrghilhdrohhrgheqnecuggftrfgrthhtvghrnhepkeeuvdffueduke egieeuffejhefgkeetfeehueelfeduuefgveellefhfefgjedvnecuvehluhhsthgvrhfu ihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepghgrrhihrhhoohhkrghrugesfh grshhtmhgrihhlrdhorhhg X-ME-Proxy: Feedback-ID: ifd194980:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat, 16 Dec 2023 07:52:34 -0500 (EST) From: Gary Rookard To: gregkh@linuxfoundation.org, philipp.g.hortmann@gmail.com Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Gary Rookard Subject: [PATCH v3 4/4] staging: rtl8192e: renamed variable HTFilterMCSRate Date: Sat, 16 Dec 2023 07:53:03 -0500 Message-ID: <20231216125303.3404-5-garyrookard@fastmail.org> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20231216125303.3404-1-garyrookard@fastmail.org> References: <20231216125303.3404-1-garyrookard@fastmail.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Coding style issue, checkpatch Avoid CamelCase, rename it. HTFilterMCSRate -> ht_filter_mcs_rate Signed-off-by: Gary Rookard --- v3: Corrects versioning. v2: Corrections to make applicable. v1: Not applicable, conflicting line numbers, code change. drivers/staging/rtl8192e/rtl819x_HTProc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl819x_HTProc.c b/drivers/staging/rt= l8192e/rtl819x_HTProc.c index 6c1af19d67d2..0d57bcda33b4 100644 --- a/drivers/staging/rtl8192e/rtl819x_HTProc.c +++ b/drivers/staging/rtl8192e/rtl819x_HTProc.c @@ -397,7 +397,7 @@ u8 ht_get_highest_mcs_rate(struct rtllib_device *ieee, = u8 *pMCSRateSet, return mcsRate | 0x80; } =20 -static u8 HTFilterMCSRate(struct rtllib_device *ieee, u8 *pSupportMCS, +static u8 ht_filter_mcs_rate(struct rtllib_device *ieee, u8 *pSupportMCS, u8 *pOperateMCS) { u8 i; @@ -490,7 +490,7 @@ void ht_on_assoc_rsp(struct rtllib_device *ieee) =20 ht_iot_act_determine_ra_func(ieee, ((pPeerHTCap->MCS[1]) !=3D 0)); =20 - HTFilterMCSRate(ieee, pPeerHTCap->MCS, ieee->dot11ht_oper_rate_set); + ht_filter_mcs_rate(ieee, pPeerHTCap->MCS, ieee->dot11ht_oper_rate_set); =20 pMcsFilter =3D MCS_FILTER_ALL; ieee->HTHighestOperaRate =3D ht_get_highest_mcs_rate(ieee, --=20 2.41.0