From nobody Sat Dec 27 20:42:32 2025 Received: from wout4-smtp.messagingengine.com (wout4-smtp.messagingengine.com [64.147.123.20]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 49FD017E8 for ; Sat, 16 Dec 2023 01:00:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=fastmail.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=fastmail.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=fastmail.org header.i=@fastmail.org header.b="krijQ7z4"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="wl/NDM1m" Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id 585623200A47; Fri, 15 Dec 2023 20:00:48 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Fri, 15 Dec 2023 20:00:48 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastmail.org; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to; s=fm2; t=1702688447; x= 1702774847; bh=UNqxnPS/KECSJYSAYrhyozfSwB0BLIrorXrPvuKMpIw=; b=k rijQ7z4dC/X1TkaIVNpPYJijTkUu1LKK3b32MRl3XDdey+0iHt0VptChxoobPfMp +Z5z7tddUQypyI385x1XZYC+N4sx6wndtJIPciUVw3MDkOCRH9gK+cCSvYG7nGvr wcOHr91SvvP6Br+vxuIpb9+pA6VwBpsg8PhybwxZN2KuNDek3XXKTU0NzNmp3i0b kgilFJJwkMRphAC7xm5wqEe2Jy4I3bND5LYxjqStzQkL0LOrXB6JwULbEoXzRY8D URzIPp1ExlEFR6++nFoClZl2RG0zAGlpHtMHCaRBtcr/o8Ek1JBnQzZxq3MRNIlv Bxp02MvaKOURAyPbV/lVg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1702688447; x= 1702774847; bh=UNqxnPS/KECSJYSAYrhyozfSwB0BLIrorXrPvuKMpIw=; b=w l/NDM1m8yZXQiYrAE8QeFNqpyFqKuO615AYFeWYz116j24ry2WDi/xeWPE9DzE6E pm9ruZlOyk7iQ0uP3SpxcANEPmFer2R6cH4LWRnGda7n6nZoB9VIYgAger0wKZSH pp2sdHY9VlIonnjwYEiWnlzWcCp4kkQZxv/2DeDZ0kCMvdWKhc5Ucd3dpew6rjI9 IGiuSunOH0v62iM5bThwJGU46yUcTxdDtqD+hXLc/fiFSPSFfnGq9JyJgQ6ZjIAu rBYtdIcPzghLPq/0+oqhFzodr2l86jCrXPnQQDYIlEbtOCdDo+0wAdxWeMxJGpep VS6U5OUCdLl2bahYT/svw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrvddtfedgfedtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefhvfevufffkffojghfggfgsedtke ertdertddtnecuhfhrohhmpefirghrhicutfhoohhkrghrugcuoehgrghrhihrohhokhgr rhgusehfrghsthhmrghilhdrohhrgheqnecuggftrfgrthhtvghrnhepkeeuvdffueduke egieeuffejhefgkeetfeehueelfeduuefgveellefhfefgjedvnecuvehluhhsthgvrhfu ihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepghgrrhihrhhoohhkrghrugesfh grshhtmhgrihhlrdhorhhg X-ME-Proxy: Feedback-ID: ifd194980:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 15 Dec 2023 20:00:47 -0500 (EST) From: Gary Rookard To: gregkh@linuxfoundation.org, philipp.g.hortmann@gmail.com Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Gary Rookard Subject: [PATCH v2 2/4] staging: rtl8192e: rename variable pCapELE Date: Fri, 15 Dec 2023 20:01:03 -0500 Message-ID: <20231216010105.9810-3-garyrookard@fastmail.org> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20231216010105.9810-1-garyrookard@fastmail.org> References: <20231216010105.9810-1-garyrookard@fastmail.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Coding style issue, checkpatch Avoid CamelCase, rename it. pCapELE -> cap_ele Signed-off-by: Gary Rookard --- v2: Corrections to make applicable. v1: Not applicable, conflicting line numbers, code changed. drivers/staging/rtl8192e/rtl819x_HTProc.c | 64 +++++++++++------------ 1 file changed, 32 insertions(+), 32 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl819x_HTProc.c b/drivers/staging/rt= l8192e/rtl819x_HTProc.c index 29c3d33bf5a6..8d9037130424 100644 --- a/drivers/staging/rtl8192e/rtl819x_HTProc.c +++ b/drivers/staging/rtl8192e/rtl819x_HTProc.c @@ -231,7 +231,7 @@ void ht_construct_capability_element(struct rtllib_devi= ce *ieee, u8 *pos_ht_cap, u8 *len, u8 is_encrypt, bool assoc) { struct rt_hi_throughput *ht =3D ieee->ht_info; - struct ht_capab_ele *pCapELE =3D NULL; + struct ht_capab_ele *cap_ele =3D NULL; =20 if (!pos_ht_cap || !ht) { netdev_warn(ieee->dev, @@ -244,66 +244,66 @@ void ht_construct_capability_element(struct rtllib_de= vice *ieee, u8 *pos_ht_cap, static const u8 EWC11NHTCap[] =3D { 0x00, 0x90, 0x4c, 0x33 }; =20 memcpy(pos_ht_cap, EWC11NHTCap, sizeof(EWC11NHTCap)); - pCapELE =3D (struct ht_capab_ele *)&pos_ht_cap[4]; + cap_ele =3D (struct ht_capab_ele *)&pos_ht_cap[4]; *len =3D 30 + 2; } else { - pCapELE =3D (struct ht_capab_ele *)pos_ht_cap; + cap_ele =3D (struct ht_capab_ele *)pos_ht_cap; *len =3D 26 + 2; } =20 - pCapELE->AdvCoding =3D 0; + cap_ele->AdvCoding =3D 0; if (ieee->GetHalfNmodeSupportByAPsHandler(ieee->dev)) - pCapELE->ChlWidth =3D 0; + cap_ele->ChlWidth =3D 0; else - pCapELE->ChlWidth =3D 1; + cap_ele->ChlWidth =3D 1; =20 - pCapELE->MimoPwrSave =3D 3; - pCapELE->GreenField =3D 0; - pCapELE->ShortGI20Mhz =3D 1; - pCapELE->ShortGI40Mhz =3D 1; + cap_ele->MimoPwrSave =3D 3; + cap_ele->GreenField =3D 0; + cap_ele->ShortGI20Mhz =3D 1; + cap_ele->ShortGI40Mhz =3D 1; =20 - pCapELE->TxSTBC =3D 1; - pCapELE->RxSTBC =3D 0; - pCapELE->DelayBA =3D 0; - pCapELE->MaxAMSDUSize =3D (MAX_RECEIVE_BUFFER_SIZE >=3D 7935) ? 1 : 0; - pCapELE->DssCCk =3D 1; - pCapELE->PSMP =3D 0; - pCapELE->LSigTxopProtect =3D 0; + cap_ele->TxSTBC =3D 1; + cap_ele->RxSTBC =3D 0; + cap_ele->DelayBA =3D 0; + cap_ele->MaxAMSDUSize =3D (MAX_RECEIVE_BUFFER_SIZE >=3D 7935) ? 1 : 0; + cap_ele->DssCCk =3D 1; + cap_ele->PSMP =3D 0; + cap_ele->LSigTxopProtect =3D 0; =20 netdev_dbg(ieee->dev, "TX HT cap/info ele BW=3D%d MaxAMSDUSize:%d DssCCk:%d\n", - pCapELE->ChlWidth, pCapELE->MaxAMSDUSize, pCapELE->DssCCk); + cap_ele->ChlWidth, cap_ele->MaxAMSDUSize, cap_ele->DssCCk); =20 if (is_encrypt) { - pCapELE->MPDUDensity =3D 7; - pCapELE->MaxRxAMPDUFactor =3D 2; + cap_ele->MPDUDensity =3D 7; + cap_ele->MaxRxAMPDUFactor =3D 2; } else { - pCapELE->MaxRxAMPDUFactor =3D 3; - pCapELE->MPDUDensity =3D 0; + cap_ele->MaxRxAMPDUFactor =3D 3; + cap_ele->MPDUDensity =3D 0; } =20 - memcpy(pCapELE->MCS, ieee->reg_dot11ht_oper_rate_set, 16); - memset(&pCapELE->ExtHTCapInfo, 0, 2); - memset(pCapELE->TxBFCap, 0, 4); + memcpy(cap_ele->MCS, ieee->reg_dot11ht_oper_rate_set, 16); + memset(&cap_ele->ExtHTCapInfo, 0, 2); + memset(cap_ele->TxBFCap, 0, 4); =20 - pCapELE->ASCap =3D 0; + cap_ele->ASCap =3D 0; =20 if (assoc) { if (ht->iot_action & HT_IOT_ACT_DISABLE_MCS15) - pCapELE->MCS[1] &=3D 0x7f; + cap_ele->MCS[1] &=3D 0x7f; =20 if (ht->iot_action & HT_IOT_ACT_DISABLE_MCS14) - pCapELE->MCS[1] &=3D 0xbf; + cap_ele->MCS[1] &=3D 0xbf; =20 if (ht->iot_action & HT_IOT_ACT_DISABLE_ALL_2SS) - pCapELE->MCS[1] &=3D 0x00; + cap_ele->MCS[1] &=3D 0x00; =20 if (ht->iot_action & HT_IOT_ACT_DISABLE_RX_40MHZ_SHORT_GI) - pCapELE->ShortGI40Mhz =3D 0; + cap_ele->ShortGI40Mhz =3D 0; =20 if (ieee->GetHalfNmodeSupportByAPsHandler(ieee->dev)) { - pCapELE->ChlWidth =3D 0; - pCapELE->MCS[1] =3D 0; + cap_ele->ChlWidth =3D 0; + cap_ele->MCS[1] =3D 0; } } } --=20 2.41.0