From nobody Sat Dec 27 18:38:27 2025 Received: from wout4-smtp.messagingengine.com (wout4-smtp.messagingengine.com [64.147.123.20]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 36738110D for ; Sat, 16 Dec 2023 01:00:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=fastmail.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=fastmail.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=fastmail.org header.i=@fastmail.org header.b="eke9PR4e"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="RIMU3iVw" Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.west.internal (Postfix) with ESMTP id 254863200A40; Fri, 15 Dec 2023 20:00:46 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Fri, 15 Dec 2023 20:00:46 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastmail.org; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to; s=fm2; t=1702688445; x= 1702774845; bh=FoS8lC9fW9ZTl/Zz6IRqj1lD+lGfaphBlupDI+uRre8=; b=e ke9PR4eZsKu8kWsst8HH9MqI1L6iTC1fYTvEVcSdbHr9G8k+QEA4uQrqe+WaWZOj 5yLDGMBcx6ZA7BOkbjlj0JIFFbu6L4sFb95JbWKp8ELQVxFUP5ahmwTxouqipY40 Z4wEo2ZUJE7iB1c4wM2SNlQYR/V8SMLhztvpYnp62miYE131oexvo86Fsmvrte6e Zp+dOh0mMhgHHHra+0xS0Y/bwef1k9zffRgjmTexQjvc7K2yC9UgeN3D17lKN6mj UEJro7+cKjg/gOYlfNDO+nrHW74RgHmjKtrbD73LSBgax+vP8NcNEoCaxEmZJLAP IAiIlgJe/Jn004ek2ixfA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1702688445; x= 1702774845; bh=FoS8lC9fW9ZTl/Zz6IRqj1lD+lGfaphBlupDI+uRre8=; b=R IMU3iVwhDxdqpiCzKg5Ho1gm55e2eEKvZeNMq6ZxdIPtn8F+cq4zp9O/B8M1TXEC kzim8mGBx+D40OKAZQPC3QeN4OE2SB5R9cuJof5B4s5FyD9fH8tPZ9N94ouTU9DW pxLPELdP0F9UILC/DiXXbJSw4N04CPS39UTd9S1BobWYNqvPLz274gha/en7/ljs xmku1FJ2cwCaayiwnSbU/cOdcsYPRSV10PmWxQ8PQHPpmRKXGTUZDJwZ6qgKpfjh /Nc+EQ8QuYeJmQ1p344HT4rSNRoPa+CChvBtSA99jjooVkbZrdquBUCJQ+MTBP59 bWxSe4Gy6S4TVn8lOQWkQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrvddtfedgfedtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefhvfevufffkffojghfggfgsedtke ertdertddtnecuhfhrohhmpefirghrhicutfhoohhkrghrugcuoehgrghrhihrohhokhgr rhgusehfrghsthhmrghilhdrohhrgheqnecuggftrfgrthhtvghrnhepkeeuvdffueduke egieeuffejhefgkeetfeehueelfeduuefgveellefhfefgjedvnecuvehluhhsthgvrhfu ihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepghgrrhihrhhoohhkrghrugesfh grshhtmhgrihhlrdhorhhg X-ME-Proxy: Feedback-ID: ifd194980:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 15 Dec 2023 20:00:44 -0500 (EST) From: Gary Rookard To: gregkh@linuxfoundation.org, philipp.g.hortmann@gmail.com Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Gary Rookard Subject: [PATCH v2 1/4] staging: rtl8192e: rename variable pHT Date: Fri, 15 Dec 2023 20:01:02 -0500 Message-ID: <20231216010105.9810-2-garyrookard@fastmail.org> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20231216010105.9810-1-garyrookard@fastmail.org> References: <20231216010105.9810-1-garyrookard@fastmail.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Coding style issue, checkpatch Avoid CamelCase, rename it. pHT -> ht Signed-off-by: Gary Rookard --- v2: Corrections to make applicable. v1: Not applicable, conflicting line numbers, code changed. drivers/staging/rtl8192e/rtl819x_HTProc.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl819x_HTProc.c b/drivers/staging/rt= l8192e/rtl819x_HTProc.c index 90a9356d78ca..29c3d33bf5a6 100644 --- a/drivers/staging/rtl8192e/rtl819x_HTProc.c +++ b/drivers/staging/rtl8192e/rtl819x_HTProc.c @@ -230,17 +230,17 @@ void ht_reset_iot_setting(struct rt_hi_throughput *ht= _info) void ht_construct_capability_element(struct rtllib_device *ieee, u8 *pos_h= t_cap, u8 *len, u8 is_encrypt, bool assoc) { - struct rt_hi_throughput *pHT =3D ieee->ht_info; + struct rt_hi_throughput *ht =3D ieee->ht_info; struct ht_capab_ele *pCapELE =3D NULL; =20 - if (!pos_ht_cap || !pHT) { + if (!pos_ht_cap || !ht) { netdev_warn(ieee->dev, "%s(): posHTCap and ht_info are null\n", __func__); return; } memset(pos_ht_cap, 0, *len); =20 - if ((assoc) && (pHT->ePeerHTSpecVer =3D=3D HT_SPEC_VER_EWC)) { + if ((assoc) && (ht->ePeerHTSpecVer =3D=3D HT_SPEC_VER_EWC)) { static const u8 EWC11NHTCap[] =3D { 0x00, 0x90, 0x4c, 0x33 }; =20 memcpy(pos_ht_cap, EWC11NHTCap, sizeof(EWC11NHTCap)); @@ -289,16 +289,16 @@ void ht_construct_capability_element(struct rtllib_de= vice *ieee, u8 *pos_ht_cap, pCapELE->ASCap =3D 0; =20 if (assoc) { - if (pHT->iot_action & HT_IOT_ACT_DISABLE_MCS15) + if (ht->iot_action & HT_IOT_ACT_DISABLE_MCS15) pCapELE->MCS[1] &=3D 0x7f; =20 - if (pHT->iot_action & HT_IOT_ACT_DISABLE_MCS14) + if (ht->iot_action & HT_IOT_ACT_DISABLE_MCS14) pCapELE->MCS[1] &=3D 0xbf; =20 - if (pHT->iot_action & HT_IOT_ACT_DISABLE_ALL_2SS) + if (ht->iot_action & HT_IOT_ACT_DISABLE_ALL_2SS) pCapELE->MCS[1] &=3D 0x00; =20 - if (pHT->iot_action & HT_IOT_ACT_DISABLE_RX_40MHZ_SHORT_GI) + if (ht->iot_action & HT_IOT_ACT_DISABLE_RX_40MHZ_SHORT_GI) pCapELE->ShortGI40Mhz =3D 0; =20 if (ieee->GetHalfNmodeSupportByAPsHandler(ieee->dev)) { --=20 2.41.0 From nobody Sat Dec 27 18:38:27 2025 Received: from wout4-smtp.messagingengine.com (wout4-smtp.messagingengine.com [64.147.123.20]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 49FD017E8 for ; Sat, 16 Dec 2023 01:00:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=fastmail.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=fastmail.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=fastmail.org header.i=@fastmail.org header.b="krijQ7z4"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="wl/NDM1m" Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id 585623200A47; Fri, 15 Dec 2023 20:00:48 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Fri, 15 Dec 2023 20:00:48 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastmail.org; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to; s=fm2; t=1702688447; x= 1702774847; bh=UNqxnPS/KECSJYSAYrhyozfSwB0BLIrorXrPvuKMpIw=; b=k rijQ7z4dC/X1TkaIVNpPYJijTkUu1LKK3b32MRl3XDdey+0iHt0VptChxoobPfMp +Z5z7tddUQypyI385x1XZYC+N4sx6wndtJIPciUVw3MDkOCRH9gK+cCSvYG7nGvr wcOHr91SvvP6Br+vxuIpb9+pA6VwBpsg8PhybwxZN2KuNDek3XXKTU0NzNmp3i0b kgilFJJwkMRphAC7xm5wqEe2Jy4I3bND5LYxjqStzQkL0LOrXB6JwULbEoXzRY8D URzIPp1ExlEFR6++nFoClZl2RG0zAGlpHtMHCaRBtcr/o8Ek1JBnQzZxq3MRNIlv Bxp02MvaKOURAyPbV/lVg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1702688447; x= 1702774847; bh=UNqxnPS/KECSJYSAYrhyozfSwB0BLIrorXrPvuKMpIw=; b=w l/NDM1m8yZXQiYrAE8QeFNqpyFqKuO615AYFeWYz116j24ry2WDi/xeWPE9DzE6E pm9ruZlOyk7iQ0uP3SpxcANEPmFer2R6cH4LWRnGda7n6nZoB9VIYgAger0wKZSH pp2sdHY9VlIonnjwYEiWnlzWcCp4kkQZxv/2DeDZ0kCMvdWKhc5Ucd3dpew6rjI9 IGiuSunOH0v62iM5bThwJGU46yUcTxdDtqD+hXLc/fiFSPSFfnGq9JyJgQ6ZjIAu rBYtdIcPzghLPq/0+oqhFzodr2l86jCrXPnQQDYIlEbtOCdDo+0wAdxWeMxJGpep VS6U5OUCdLl2bahYT/svw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrvddtfedgfedtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefhvfevufffkffojghfggfgsedtke ertdertddtnecuhfhrohhmpefirghrhicutfhoohhkrghrugcuoehgrghrhihrohhokhgr rhgusehfrghsthhmrghilhdrohhrgheqnecuggftrfgrthhtvghrnhepkeeuvdffueduke egieeuffejhefgkeetfeehueelfeduuefgveellefhfefgjedvnecuvehluhhsthgvrhfu ihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepghgrrhihrhhoohhkrghrugesfh grshhtmhgrihhlrdhorhhg X-ME-Proxy: Feedback-ID: ifd194980:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 15 Dec 2023 20:00:47 -0500 (EST) From: Gary Rookard To: gregkh@linuxfoundation.org, philipp.g.hortmann@gmail.com Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Gary Rookard Subject: [PATCH v2 2/4] staging: rtl8192e: rename variable pCapELE Date: Fri, 15 Dec 2023 20:01:03 -0500 Message-ID: <20231216010105.9810-3-garyrookard@fastmail.org> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20231216010105.9810-1-garyrookard@fastmail.org> References: <20231216010105.9810-1-garyrookard@fastmail.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Coding style issue, checkpatch Avoid CamelCase, rename it. pCapELE -> cap_ele Signed-off-by: Gary Rookard --- v2: Corrections to make applicable. v1: Not applicable, conflicting line numbers, code changed. drivers/staging/rtl8192e/rtl819x_HTProc.c | 64 +++++++++++------------ 1 file changed, 32 insertions(+), 32 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl819x_HTProc.c b/drivers/staging/rt= l8192e/rtl819x_HTProc.c index 29c3d33bf5a6..8d9037130424 100644 --- a/drivers/staging/rtl8192e/rtl819x_HTProc.c +++ b/drivers/staging/rtl8192e/rtl819x_HTProc.c @@ -231,7 +231,7 @@ void ht_construct_capability_element(struct rtllib_devi= ce *ieee, u8 *pos_ht_cap, u8 *len, u8 is_encrypt, bool assoc) { struct rt_hi_throughput *ht =3D ieee->ht_info; - struct ht_capab_ele *pCapELE =3D NULL; + struct ht_capab_ele *cap_ele =3D NULL; =20 if (!pos_ht_cap || !ht) { netdev_warn(ieee->dev, @@ -244,66 +244,66 @@ void ht_construct_capability_element(struct rtllib_de= vice *ieee, u8 *pos_ht_cap, static const u8 EWC11NHTCap[] =3D { 0x00, 0x90, 0x4c, 0x33 }; =20 memcpy(pos_ht_cap, EWC11NHTCap, sizeof(EWC11NHTCap)); - pCapELE =3D (struct ht_capab_ele *)&pos_ht_cap[4]; + cap_ele =3D (struct ht_capab_ele *)&pos_ht_cap[4]; *len =3D 30 + 2; } else { - pCapELE =3D (struct ht_capab_ele *)pos_ht_cap; + cap_ele =3D (struct ht_capab_ele *)pos_ht_cap; *len =3D 26 + 2; } =20 - pCapELE->AdvCoding =3D 0; + cap_ele->AdvCoding =3D 0; if (ieee->GetHalfNmodeSupportByAPsHandler(ieee->dev)) - pCapELE->ChlWidth =3D 0; + cap_ele->ChlWidth =3D 0; else - pCapELE->ChlWidth =3D 1; + cap_ele->ChlWidth =3D 1; =20 - pCapELE->MimoPwrSave =3D 3; - pCapELE->GreenField =3D 0; - pCapELE->ShortGI20Mhz =3D 1; - pCapELE->ShortGI40Mhz =3D 1; + cap_ele->MimoPwrSave =3D 3; + cap_ele->GreenField =3D 0; + cap_ele->ShortGI20Mhz =3D 1; + cap_ele->ShortGI40Mhz =3D 1; =20 - pCapELE->TxSTBC =3D 1; - pCapELE->RxSTBC =3D 0; - pCapELE->DelayBA =3D 0; - pCapELE->MaxAMSDUSize =3D (MAX_RECEIVE_BUFFER_SIZE >=3D 7935) ? 1 : 0; - pCapELE->DssCCk =3D 1; - pCapELE->PSMP =3D 0; - pCapELE->LSigTxopProtect =3D 0; + cap_ele->TxSTBC =3D 1; + cap_ele->RxSTBC =3D 0; + cap_ele->DelayBA =3D 0; + cap_ele->MaxAMSDUSize =3D (MAX_RECEIVE_BUFFER_SIZE >=3D 7935) ? 1 : 0; + cap_ele->DssCCk =3D 1; + cap_ele->PSMP =3D 0; + cap_ele->LSigTxopProtect =3D 0; =20 netdev_dbg(ieee->dev, "TX HT cap/info ele BW=3D%d MaxAMSDUSize:%d DssCCk:%d\n", - pCapELE->ChlWidth, pCapELE->MaxAMSDUSize, pCapELE->DssCCk); + cap_ele->ChlWidth, cap_ele->MaxAMSDUSize, cap_ele->DssCCk); =20 if (is_encrypt) { - pCapELE->MPDUDensity =3D 7; - pCapELE->MaxRxAMPDUFactor =3D 2; + cap_ele->MPDUDensity =3D 7; + cap_ele->MaxRxAMPDUFactor =3D 2; } else { - pCapELE->MaxRxAMPDUFactor =3D 3; - pCapELE->MPDUDensity =3D 0; + cap_ele->MaxRxAMPDUFactor =3D 3; + cap_ele->MPDUDensity =3D 0; } =20 - memcpy(pCapELE->MCS, ieee->reg_dot11ht_oper_rate_set, 16); - memset(&pCapELE->ExtHTCapInfo, 0, 2); - memset(pCapELE->TxBFCap, 0, 4); + memcpy(cap_ele->MCS, ieee->reg_dot11ht_oper_rate_set, 16); + memset(&cap_ele->ExtHTCapInfo, 0, 2); + memset(cap_ele->TxBFCap, 0, 4); =20 - pCapELE->ASCap =3D 0; + cap_ele->ASCap =3D 0; =20 if (assoc) { if (ht->iot_action & HT_IOT_ACT_DISABLE_MCS15) - pCapELE->MCS[1] &=3D 0x7f; + cap_ele->MCS[1] &=3D 0x7f; =20 if (ht->iot_action & HT_IOT_ACT_DISABLE_MCS14) - pCapELE->MCS[1] &=3D 0xbf; + cap_ele->MCS[1] &=3D 0xbf; =20 if (ht->iot_action & HT_IOT_ACT_DISABLE_ALL_2SS) - pCapELE->MCS[1] &=3D 0x00; + cap_ele->MCS[1] &=3D 0x00; =20 if (ht->iot_action & HT_IOT_ACT_DISABLE_RX_40MHZ_SHORT_GI) - pCapELE->ShortGI40Mhz =3D 0; + cap_ele->ShortGI40Mhz =3D 0; =20 if (ieee->GetHalfNmodeSupportByAPsHandler(ieee->dev)) { - pCapELE->ChlWidth =3D 0; - pCapELE->MCS[1] =3D 0; + cap_ele->ChlWidth =3D 0; + cap_ele->MCS[1] =3D 0; } } } --=20 2.41.0 From nobody Sat Dec 27 18:38:27 2025 Received: from wout4-smtp.messagingengine.com (wout4-smtp.messagingengine.com [64.147.123.20]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 83461257E for ; Sat, 16 Dec 2023 01:00:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=fastmail.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=fastmail.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=fastmail.org header.i=@fastmail.org header.b="MivDLGmr"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="tXXgs4qK" Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.west.internal (Postfix) with ESMTP id 989B0320099B; Fri, 15 Dec 2023 20:00:50 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Fri, 15 Dec 2023 20:00:51 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastmail.org; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to; s=fm2; t=1702688450; x= 1702774850; bh=5750rQocdnyD7jpR3uy757KH/wiiVOExOowo8BdV8LQ=; b=M ivDLGmrD1XO+HxFe1xL2Rd14o0PHGsIivWMC2yMOY2IMhpwW1RzoByqg7NGaReuc O75vqpHuDGTfSLv4gFofw0Zem/q4TvK7M2ae+LROLaoSv8W3YTzS6qpH4O+05Jck 1KWrE+jEcAm6Q8DHdZvUEC6kyBnYEM1Hxpx/S0+qAvxlUKvYxZDrvIDDQ7r6CfZD e/K1P2q82e1yMSIZ7chl3LJN3oi/BDeqIKZnpbfXKTVV29SjQaLhbmwBPKYBAzGI A9DMolt5GMf0oH97zomp7xw0udG3dTqYN9Ato80rWq/fZNHo51xua7iz4sCDBTpB rvP3hwV5nByJvoCQ67WeQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1702688450; x= 1702774850; bh=5750rQocdnyD7jpR3uy757KH/wiiVOExOowo8BdV8LQ=; b=t XXgs4qK/a6BwhtMN/O0MhehFxj6B/mHXcTLoh7RlcgqblQZK3/CMMPPBO4pnHknu HUbus//1YaUorua0xKWiCsV8bPCtDrWXWsC5mE8cKnrDYAH24Qk3UpXuBsVVcYS9 Fs/3MkSbjSYa8c62EiY+VRVJ9kpUO7du9mrv3bRek/B9qVEZWNvW4kPl+Ss2QBMD txsravPlDd1heTEnMTz1m9NtCe8VFTbThI1RULSz5Wdyy0TnD0hF3MLmpJcVU5Qx DB8CeGvXr+ig29HsRKZPLhHojmDjK3KbgoU6c3rnexdrZsUrCdvOpHrAFxTqI2do FReOhRhY/r2by6FaMgF0Q== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrvddtfedgfedtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefhvfevufffkffojghfggfgsedtke ertdertddtnecuhfhrohhmpefirghrhicutfhoohhkrghrugcuoehgrghrhihrohhokhgr rhgusehfrghsthhmrghilhdrohhrgheqnecuggftrfgrthhtvghrnhepkeeuvdffueduke egieeuffejhefgkeetfeehueelfeduuefgveellefhfefgjedvnecuvehluhhsthgvrhfu ihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepghgrrhihrhhoohhkrghrugesfh grshhtmhgrihhlrdhorhhg X-ME-Proxy: Feedback-ID: ifd194980:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 15 Dec 2023 20:00:49 -0500 (EST) From: Gary Rookard To: gregkh@linuxfoundation.org, philipp.g.hortmann@gmail.com Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Gary Rookard Subject: [PATCH v2 3/4] staging: rtl8192e: rename variable HTGetHighestMCSRate Date: Fri, 15 Dec 2023 20:01:04 -0500 Message-ID: <20231216010105.9810-4-garyrookard@fastmail.org> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20231216010105.9810-1-garyrookard@fastmail.org> References: <20231216010105.9810-1-garyrookard@fastmail.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Coding style issue, checkpatch Avoid CamelCase, rename it. HTGetHighestMCSRate -> ht_get_highest_mcs_rate Signed-off-by: Gary Rookard --- v2: Corrections to make applicable. v1: Not applicable, conflicting line numbers, code changed. drivers/staging/rtl8192e/rtl819x_HTProc.c | 4 ++-- drivers/staging/rtl8192e/rtllib.h | 2 +- drivers/staging/rtl8192e/rtllib_wx.c | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl819x_HTProc.c b/drivers/staging/rt= l8192e/rtl819x_HTProc.c index 8d9037130424..6c1af19d67d2 100644 --- a/drivers/staging/rtl8192e/rtl819x_HTProc.c +++ b/drivers/staging/rtl8192e/rtl819x_HTProc.c @@ -357,7 +357,7 @@ static u8 ht_pick_mcs_rate(struct rtllib_device *ieee, = u8 *pOperateMCS) return true; } =20 -u8 HTGetHighestMCSRate(struct rtllib_device *ieee, u8 *pMCSRateSet, +u8 ht_get_highest_mcs_rate(struct rtllib_device *ieee, u8 *pMCSRateSet, u8 *pMCSFilter) { u8 i, j; @@ -493,7 +493,7 @@ void ht_on_assoc_rsp(struct rtllib_device *ieee) HTFilterMCSRate(ieee, pPeerHTCap->MCS, ieee->dot11ht_oper_rate_set); =20 pMcsFilter =3D MCS_FILTER_ALL; - ieee->HTHighestOperaRate =3D HTGetHighestMCSRate(ieee, + ieee->HTHighestOperaRate =3D ht_get_highest_mcs_rate(ieee, ieee->dot11ht_oper_rate_set, pMcsFilter); ieee->HTCurrentOperaRate =3D ieee->HTHighestOperaRate; diff --git a/drivers/staging/rtl8192e/rtllib.h b/drivers/staging/rtl8192e/r= tllib.h index b4413cfcb17e..966a62cfcfde 100644 --- a/drivers/staging/rtl8192e/rtllib.h +++ b/drivers/staging/rtl8192e/rtllib.h @@ -1763,7 +1763,7 @@ void HTResetSelfAndSavePeerSetting(struct rtllib_devi= ce *ieee, struct rtllib_network *pNetwork); void HT_update_self_and_peer_setting(struct rtllib_device *ieee, struct rtllib_network *pNetwork); -u8 HTGetHighestMCSRate(struct rtllib_device *ieee, u8 *pMCSRateSet, +u8 ht_get_highest_mcs_rate(struct rtllib_device *ieee, u8 *pMCSRateSet, u8 *pMCSFilter); extern u8 MCS_FILTER_ALL[]; extern u16 MCS_DATA_RATE[2][2][77]; diff --git a/drivers/staging/rtl8192e/rtllib_wx.c b/drivers/staging/rtl8192= e/rtllib_wx.c index a37250de7ba3..f92ec0faf4d5 100644 --- a/drivers/staging/rtl8192e/rtllib_wx.c +++ b/drivers/staging/rtl8192e/rtllib_wx.c @@ -134,7 +134,7 @@ static inline char *rtl819x_translate_scan(struct rtlli= b_device *ieee, ((ht_cap->ShortGI40Mhz) ? 1 : 0) : ((ht_cap->ShortGI20Mhz) ? 1 : 0); =20 - max_mcs =3D HTGetHighestMCSRate(ieee, ht_cap->MCS, + max_mcs =3D ht_get_highest_mcs_rate(ieee, ht_cap->MCS, MCS_FILTER_ALL); rate =3D MCS_DATA_RATE[is40M][isShortGI][max_mcs & 0x7f]; if (rate > max_rate) --=20 2.41.0 From nobody Sat Dec 27 18:38:27 2025 Received: from wout4-smtp.messagingengine.com (wout4-smtp.messagingengine.com [64.147.123.20]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9BC755C82 for ; Sat, 16 Dec 2023 01:00:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=fastmail.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=fastmail.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=fastmail.org header.i=@fastmail.org header.b="siGbXl7G"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="03+43M1q" Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.west.internal (Postfix) with ESMTP id 7A8A6320099B; Fri, 15 Dec 2023 20:00:54 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Fri, 15 Dec 2023 20:00:54 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastmail.org; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to; s=fm2; t=1702688454; x= 1702774854; bh=/rTFRkoubujNguLvM+nzRXTxdokh3eYIDIQoUp6/p3M=; b=s iGbXl7G+SZK5drAIJOu8vfi3gqVnjChWpIOCyN/Vq2qGyeneDFwsovyUrRcCRXOW r0Lxyi5fLZ4QIyaag3HBrxQPJ5ZEzgv0FMx0QioqYD2/qosc1f7Q1Rld8f9F5tE4 9L1EincJ0iLMnnPD3wTrglhxYoRxfbZmlUF3BkFZtB/D81HrtmVZw69JMLWMNxgw CXaL4wHhtTdMqZRlDea8xY6q/1CmVUxAFklQ5jl8EPYAoiGwqYiEIAV8SZEKydGb aw3Pe3QtJPoF9gyTF0lQb5t+yLJB43b0fsOoWT1SDhDa595A3wMOV3hbeGM71jTo YzO6EmPblv3+Utg6myp2A== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1702688454; x= 1702774854; bh=/rTFRkoubujNguLvM+nzRXTxdokh3eYIDIQoUp6/p3M=; b=0 3+43M1qOchUAv6UOOyPpAd5jUESDU9PkMPaXR5oPzXhWkWiSz6HrCNQM1oNm2J8H /0LU/gVQ82lk2ajieR++7H1CK8TQ/RQCvGxjgM0NRuurySoEul9nNfOs31eXfaxT YksimFpmQJO/cR4s7brdNGUXo3Kpk149gynNKs9MbHR4sYwCjjfWX1yt9ds/XiwR Axa5YKt688Sj3HQEdwNVi67cTmlb2hBhLrtbbphZ5c5Ax7Sz7dHqW1f0Fl9X17ye gCDmDqcWYXWROp3YWQmrTszYXr4GEZHhfcYI3i+K6EAwsP2nPfqmEgfna5wmBZni 8cRc0Ns62yp4adkTFhnYQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrvddtfedgfedtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefhvfevufffkffojghfggfgsedtke ertdertddtnecuhfhrohhmpefirghrhicutfhoohhkrghrugcuoehgrghrhihrohhokhgr rhgusehfrghsthhmrghilhdrohhrgheqnecuggftrfgrthhtvghrnhepkeeuvdffueduke egieeuffejhefgkeetfeehueelfeduuefgveellefhfefgjedvnecuvehluhhsthgvrhfu ihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepghgrrhihrhhoohhkrghrugesfh grshhtmhgrihhlrdhorhhg X-ME-Proxy: Feedback-ID: ifd194980:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 15 Dec 2023 20:00:53 -0500 (EST) From: Gary Rookard To: gregkh@linuxfoundation.org, philipp.g.hortmann@gmail.com Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Gary Rookard Subject: [PATCH v2 4/4] staging: rtl8192e: renamed variable HTFilterMCSRate Date: Fri, 15 Dec 2023 20:01:05 -0500 Message-ID: <20231216010105.9810-5-garyrookard@fastmail.org> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20231216010105.9810-1-garyrookard@fastmail.org> References: <20231216010105.9810-1-garyrookard@fastmail.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Coding style issue, checkpatch Avoid CamelCase, rename it. HTFilterMCSRate -> ht_filter_mcs_rate Signed-off-by: Gary Rookard --- v2: Corrections to make applicable. v1: Not applicable, conflicting line numbers, code changed. drivers/staging/rtl8192e/rtl819x_HTProc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl819x_HTProc.c b/drivers/staging/rt= l8192e/rtl819x_HTProc.c index 6c1af19d67d2..0d57bcda33b4 100644 --- a/drivers/staging/rtl8192e/rtl819x_HTProc.c +++ b/drivers/staging/rtl8192e/rtl819x_HTProc.c @@ -397,7 +397,7 @@ u8 ht_get_highest_mcs_rate(struct rtllib_device *ieee, = u8 *pMCSRateSet, return mcsRate | 0x80; } =20 -static u8 HTFilterMCSRate(struct rtllib_device *ieee, u8 *pSupportMCS, +static u8 ht_filter_mcs_rate(struct rtllib_device *ieee, u8 *pSupportMCS, u8 *pOperateMCS) { u8 i; @@ -490,7 +490,7 @@ void ht_on_assoc_rsp(struct rtllib_device *ieee) =20 ht_iot_act_determine_ra_func(ieee, ((pPeerHTCap->MCS[1]) !=3D 0)); =20 - HTFilterMCSRate(ieee, pPeerHTCap->MCS, ieee->dot11ht_oper_rate_set); + ht_filter_mcs_rate(ieee, pPeerHTCap->MCS, ieee->dot11ht_oper_rate_set); =20 pMcsFilter =3D MCS_FILTER_ALL; ieee->HTHighestOperaRate =3D ht_get_highest_mcs_rate(ieee, --=20 2.41.0