From nobody Sat Dec 27 18:55:31 2025 Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 24F003FB12 for ; Fri, 15 Dec 2023 23:12:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=fastmail.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=fastmail.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=fastmail.org header.i=@fastmail.org header.b="JL4DajpJ"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="wmgmG4sF" Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 512BB5C01C5; Fri, 15 Dec 2023 18:12:01 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Fri, 15 Dec 2023 18:12:01 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastmail.org; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to; s=fm2; t=1702681921; x= 1702768321; bh=NaUjN3g+a3d0G2064+wY3rD5KV/0JB4rEeQ9newEbxE=; b=J L4DajpJadepvJDfVn0/mC219j5lkC4lp4afVIkcjevR5B4IE4cvWpe56iNhrJG1U 5PqhI1OOyl32OWJjIPVOlwbjipj5BqrM8KorSO6O7jOJZU0AV7p/4m0t36EST51D vy+H8jgt6lwKoDTX7yMOL9lJBhSdI7KPwoKqKBfc97mVTn39rB4QymV60R5CUXjO 1hzyuLjz6CFx74sIeupRBbssFcCbfsqBHYoVx/O/MCVqJwB48BOaVz6gJxf6DwMc Wdai5UvTVypWDMRB+0YL2aimPco0dbUeAdTpc/rYmBhHgu21Ra3Y8z6twVo/Ujg+ LXy2+h7tEc2f0pkeAvifw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1702681921; x= 1702768321; bh=NaUjN3g+a3d0G2064+wY3rD5KV/0JB4rEeQ9newEbxE=; b=w mgmG4sF8rfBuk/0KV2ORQhJsK6zKVbMlYFrFjPkljgtGslf/Z78cLEplk391tpl3 qbw20QyoIwpD76IuUKLlfsKosB5swxBEF8jhbg2p2ldp0v9XMNtliWqoUtYrtCgC v2kdvju3+Htw/Z5Q5Vsse1QAKhRj38IzzTZWppP0eZ5bLaFG3RIL8dilFWwKVOpc cs1oC3GuNWkkT+d9MwBspvpHXD+69scuAqO8S+A6Fv6GdsMQ7HZGQIv7e8XSiwUm GrB14elcSGl4JJERwvNnxWb3HjKhw8a3GOZsw9rl7xRXyj5ksxbt+2jqFdspIkxI th/hP/NkmPPSdilInaRqg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrvddtfedgtdekucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefhvfevufffkffojghfggfgsedtke ertdertddtnecuhfhrohhmpefirghrhicutfhoohhkrghrugcuoehgrghrhihrohhokhgr rhgusehfrghsthhmrghilhdrohhrgheqnecuggftrfgrthhtvghrnhepkeeuvdffueduke egieeuffejhefgkeetfeehueelfeduuefgveellefhfefgjedvnecuvehluhhsthgvrhfu ihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepghgrrhihrhhoohhkrghrugesfh grshhtmhgrihhlrdhorhhg X-ME-Proxy: Feedback-ID: ifd194980:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 15 Dec 2023 18:12:00 -0500 (EST) From: Gary Rookard To: gregkh@linuxfoundation.org, philipp.g.hortmann@gmail.com Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Gary Rookard Subject: [PATCH 1/4] staging: rtl8192e: rename variable pHT Date: Fri, 15 Dec 2023 18:12:32 -0500 Message-ID: <20231215231235.8265-2-garyrookard@fastmail.org> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20231215231235.8265-1-garyrookard@fastmail.org> References: <20231215231235.8265-1-garyrookard@fastmail.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Coding style issue, checkpatch Avoid CamelCase, rename it. pHT -> ht Signed-off-by: Gary Rookard --- drivers/staging/rtl8192e/rtl819x_HTProc.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl819x_HTProc.c b/drivers/staging/rt= l8192e/rtl819x_HTProc.c index 90a9356d78ca..29c3d33bf5a6 100644 --- a/drivers/staging/rtl8192e/rtl819x_HTProc.c +++ b/drivers/staging/rtl8192e/rtl819x_HTProc.c @@ -230,17 +230,17 @@ void ht_reset_iot_setting(struct rt_hi_throughput *ht= _info) void ht_construct_capability_element(struct rtllib_device *ieee, u8 *pos_h= t_cap, u8 *len, u8 is_encrypt, bool assoc) { - struct rt_hi_throughput *pHT =3D ieee->ht_info; + struct rt_hi_throughput *ht =3D ieee->ht_info; struct ht_capab_ele *pCapELE =3D NULL; =20 - if (!pos_ht_cap || !pHT) { + if (!pos_ht_cap || !ht) { netdev_warn(ieee->dev, "%s(): posHTCap and ht_info are null\n", __func__); return; } memset(pos_ht_cap, 0, *len); =20 - if ((assoc) && (pHT->ePeerHTSpecVer =3D=3D HT_SPEC_VER_EWC)) { + if ((assoc) && (ht->ePeerHTSpecVer =3D=3D HT_SPEC_VER_EWC)) { static const u8 EWC11NHTCap[] =3D { 0x00, 0x90, 0x4c, 0x33 }; =20 memcpy(pos_ht_cap, EWC11NHTCap, sizeof(EWC11NHTCap)); @@ -289,16 +289,16 @@ void ht_construct_capability_element(struct rtllib_de= vice *ieee, u8 *pos_ht_cap, pCapELE->ASCap =3D 0; =20 if (assoc) { - if (pHT->iot_action & HT_IOT_ACT_DISABLE_MCS15) + if (ht->iot_action & HT_IOT_ACT_DISABLE_MCS15) pCapELE->MCS[1] &=3D 0x7f; =20 - if (pHT->iot_action & HT_IOT_ACT_DISABLE_MCS14) + if (ht->iot_action & HT_IOT_ACT_DISABLE_MCS14) pCapELE->MCS[1] &=3D 0xbf; =20 - if (pHT->iot_action & HT_IOT_ACT_DISABLE_ALL_2SS) + if (ht->iot_action & HT_IOT_ACT_DISABLE_ALL_2SS) pCapELE->MCS[1] &=3D 0x00; =20 - if (pHT->iot_action & HT_IOT_ACT_DISABLE_RX_40MHZ_SHORT_GI) + if (ht->iot_action & HT_IOT_ACT_DISABLE_RX_40MHZ_SHORT_GI) pCapELE->ShortGI40Mhz =3D 0; =20 if (ieee->GetHalfNmodeSupportByAPsHandler(ieee->dev)) { --=20 2.41.0 From nobody Sat Dec 27 18:55:31 2025 Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 32EA04653B for ; Fri, 15 Dec 2023 23:12:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=fastmail.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=fastmail.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=fastmail.org header.i=@fastmail.org header.b="lOwaxZ89"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="2K0RrMZV" Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 594435C029D; Fri, 15 Dec 2023 18:12:03 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Fri, 15 Dec 2023 18:12:03 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastmail.org; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to; s=fm2; t=1702681923; x= 1702768323; bh=1DHPsvWEuMaTTOoIqrXEFhe9UR8dRXa61SmYgRwAafA=; b=l OwaxZ89ztzl0SC5n+yAE5yEQbQWYSdlpN0FGXCX6UBXSPJPAdDIXcfVDjULEfy0P 5bKMoDZvIB/P7QdVIERwa2k0b6PPood36GlWe1p5YpFFiaJQ9ldBXdmCxl0bc1e2 N/Lg60sUDH93zC83VLor5u2QrPcUS3r8uEvmzPb+S/qGMhyWO8/OUecvz6nU2vi2 uTC0bM3bueYtarZ4JMmeNkdMaVR/ZmzOFId+FyBu6Z+R5Z166k45Hg+y8dZPdyDv 3Vzym6WIhBeTMEXr3LGJxV9denJeDTVzHovKEJY/X8JTNwpGIdb0kU8qUEmui4Qs ZoPOofTF+op0UaFWEHaDA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1702681923; x= 1702768323; bh=1DHPsvWEuMaTTOoIqrXEFhe9UR8dRXa61SmYgRwAafA=; b=2 K0RrMZV5YiUmNnT3K/nu8GYoO0O0zxH6T+gSsn55WPBKI5Fc3sT+iT0AjUqHxv9Q edIvkczllt7k2KL/esoLz/53cwbuvW1l1JaVFwc8ieVR7cnDz3m2wYcN+P75tqsj F64mNp+p1Rq4RXrheXkIKHgDd64V1gbz3ghHRVP+VsLPXLausy4uJb9BmYr0jT9I BtvbGl+M1P4h2iEmkoj8qwolmpEHbtUuS2N0lgrZ3C8vBiEJbedPDbl9gzsgdehc +ox//GbTK8vlMQp1XGyPSfTrNU9DuL/kaAhkcL+OYenWQdau7iBvNXYoVYiXvZ3i 6JuB6004AIX1JfBcOFV9A== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrvddtfedgtdejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefhvfevufffkffojghfggfgsedtke ertdertddtnecuhfhrohhmpefirghrhicutfhoohhkrghrugcuoehgrghrhihrohhokhgr rhgusehfrghsthhmrghilhdrohhrgheqnecuggftrfgrthhtvghrnhepkeeuvdffueduke egieeuffejhefgkeetfeehueelfeduuefgveellefhfefgjedvnecuvehluhhsthgvrhfu ihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepghgrrhihrhhoohhkrghrugesfh grshhtmhgrihhlrdhorhhg X-ME-Proxy: Feedback-ID: ifd194980:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 15 Dec 2023 18:12:02 -0500 (EST) From: Gary Rookard To: gregkh@linuxfoundation.org, philipp.g.hortmann@gmail.com Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Gary Rookard Subject: [PATCH 2/4] staging: rtl8192e: rename variable pCapELE Date: Fri, 15 Dec 2023 18:12:33 -0500 Message-ID: <20231215231235.8265-3-garyrookard@fastmail.org> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20231215231235.8265-1-garyrookard@fastmail.org> References: <20231215231235.8265-1-garyrookard@fastmail.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Coding style issue, checkpatch Avoid CamelCase, rename it. pCapELE -> cap_ele Signed-off-by: Gary Rookard --- drivers/staging/rtl8192e/rtl819x_HTProc.c | 64 +++++++++++------------ 1 file changed, 32 insertions(+), 32 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl819x_HTProc.c b/drivers/staging/rt= l8192e/rtl819x_HTProc.c index 29c3d33bf5a6..8d9037130424 100644 --- a/drivers/staging/rtl8192e/rtl819x_HTProc.c +++ b/drivers/staging/rtl8192e/rtl819x_HTProc.c @@ -231,7 +231,7 @@ void ht_construct_capability_element(struct rtllib_devi= ce *ieee, u8 *pos_ht_cap, u8 *len, u8 is_encrypt, bool assoc) { struct rt_hi_throughput *ht =3D ieee->ht_info; - struct ht_capab_ele *pCapELE =3D NULL; + struct ht_capab_ele *cap_ele =3D NULL; =20 if (!pos_ht_cap || !ht) { netdev_warn(ieee->dev, @@ -244,66 +244,66 @@ void ht_construct_capability_element(struct rtllib_de= vice *ieee, u8 *pos_ht_cap, static const u8 EWC11NHTCap[] =3D { 0x00, 0x90, 0x4c, 0x33 }; =20 memcpy(pos_ht_cap, EWC11NHTCap, sizeof(EWC11NHTCap)); - pCapELE =3D (struct ht_capab_ele *)&pos_ht_cap[4]; + cap_ele =3D (struct ht_capab_ele *)&pos_ht_cap[4]; *len =3D 30 + 2; } else { - pCapELE =3D (struct ht_capab_ele *)pos_ht_cap; + cap_ele =3D (struct ht_capab_ele *)pos_ht_cap; *len =3D 26 + 2; } =20 - pCapELE->AdvCoding =3D 0; + cap_ele->AdvCoding =3D 0; if (ieee->GetHalfNmodeSupportByAPsHandler(ieee->dev)) - pCapELE->ChlWidth =3D 0; + cap_ele->ChlWidth =3D 0; else - pCapELE->ChlWidth =3D 1; + cap_ele->ChlWidth =3D 1; =20 - pCapELE->MimoPwrSave =3D 3; - pCapELE->GreenField =3D 0; - pCapELE->ShortGI20Mhz =3D 1; - pCapELE->ShortGI40Mhz =3D 1; + cap_ele->MimoPwrSave =3D 3; + cap_ele->GreenField =3D 0; + cap_ele->ShortGI20Mhz =3D 1; + cap_ele->ShortGI40Mhz =3D 1; =20 - pCapELE->TxSTBC =3D 1; - pCapELE->RxSTBC =3D 0; - pCapELE->DelayBA =3D 0; - pCapELE->MaxAMSDUSize =3D (MAX_RECEIVE_BUFFER_SIZE >=3D 7935) ? 1 : 0; - pCapELE->DssCCk =3D 1; - pCapELE->PSMP =3D 0; - pCapELE->LSigTxopProtect =3D 0; + cap_ele->TxSTBC =3D 1; + cap_ele->RxSTBC =3D 0; + cap_ele->DelayBA =3D 0; + cap_ele->MaxAMSDUSize =3D (MAX_RECEIVE_BUFFER_SIZE >=3D 7935) ? 1 : 0; + cap_ele->DssCCk =3D 1; + cap_ele->PSMP =3D 0; + cap_ele->LSigTxopProtect =3D 0; =20 netdev_dbg(ieee->dev, "TX HT cap/info ele BW=3D%d MaxAMSDUSize:%d DssCCk:%d\n", - pCapELE->ChlWidth, pCapELE->MaxAMSDUSize, pCapELE->DssCCk); + cap_ele->ChlWidth, cap_ele->MaxAMSDUSize, cap_ele->DssCCk); =20 if (is_encrypt) { - pCapELE->MPDUDensity =3D 7; - pCapELE->MaxRxAMPDUFactor =3D 2; + cap_ele->MPDUDensity =3D 7; + cap_ele->MaxRxAMPDUFactor =3D 2; } else { - pCapELE->MaxRxAMPDUFactor =3D 3; - pCapELE->MPDUDensity =3D 0; + cap_ele->MaxRxAMPDUFactor =3D 3; + cap_ele->MPDUDensity =3D 0; } =20 - memcpy(pCapELE->MCS, ieee->reg_dot11ht_oper_rate_set, 16); - memset(&pCapELE->ExtHTCapInfo, 0, 2); - memset(pCapELE->TxBFCap, 0, 4); + memcpy(cap_ele->MCS, ieee->reg_dot11ht_oper_rate_set, 16); + memset(&cap_ele->ExtHTCapInfo, 0, 2); + memset(cap_ele->TxBFCap, 0, 4); =20 - pCapELE->ASCap =3D 0; + cap_ele->ASCap =3D 0; =20 if (assoc) { if (ht->iot_action & HT_IOT_ACT_DISABLE_MCS15) - pCapELE->MCS[1] &=3D 0x7f; + cap_ele->MCS[1] &=3D 0x7f; =20 if (ht->iot_action & HT_IOT_ACT_DISABLE_MCS14) - pCapELE->MCS[1] &=3D 0xbf; + cap_ele->MCS[1] &=3D 0xbf; =20 if (ht->iot_action & HT_IOT_ACT_DISABLE_ALL_2SS) - pCapELE->MCS[1] &=3D 0x00; + cap_ele->MCS[1] &=3D 0x00; =20 if (ht->iot_action & HT_IOT_ACT_DISABLE_RX_40MHZ_SHORT_GI) - pCapELE->ShortGI40Mhz =3D 0; + cap_ele->ShortGI40Mhz =3D 0; =20 if (ieee->GetHalfNmodeSupportByAPsHandler(ieee->dev)) { - pCapELE->ChlWidth =3D 0; - pCapELE->MCS[1] =3D 0; + cap_ele->ChlWidth =3D 0; + cap_ele->MCS[1] =3D 0; } } } --=20 2.41.0 From nobody Sat Dec 27 18:55:31 2025 Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1C1FF49F67 for ; Fri, 15 Dec 2023 23:12:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=fastmail.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=fastmail.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=fastmail.org header.i=@fastmail.org header.b="eu/WKnCb"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="kmYZUZ8t" Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 5286B5C01B4; Fri, 15 Dec 2023 18:12:05 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Fri, 15 Dec 2023 18:12:05 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastmail.org; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to; s=fm2; t=1702681925; x= 1702768325; bh=xFMn8TRG6BQqEPJx0TwrVqYON1NIGk0tmOvBi1/MOLE=; b=e u/WKnCbk4ND+W25ezcJW4/hRdM41dM2mvC+eGJi4285OwylfQWg39NsqQzmxVs7i CpsGBgx/PFOpI7qTIaW2QkgCYz8tIrpr7ueqZY85cuoUoSEWuMnxOJQrbSJZHgQn 0U25GHSOZ+fxkUUYcdk+xP79plwl1ew/dRl1d+OlakrVSTXrfEs7lZ5N7qwwpBno 1dMFHgcVCRvhilZ7THEftkZXhIHtfPjTj2xhI/KF5pJlI/6VnHFqTv0ZWGOx7lOa px02DMn9nQQ+0WDIuObsfxmrPWIYLS2bB3fGHeGGmMZc0YCs20W8JEfDvGbKJHBB zMhV87KK5swLaMvjC4HCw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1702681925; x= 1702768325; bh=xFMn8TRG6BQqEPJx0TwrVqYON1NIGk0tmOvBi1/MOLE=; b=k mYZUZ8tYymJQwLBFQWPdwztSr39kTRBM6Bkijn2KxhbkTHOeuOAnax+IBYP3/j3A WEbCIlUNViz7dvU3160Jf2klcSOqpR591mbT78YabzPWb/c8u3AJ1onXAtf2/izK uRILeeF9fFVXza/PbA/BZt6ysCfrDVYItKNRgrhkqCbXeHd00UZKUlGcAsq63f4Z GaH90enoG/McaSogCKhmayXDV8WoCmV85jYBNT+PK7d6AZ2Dmu+2NQV1zzkGgcfJ qATxEcORm4Za7iGvbrmjec7+OwWATUWxFAi8rbwUq5bjuB7MXCLg5alA8CxWFUG4 on7L0oVTnUkhhrBLXQyKg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrvddtfedgtdejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefhvfevufffkffojghfggfgsedtke ertdertddtnecuhfhrohhmpefirghrhicutfhoohhkrghrugcuoehgrghrhihrohhokhgr rhgusehfrghsthhmrghilhdrohhrgheqnecuggftrfgrthhtvghrnhepkeeuvdffueduke egieeuffejhefgkeetfeehueelfeduuefgveellefhfefgjedvnecuvehluhhsthgvrhfu ihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepghgrrhihrhhoohhkrghrugesfh grshhtmhgrihhlrdhorhhg X-ME-Proxy: Feedback-ID: ifd194980:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 15 Dec 2023 18:12:04 -0500 (EST) From: Gary Rookard To: gregkh@linuxfoundation.org, philipp.g.hortmann@gmail.com Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Gary Rookard Subject: [PATCH 3/4] staging: rtl8192e: rename variable HTGetHighestMCSRate Date: Fri, 15 Dec 2023 18:12:34 -0500 Message-ID: <20231215231235.8265-4-garyrookard@fastmail.org> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20231215231235.8265-1-garyrookard@fastmail.org> References: <20231215231235.8265-1-garyrookard@fastmail.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Coding style issue, checkpatch Avoid CamelCase, rename it. HTGetHighestMCSRate -> ht_get_highest_mcs_rate Signed-off-by: Gary Rookard --- drivers/staging/rtl8192e/rtl819x_HTProc.c | 4 ++-- drivers/staging/rtl8192e/rtllib.h | 2 +- drivers/staging/rtl8192e/rtllib_wx.c | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl819x_HTProc.c b/drivers/staging/rt= l8192e/rtl819x_HTProc.c index 8d9037130424..6c1af19d67d2 100644 --- a/drivers/staging/rtl8192e/rtl819x_HTProc.c +++ b/drivers/staging/rtl8192e/rtl819x_HTProc.c @@ -357,7 +357,7 @@ static u8 ht_pick_mcs_rate(struct rtllib_device *ieee, = u8 *pOperateMCS) return true; } =20 -u8 HTGetHighestMCSRate(struct rtllib_device *ieee, u8 *pMCSRateSet, +u8 ht_get_highest_mcs_rate(struct rtllib_device *ieee, u8 *pMCSRateSet, u8 *pMCSFilter) { u8 i, j; @@ -493,7 +493,7 @@ void ht_on_assoc_rsp(struct rtllib_device *ieee) HTFilterMCSRate(ieee, pPeerHTCap->MCS, ieee->dot11ht_oper_rate_set); =20 pMcsFilter =3D MCS_FILTER_ALL; - ieee->HTHighestOperaRate =3D HTGetHighestMCSRate(ieee, + ieee->HTHighestOperaRate =3D ht_get_highest_mcs_rate(ieee, ieee->dot11ht_oper_rate_set, pMcsFilter); ieee->HTCurrentOperaRate =3D ieee->HTHighestOperaRate; diff --git a/drivers/staging/rtl8192e/rtllib.h b/drivers/staging/rtl8192e/r= tllib.h index b4413cfcb17e..966a62cfcfde 100644 --- a/drivers/staging/rtl8192e/rtllib.h +++ b/drivers/staging/rtl8192e/rtllib.h @@ -1763,7 +1763,7 @@ void HTResetSelfAndSavePeerSetting(struct rtllib_devi= ce *ieee, struct rtllib_network *pNetwork); void HT_update_self_and_peer_setting(struct rtllib_device *ieee, struct rtllib_network *pNetwork); -u8 HTGetHighestMCSRate(struct rtllib_device *ieee, u8 *pMCSRateSet, +u8 ht_get_highest_mcs_rate(struct rtllib_device *ieee, u8 *pMCSRateSet, u8 *pMCSFilter); extern u8 MCS_FILTER_ALL[]; extern u16 MCS_DATA_RATE[2][2][77]; diff --git a/drivers/staging/rtl8192e/rtllib_wx.c b/drivers/staging/rtl8192= e/rtllib_wx.c index a37250de7ba3..f92ec0faf4d5 100644 --- a/drivers/staging/rtl8192e/rtllib_wx.c +++ b/drivers/staging/rtl8192e/rtllib_wx.c @@ -134,7 +134,7 @@ static inline char *rtl819x_translate_scan(struct rtlli= b_device *ieee, ((ht_cap->ShortGI40Mhz) ? 1 : 0) : ((ht_cap->ShortGI20Mhz) ? 1 : 0); =20 - max_mcs =3D HTGetHighestMCSRate(ieee, ht_cap->MCS, + max_mcs =3D ht_get_highest_mcs_rate(ieee, ht_cap->MCS, MCS_FILTER_ALL); rate =3D MCS_DATA_RATE[is40M][isShortGI][max_mcs & 0x7f]; if (rate > max_rate) --=20 2.41.0 From nobody Sat Dec 27 18:55:31 2025 Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4591456391 for ; Fri, 15 Dec 2023 23:12:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=fastmail.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=fastmail.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=fastmail.org header.i=@fastmail.org header.b="Qej8fymQ"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="kfkRurrw" Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 8B4AB5C01BA; Fri, 15 Dec 2023 18:12:07 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Fri, 15 Dec 2023 18:12:07 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastmail.org; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to; s=fm2; t=1702681927; x= 1702768327; bh=eP5A/gmHCPtTycTJxJLZQNbIr/FqbR3Kb8PAuvHL7i0=; b=Q ej8fymQpOvdQmzkeMoPsf0+zBdKR2X3/CAZQKBAxB4wZQVPwqAfWOAhoZQOo0ArD 9Ix9KXq/t+30ZtewrewTAiqJe00VshfSCdH8EjTF3H2ohtpqZEHcAAr3ydZMR85C 9q7RmtXMuypQ5oj14bnwJm8FAihd5mCF18helWtJOj4BGNbivWXZsy+RVqQrBlVx vrEDff/j0FFsoZjxP71wi0yRYnyANSsCvxSMroBbNzcYUH/zCxkssHu0dC/9PqOM f6SwRFPH5/L6EeWfbNuvVMkAAzPX1SzkS5gHYuEIvxTFSeGcbB+qxULMh9JU88LH E1EwRA4iKebZlFLUHNO5g== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1702681927; x= 1702768327; bh=eP5A/gmHCPtTycTJxJLZQNbIr/FqbR3Kb8PAuvHL7i0=; b=k fkRurrw2zREvBRAjfJj3ZlQWpd/cwqVEXcYacminV+9y9vtJYED21L+UIUdOxnoM iWh8fAg1iitaJ5LRH4h1RNv5xlFjOTKeAdy55zd2YPlxMT/j8j3tJaEpYTkkYh1H Gj2RHXi3nc4of2syW6hT+lnJN4oU8LCMf9M8+bFJGJKCR0JGk6uQiDffGESMmTlE WScUJg6gDeRR4E2/l353X5dyLr1WZtwsBL2dHEqtuNteBB7kIR3SOjqAFfFUVjNU P04qX3Q5+oSmR4V5RRUUWoZSkWuEbrIdnTHN5cUpxDE1rfhefA3C4kRHMWYGYR9m wv0LOKGOc2g1PU9BPlSuw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrvddtfedgtdejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefhvfevufffkffojghfggfgsedtke ertdertddtnecuhfhrohhmpefirghrhicutfhoohhkrghrugcuoehgrghrhihrohhokhgr rhgusehfrghsthhmrghilhdrohhrgheqnecuggftrfgrthhtvghrnhepkeeuvdffueduke egieeuffejhefgkeetfeehueelfeduuefgveellefhfefgjedvnecuvehluhhsthgvrhfu ihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepghgrrhihrhhoohhkrghrugesfh grshhtmhgrihhlrdhorhhg X-ME-Proxy: Feedback-ID: ifd194980:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 15 Dec 2023 18:12:06 -0500 (EST) From: Gary Rookard To: gregkh@linuxfoundation.org, philipp.g.hortmann@gmail.com Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Gary Rookard Subject: [PATCH 4/4] staging: rtl8192e: renamed variable HTFilterMCSRate Date: Fri, 15 Dec 2023 18:12:35 -0500 Message-ID: <20231215231235.8265-5-garyrookard@fastmail.org> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20231215231235.8265-1-garyrookard@fastmail.org> References: <20231215231235.8265-1-garyrookard@fastmail.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Coding style issue, checkpatch Avoid CamelCase, rename it. HTFilterMCSRate -> ht_filter_mcs_rate Signed-off-by: Gary Rookard --- drivers/staging/rtl8192e/rtl819x_HTProc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl819x_HTProc.c b/drivers/staging/rt= l8192e/rtl819x_HTProc.c index 6c1af19d67d2..0d57bcda33b4 100644 --- a/drivers/staging/rtl8192e/rtl819x_HTProc.c +++ b/drivers/staging/rtl8192e/rtl819x_HTProc.c @@ -397,7 +397,7 @@ u8 ht_get_highest_mcs_rate(struct rtllib_device *ieee, = u8 *pMCSRateSet, return mcsRate | 0x80; } =20 -static u8 HTFilterMCSRate(struct rtllib_device *ieee, u8 *pSupportMCS, +static u8 ht_filter_mcs_rate(struct rtllib_device *ieee, u8 *pSupportMCS, u8 *pOperateMCS) { u8 i; @@ -490,7 +490,7 @@ void ht_on_assoc_rsp(struct rtllib_device *ieee) =20 ht_iot_act_determine_ra_func(ieee, ((pPeerHTCap->MCS[1]) !=3D 0)); =20 - HTFilterMCSRate(ieee, pPeerHTCap->MCS, ieee->dot11ht_oper_rate_set); + ht_filter_mcs_rate(ieee, pPeerHTCap->MCS, ieee->dot11ht_oper_rate_set); =20 pMcsFilter =3D MCS_FILTER_ALL; ieee->HTHighestOperaRate =3D ht_get_highest_mcs_rate(ieee, --=20 2.41.0