From nobody Sat Dec 27 20:57:02 2025 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 5C7CE35F16; Fri, 15 Dec 2023 15:01:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 0D1BB1063; Fri, 15 Dec 2023 07:01:49 -0800 (PST) Received: from e127643.broadband (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 3393F3F5A1; Fri, 15 Dec 2023 07:01:00 -0800 (PST) From: James Clark To: linux-arm-kernel@lists.infradead.org, linux-perf-users@vger.kernel.org, linux-next@vger.kernel.org, will@kernel.org, u.kleine-koenig@pengutronix.de Cc: James Clark , Mark Rutland , Nathan Chancellor , Nick Desaulniers , Bill Wendling , Justin Stitt , Anshuman Khandual , Suzuki K Poulose , linux-kernel@vger.kernel.org, llvm@lists.linux.dev Subject: [PATCH 1/2] arm: perf: Fix ARCH=arm build with GCC in armv8pmu_write_evtype() Date: Fri, 15 Dec 2023 15:00:38 +0000 Message-Id: <20231215150040.3342183-2-james.clark@arm.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20231215150040.3342183-1-james.clark@arm.com> References: <20231215150040.3342183-1-james.clark@arm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable LLVM ignores everything inside the if statement and doesn't generate errors, but GCC doesn't ignore it, resulting in the following error: drivers/perf/arm_pmuv3.c: In function =E2=80=98armv8pmu_write_evtype=E2= =80=99: include/linux/bits.h:34:29: error: left shift count >=3D width of type [-= Werror=3Dshift-count-overflow] 34 | (((~UL(0)) - (UL(1) << (l)) + 1) & \ Fix it by changing the if to #if. Fixes: 3115ee021bfb ("arm64: perf: Include threshold control fields in PMEV= TYPER mask") Reported-by: Uwe Kleine-K=C3=B6nig Closes: https://lore.kernel.org/linux-arm-kernel/20231215120817.h2f3akgv72z= hrtqo@pengutronix.de/ Signed-off-by: James Clark --- drivers/perf/arm_pmuv3.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/perf/arm_pmuv3.c b/drivers/perf/arm_pmuv3.c index 23fa6c5da82c..3ed2086cefc3 100644 --- a/drivers/perf/arm_pmuv3.c +++ b/drivers/perf/arm_pmuv3.c @@ -631,8 +631,9 @@ static void armv8pmu_write_evtype(int idx, unsigned lon= g val) ARMV8_PMU_EXCLUDE_EL0 | ARMV8_PMU_EXCLUDE_EL1; =20 - if (IS_ENABLED(CONFIG_ARM64)) - mask |=3D ARMV8_PMU_EVTYPE_TC | ARMV8_PMU_EVTYPE_TH; +#if IS_ENABLED(CONFIG_ARM64) + mask |=3D ARMV8_PMU_EVTYPE_TC | ARMV8_PMU_EVTYPE_TH; +#endif =20 val &=3D mask; write_pmevtypern(counter, val); --=20 2.34.1 From nobody Sat Dec 27 20:57:02 2025 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 3DD803714C; Fri, 15 Dec 2023 15:01:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id CA28CC15; Fri, 15 Dec 2023 07:01:52 -0800 (PST) Received: from e127643.broadband (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id BB2853F5A1; Fri, 15 Dec 2023 07:01:04 -0800 (PST) From: James Clark To: linux-arm-kernel@lists.infradead.org, linux-perf-users@vger.kernel.org, linux-next@vger.kernel.org, will@kernel.org, u.kleine-koenig@pengutronix.de Cc: James Clark , Mark Rutland , Nathan Chancellor , Nick Desaulniers , Bill Wendling , Justin Stitt , Anshuman Khandual , Suzuki K Poulose , linux-kernel@vger.kernel.org, llvm@lists.linux.dev Subject: [PATCH 2/2] arm: perf: Fix ARCH=arm build with GCC in armv8pmu_set_event_filter() Date: Fri, 15 Dec 2023 15:00:39 +0000 Message-Id: <20231215150040.3342183-3-james.clark@arm.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20231215150040.3342183-1-james.clark@arm.com> References: <20231215150040.3342183-1-james.clark@arm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" LLVM ignores everything inside the if statement and doesn't generate errors, but GCC does, resulting in the following: drivers/perf/arm_pmuv3.c: In function armv8pmu_set_event_filter: include/linux/bits.h:34:29: error: left shift count >=3D width of type [-= Werror=3Dshift-count-overflow] 34 | (((~UL(0)) - (UL(1) << (l)) + 1) & \ Fix it by changing the if to #if. This results in an unused function warning for armv8pmu_event_threshold_control(), so suppress that too. Fixes: 816c26754447 ("arm64: perf: Add support for event counting threshold= ") Signed-off-by: James Clark --- drivers/perf/arm_pmuv3.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/perf/arm_pmuv3.c b/drivers/perf/arm_pmuv3.c index 3ed2086cefc3..8aa23878019a 100644 --- a/drivers/perf/arm_pmuv3.c +++ b/drivers/perf/arm_pmuv3.c @@ -338,7 +338,7 @@ static bool armv8pmu_event_want_user_access(struct perf= _event *event) return ATTR_CFG_GET_FLD(&event->attr, rdpmc); } =20 -static u8 armv8pmu_event_threshold_control(struct perf_event_attr *attr) +static __maybe_unused u8 armv8pmu_event_threshold_control(struct perf_even= t_attr *attr) { u8 th_compare =3D ATTR_CFG_GET_FLD(attr, threshold_compare); u8 th_count =3D ATTR_CFG_GET_FLD(attr, threshold_count); @@ -1040,11 +1040,13 @@ static int armv8pmu_set_event_filter(struct hw_perf= _event *event, return -EINVAL; } =20 - if (IS_ENABLED(CONFIG_ARM64) && th) { +#if IS_ENABLED(CONFIG_ARM64) + if (th) { config_base |=3D FIELD_PREP(ARMV8_PMU_EVTYPE_TH, th); config_base |=3D FIELD_PREP(ARMV8_PMU_EVTYPE_TC, armv8pmu_event_threshold_control(attr)); } +#endif =20 /* * Install the filter into config_base as this is used to --=20 2.34.1