From nobody Fri Dec 19 00:35:29 2025 Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5E53E13FE1 for ; Fri, 15 Dec 2023 08:21:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="HrhuLvCg" Received: by mail-wm1-f49.google.com with SMTP id 5b1f17b1804b1-40c3fe6c08fso4599665e9.1 for ; Fri, 15 Dec 2023 00:21:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1702628503; x=1703233303; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=WE4J9sdEbAWjadlcgrRDtUX7vxkIo3SYHmREd1D2LhY=; b=HrhuLvCgAyvJKjS4PHjeQWvboAWMZ5PXakURmnPSXSfNkX3V8oN9juOOtbVVYpqopW LnBjvENpj9FzRc2A4eBOq06nD7CUsmQb6AATbsxv/S8qO4sTKgV3/+dA5ZBSQTsLKsS5 NeaTnUw5TQ1t90/Bj/y+ZLuprkuAuOEjwPpvGVfjfaaTDM9TO0q2PKC6hpXABzPXQYDP Qc+gknVD2J7SpEZRDM7pgG894nwWo9UHy2Zvz0qTyDBlJ4Z/fA9uHVbDRChMFqoruV2u /ZB+03jsJXd0zFMq2Oejr/Pn37zXX2zPETC+EtT3vfUfotJaDtpo5vYNl+eRbEWvmu6Q FSWw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702628503; x=1703233303; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=WE4J9sdEbAWjadlcgrRDtUX7vxkIo3SYHmREd1D2LhY=; b=I58M0zdcAnHXeoz7ZgrXeZLWBDPhdwUXZ+3LgOegylkgmtozLkJz1tw9HSRgk+h19a 6gs1FqJU26iTCnL8oEnPUn6JyVRi513cCqEI0sg1xfNj2hrmFNHS5Xiv/JYy2piLkphm Ob+G7OivPrIRpfccg8gPjuuBDiUkzvmcDPtpIRFqZsTDknKuTtFq/pUI324kSVdrxxVU geVzmT3ReEv8xMGDtJ7K7pkDQqt/pY3AmszSruQOhvOXIf8UkHBSQp6nqOuCG+xMeZGL lW67hYnMJedYXy+mNYVvM8DBQ2sGtTyo1QoazOCvVFN9rL1v+zGoQ+V4Pzijy9elPL4d qHcw== X-Gm-Message-State: AOJu0Yzt/iZTyENmEF4HQexgdgcLBYoMtsxZ8N20E5SxmG6YeRZC1zKY v7n+1kUkq8cOpbKfvYfqOW0jMQ== X-Google-Smtp-Source: AGHT+IGxkZNgiuICrNCLFJ3rZoeDIcqctyrcaLzvdZrAndm8llSBFigGkDTnFtdo2gynrVR2w/tUaA== X-Received: by 2002:a05:600c:249:b0:40b:5e59:99bf with SMTP id 9-20020a05600c024900b0040b5e5999bfmr4088179wmj.223.1702628503704; Fri, 15 Dec 2023 00:21:43 -0800 (PST) Received: from 1.. ([79.115.63.202]) by smtp.gmail.com with ESMTPSA id p1-20020a05600c1d8100b0040b47c69d08sm30365570wms.18.2023.12.15.00.21.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Dec 2023 00:21:43 -0800 (PST) From: Tudor Ambarus To: pratyush@kernel.org, michael@walle.cc, miquel.raynal@bootlin.com Cc: richard@nod.at, jaimeliao@mxic.com.tw, linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org, Tudor Ambarus Subject: [PATCH 1/4] mtd: spi-nor: print flash ID instead of name Date: Fri, 15 Dec 2023 10:21:35 +0200 Message-Id: <20231215082138.16063-2-tudor.ambarus@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20231215082138.16063-1-tudor.ambarus@linaro.org> References: <20231215082138.16063-1-tudor.ambarus@linaro.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1014; i=tudor.ambarus@linaro.org; h=from:subject; bh=fRyfzko8la0oCOG0RX2CCXFxXMrr7i/8B7atPKhz260=; b=owEBbQGS/pANAwAKAUtVT0eljRTpAcsmYgBlfAyRihKH+RI8/qRe0hK1IhGDHTic6pMxXPYs5 LnRM+P/4lCJATMEAAEKAB0WIQQdQirKzw7IbV4d/t9LVU9HpY0U6QUCZXwMkQAKCRBLVU9HpY0U 6XD6CACyrcB+g8TzFuiWVZUQywzLCBw9n8J1TZkKlPXDSge9SYaMxQWXrisUVJRyp4TPFDckCcq g+Ogvbm8MrdTNXYi/rZHjVxYxQQ2nF9Dhrwd5tMNv0Y8MlqgIIV7jN2d7BGiBYzyat2z2+LszYE jX1HuX/mcZvyLxPPTZBGP/YXUOzwGr91zgRQE/bOJ1f56TEGN+0tU+MA8J+QjfUyuj8jeowM6V4 YJZCpPqxk/V3XxKTV5S+r2bZDAz81yj+p3coY3DjhNuKvOXec3yzFJPOiIap3byp9xa6+WfA7If 4DC5Q4PsepRygwyOPgCUhGDsdCmPQsrrE4KCTnZ3PBdngr+W X-Developer-Key: i=tudor.ambarus@linaro.org; a=openpgp; fpr=280B06FD4CAAD2980C46DDDF4DB1B079AD29CF3D Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" We saw flash ID collisions which make the flash name unreliable. Print the manufacgturer and device ID instead of the flash name. Lower the print to dev_dbg to stop polluting the kernel log. Suggested-by: Miquel Raynal Signed-off-by: Tudor Ambarus Acked-by: Pratyush Yadav Reviewed-by: Michael Walle --- drivers/mtd/spi-nor/core.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/mtd/spi-nor/core.c b/drivers/mtd/spi-nor/core.c index 503fed90c2fa..ca5bd93d1f17 100644 --- a/drivers/mtd/spi-nor/core.c +++ b/drivers/mtd/spi-nor/core.c @@ -3558,8 +3558,8 @@ int spi_nor_scan(struct spi_nor *nor, const char *nam= e, /* No mtd_info fields should be used up to this point. */ spi_nor_set_mtd_info(nor); =20 - dev_info(dev, "%s (%lld Kbytes)\n", info->name, - (long long)mtd->size >> 10); + dev_dbg(dev, "Manufacturer and device ID: %*phN\n", + SPI_NOR_MAX_ID_LEN, nor->id); =20 dev_dbg(dev, "mtd .name =3D %s, .size =3D 0x%llx (%lldMiB), " --=20 2.34.1 From nobody Fri Dec 19 00:35:29 2025 Received: from mail-wm1-f54.google.com (mail-wm1-f54.google.com [209.85.128.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 127E216433 for ; Fri, 15 Dec 2023 08:21:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="diDZQ6dA" Received: by mail-wm1-f54.google.com with SMTP id 5b1f17b1804b1-40c39e936b4so4283865e9.1 for ; Fri, 15 Dec 2023 00:21:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1702628505; x=1703233305; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=SEWvOGCN/u1S0GBF+sW6ffPiHV6fPcYw3Pxlfl13c70=; b=diDZQ6dAL+hEw4ZcfCvmcW8CO1xU2RwoC+hqXW082sNHLfKVqjSbZ1gt722hJOXe7o 8NmvF+TOKGo7thhUftpn/HGmBwIJPMox27ZRC9ABuxlgGQx9azvQpc8mdV/+4aWbr3qf Mr+QhEz1AaaiYvbpiZvJXnbS7+PSnm3jYJfRFtd5RoJdnkv4UEFU4c2d2rE54n1LdRpp zEXcSSa8s9+mlyTLaICZOwT1JVv1O16VmtFkhhBacV1F1KSvlcllB6klr95/Yr9g50Zw dKvRE41mTj/Bev8O7KdCwF0jqVXZ73/pZoSIvlUy0ZPMD3XCQm20XNXktHrdHoVtFUYO GdTg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702628505; x=1703233305; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=SEWvOGCN/u1S0GBF+sW6ffPiHV6fPcYw3Pxlfl13c70=; b=Vphty72BvCab3Q8l43xwOO/8EOW1GkR8F32563BdhK3rUQfdWCXpkbuckQWx/DXzcx go4O9Vv7d74z5XtzDhziRcx33I8k7ylri863mWEAJUFmiOlbxk4xnUWXs2N0z/A0rHUb fhH1C2dFUd1sIrt+hTD91sHt9sweYspLs/YsSdNR+Swl39HOnMWrHAHIeOtazbI0NG7U qLzxn0YFptDIJg+jcuokXfOnFr/hxG82fDHhTELUofxT6zvXZ11PmOU0mShSc1anVNxd gAbY7i/kyNbOO5r5ywhLWy2san9xNCn5BG7MsWU1xvo2eGMPAG2tLsbUHj7SwusZsRiI j0fw== X-Gm-Message-State: AOJu0Yz0lRHc9gjx95fzi2ksn/yuBSRFs1LPeFe3eGe7IJPKT0iHRG7O xllYsRnc3iq7nFDwbge/ynnIvQ== X-Google-Smtp-Source: AGHT+IGvO7zkyFnU8GsRJmvW+rPS2Q+LIghaAx6KbttBuhmMA07qt3UDlPud8epnRuHUWI8Gp3z4/g== X-Received: by 2002:a1c:7218:0:b0:40b:5e59:f714 with SMTP id n24-20020a1c7218000000b0040b5e59f714mr2742618wmc.134.1702628505281; Fri, 15 Dec 2023 00:21:45 -0800 (PST) Received: from 1.. ([79.115.63.202]) by smtp.gmail.com with ESMTPSA id p1-20020a05600c1d8100b0040b47c69d08sm30365570wms.18.2023.12.15.00.21.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Dec 2023 00:21:44 -0800 (PST) From: Tudor Ambarus To: pratyush@kernel.org, michael@walle.cc, miquel.raynal@bootlin.com Cc: richard@nod.at, jaimeliao@mxic.com.tw, linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org, Tudor Ambarus Subject: [PATCH 2/4] mtd: spi-nor: mark the flash name as obsolete Date: Fri, 15 Dec 2023 10:21:36 +0200 Message-Id: <20231215082138.16063-3-tudor.ambarus@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20231215082138.16063-1-tudor.ambarus@linaro.org> References: <20231215082138.16063-1-tudor.ambarus@linaro.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=949; i=tudor.ambarus@linaro.org; h=from:subject; bh=IB4QfMo7QOIyKQXCF0nV7DFWobXewCSfAICOVpteVKQ=; b=owEBbQGS/pANAwAKAUtVT0eljRTpAcsmYgBlfAySVVu12IWkgPGS2uNZhNhqZQi2mTtOCZdp9 lPA+WdxHkmJATMEAAEKAB0WIQQdQirKzw7IbV4d/t9LVU9HpY0U6QUCZXwMkgAKCRBLVU9HpY0U 6QRfCACQfEZgkzJZCB6bxYk+Nl/lieSKRnJ8+3ATk4izz80IDzr2Yp4EjAhhTGV/whZVhcXDLme Q5tkFn5g4y9u82uiX6pUCp8epAVuwNvOCgCcz975n0lFVEjZOroebxyRwuun9dvn8i3krcg6h4c vkx0fEf2RJYy/kVQyIsETwYFLreijtOqimzgdJKBYZaX7J+QiN9LdwCMKPgNjFjRdZ2Ypf0piOM npFhJwD7rqY8pCqVKmGyXtHdkO0bjSRl/35NKbNwJwMXI7Za4+v2PeBJx3k+kJJqGEVje4W5Mi8 D75HI+hO3ymNk3NMqNsG1dQvL4Q7NBeJyC4UbBiLd1cuBkI7 X-Developer-Key: i=tudor.ambarus@linaro.org; a=openpgp; fpr=280B06FD4CAAD2980C46DDDF4DB1B079AD29CF3D Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The flash name is unreliable as we saw flash ID collisions. Mark the name as obsolete. Signed-off-by: Tudor Ambarus Reviewed-by: Michael Walle Reviewed-by: Pratyush Yadav --- drivers/mtd/spi-nor/core.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mtd/spi-nor/core.h b/drivers/mtd/spi-nor/core.h index 29ed67725b18..d36c0e072954 100644 --- a/drivers/mtd/spi-nor/core.h +++ b/drivers/mtd/spi-nor/core.h @@ -465,7 +465,7 @@ struct spi_nor_id { * struct flash_info - SPI NOR flash_info entry. * @id: pointer to struct spi_nor_id or NULL, which means "no ID" (mostly * older chips). - * @name: the name of the flash. + * @name: (obsolete) the name of the flash. Do not set it for new addition= s. * @size: the size of the flash in bytes. * @sector_size: (optional) the size listed here is what works with * SPINOR_OP_SE, which isn't necessarily called a "sector= " by --=20 2.34.1 From nobody Fri Dec 19 00:35:29 2025 Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 58F3117747 for ; Fri, 15 Dec 2023 08:21:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="L5DOu1fH" Received: by mail-wm1-f42.google.com with SMTP id 5b1f17b1804b1-40c517d0de5so4515065e9.0 for ; Fri, 15 Dec 2023 00:21:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1702628506; x=1703233306; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=NqNjncwqqjJXTlOOAiExi5LnEF+/WvA2Fq4G9Cr+svw=; b=L5DOu1fHuPmbuD8K2wySR3lGQIKm8MTlpaNQdHPl3f9f9D++eJ36UBQyeAUq8lpoSw FrvvkZ+KLKNKyYhqk1uMMCBkp8wTbETmWGFkG6dpFZtHcqS0Xbi8AcqzwcHn8/rzSqWC 05tRVpaW8Tt+FvzWrLr4a/9xZP/qYmbUcmDJvHnr5//sow/uJMlnb3Yw40BR2j1bfCua 73Z+/JEwG9kviVQquONYNzLq+RJsMOj/gfEAT9gW3kI2iAyBHUeqC3iQUnoSCx1u2Pe1 p/udT/xF+NsUzeA2bbWJdOd+NCpWx8cG97BirLVDaKK4mcgyU4mXMSWbtPqcIWrEhsP7 2/xg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702628506; x=1703233306; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=NqNjncwqqjJXTlOOAiExi5LnEF+/WvA2Fq4G9Cr+svw=; b=d1aKEOsVVdqI7YAe6dbLitsmb/N38P6pjwWmr619xqX2LXmiqQV1tXVuKM06iG0/Ue RjVK07vZ/OrU9/q/Q6dVj4/tHsheE0RaFJK+jnYjSXbfwoVww1eEP0itZLFJnbh6Z+Uv YcOTCPWsDocd37FF3UU28VVVjx767CNySdCqASQUw1/1Lgz8zH1jpZH+IpcbZFy7PCOb uzs1MErMc+Jk0OX4dfLtp8UZ8s56fgxen56mKxvNUsMOals5MWxusjio0l6zzUj/+zTO kImtt11zCoi9nHx5dgmvouHb5zdUS642bW7NTgcySSbvHechfZVyNTAtkEzl0Bo6/ttE aWxg== X-Gm-Message-State: AOJu0YzS5xgFffJFi+rlSBmseXRzBt4iO44FsY++tr1Cv+JlPO4oEHZQ jh0A3V2mR1WbQHTR1eQZ7EbvYg== X-Google-Smtp-Source: AGHT+IEAprxPB8+tgE3JnpMosxNYTrH7hypu72LvvlwTtYzO4+cM2VZVHdoj8gUmTcXKKT9/DpKA0w== X-Received: by 2002:a05:600c:4384:b0:40b:2977:3d7a with SMTP id e4-20020a05600c438400b0040b29773d7amr6188952wmn.31.1702628506656; Fri, 15 Dec 2023 00:21:46 -0800 (PST) Received: from 1.. ([79.115.63.202]) by smtp.gmail.com with ESMTPSA id p1-20020a05600c1d8100b0040b47c69d08sm30365570wms.18.2023.12.15.00.21.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Dec 2023 00:21:46 -0800 (PST) From: Tudor Ambarus To: pratyush@kernel.org, michael@walle.cc, miquel.raynal@bootlin.com Cc: richard@nod.at, jaimeliao@mxic.com.tw, linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org, Tudor Ambarus Subject: [PATCH 3/4] mtd: spi-nor: sysfs: hide the flash name if not set Date: Fri, 15 Dec 2023 10:21:37 +0200 Message-Id: <20231215082138.16063-4-tudor.ambarus@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20231215082138.16063-1-tudor.ambarus@linaro.org> References: <20231215082138.16063-1-tudor.ambarus@linaro.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1557; i=tudor.ambarus@linaro.org; h=from:subject; bh=hQA5sORbw3xtkYv7YIEfdLni0OPdPoQur1BiyIea9wA=; b=owEBbQGS/pANAwAKAUtVT0eljRTpAcsmYgBlfAySzUrbRUhPFtUY+SLXVrH2ZVFiRqJ+XTJmx 6Y8ol5Q7c+JATMEAAEKAB0WIQQdQirKzw7IbV4d/t9LVU9HpY0U6QUCZXwMkgAKCRBLVU9HpY0U 6d0GB/9LEbjWhFVspZLCZOYxkhAWms2RGSpBdOGHiBozm1pTqpVVvwgUhHQOoexQ+ApAgD5n+qo QNAAdxWhNakleE9iq5tV8QmhYTzaplcyg+8RlsQbpS9fwMGwk98LmHE7Dt974gmuJNFR+IBYhIS iURU69hhL1D3pl2sjh2NaDHEgQuH4WFqIX8+0zP5WCzDyoFB8vjfwsJ99rO8kcR7fF0wwWTvXC8 YU6aEWiUELfKZkvsZwfO7Gru5IgDkqv1mUZumIF+IV/q8zpgf4phkuAwXNfNDfDaXyGWeYi00gE RW7HHx8c1LR/98xHAE3GF2eR9wF9LRM/x8dt/cPZV7u8YKWz X-Developer-Key: i=tudor.ambarus@linaro.org; a=openpgp; fpr=280B06FD4CAAD2980C46DDDF4DB1B079AD29CF3D Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: JaimeLiao The flash name is not reliable as we saw flash ID collisions. Hide the flash name if not set. Signed-off-by: JaimeLiao [ta: update commit subject and description] Signed-off-by: Tudor Ambarus Reviewed-by: Michael Walle --- Documentation/ABI/testing/sysfs-bus-spi-devices-spi-nor | 3 +++ drivers/mtd/spi-nor/sysfs.c | 2 ++ 2 files changed, 5 insertions(+) diff --git a/Documentation/ABI/testing/sysfs-bus-spi-devices-spi-nor b/Docu= mentation/ABI/testing/sysfs-bus-spi-devices-spi-nor index c800621eff95..6d7be97bf7d1 100644 --- a/Documentation/ABI/testing/sysfs-bus-spi-devices-spi-nor +++ b/Documentation/ABI/testing/sysfs-bus-spi-devices-spi-nor @@ -25,6 +25,9 @@ KernelVersion: 5.14 Contact: linux-mtd@lists.infradead.org Description: (RO) Part name of the SPI NOR flash. =20 + The attribute is not present if the jedec_id founded in + ID table but flash name didn't include in it. + =20 What: /sys/bus/spi/devices/.../spi-nor/sfdp Date: April 2021 diff --git a/drivers/mtd/spi-nor/sysfs.c b/drivers/mtd/spi-nor/sysfs.c index 2dfdc555a69f..96064e4babf0 100644 --- a/drivers/mtd/spi-nor/sysfs.c +++ b/drivers/mtd/spi-nor/sysfs.c @@ -78,6 +78,8 @@ static umode_t spi_nor_sysfs_is_visible(struct kobject *k= obj, =20 if (attr =3D=3D &dev_attr_manufacturer.attr && !nor->manufacturer) return 0; + if (attr =3D=3D &dev_attr_partname.attr && !nor->info->name) + return 0; if (attr =3D=3D &dev_attr_jedec_id.attr && !nor->info->id && !nor->id) return 0; =20 --=20 2.34.1 From nobody Fri Dec 19 00:35:29 2025 Received: from mail-wm1-f50.google.com (mail-wm1-f50.google.com [209.85.128.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CC088182B5 for ; Fri, 15 Dec 2023 08:21:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="OFu3vEQG" Received: by mail-wm1-f50.google.com with SMTP id 5b1f17b1804b1-40c41b43e1eso4677325e9.1 for ; Fri, 15 Dec 2023 00:21:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1702628508; x=1703233308; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=TuJawO4SusZv8/FICQYIvQK4zSxUomciGjXfeupkpPM=; b=OFu3vEQGw3noi41QwdOnUqkSZ2qQl2fXzpgSdp1zAMqZTciVFG+iB372kFP2cl2syd vfG7GgZGLw+LhH523fGGh/zvoaCuWfk9MeNXfhMLuO4U4np/geKJkgaEN6c26vcZL6cv 7IIFuIE/5Ugs5MxPq5U8P2gyztzq8Ul9NwDTfVOtNm+MkRa9J3YzvfykmQ3vQBtY13oV stW/CE9+3j1c21SM8eQJkDgpHuCgvWbkc10vL/IJD0pH/1nh12sPPyFo345JwC4B6YfP Y4SIDZvb34Zq9cqdcMiQYS0YpLD+V0hhaKiiennmWm8vPujPCbFs6PNuHtafxOk4FVF/ lsiA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702628508; x=1703233308; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=TuJawO4SusZv8/FICQYIvQK4zSxUomciGjXfeupkpPM=; b=wkeg5vo36kzcry/EZ4qUBLB7CgrxFVZOO5odiOqcJQ9eRv78hMN/9QasbgBOa+ahc3 0ta6bb3++JPqFgjHfQFCwgxqdSqJJQLbd+cqCztJqRglu8HuI3L5nWhZFMze2X7mx+qo KzikTL+PEv76DVgRWfXzhdT6viG4Dw4Hvv31C18vh1Zqm0PUFO8LHXGp2KJNuF/IfVWL DqKPAVEzWJ10E1iya43cic18dn/G6GGMEeivwRqce+B6KXPPUyWXBUq8XlfsNXkSJh0M WXUC5KPMPX9xkUCAi4uhIVn6/TecAfUS7XcU8pXTl4/XBLxPU7tXd/to9uAJSf1oB9EE mfpA== X-Gm-Message-State: AOJu0Yzx1W2a3X/rZPEpZs8uQOLY51qzKDFnH13irkAcR5fU21l1fjVI p2PMb5HmmdoiN8zzzaTB3M4aSw== X-Google-Smtp-Source: AGHT+IEbe2QkPEqCtjPj/fi/n5kO4uAzZ+iTCV7x1AVruE2cmQ2PU5UDSwoezU/9v/C8IO+qTKl4vg== X-Received: by 2002:a05:600c:292:b0:40c:260e:1bf6 with SMTP id 18-20020a05600c029200b0040c260e1bf6mr4922669wmk.192.1702628508089; Fri, 15 Dec 2023 00:21:48 -0800 (PST) Received: from 1.. ([79.115.63.202]) by smtp.gmail.com with ESMTPSA id p1-20020a05600c1d8100b0040b47c69d08sm30365570wms.18.2023.12.15.00.21.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Dec 2023 00:21:47 -0800 (PST) From: Tudor Ambarus To: pratyush@kernel.org, michael@walle.cc, miquel.raynal@bootlin.com Cc: richard@nod.at, jaimeliao@mxic.com.tw, linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org, Tudor Ambarus Subject: [PATCH 4/4] mtd: spi-nor: drop superfluous debug prints Date: Fri, 15 Dec 2023 10:21:38 +0200 Message-Id: <20231215082138.16063-5-tudor.ambarus@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20231215082138.16063-1-tudor.ambarus@linaro.org> References: <20231215082138.16063-1-tudor.ambarus@linaro.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1327; i=tudor.ambarus@linaro.org; h=from:subject; bh=g4bufmfMS6w03D11CI2uGLsvxqA3io9spWS2c3zko/k=; b=owEBbQGS/pANAwAKAUtVT0eljRTpAcsmYgBlfAySTlx2lf9cwP4qqsgz/vxDdsVq7T1ap/JJI BpGZZFzFMiJATMEAAEKAB0WIQQdQirKzw7IbV4d/t9LVU9HpY0U6QUCZXwMkgAKCRBLVU9HpY0U 6Te1B/0RAVmyu2FL3aavzo1rPOrgqcXWHparU1NyB6HBFb6+5q5BQ2Sglzlrm7fsREvIdcQni3f k/SwZgWKcJ8caUR4mZJJnTTwuV9e+Y3hPkLUNlK74SBOzxZ3UuvugVxykGAvUYjT1vhUixxKLnH p17ELt0f8QR9bxPhHZ8rn/S25uX/36CcDFIrtOK/bdvW6Sbv2q3wZPXfnNlMfZzi2e12t+ok4Mj lMkdls5z5E54mrtjOfxS+isLi1qEOaro8jjw9i4RvgZA9fl1AH5/xssRUE4oCrV7uZYivrvG/nu /e7opM8CRO2jk2kLLEp/XqNtuIuWWYgomUXVDUeeWabi/K4T X-Developer-Key: i=tudor.ambarus@linaro.org; a=openpgp; fpr=280B06FD4CAAD2980C46DDDF4DB1B079AD29CF3D Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The mtd data hall be obtained with the mtd ioctls or with new debugs entries if one cares. Drop the debug prints. Signed-off-by: Tudor Ambarus Reviewed-by: Michael Walle Reviewed-by: Pratyush Yadav --- drivers/mtd/spi-nor/core.c | 16 ---------------- 1 file changed, 16 deletions(-) diff --git a/drivers/mtd/spi-nor/core.c b/drivers/mtd/spi-nor/core.c index ca5bd93d1f17..a708c3448809 100644 --- a/drivers/mtd/spi-nor/core.c +++ b/drivers/mtd/spi-nor/core.c @@ -3561,22 +3561,6 @@ int spi_nor_scan(struct spi_nor *nor, const char *na= me, dev_dbg(dev, "Manufacturer and device ID: %*phN\n", SPI_NOR_MAX_ID_LEN, nor->id); =20 - dev_dbg(dev, - "mtd .name =3D %s, .size =3D 0x%llx (%lldMiB), " - ".erasesize =3D 0x%.8x (%uKiB) .numeraseregions =3D %d\n", - mtd->name, (long long)mtd->size, (long long)(mtd->size >> 20), - mtd->erasesize, mtd->erasesize / 1024, mtd->numeraseregions); - - if (mtd->numeraseregions) - for (i =3D 0; i < mtd->numeraseregions; i++) - dev_dbg(dev, - "mtd.eraseregions[%d] =3D { .offset =3D 0x%llx, " - ".erasesize =3D 0x%.8x (%uKiB), " - ".numblocks =3D %d }\n", - i, (long long)mtd->eraseregions[i].offset, - mtd->eraseregions[i].erasesize, - mtd->eraseregions[i].erasesize / 1024, - mtd->eraseregions[i].numblocks); return 0; } EXPORT_SYMBOL_GPL(spi_nor_scan); --=20 2.34.1