From nobody Sat Dec 27 22:50:37 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3F3A8C4167B for ; Thu, 14 Dec 2023 16:40:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1443535AbjLNQk2 (ORCPT ); Thu, 14 Dec 2023 11:40:28 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59870 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229873AbjLNQkZ (ORCPT ); Thu, 14 Dec 2023 11:40:25 -0500 Received: from mail-pl1-x636.google.com (mail-pl1-x636.google.com [IPv6:2607:f8b0:4864:20::636]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0FC9811B for ; Thu, 14 Dec 2023 08:40:31 -0800 (PST) Received: by mail-pl1-x636.google.com with SMTP id d9443c01a7336-1d351cb8b82so10529615ad.3 for ; Thu, 14 Dec 2023 08:40:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1702572031; x=1703176831; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=pQ3Qdqt0V+ZhHZ5PlObynzpb2Nb+bXeilCmC71DhFUE=; b=NFuagq7EQ1o5adNeSTINoY3k5HDp6hroJuKtLxQTfZljxCRPhY/ExElKll/zwihQ4l qCqd+lATftJnwZ90rorN5bPF5e0rwtSPxm2gdyH2ZovbOg1mCVQ+ctJT2j9i+AWURgp/ mF/RaqiXSUtNWMoIvKSmGXY984KqDFcDcfsZMG7XpHPzVfOZbE7/gd0deafYsWchnECc 7P/Fz69OWuVF7Ti8JswM0qmSLFfBSMUK8vX8Fd5iY9GtnbHeq2S6ynY7/HOo7GC5UsqY HAKb0i8NEmFv5BwofuOIH/sQVWYLMu3F7toDFu1pv6Q7zcD0+H4NocCWT+X9TE8K+Rla pcMw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702572031; x=1703176831; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=pQ3Qdqt0V+ZhHZ5PlObynzpb2Nb+bXeilCmC71DhFUE=; b=XTb3yfc3yr/p9E/YFtx+XXnF1wtDPh/Ern8oHSFo0Z9fKlyM1MrjH+hQsrnwIsc5WQ uyxK3vyX0EnmuryeOVi4IxHikuFMJpRWmvAHozqbSkTtKxNlHQ3fLCcemPJG9cv11CXF Ytl5Ei9SFzfIHqGMDC7W3YYFngKX+0weYr4VGdw+F+yZhWv16yx5229hSrw3O7tuq4JL qxG3J8BaFkkcJn0Qe2HKG3TgwpFwm3hqJrmuMP9ZDGf4ooOVmQmbjXgXEVk9Sva0JAWm f81jMyrFtX+l1+d6UXfuLREDz+KjjJ92fdmXfDGKjzIFUG5pxLl2B+90PijUSSP0o22m CoKw== X-Gm-Message-State: AOJu0YxyhWlwNlVXGas5/ZH3LHn9zVG9YkeXfjNMXM6cG4MdmHwWOq/H 1T/WlSdfFWm9ZDVgkmF63B+RSkIzmZE= X-Google-Smtp-Source: AGHT+IH2DfA4x6xKySy2o3svU4hSncEcqlwcYRSA4lqR7ptqakTKaNBJD+2zF0pkzhSr+P6S1sAA7A== X-Received: by 2002:a17:903:22c8:b0:1d0:6ffd:adfc with SMTP id y8-20020a17090322c800b001d06ffdadfcmr6419298plg.99.1702572031036; Thu, 14 Dec 2023 08:40:31 -0800 (PST) Received: from code.. ([144.202.108.46]) by smtp.gmail.com with ESMTPSA id p12-20020a170902e74c00b001d0b32ec81esm12595897plf.79.2023.12.14.08.40.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Dec 2023 08:40:30 -0800 (PST) From: Yuntao Wang To: linux-kernel@vger.kernel.org, kexec@lists.infradead.org, x86@kernel.org Cc: Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , Baoquan He , Vivek Goyal , Dave Young , Hari Bathini , Eric DeVolder , Andrew Morton , Sourabh Jain , Sean Christopherson , Takashi Iwai , Lianbo Jiang , Yuntao Wang Subject: [PATCH 1/3] x86/crash: remove the unused image parameter from prepare_elf_headers() Date: Fri, 15 Dec 2023 00:38:40 +0800 Message-ID: <20231214163842.129139-2-ytcoode@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20231214163842.129139-1-ytcoode@gmail.com> References: <20231214163842.129139-1-ytcoode@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" The image parameter is no longer in use, remove it. Also, tidy up the code formatting. Signed-off-by: Yuntao Wang Acked-by: Baoquan He --- arch/x86/kernel/crash.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/arch/x86/kernel/crash.c b/arch/x86/kernel/crash.c index c92d88680dbf..792231a56d11 100644 --- a/arch/x86/kernel/crash.c +++ b/arch/x86/kernel/crash.c @@ -198,8 +198,8 @@ static int prepare_elf64_ram_headers_callback(struct re= source *res, void *arg) } =20 /* Prepare elf headers. Return addr and size */ -static int prepare_elf_headers(struct kimage *image, void **addr, - unsigned long *sz, unsigned long *nr_mem_ranges) +static int prepare_elf_headers(void **addr, unsigned long *sz, + unsigned long *nr_mem_ranges) { struct crash_mem *cmem; int ret; @@ -221,7 +221,7 @@ static int prepare_elf_headers(struct kimage *image, vo= id **addr, *nr_mem_ranges =3D cmem->nr_ranges; =20 /* By default prepare 64bit headers */ - ret =3D crash_prepare_elf64_headers(cmem, IS_ENABLED(CONFIG_X86_64), add= r, sz); + ret =3D crash_prepare_elf64_headers(cmem, IS_ENABLED(CONFIG_X86_64), addr= , sz); =20 out: vfree(cmem); @@ -349,7 +349,7 @@ int crash_load_segments(struct kimage *image) .buf_max =3D ULONG_MAX, .top_down =3D false }; =20 /* Prepare elf headers and add a segment */ - ret =3D prepare_elf_headers(image, &kbuf.buffer, &kbuf.bufsz, &pnum); + ret =3D prepare_elf_headers(&kbuf.buffer, &kbuf.bufsz, &pnum); if (ret) return ret; =20 @@ -452,7 +452,7 @@ void arch_crash_handle_hotplug_event(struct kimage *ima= ge) * Create the new elfcorehdr reflecting the changes to CPU and/or * memory resources. */ - if (prepare_elf_headers(image, &elfbuf, &elfsz, &nr_mem_ranges)) { + if (prepare_elf_headers(&elfbuf, &elfsz, &nr_mem_ranges)) { pr_err("unable to create new elfcorehdr"); goto out; } --=20 2.43.0 From nobody Sat Dec 27 22:50:37 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D7153C4332F for ; Thu, 14 Dec 2023 16:41:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1443557AbjLNQki (ORCPT ); Thu, 14 Dec 2023 11:40:38 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40730 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230281AbjLNQke (ORCPT ); Thu, 14 Dec 2023 11:40:34 -0500 Received: from mail-pl1-x62e.google.com (mail-pl1-x62e.google.com [IPv6:2607:f8b0:4864:20::62e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5EF2F131 for ; Thu, 14 Dec 2023 08:40:39 -0800 (PST) Received: by mail-pl1-x62e.google.com with SMTP id d9443c01a7336-1d0c4d84bf6so50125525ad.1 for ; Thu, 14 Dec 2023 08:40:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1702572038; x=1703176838; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=VRn1DTbbmWGLB1nxG36xstbG89fQMD3XiAVHtLkUKlI=; b=dOC8w8ZkjgYsSIKHdseod5HSGGz2xSe09FURQkBUmu+B5bBO8x+3T6QUOEZ4Y/K9Xi hnynuV/qS6f/A8//ztca9zirppl1oaW7uJ0iEUIka+q9U2bLOAR1HKKExNA2z4eDSU5G xUT8T31E3N0KuMr8f8S03nZEvHO/rhToBYtbHEQJYb+gGi0E/lqdtZd0TaTH91bra5+C XBc5Fj7GZEJ05Ce8dTipbjMrCVMB/OdQACs/euGG2Bff+XrDxVKS6v+QGwfMXb4/NHfT xCIa6VPNz3ICPCnlhQbKW8X/cpTXg3AwXTl6RUw25D64umwc2g0qvc7BSi6eq8wwvSuW cIXg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702572038; x=1703176838; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=VRn1DTbbmWGLB1nxG36xstbG89fQMD3XiAVHtLkUKlI=; b=wTjFm54nyDXxCt+CoffqtuaUutCE7Df8MV77YRrWP2obi123adEhzVctfCfk3AXYsS ObN8763wMWOADvgo1OD3eMz4sBgF97ItLi8x66VC/a512m7pArf74Fa7s5T3mqOgX/ri QLsERUbR0qgNn6Dvu+8s9wrM4pwGvG3+h02myDT0/RxxQOEvunkLOYf2uh4NmhzrHIYm qOpDwDlokSUxbUV7k6/Oc5p7gx7/w1yAH8Eu6wvWty5YMMImhVITfqOt0zohI3nEG93i VZN152xgA+T/+GWghgHV2KdbyEiZUURXQlErFqE3WzITZ/e9Qx7I6cNctFux5O6cI5Pz veCA== X-Gm-Message-State: AOJu0Yx5kHLrHtw8ZMkfdl9fIeP326vZsLPOR0M5+wAqXPoHpE/ZYncq DMQbL+DQwTcVZ8WZjq9s1pgt+geH9GI= X-Google-Smtp-Source: AGHT+IESkQlL7JhHRaVr6xofo//eAXSa64RW84yr+T6FldHHTCobQXcxJcnZQDwsiYeR88Wr3ZnhTQ== X-Received: by 2002:a17:902:c3c5:b0:1d3:64dc:e9d0 with SMTP id j5-20020a170902c3c500b001d364dce9d0mr848917plj.26.1702572038411; Thu, 14 Dec 2023 08:40:38 -0800 (PST) Received: from code.. ([144.202.108.46]) by smtp.gmail.com with ESMTPSA id p12-20020a170902e74c00b001d0b32ec81esm12595897plf.79.2023.12.14.08.40.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Dec 2023 08:40:38 -0800 (PST) From: Yuntao Wang To: linux-kernel@vger.kernel.org, kexec@lists.infradead.org, x86@kernel.org Cc: Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , Baoquan He , Vivek Goyal , Dave Young , Hari Bathini , Eric DeVolder , Andrew Morton , Sourabh Jain , Sean Christopherson , Takashi Iwai , Lianbo Jiang , Yuntao Wang Subject: [PATCH 2/3] x86/crash: use SZ_1M macro instead of hardcoded value Date: Fri, 15 Dec 2023 00:38:41 +0800 Message-ID: <20231214163842.129139-3-ytcoode@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20231214163842.129139-1-ytcoode@gmail.com> References: <20231214163842.129139-1-ytcoode@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Use SZ_1M macro instead of hardcoded 1<<20 to make code more readable. Signed-off-by: Yuntao Wang Acked-by: Baoquan He --- arch/x86/kernel/crash.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/x86/kernel/crash.c b/arch/x86/kernel/crash.c index 792231a56d11..249b5876e7ec 100644 --- a/arch/x86/kernel/crash.c +++ b/arch/x86/kernel/crash.c @@ -170,7 +170,7 @@ static int elf_header_exclude_ranges(struct crash_mem *= cmem) int ret =3D 0; =20 /* Exclude the low 1M because it is always reserved */ - ret =3D crash_exclude_mem_range(cmem, 0, (1<<20)-1); + ret =3D crash_exclude_mem_range(cmem, 0, SZ_1M - 1); if (ret) return ret; =20 --=20 2.43.0 From nobody Sat Dec 27 22:50:37 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5F678C4332F for ; Thu, 14 Dec 2023 16:52:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230297AbjLNQwm (ORCPT ); Thu, 14 Dec 2023 11:52:42 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40770 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230373AbjLNQkm (ORCPT ); Thu, 14 Dec 2023 11:40:42 -0500 Received: from mail-pl1-x635.google.com (mail-pl1-x635.google.com [IPv6:2607:f8b0:4864:20::635]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 236F8125 for ; Thu, 14 Dec 2023 08:40:47 -0800 (PST) Received: by mail-pl1-x635.google.com with SMTP id d9443c01a7336-1d350dff621so18684135ad.1 for ; Thu, 14 Dec 2023 08:40:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1702572046; x=1703176846; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ti6fJ0q7IpNfuWyKxmP8PV98iLP1/8o/ewhA7a4SgUI=; b=kDUTLDbMf9yklFs28/jCpfaXoCirUi+aiVu4oVMZxOVnMMFyYbyUrzCS8KCSe5+cR0 osvkqoCl5e73DiFqpoG3zDseVorsMzZZqeYfeD9w/dJ2e68NYyFS5O+34ASOGgNqpKDj ZI4hBg9W9MGcOH7wYmQ9NE4JMHeBhQtD1zHDRtusrKZUmb8OLghhGv2KmCem/iIasFem 7fVulnsSyU25i0RYGKcsp7+YIXJSPp+NvVsJKXs1zVf2Vv37LYT0a2Tw+RPZAlD4qKTH ENPcFPZ7Fq88w+0HekZSZaOUqUifnAT1Iq/FNNuD9s6nmg2bE0VfC22QspOPGEnl8qya wC+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702572046; x=1703176846; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ti6fJ0q7IpNfuWyKxmP8PV98iLP1/8o/ewhA7a4SgUI=; b=vYVzLAlMS1yGCZwuFVP/3fDPDTMXQmOQu0LcDgko7ps0Wi7jA1RNkcQyGs//z0vLwM TpSKXNQntE62bLnjB7px8xQfKVGqC9k+Jit1bjxhUBKnYcnlfLSloWubXeT0JcVBCCA9 n4g79UE3sE/SIUCx+DfpNEVJgbGyP02pXqALvpPb0Z1vyxl7FcOF9rhC88jiBihB2VOZ qU50K84zcUQy8lcPEby/MuqYsRsduhO51x2PxvdfN0bfkkoOcLGlKdCMDAPQZcEAatU/ jniR5ttb7qB6LG3K5yh07LtyEgDeAnZImx6APJJB1oNdxbA+ZP/Y5B0qeiqAGEG9ubAp J6WA== X-Gm-Message-State: AOJu0YwN/pDX3NQRzBlDLk7zn736jv5ogXlu0BOI/eLofmL8JD9n1LVS KctZVzP7aIBnneJqg9FsXKaF7YSGO4g= X-Google-Smtp-Source: AGHT+IHQ4qZPIQ2nZd+rqHbw2B+B5GXKKrM1wuoCjHBF9nDKZgAuS+1Z+WxnRl2QvHLLFKAZWGBD/w== X-Received: by 2002:a17:902:7ecf:b0:1d3:3c35:81b5 with SMTP id p15-20020a1709027ecf00b001d33c3581b5mr3669073plb.46.1702572046197; Thu, 14 Dec 2023 08:40:46 -0800 (PST) Received: from code.. ([144.202.108.46]) by smtp.gmail.com with ESMTPSA id p12-20020a170902e74c00b001d0b32ec81esm12595897plf.79.2023.12.14.08.40.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Dec 2023 08:40:45 -0800 (PST) From: Yuntao Wang To: linux-kernel@vger.kernel.org, kexec@lists.infradead.org, x86@kernel.org Cc: Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , Baoquan He , Vivek Goyal , Dave Young , Hari Bathini , Eric DeVolder , Andrew Morton , Sourabh Jain , Sean Christopherson , Takashi Iwai , Lianbo Jiang , Yuntao Wang Subject: [PATCH 3/3] crash_core: fix and simplify the logic of crash_exclude_mem_range() Date: Fri, 15 Dec 2023 00:38:42 +0800 Message-ID: <20231214163842.129139-4-ytcoode@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20231214163842.129139-1-ytcoode@gmail.com> References: <20231214163842.129139-1-ytcoode@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" The purpose of crash_exclude_mem_range() is to remove all memory ranges that overlap with [mstart-mend]. However, the current logic only removes the first overlapping memory range. Commit a2e9a95d2190 ("kexec: Improve & fix crash_exclude_mem_range() to handle overlapping ranges") attempted to address this issue, but it did not fix all error cases. Let's fix and simplify the logic of crash_exclude_mem_range(). Signed-off-by: Yuntao Wang --- kernel/crash_core.c | 70 ++++++++++++--------------------------------- 1 file changed, 19 insertions(+), 51 deletions(-) diff --git a/kernel/crash_core.c b/kernel/crash_core.c index efe87d501c8c..0292a4c8bb2f 100644 --- a/kernel/crash_core.c +++ b/kernel/crash_core.c @@ -565,9 +565,8 @@ int crash_prepare_elf64_headers(struct crash_mem *mem, = int need_kernel_map, int crash_exclude_mem_range(struct crash_mem *mem, unsigned long long mstart, unsigned long long mend) { - int i, j; + int i; unsigned long long start, end, p_start, p_end; - struct range temp_range =3D {0, 0}; =20 for (i =3D 0; i < mem->nr_ranges; i++) { start =3D mem->ranges[i].start; @@ -575,72 +574,41 @@ int crash_exclude_mem_range(struct crash_mem *mem, p_start =3D mstart; p_end =3D mend; =20 - if (mstart > end || mend < start) + if (p_start > end || p_end < start) continue; =20 /* Truncate any area outside of range */ - if (mstart < start) + if (p_start < start) p_start =3D start; - if (mend > end) + if (p_end > end) p_end =3D end; =20 /* Found completely overlapping range */ if (p_start =3D=3D start && p_end =3D=3D end) { - mem->ranges[i].start =3D 0; - mem->ranges[i].end =3D 0; - if (i < mem->nr_ranges - 1) { - /* Shift rest of the ranges to left */ - for (j =3D i; j < mem->nr_ranges - 1; j++) { - mem->ranges[j].start =3D - mem->ranges[j+1].start; - mem->ranges[j].end =3D - mem->ranges[j+1].end; - } - - /* - * Continue to check if there are another overlapping ranges - * from the current position because of shifting the above - * mem ranges. - */ - i--; - mem->nr_ranges--; - continue; - } + memmove(&mem->ranges[i], &mem->ranges[i + 1], + (mem->nr_ranges - (i + 1)) * sizeof(mem->ranges[i])); + i--; mem->nr_ranges--; - return 0; - } - - if (p_start > start && p_end < end) { + } else if (p_start > start && p_end < end) { /* Split original range */ + if (mem->nr_ranges >=3D mem->max_nr_ranges) + return -ENOMEM; + + memmove(&mem->ranges[i + 2], &mem->ranges[i + 1], + (mem->nr_ranges - (i + 1)) * sizeof(mem->ranges[i])); + mem->ranges[i].end =3D p_start - 1; - temp_range.start =3D p_end + 1; - temp_range.end =3D end; + mem->ranges[i + 1].start =3D p_end + 1; + mem->ranges[i + 1].end =3D end; + + i++; + mem->nr_ranges++; } else if (p_start !=3D start) mem->ranges[i].end =3D p_start - 1; else mem->ranges[i].start =3D p_end + 1; - break; - } - - /* If a split happened, add the split to array */ - if (!temp_range.end) - return 0; - - /* Split happened */ - if (i =3D=3D mem->max_nr_ranges - 1) - return -ENOMEM; - - /* Location where new range should go */ - j =3D i + 1; - if (j < mem->nr_ranges) { - /* Move over all ranges one slot towards the end */ - for (i =3D mem->nr_ranges - 1; i >=3D j; i--) - mem->ranges[i + 1] =3D mem->ranges[i]; } =20 - mem->ranges[j].start =3D temp_range.start; - mem->ranges[j].end =3D temp_range.end; - mem->nr_ranges++; return 0; } =20 --=20 2.43.0