From nobody Sun Dec 28 02:41:49 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7CE83C4332F for ; Wed, 13 Dec 2023 17:34:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1442039AbjLMRe2 (ORCPT ); Wed, 13 Dec 2023 12:34:28 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53422 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1379471AbjLMReQ (ORCPT ); Wed, 13 Dec 2023 12:34:16 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EA8B2109 for ; Wed, 13 Dec 2023 09:34:19 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7DC4BC433C8; Wed, 13 Dec 2023 17:34:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1702488859; bh=z5vRF5xTB2DyU68YJt7eopt5kMmuIX3FIrosJmZo00o=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=X/vsPDIJdBvT0W9Nu6dz9a57imxvUncs9l5zIGABdEQpyYkMQdJgI2BTGLD5RfLUz 3/e4t0euMXGVnZh/5UzbJd0kPBArG+Y60/uJ5Z2qu49gHRARCNMwVoV+fmGTNjuEQC k3zfR8GCtH3kWTkzE+M3Bu7fPJEIB/mgZOWxOtD6h4jlcAje6BZyV3Uwkqb8uzKGfd M0B8THnNIJAPmVGJZ5+G7rWWrkVrtGYKaWqlyFdgmSDHZ1GTqjb4yUL1mdRnMjNvLN GHI+El/PyoJujlkTfG8VvcL5w/tw3VvaGQePlawcoSxLg5jcYh+A8e+Rhxvgref/1/ N1I2FcHD8mJjg== Received: from johan by xi.lan with local (Exim 4.96.2) (envelope-from ) id 1rDT7h-0007gy-1Z; Wed, 13 Dec 2023 18:34:17 +0100 From: Johan Hovold To: Bjorn Andersson Cc: Andy Gross , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Krishna Kurapati PSSNV , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Johan Hovold , stable@vger.kernel.org Subject: [PATCH 2/5] arm64: dts: qcom: sdm845: fix USB DP/DM HS PHY interrupts Date: Wed, 13 Dec 2023 18:34:00 +0100 Message-ID: <20231213173403.29544-3-johan+linaro@kernel.org> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20231213173403.29544-1-johan+linaro@kernel.org> References: <20231213173403.29544-1-johan+linaro@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" The USB DP/DM HS PHY interrupts need to be provided by the PDC interrupt controller in order to be able to wake the system up from low-power states and to be able to detect disconnect events, which requires triggering on falling edges. A recent commit updated the trigger type but failed to change the interrupt provider as required. This leads to the current Linux driver failing to probe instead of printing an error during suspend and USB wakeup not working as intended. Fixes: 84ad9ac8d9ca ("arm64: dts: qcom: sdm845: fix USB wakeup interrupt ty= pes") Fixes: ca4db2b538a1 ("arm64: dts: qcom: sdm845: Add USB-related nodes") Cc: stable@vger.kernel.org # 4.20 Signed-off-by: Johan Hovold Reviewed-by: Konrad Dybcio --- arch/arm64/boot/dts/qcom/sdm845.dtsi | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi b/arch/arm64/boot/dts/qco= m/sdm845.dtsi index 0d2be706505a..97ee02469d69 100644 --- a/arch/arm64/boot/dts/qcom/sdm845.dtsi +++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi @@ -4053,10 +4053,10 @@ usb_1: usb@a6f8800 { <&gcc GCC_USB30_PRIM_MASTER_CLK>; assigned-clock-rates =3D <19200000>, <150000000>; =20 - interrupts =3D , - , - , - ; + interrupts-extended =3D <&intc GIC_SPI 131 IRQ_TYPE_LEVEL_HIGH>, + <&intc GIC_SPI 486 IRQ_TYPE_LEVEL_HIGH>, + <&pdc_intc 8 IRQ_TYPE_EDGE_BOTH>, + <&pdc_intc 9 IRQ_TYPE_EDGE_BOTH>; interrupt-names =3D "hs_phy_irq", "ss_phy_irq", "dm_hs_phy_irq", "dp_hs_phy_irq"; =20 @@ -4104,10 +4104,10 @@ usb_2: usb@a8f8800 { <&gcc GCC_USB30_SEC_MASTER_CLK>; assigned-clock-rates =3D <19200000>, <150000000>; =20 - interrupts =3D , - , - , - ; + interrupts-extended =3D <&intc GIC_SPI 136 IRQ_TYPE_LEVEL_HIGH>, + <&intc GIC_SPI 487 IRQ_TYPE_LEVEL_HIGH>, + <&pdc_intc 10 IRQ_TYPE_EDGE_BOTH>, + <&pdc_intc 11 IRQ_TYPE_EDGE_BOTH>; interrupt-names =3D "hs_phy_irq", "ss_phy_irq", "dm_hs_phy_irq", "dp_hs_phy_irq"; =20 --=20 2.41.0