From nobody Thu Dec 18 14:46:03 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BE1EFC4332F for ; Wed, 13 Dec 2023 12:43:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1378834AbjLMMnL (ORCPT ); Wed, 13 Dec 2023 07:43:11 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56838 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233379AbjLMMnJ (ORCPT ); Wed, 13 Dec 2023 07:43:09 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EF701F5 for ; Wed, 13 Dec 2023 04:43:15 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D65C5C433CA; Wed, 13 Dec 2023 12:43:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1702471395; bh=S5dSnA41y/QX1OV5ufybA5eBL4578WDAqBgybqwlsMY=; h=From:To:Cc:Subject:Date:From; b=AtqJIpxEVNKW8/4YwZ052AvcohHWiFlJwJj7skuxaQZeMTqux4ITVcKJZijEnWbT6 /9C+uxjHsphZIiLt6MdoI1FKPJG2VS+8OmXfi+lnmBcHrqxfHFO3FTYfDgxbQGvD7W /HAsU0ysZInnThshhwkyB9JyRVbVyZNDYUln1+N/361VCoV+PdMlgZw/dYt/Qe3NP0 dKYHlRgcW8D4x4oQ+BaJMuO6MjzjgB+V41lHrig55InkCXDbqu+r9SMMQ+ILDxfdRQ LYC/0mBhAYHpLandcdZd60VOS+ARalvZWZAcGIrO75MStxeQR5bkDTDBas+rYYSKMc wJgOyhJ5a92lg== From: Arnd Bergmann To: Tomas Winkler , Arnd Bergmann , Greg Kroah-Hartman , Wentong Wu , Sakari Ailus Cc: Alexander Usyskin , linux-kernel@vger.kernel.org Subject: [PATCH] mei: fix vsc dependency Date: Wed, 13 Dec 2023 13:43:05 +0100 Message-Id: <20231213124310.761638-1-arnd@kernel.org> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" From: Arnd Bergmann The Kconfig dependency in the new module is reversed from the dependency on the exported symbols, so it fails to link with CONFIG_INTEL_MEI_VSC disabled and CONFIG_INTEL_MEI_VSC_HW enabled: ERROR: modpost: "vsc_tp_reset" [drivers/misc/mei/mei-vsc.ko] undefined! ERROR: modpost: "vsc_tp_init" [drivers/misc/mei/mei-vsc.ko] undefined! ERROR: modpost: "vsc_tp_xfer" [drivers/misc/mei/mei-vsc.ko] undefined! ERROR: modpost: "vsc_tp_need_read" [drivers/misc/mei/mei-vsc.ko] undefined! ERROR: modpost: "vsc_tp_intr_enable" [drivers/misc/mei/mei-vsc.ko] undefine= d! ERROR: modpost: "vsc_tp_intr_synchronize" [drivers/misc/mei/mei-vsc.ko] und= efined! ERROR: modpost: "vsc_tp_intr_disable" [drivers/misc/mei/mei-vsc.ko] undefin= ed! ERROR: modpost: "vsc_tp_register_event_cb" [drivers/misc/mei/mei-vsc.ko] un= defined! Make the dependency reflect the module dependency. Fixes: 566f5ca97680 ("mei: Add transport driver for IVSC device") Signed-off-by: Arnd Bergmann --- drivers/misc/mei/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/misc/mei/Kconfig b/drivers/misc/mei/Kconfig index 858bd701d68c..eb69987f8325 100644 --- a/drivers/misc/mei/Kconfig +++ b/drivers/misc/mei/Kconfig @@ -64,6 +64,7 @@ config INTEL_MEI_VSC_HW tristate "Intel visual sensing controller device transport driver" depends on ACPI && SPI depends on GPIOLIB || COMPILE_TEST + depends on INTEL_MEI_VSC help Intel SPI transport driver between host and Intel visual sensing controller (IVSC) device. @@ -73,7 +74,6 @@ config INTEL_MEI_VSC_HW =20 config INTEL_MEI_VSC tristate "Intel visual sensing controller device with ME interface" - depends on INTEL_MEI_VSC_HW depends on INTEL_MEI help Intel MEI over SPI driver for Intel visual sensing controller --=20 2.39.2