From nobody Sun Dec 28 04:57:20 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3AE64C4332F for ; Tue, 12 Dec 2023 23:05:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1377990AbjLLXE5 (ORCPT ); Tue, 12 Dec 2023 18:04:57 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43340 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235334AbjLLXEX (ORCPT ); Tue, 12 Dec 2023 18:04:23 -0500 Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.93]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 580E71704; Tue, 12 Dec 2023 15:04:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1702422245; x=1733958245; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=fETq5AdND9wjaev3rV22iysiP7uaRlJ1rv6ZEULKZsQ=; b=LHYb8kfOcdodBJDIqI8gXkYUjmfr2XS6vN9+N5W6DWAqmp10wKiI4I86 9q6NXhu8FvRe/XBUmLsVbWGrmPCXqJvm7KagE7bsVJ8TijNJxgpI8eiQh KV+0/l5mx1fgj/hq1YLiqC7VxgPPIXhSB4GtRXhUF3ZJfOlkLiFEm4A9k OvV9XiXJVpzAZiRyVI6bsZ5JvbawMxDnxMxDeRe2vaJRwrZRgBMnLuUoa PjrTc7ba265YTMr43ogCoYhwgTKKfyfA21oBuiN0W84tHHEs0TyL6+sl9 Pep2DMFNsFvJJClqvQRMTQCz+F0XwEJw/ktoQ1Y04UPWVc8RyBhdpCFpP w==; X-IronPort-AV: E=McAfee;i="6600,9927,10922"; a="392056040" X-IronPort-AV: E=Sophos;i="6.04,271,1695711600"; d="scan'208";a="392056040" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Dec 2023 15:02:59 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10922"; a="864392039" X-IronPort-AV: E=Sophos;i="6.04,271,1695711600"; d="scan'208";a="864392039" Received: from node-10329.jf.intel.com ([10.54.34.22]) by FMSMGA003.fm.intel.com with ESMTP; 12 Dec 2023 15:02:58 -0800 From: weilin.wang@intel.com To: weilin.wang@intel.com, Ian Rogers , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Adrian Hunter , Kan Liang Cc: linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, Perry Taylor , Samantha Alt , Caleb Biggers , Mark Rutland , Yang Jihong Subject: [RFC PATCH v3 16/18] perf stat: Add tool events support in hardware-grouping Date: Tue, 12 Dec 2023 15:02:22 -0800 Message-Id: <20231212230224.1473300-18-weilin.wang@intel.com> X-Mailer: git-send-email 2.39.3 In-Reply-To: <20231212230224.1473300-1-weilin.wang@intel.com> References: <20231212230224.1473300-1-weilin.wang@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" From: Weilin Wang Add tool events into default_core grouping strings if find tool events so that metrics use tool events could be correctly calculated. Need this step to support TopdownL4-L5. Signed-off-by: Weilin Wang --- tools/perf/util/metricgroup.c | 49 ++++++++++++++++++++++++++++++++++- 1 file changed, 48 insertions(+), 1 deletion(-) diff --git a/tools/perf/util/metricgroup.c b/tools/perf/util/metricgroup.c index f0ef0c2ed860..dc21a8255d82 100644 --- a/tools/perf/util/metricgroup.c +++ b/tools/perf/util/metricgroup.c @@ -1391,6 +1391,35 @@ static void find_tool_events(const struct list_head = *metric_list, } } =20 +/** + * get_tool_event_str - Generate and return a string with all the used tool + * event names. + */ +static int get_tool_event_str(struct strbuf *events, + const bool tool_events[PERF_TOOL_MAX], + bool *has_tool_event) +{ + int i =3D 0; + int ret; + + perf_tool_event__for_each_event(i) { + if (tool_events[i]) { + const char *tmp =3D strdup(perf_tool_event__to_str(i)); + + if (!tmp) + return -ENOMEM; + *has_tool_event =3D true; + ret =3D strbuf_addstr(events, ","); + if (ret) + return ret; + ret =3D strbuf_addstr(events, tmp); + if (ret) + return ret; + } + } + return 0; +} + /** * build_combined_expr_ctx - Make an expr_parse_ctx with all !group_events * metric IDs, as the IDs are held in a set, @@ -1954,6 +1983,7 @@ static int assign_event_grouping(struct metricgroup__= event_info *e, =20 static int hw_aware_metricgroup__build_event_string(struct list_head *grou= p_strs, const char *modifier, + const bool tool_events[PERF_TOOL_MAX], struct list_head *groups) { struct metricgroup__pmu_group_list *p; @@ -1961,8 +1991,12 @@ static int hw_aware_metricgroup__build_event_string(= struct list_head *group_strs struct metricgroup__group_events *ge; bool no_group =3D true; int ret =3D 0; + struct strbuf tool_event_str =3D STRBUF_INIT; + bool has_tool_event =3D false; =20 #define RETURN_IF_NON_ZERO(x) do { if (x) return x; } while (0) + ret =3D get_tool_event_str(&tool_event_str, tool_events, &has_tool_event); + RETURN_IF_NON_ZERO(ret); =20 list_for_each_entry(p, groups, nd) { list_for_each_entry(g, &p->group_head, nd) { @@ -2034,6 +2068,12 @@ static int hw_aware_metricgroup__build_event_string(= struct list_head *group_strs } ret =3D strbuf_addf(events, "}:W"); RETURN_IF_NON_ZERO(ret); + + if (!strcmp(p->pmu_name, "default_core") && has_tool_event) { + ret =3D strbuf_addstr(events, tool_event_str.buf); + RETURN_IF_NON_ZERO(ret); + } + pr_debug("events-buf: %s\n", events->buf); list_add_tail(&new_group_str->nd, group_strs); } @@ -2119,6 +2159,7 @@ static int hw_aware_build_grouping(struct expr_parse_= ctx *ctx, if (ret) goto err_out; } + ret =3D get_pmu_counter_layouts(&pmu_info_list, ltable); if (ret) goto err_out; @@ -2164,6 +2205,7 @@ static void metricgroup__free_grouping_strs(struct li= st_head */ static int hw_aware_parse_ids(struct perf_pmu *fake_pmu, struct expr_parse_ctx *ids, const char *modifier, + const bool tool_events[PERF_TOOL_MAX], struct evlist **out_evlist) { struct parse_events_error parse_error; @@ -2177,7 +2219,8 @@ static int hw_aware_parse_ids(struct perf_pmu *fake_p= mu, ret =3D hw_aware_build_grouping(ids, &grouping); if (ret) goto out; - ret =3D hw_aware_metricgroup__build_event_string(&grouping_str, modifier,= &grouping); + ret =3D hw_aware_metricgroup__build_event_string(&grouping_str, modifier, + tool_events, &grouping); if (ret) goto out; =20 @@ -2312,6 +2355,7 @@ static int hw_aware_parse_groups(struct evlist *perf_= evlist, struct evlist *combined_evlist =3D NULL; LIST_HEAD(metric_list); struct metric *m; + bool tool_events[PERF_TOOL_MAX] =3D {false}; int ret; bool metric_no_group =3D false; bool metric_no_merge =3D false; @@ -2330,11 +2374,14 @@ static int hw_aware_parse_groups(struct evlist *per= f_evlist, if (!metric_no_merge) { struct expr_parse_ctx *combined =3D NULL; =20 + find_tool_events(&metric_list, tool_events); + ret =3D hw_aware_build_combined_expr_ctx(&metric_list, &combined); =20 if (!ret && combined && hashmap__size(combined->ids)) { ret =3D hw_aware_parse_ids(fake_pmu, combined, /*modifier=3D*/NULL, + tool_events, &combined_evlist); } =20 --=20 2.39.3