From nobody Wed Dec 17 05:47:50 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 54ADFC4332F for ; Tue, 12 Dec 2023 16:57:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229928AbjLLQ5H (ORCPT ); Tue, 12 Dec 2023 11:57:07 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53450 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235125AbjLLQ4E (ORCPT ); Tue, 12 Dec 2023 11:56:04 -0500 Received: from wout4-smtp.messagingengine.com (wout4-smtp.messagingengine.com [64.147.123.20]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 102BAE3 for ; Tue, 12 Dec 2023 08:56:09 -0800 (PST) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.west.internal (Postfix) with ESMTP id 8E6D03200A0F; Tue, 12 Dec 2023 11:56:08 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Tue, 12 Dec 2023 11:56:09 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastmail.org; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to; s=fm1; t=1702400168; x= 1702486568; bh=bBi+M/BPgj1IfpVblsWubMsCCFJ3nZ0KD2Xl/FWBwdU=; b=H V7WBwMnopwuBm9xc7Gh7pYQZNTxhCExGNczofrjirbtJxtYvJIzvcVfwh1FJgpfP 3Cv6+VfGLFr6sFQAPHs/8+WVmQN4sxeNh1avmhUW2r79JyWRaCl3Nj9FYFWajBVM x02Lu5zKx1qQARGgwXpOPJycqq2/ooWA03vp3Um8pDvOtjvlRsflX023B7XsjzM9 oNSpTikkpiNHnhRKdr0vIgcUht9sqbcD2J6az0bR+VtCeKjI80a913tBP3qcQRP1 7YY5D4TNWeZWZUbPxOxSJzhC1btvIfCQCQoPQorekrRl61DteuIUYe5abB+jnt0u PGiEOh49ag9zc81tp/uew== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1702400168; x= 1702486568; bh=bBi+M/BPgj1IfpVblsWubMsCCFJ3nZ0KD2Xl/FWBwdU=; b=K ee54Y+wTdDJG4iKIhKIQQMziLaNHRAs/R6WIGldw0AzWF5AO5L9D3dnqCaCatHyP lNiVqP+Bk43z2cxhOaFBAqrdsRtuz+pLJkPbJnJsVMGU9IYisXzpdirvmbqK3L71 n2j/2PF7g6S0XgG5iFap931anu0Q9m7EOOiCoX1t0SG/55hdGHpgIwRFLEYQ/roF Jp5XTZUZoHvmB3GjcwF4o4tWrwcbUDeY9x6/FLy1y1lAw1zOy9nGkVnCcNLqb/Kn kYMj7GX9PVtqY/OThA9kv2rt+xUDHYckTWeKteoEtL6iojs8LpcRIGqxxyKKDSH8 erKT6nIdqD7crUHTeFxbw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrudelgedgledvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefhvfevufffkffojghfggfgsedtke ertdertddtnecuhfhrohhmpefirghrhicutfhoohhkrghrugcuoehgrghrhihrohhokhgr rhgusehfrghsthhmrghilhdrohhrgheqnecuggftrfgrthhtvghrnhepkeeuvdffueduke egieeuffejhefgkeetfeehueelfeduuefgveellefhfefgjedvnecuvehluhhsthgvrhfu ihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepghgrrhihrhhoohhkrghrugesfh grshhtmhgrihhlrdhorhhg X-ME-Proxy: Feedback-ID: ifd194980:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 12 Dec 2023 11:56:07 -0500 (EST) From: Gary Rookard To: gregkh@linuxfoundation.org, philipp.g.hortmann@gmail.com Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Gary Rookard Subject: [PATCH 1/5] staging: rtl8192e: rename variable posHTCap Date: Tue, 12 Dec 2023 11:56:33 -0500 Message-ID: <20231212165637.17618-2-garyrookard@fastmail.org> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20231212165637.17618-1-garyrookard@fastmail.org> References: <20231212165637.17618-1-garyrookard@fastmail.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Coding style issue, checkpatch Avoid CamelCase, rename it. posHTCap -> pos_ht_cap Signed-off-by: Gary Rookard --- drivers/staging/rtl8192e/rtl819x_HTProc.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl819x_HTProc.c b/drivers/staging/rt= l8192e/rtl819x_HTProc.c index 14e25f87c1bf..eb798a3a9052 100644 --- a/drivers/staging/rtl8192e/rtl819x_HTProc.c +++ b/drivers/staging/rtl8192e/rtl819x_HTProc.c @@ -247,27 +247,27 @@ void ht_reset_iot_setting(struct rt_hi_throughput *ht= _info) ht_info->iot_ra_func =3D 0; } =20 -void ht_construct_capability_element(struct rtllib_device *ieee, u8 *posHT= Cap, +void ht_construct_capability_element(struct rtllib_device *ieee, u8 *pos_h= t_cap, u8 *len, u8 IsEncrypt, bool bAssoc) { struct rt_hi_throughput *pHT =3D ieee->ht_info; struct ht_capab_ele *pCapELE =3D NULL; =20 - if (!posHTCap || !pHT) { + if (!pos_ht_cap || !pHT) { netdev_warn(ieee->dev, "%s(): posHTCap and ht_info are null\n", __func__); return; } - memset(posHTCap, 0, *len); + memset(pos_ht_cap, 0, *len); =20 if ((bAssoc) && (pHT->ePeerHTSpecVer =3D=3D HT_SPEC_VER_EWC)) { static const u8 EWC11NHTCap[] =3D { 0x00, 0x90, 0x4c, 0x33 }; =20 - memcpy(posHTCap, EWC11NHTCap, sizeof(EWC11NHTCap)); - pCapELE =3D (struct ht_capab_ele *)&posHTCap[4]; + memcpy(pos_ht_cap, EWC11NHTCap, sizeof(EWC11NHTCap)); + pCapELE =3D (struct ht_capab_ele *)&pos_ht_cap[4]; *len =3D 30 + 2; } else { - pCapELE =3D (struct ht_capab_ele *)posHTCap; + pCapELE =3D (struct ht_capab_ele *)pos_ht_cap; *len =3D 26 + 2; } =20 --=20 2.41.0 From nobody Wed Dec 17 05:47:50 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3CD77C4332F for ; Tue, 12 Dec 2023 16:57:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232674AbjLLQ5J (ORCPT ); Tue, 12 Dec 2023 11:57:09 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53498 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235134AbjLLQ4G (ORCPT ); Tue, 12 Dec 2023 11:56:06 -0500 Received: from wout4-smtp.messagingengine.com (wout4-smtp.messagingengine.com [64.147.123.20]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A284495 for ; Tue, 12 Dec 2023 08:56:12 -0800 (PST) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.west.internal (Postfix) with ESMTP id B94A83200AB1; Tue, 12 Dec 2023 11:56:11 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Tue, 12 Dec 2023 11:56:12 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastmail.org; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to; s=fm1; t=1702400171; x= 1702486571; bh=S72tWKUns9afSXndZ/MSiOmUd5W9n0rvW6OunSV0Fe0=; b=h 7oOO4OTjKB0q9x5ODhbEQ/MfIADXxV6B4fDcZDL4x7rOKVeN/Wvk7HdXjQVs4cU1 ILwDlMt3Otijbuel2LUXMth2JQ9VLz3v2Rmb9o1ZDRnnmZ0b9hDiX1S+SRmdWqu7 LgnbL0ScStYDO+edYlNEhT0qn5M5Pgs31JLuf/K+HAZPwEGsA0B2vh8x7g6JQU9C QmlKKtAFMGuN82mCcGNcA7miWl3wfN0JEzarAm45UEq7UWahsOZE3c0xQ9x1b6Sr +t25EFl9rlGzvpP0tz181bEQOPcQb7mxCq4VgWHyBBhlyRp8AghFe3fku6hAPgIs Kkg12uKjkjEXA3+budEWw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1702400171; x= 1702486571; bh=S72tWKUns9afSXndZ/MSiOmUd5W9n0rvW6OunSV0Fe0=; b=I ZEbm2k7ir7AfFt5SufdrIOIwh8i5X0KoWSWZQ+KfLw5qRBfIXMA5xFYr1ZvwuSEk 4Yz5N+9HEfhyxUBzeDnu2fRxD5VlLynkZRvS/HCSvEwWkitcta2u8pVH0g2516U1 ZcI8P9oMgyl2GAkQR7EjXWBFS32+33euxfwtmwKx1qFCEjpsgDjvV8ipMfHd31F0 YeQJj0IX//QMxRyANwxs13hSWPDMQx+Uhg77gDzLAaWHeOjrEy+1sQ0a1lg6LCb+ 3nLDdSB0d1UR4cbX38PduB4zcgw6SXskCUSsLCC+r6O+n5vTpGKCPslS5jfaSOJ5 C6Jr6xsLJ0to2iP3zrDQw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrudelgedgledvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefhvfevufffkffojghfggfgsedtke ertdertddtnecuhfhrohhmpefirghrhicutfhoohhkrghrugcuoehgrghrhihrohhokhgr rhgusehfrghsthhmrghilhdrohhrgheqnecuggftrfgrthhtvghrnhepkeeuvdffueduke egieeuffejhefgkeetfeehueelfeduuefgveellefhfefgjedvnecuvehluhhsthgvrhfu ihiivgepudenucfrrghrrghmpehmrghilhhfrhhomhepghgrrhihrhhoohhkrghrugesfh grshhtmhgrihhlrdhorhhg X-ME-Proxy: Feedback-ID: ifd194980:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 12 Dec 2023 11:56:10 -0500 (EST) From: Gary Rookard To: gregkh@linuxfoundation.org, philipp.g.hortmann@gmail.com Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Gary Rookard Subject: [PATCH 2/5] staging: rtl8192e: rename variable IsEncrypt Date: Tue, 12 Dec 2023 11:56:34 -0500 Message-ID: <20231212165637.17618-3-garyrookard@fastmail.org> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20231212165637.17618-1-garyrookard@fastmail.org> References: <20231212165637.17618-1-garyrookard@fastmail.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Coding style issue, checkpatch Avoid CamelCase, rename it. IsEncrypt -> is_encrypt Signed-off-by: Gary Rookard --- drivers/staging/rtl8192e/rtl819x_HTProc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl819x_HTProc.c b/drivers/staging/rt= l8192e/rtl819x_HTProc.c index eb798a3a9052..b6e9b7e000ef 100644 --- a/drivers/staging/rtl8192e/rtl819x_HTProc.c +++ b/drivers/staging/rtl8192e/rtl819x_HTProc.c @@ -248,7 +248,7 @@ void ht_reset_iot_setting(struct rt_hi_throughput *ht_i= nfo) } =20 void ht_construct_capability_element(struct rtllib_device *ieee, u8 *pos_h= t_cap, - u8 *len, u8 IsEncrypt, bool bAssoc) + u8 *len, u8 is_encrypt, bool bAssoc) { struct rt_hi_throughput *pHT =3D ieee->ht_info; struct ht_capab_ele *pCapELE =3D NULL; @@ -294,7 +294,7 @@ void ht_construct_capability_element(struct rtllib_devi= ce *ieee, u8 *pos_ht_cap, "TX HT cap/info ele BW=3D%d MaxAMSDUSize:%d DssCCk:%d\n", pCapELE->ChlWidth, pCapELE->MaxAMSDUSize, pCapELE->DssCCk); =20 - if (IsEncrypt) { + if (is_encrypt) { pCapELE->MPDUDensity =3D 7; pCapELE->MaxRxAMPDUFactor =3D 2; } else { --=20 2.41.0 From nobody Wed Dec 17 05:47:50 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B28A9C4167B for ; Tue, 12 Dec 2023 16:56:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1376790AbjLLQ4V (ORCPT ); Tue, 12 Dec 2023 11:56:21 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53500 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1376346AbjLLQ4J (ORCPT ); Tue, 12 Dec 2023 11:56:09 -0500 Received: from wout4-smtp.messagingengine.com (wout4-smtp.messagingengine.com [64.147.123.20]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1290B95 for ; Tue, 12 Dec 2023 08:56:16 -0800 (PST) Received: from compute7.internal (compute7.nyi.internal [10.202.2.48]) by mailout.west.internal (Postfix) with ESMTP id 297343200AB1; Tue, 12 Dec 2023 11:56:15 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute7.internal (MEProxy); Tue, 12 Dec 2023 11:56:15 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastmail.org; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to; s=fm1; t=1702400174; x= 1702486574; bh=2mXfL9IW6ycYX1z5aGtzBPjpQKShBvxr7MP2joA8Ff0=; b=W EAUY6PIAYEdSdAvllHW8+K/osMQbRZQuok6/V6S+hrklACABt7NoqUtW+pJGjTBQ re3gpqb4m7HLdKxotPG+i7O5+pmuTwWPw/sqG8ZLv26vNYTpRHCB83TDKu68xAJD z05eF/RB88oNP4aMrhBHok6PU0vJnuDCFrn97n4SNFNDKfWKJu1sboPPsPRyLGQ6 UnCR//TaYLs5PJNXr2lRO+pqc+LA9PaEOVn+X69m77PcxQH3JXY8XOLyQ17HdVFg qcrNYpL/blCpwOnPrE53LpebyhFnmIr/rgdobop5GP8BWk0q1q1THnZmAe//4mbB qzwFJeUtshcTidmX5ZVzw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1702400174; x= 1702486574; bh=2mXfL9IW6ycYX1z5aGtzBPjpQKShBvxr7MP2joA8Ff0=; b=p 31OgRRR+OqzIINM3SxEDR1iv+MYRU1V5chOhefsJwsyMI8rIxNFVctqHN8zxc+cr R3HIeLPsuQhmA3ArT25oVq57HuI2sZiBILFQQD6UsFD7NZWFyJeu/6QbGLth4RdL RHUaVt763djjm5Sicw50Hxmlv2TlwfEGUfEhYyjV3qfomcrEhmmr83PO41Q3GrRx RYqGwHmOWFKu/KopGCh+PbQEdhcv/pIunFoLroGr6aLELtgBWdKRzxOYSeLv7Vpb /dEyCz14nOCHQPP+PBv9e4MFcEc7ZTRbt9Z7UDyT1/ssxLBuGNCu/m52P2Ens1vU v8qZvTCuBmzF1Focyh5RA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrudelgedgledvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefhvfevufffkffojghfggfgsedtke ertdertddtnecuhfhrohhmpefirghrhicutfhoohhkrghrugcuoehgrghrhihrohhokhgr rhgusehfrghsthhmrghilhdrohhrgheqnecuggftrfgrthhtvghrnhepkeeuvdffueduke egieeuffejhefgkeetfeehueelfeduuefgveellefhfefgjedvnecuvehluhhsthgvrhfu ihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepghgrrhihrhhoohhkrghrugesfh grshhtmhgrihhlrdhorhhg X-ME-Proxy: Feedback-ID: ifd194980:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 12 Dec 2023 11:56:14 -0500 (EST) From: Gary Rookard To: gregkh@linuxfoundation.org, philipp.g.hortmann@gmail.com Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Gary Rookard Subject: [PATCH 3/5] staging: rtl8192e: rename variable bAssoc Date: Tue, 12 Dec 2023 11:56:35 -0500 Message-ID: <20231212165637.17618-4-garyrookard@fastmail.org> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20231212165637.17618-1-garyrookard@fastmail.org> References: <20231212165637.17618-1-garyrookard@fastmail.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Coding style issue, checkpatch Avoid CamelCase, rename it. bAssoc -> assoc Signed-off-by: Gary Rookard --- drivers/staging/rtl8192e/rtl819x_HTProc.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl819x_HTProc.c b/drivers/staging/rt= l8192e/rtl819x_HTProc.c index b6e9b7e000ef..ac85151a6069 100644 --- a/drivers/staging/rtl8192e/rtl819x_HTProc.c +++ b/drivers/staging/rtl8192e/rtl819x_HTProc.c @@ -248,7 +248,7 @@ void ht_reset_iot_setting(struct rt_hi_throughput *ht_i= nfo) } =20 void ht_construct_capability_element(struct rtllib_device *ieee, u8 *pos_h= t_cap, - u8 *len, u8 is_encrypt, bool bAssoc) + u8 *len, u8 is_encrypt, bool assoc) { struct rt_hi_throughput *pHT =3D ieee->ht_info; struct ht_capab_ele *pCapELE =3D NULL; @@ -260,7 +260,7 @@ void ht_construct_capability_element(struct rtllib_devi= ce *ieee, u8 *pos_ht_cap, } memset(pos_ht_cap, 0, *len); =20 - if ((bAssoc) && (pHT->ePeerHTSpecVer =3D=3D HT_SPEC_VER_EWC)) { + if ((assoc) && (pHT->ePeerHTSpecVer =3D=3D HT_SPEC_VER_EWC)) { static const u8 EWC11NHTCap[] =3D { 0x00, 0x90, 0x4c, 0x33 }; =20 memcpy(pos_ht_cap, EWC11NHTCap, sizeof(EWC11NHTCap)); @@ -308,7 +308,7 @@ void ht_construct_capability_element(struct rtllib_devi= ce *ieee, u8 *pos_ht_cap, =20 pCapELE->ASCap =3D 0; =20 - if (bAssoc) { + if (assoc) { if (pHT->iot_action & HT_IOT_ACT_DISABLE_MCS15) pCapELE->MCS[1] &=3D 0x7f; =20 --=20 2.41.0 From nobody Wed Dec 17 05:47:50 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 07352C4167D for ; Tue, 12 Dec 2023 16:57:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232623AbjLLQ5M (ORCPT ); Tue, 12 Dec 2023 11:57:12 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55928 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1376773AbjLLQ4M (ORCPT ); Tue, 12 Dec 2023 11:56:12 -0500 Received: from wout4-smtp.messagingengine.com (wout4-smtp.messagingengine.com [64.147.123.20]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1F81895 for ; Tue, 12 Dec 2023 08:56:19 -0800 (PST) Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailout.west.internal (Postfix) with ESMTP id 3BC913200AB1; Tue, 12 Dec 2023 11:56:18 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute6.internal (MEProxy); Tue, 12 Dec 2023 11:56:18 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastmail.org; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to; s=fm1; t=1702400177; x= 1702486577; bh=/+M9IjnFHxdC7RuAIS3s25vkqInV/9zFKLtDT3kzv/I=; b=b ke5HObmZP9BQYI/hHrINGwDrAF+NarFlwX7RQpZc7Ru7wZX09bhVCJVlJ4STMPg/ gUZ0qyOC5SBZEbZviPmTGu8GjNFZQyegs7IcZ0nrHkLGlIzmmbHBKvgd8jXBRC6t 7l66I6RtmBX3DpdofJqUmHW5zbMCl1U4D7F1gR0CwWAdGQty826c97XOWSiBA7zw +j0z3tvQW8emWlWF0TTsV5sKDI+iiLp2+TrT7Xsd1WLc8gzqXeOfRgUg9amktW3P XAisCXMwGjiH9bCEQKW6R67NZWBhiavo2eTnF8aHxggtpnQBZm9bDCwOF+yI4RFo JMmUP/QYzKVTfel/X74ww== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1702400177; x= 1702486577; bh=/+M9IjnFHxdC7RuAIS3s25vkqInV/9zFKLtDT3kzv/I=; b=G OOIDE1MnLrFSx5wStnhMYJh+DKiya9bjvuP+qRev9D7K71WwITEcywYyGOrQ3RdB B1TrYwDBTuzitvCRaQHu/cjskZPolyj1TxiwpYkxtox9k5+8kRdGtqBpqQ18hl7u Dv5wAKzexjsKglVtuZ4S5oWBMt2mDV002M9HMj5SjwztjBG9Y410ZocTox2+8Esl R6TOFtFs/YZ6G/tjCsAqJpVTZU6VoZe0OEfYcSpcVdtKFN5r9m2/Dyx1nS5sNnmI puWHIbvxGI1Ki2Wm4iAvOucSTnPQ5MujG8McWnhoHg1SxFPKIjHDsR9Z7N+n9lZV FlkqOOUYW+63oE2GMTThw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrudelgedgledvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefhvfevufffkffojghfggfgsedtke ertdertddtnecuhfhrohhmpefirghrhicutfhoohhkrghrugcuoehgrghrhihrohhokhgr rhgusehfrghsthhmrghilhdrohhrgheqnecuggftrfgrthhtvghrnhepkeeuvdffueduke egieeuffejhefgkeetfeehueelfeduuefgveellefhfefgjedvnecuvehluhhsthgvrhfu ihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepghgrrhihrhhoohhkrghrugesfh grshhtmhgrihhlrdhorhhg X-ME-Proxy: Feedback-ID: ifd194980:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 12 Dec 2023 11:56:17 -0500 (EST) From: Gary Rookard To: gregkh@linuxfoundation.org, philipp.g.hortmann@gmail.com Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Gary Rookard Subject: [PATCH 4/5] staging: rtl8192e: rename variable pHT Date: Tue, 12 Dec 2023 11:56:36 -0500 Message-ID: <20231212165637.17618-5-garyrookard@fastmail.org> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20231212165637.17618-1-garyrookard@fastmail.org> References: <20231212165637.17618-1-garyrookard@fastmail.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Coding style issue, Avoid CamelCase rename it. pHT -> ht Signed-off-by: Gary Rookard --- drivers/staging/rtl8192e/rtl819x_HTProc.c | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl819x_HTProc.c b/drivers/staging/rt= l8192e/rtl819x_HTProc.c index ac85151a6069..add8f58b5b1e 100644 --- a/drivers/staging/rtl8192e/rtl819x_HTProc.c +++ b/drivers/staging/rtl8192e/rtl819x_HTProc.c @@ -250,17 +250,17 @@ void ht_reset_iot_setting(struct rt_hi_throughput *ht= _info) void ht_construct_capability_element(struct rtllib_device *ieee, u8 *pos_h= t_cap, u8 *len, u8 is_encrypt, bool assoc) { - struct rt_hi_throughput *pHT =3D ieee->ht_info; + struct rt_hi_throughput *ht =3D ieee->ht_info; struct ht_capab_ele *pCapELE =3D NULL; =20 - if (!pos_ht_cap || !pHT) { + if (!pos_ht_cap || !ht) { netdev_warn(ieee->dev, "%s(): posHTCap and ht_info are null\n", __func__); return; } memset(pos_ht_cap, 0, *len); =20 - if ((assoc) && (pHT->ePeerHTSpecVer =3D=3D HT_SPEC_VER_EWC)) { + if ((assoc) && (ht->ePeerHTSpecVer =3D=3D HT_SPEC_VER_EWC)) { static const u8 EWC11NHTCap[] =3D { 0x00, 0x90, 0x4c, 0x33 }; =20 memcpy(pos_ht_cap, EWC11NHTCap, sizeof(EWC11NHTCap)); @@ -275,9 +275,9 @@ void ht_construct_capability_element(struct rtllib_devi= ce *ieee, u8 *pos_ht_cap, if (ieee->GetHalfNmodeSupportByAPsHandler(ieee->dev)) pCapELE->ChlWidth =3D 0; else - pCapELE->ChlWidth =3D (pHT->reg_bw_40mhz ? 1 : 0); + pCapELE->ChlWidth =3D (ht->reg_bw_40mhz ? 1 : 0); =20 - pCapELE->MimoPwrSave =3D pHT->self_mimo_ps; + pCapELE->MimoPwrSave =3D ht->self_mimo_ps; pCapELE->GreenField =3D 0; pCapELE->ShortGI20Mhz =3D 1; pCapELE->ShortGI40Mhz =3D 1; @@ -286,7 +286,7 @@ void ht_construct_capability_element(struct rtllib_devi= ce *ieee, u8 *pos_ht_cap, pCapELE->RxSTBC =3D 0; pCapELE->DelayBA =3D 0; pCapELE->MaxAMSDUSize =3D (MAX_RECEIVE_BUFFER_SIZE >=3D 7935) ? 1 : 0; - pCapELE->DssCCk =3D ((pHT->reg_bw_40mhz) ? (pHT->reg_supp_cck ? 1 : 0) : = 0); + pCapELE->DssCCk =3D ((ht->reg_bw_40mhz) ? (ht->reg_supp_cck ? 1 : 0) : 0); pCapELE->PSMP =3D 0; pCapELE->LSigTxopProtect =3D 0; =20 @@ -309,16 +309,16 @@ void ht_construct_capability_element(struct rtllib_de= vice *ieee, u8 *pos_ht_cap, pCapELE->ASCap =3D 0; =20 if (assoc) { - if (pHT->iot_action & HT_IOT_ACT_DISABLE_MCS15) + if (ht->iot_action & HT_IOT_ACT_DISABLE_MCS15) pCapELE->MCS[1] &=3D 0x7f; =20 - if (pHT->iot_action & HT_IOT_ACT_DISABLE_MCS14) + if (ht->iot_action & HT_IOT_ACT_DISABLE_MCS14) pCapELE->MCS[1] &=3D 0xbf; =20 - if (pHT->iot_action & HT_IOT_ACT_DISABLE_ALL_2SS) + if (ht->iot_action & HT_IOT_ACT_DISABLE_ALL_2SS) pCapELE->MCS[1] &=3D 0x00; =20 - if (pHT->iot_action & HT_IOT_ACT_DISABLE_RX_40MHZ_SHORT_GI) + if (ht->iot_action & HT_IOT_ACT_DISABLE_RX_40MHZ_SHORT_GI) pCapELE->ShortGI40Mhz =3D 0; =20 if (ieee->GetHalfNmodeSupportByAPsHandler(ieee->dev)) { --=20 2.41.0 From nobody Wed Dec 17 05:47:50 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 99B6AC4332F for ; Tue, 12 Dec 2023 16:57:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230382AbjLLQ5P (ORCPT ); Tue, 12 Dec 2023 11:57:15 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55946 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235152AbjLLQ4Q (ORCPT ); Tue, 12 Dec 2023 11:56:16 -0500 Received: from wout4-smtp.messagingengine.com (wout4-smtp.messagingengine.com [64.147.123.20]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 56A57B7 for ; Tue, 12 Dec 2023 08:56:22 -0800 (PST) Received: from compute7.internal (compute7.nyi.internal [10.202.2.48]) by mailout.west.internal (Postfix) with ESMTP id 6FADE3200AB1; Tue, 12 Dec 2023 11:56:21 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute7.internal (MEProxy); Tue, 12 Dec 2023 11:56:21 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastmail.org; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to; s=fm1; t=1702400180; x= 1702486580; bh=Fb0pDO1f0yINjQLVIJ/Z6Zltm4xMmfYmovEsSAll8kg=; b=g 6gsWYvTMi6DJhpHpSIEWcHceSQI6os0nVX8dcEepSe6Y4Lj258hYu0P8oYR0lEKs Gv/AmldnUTQWb3l4eaug1N4/+yT800A9ZbS8PnXCjYcQWo2B+cSKtBvlt+g7kz+S Ll5vR33n81EC/4+qQFq8aMp5ucgItf+BBEWRgfUUjGLy5sd1YvyYZ1xovN/1In0n CyGZRS/0+NXVK5Yo3t2iOp+fgq61dg02AqSY01awMQ9caqW35BJifQfppKYRB4YI qNKC9QqaXkwYLM05UXNcQm2m/yMXWWZ2kcLsUBL1g4ZRYfAtlZRK+n0xWUFFGpc0 NQ3C+jlU6Ng72tILlgm1A== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1702400180; x= 1702486580; bh=Fb0pDO1f0yINjQLVIJ/Z6Zltm4xMmfYmovEsSAll8kg=; b=T +HuUGq//k5tMytBxtuvF5POQDfUFv5wQUd+s7eye8tthOldTjQ0DPHWGlFl2+hSw OODdwKUpJj3IKmc91VyQLke1BJZtzL5PGBnhZgWnBgwWwdaoKFUr/hqzczgrvszn LwipiJVKoS2qJtr/Mriaj9zl2IhCtHSgjA6Bu0D7AUKlFyUdBAW79z19zMzYEAcr WOR6NnI0E+lApEv8z8TGHPUC61PHOMbBHTuIpjYeETU6JsvlNMZEi5rsSiGNo29I NnEuzJ1i4qf4R3sKRha80rW7sGWr9vEtw5K2OmB5tvJ0dh3eiOlw/Y2XMSXXZVvU 8hsiPY1QPl0UNzRnoekHg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrudelgedgledvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefhvfevufffkffojghfggfgsedtke ertdertddtnecuhfhrohhmpefirghrhicutfhoohhkrghrugcuoehgrghrhihrohhokhgr rhgusehfrghsthhmrghilhdrohhrgheqnecuggftrfgrthhtvghrnhepkeeuvdffueduke egieeuffejhefgkeetfeehueelfeduuefgveellefhfefgjedvnecuvehluhhsthgvrhfu ihiivgepudenucfrrghrrghmpehmrghilhhfrhhomhepghgrrhihrhhoohhkrghrugesfh grshhtmhgrihhlrdhorhhg X-ME-Proxy: Feedback-ID: ifd194980:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 12 Dec 2023 11:56:20 -0500 (EST) From: Gary Rookard To: gregkh@linuxfoundation.org, philipp.g.hortmann@gmail.com Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Gary Rookard Subject: [PATCH 5/5] staging: rtl8192e: rename variable pCapELE Date: Tue, 12 Dec 2023 11:56:37 -0500 Message-ID: <20231212165637.17618-6-garyrookard@fastmail.org> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20231212165637.17618-1-garyrookard@fastmail.org> References: <20231212165637.17618-1-garyrookard@fastmail.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Coding style issue, checkpatch Avoid CamelCase, rename it. pCapELE -> cap_ele Signed-off-by: Gary Rookard --- drivers/staging/rtl8192e/rtl819x_HTProc.c | 64 +++++++++++------------ 1 file changed, 32 insertions(+), 32 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl819x_HTProc.c b/drivers/staging/rt= l8192e/rtl819x_HTProc.c index add8f58b5b1e..25097f1935a5 100644 --- a/drivers/staging/rtl8192e/rtl819x_HTProc.c +++ b/drivers/staging/rtl8192e/rtl819x_HTProc.c @@ -251,7 +251,7 @@ void ht_construct_capability_element(struct rtllib_devi= ce *ieee, u8 *pos_ht_cap, u8 *len, u8 is_encrypt, bool assoc) { struct rt_hi_throughput *ht =3D ieee->ht_info; - struct ht_capab_ele *pCapELE =3D NULL; + struct ht_capab_ele *cap_ele =3D NULL; =20 if (!pos_ht_cap || !ht) { netdev_warn(ieee->dev, @@ -264,66 +264,66 @@ void ht_construct_capability_element(struct rtllib_de= vice *ieee, u8 *pos_ht_cap, static const u8 EWC11NHTCap[] =3D { 0x00, 0x90, 0x4c, 0x33 }; =20 memcpy(pos_ht_cap, EWC11NHTCap, sizeof(EWC11NHTCap)); - pCapELE =3D (struct ht_capab_ele *)&pos_ht_cap[4]; + cap_ele =3D (struct ht_capab_ele *)&pos_ht_cap[4]; *len =3D 30 + 2; } else { - pCapELE =3D (struct ht_capab_ele *)pos_ht_cap; + cap_ele =3D (struct ht_capab_ele *)pos_ht_cap; *len =3D 26 + 2; } =20 - pCapELE->AdvCoding =3D 0; + cap_ele->AdvCoding =3D 0; if (ieee->GetHalfNmodeSupportByAPsHandler(ieee->dev)) - pCapELE->ChlWidth =3D 0; + cap_ele->ChlWidth =3D 0; else - pCapELE->ChlWidth =3D (ht->reg_bw_40mhz ? 1 : 0); + cap_ele->ChlWidth =3D (ht->reg_bw_40mhz ? 1 : 0); =20 - pCapELE->MimoPwrSave =3D ht->self_mimo_ps; - pCapELE->GreenField =3D 0; - pCapELE->ShortGI20Mhz =3D 1; - pCapELE->ShortGI40Mhz =3D 1; + cap_ele->MimoPwrSave =3D ht->self_mimo_ps; + cap_ele->GreenField =3D 0; + cap_ele->ShortGI20Mhz =3D 1; + cap_ele->ShortGI40Mhz =3D 1; =20 - pCapELE->TxSTBC =3D 1; - pCapELE->RxSTBC =3D 0; - pCapELE->DelayBA =3D 0; - pCapELE->MaxAMSDUSize =3D (MAX_RECEIVE_BUFFER_SIZE >=3D 7935) ? 1 : 0; - pCapELE->DssCCk =3D ((ht->reg_bw_40mhz) ? (ht->reg_supp_cck ? 1 : 0) : 0); - pCapELE->PSMP =3D 0; - pCapELE->LSigTxopProtect =3D 0; + cap_ele->TxSTBC =3D 1; + cap_ele->RxSTBC =3D 0; + cap_ele->DelayBA =3D 0; + cap_ele->MaxAMSDUSize =3D (MAX_RECEIVE_BUFFER_SIZE >=3D 7935) ? 1 : 0; + cap_ele->DssCCk =3D ((ht->reg_bw_40mhz) ? (ht->reg_supp_cck ? 1 : 0) : 0); + cap_ele->PSMP =3D 0; + cap_ele->LSigTxopProtect =3D 0; =20 netdev_dbg(ieee->dev, "TX HT cap/info ele BW=3D%d MaxAMSDUSize:%d DssCCk:%d\n", - pCapELE->ChlWidth, pCapELE->MaxAMSDUSize, pCapELE->DssCCk); + cap_ele->ChlWidth, cap_ele->MaxAMSDUSize, cap_ele->DssCCk); =20 if (is_encrypt) { - pCapELE->MPDUDensity =3D 7; - pCapELE->MaxRxAMPDUFactor =3D 2; + cap_ele->MPDUDensity =3D 7; + cap_ele->MaxRxAMPDUFactor =3D 2; } else { - pCapELE->MaxRxAMPDUFactor =3D 3; - pCapELE->MPDUDensity =3D 0; + cap_ele->MaxRxAMPDUFactor =3D 3; + cap_ele->MPDUDensity =3D 0; } =20 - memcpy(pCapELE->MCS, ieee->reg_dot11ht_oper_rate_set, 16); - memset(&pCapELE->ExtHTCapInfo, 0, 2); - memset(pCapELE->TxBFCap, 0, 4); + memcpy(cap_ele->MCS, ieee->reg_dot11ht_oper_rate_set, 16); + memset(&cap_ele->ExtHTCapInfo, 0, 2); + memset(cap_ele->TxBFCap, 0, 4); =20 - pCapELE->ASCap =3D 0; + cap_ele->ASCap =3D 0; =20 if (assoc) { if (ht->iot_action & HT_IOT_ACT_DISABLE_MCS15) - pCapELE->MCS[1] &=3D 0x7f; + cap_ele->MCS[1] &=3D 0x7f; =20 if (ht->iot_action & HT_IOT_ACT_DISABLE_MCS14) - pCapELE->MCS[1] &=3D 0xbf; + cap_ele->MCS[1] &=3D 0xbf; =20 if (ht->iot_action & HT_IOT_ACT_DISABLE_ALL_2SS) - pCapELE->MCS[1] &=3D 0x00; + cap_ele->MCS[1] &=3D 0x00; =20 if (ht->iot_action & HT_IOT_ACT_DISABLE_RX_40MHZ_SHORT_GI) - pCapELE->ShortGI40Mhz =3D 0; + cap_ele->ShortGI40Mhz =3D 0; =20 if (ieee->GetHalfNmodeSupportByAPsHandler(ieee->dev)) { - pCapELE->ChlWidth =3D 0; - pCapELE->MCS[1] =3D 0; + cap_ele->ChlWidth =3D 0; + cap_ele->MCS[1] =3D 0; } } } --=20 2.41.0