From nobody Wed Dec 17 08:36:33 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4D454C4167D for ; Tue, 12 Dec 2023 02:29:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345876AbjLLC3F (ORCPT ); Mon, 11 Dec 2023 21:29:05 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52324 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345765AbjLLC2i (ORCPT ); Mon, 11 Dec 2023 21:28:38 -0500 Received: from mail-yw1-x1133.google.com (mail-yw1-x1133.google.com [IPv6:2607:f8b0:4864:20::1133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 19DED121; Mon, 11 Dec 2023 18:28:28 -0800 (PST) Received: by mail-yw1-x1133.google.com with SMTP id 00721157ae682-5cd81e76164so50640367b3.1; Mon, 11 Dec 2023 18:28:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1702348106; x=1702952906; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=zknDDZPXO65EcmEriKlJmzs+43jcHB+zHIGvKah0pAA=; b=MqZdTTGjFZImNNR1KKtfga7ueam8z+QBLZXTmo2Xj+fGrcqxj72+38fbtfBUNU5czT NqewUCMbBAZE7hIOPp7ALiXUqSkD/ZQinVMgfzDwbazlI43IolsmWYPLcx+/DdDTkl4r 8jR+9IFHSEPqzfzFDKLDL3zkDPZgSHf9qHtck5i/yxlhlwBNbRCgVH0bqBCKBjt/bTs4 mJGCtgJmHK5aRX0Nr8jcsDv97Xd+iIOuAoMqOM6n9GpQRCT9zJt1xWdiUVhJ+ysIRxGk qoTsbngKxOzDoJvWZhVdAoDaASRVf3Dihvtb1jwzrm0tzHkymP9clxRlQvRd8FVXMQLY uANg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702348106; x=1702952906; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=zknDDZPXO65EcmEriKlJmzs+43jcHB+zHIGvKah0pAA=; b=oTrs9fEZJekGDyDiKMAqPo7jyajPaxEX2WB/PASAtLXbcdbEIOmXN4dony0U9OEHW4 pavDyt46i7Oak0J8gzVMzznZKcWGiGVxMYwnBjEfWRYBwgDBmOHTYeu7a+TaH/WxWUO7 BglUVUtFAe6eAjI6PqI4csFhJaBOo8fNSDgJMPC7IpeYBIk6CHT9o6XIW2mlJZoz3j2K 1gC7GF8+H6Vs1OjNlPzmXDXLmqutauttr0Rs2AV3zmsT0017i/nT1t8Cp6noB6ZsffGn YU38LDdWeqpL6RaXYdvnOZ81GnI80oCN2gBYsv1cNTquSx6zYNIv2GvwUWVyct6r1glC Kkdg== X-Gm-Message-State: AOJu0Yz21n6DVKYUiSEh6IPJvdMqIOt9JFUkbepCgv9stnBM80/MeUgj oZLSIRrkFYkXQ08v2wN9l8L7B9fHg+0xlg== X-Google-Smtp-Source: AGHT+IENraHLfovA+ykpOElraTDmayTCsHv+8QALmyHtH/RgQ3A/AT8Qghg9+bwu9tGKb6rIfikViw== X-Received: by 2002:a0d:c343:0:b0:5d7:1940:dd85 with SMTP id f64-20020a0dc343000000b005d71940dd85mr4712425ywd.91.1702348106198; Mon, 11 Dec 2023 18:28:26 -0800 (PST) Received: from localhost ([2601:344:8301:57f0:38aa:1c88:df05:9b73]) by smtp.gmail.com with ESMTPSA id t186-20020a0deac3000000b005ce039bf1ecsm3439166ywe.7.2023.12.11.18.28.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 Dec 2023 18:28:25 -0800 (PST) From: Yury Norov To: linux-kernel@vger.kernel.org, Greg Kroah-Hartman , Jiri Slaby , linux-serial@vger.kernel.org Cc: Yury Norov , Jan Kara , Mirsad Todorovac , Matthew Wilcox , Rasmus Villemoes , Andy Shevchenko , Maxim Kuvyrkov , Alexey Klimov , Bart Van Assche , Sergey Shtylyov Subject: [PATCH v3 22/35] tty: nozomi: optimize interrupt_handler() Date: Mon, 11 Dec 2023 18:27:36 -0800 Message-Id: <20231212022749.625238-23-yury.norov@gmail.com> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20231212022749.625238-1-yury.norov@gmail.com> References: <20231212022749.625238-1-yury.norov@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" In the exit path of interrupt_handler(), dc->flip map is traversed bit by bit to find and clear set bits and call tty_flip_buffer_push() for corresponding ports. Simplify it by using for_each_test_and_clear_bit(), as it skips already clear bits. Signed-off-by: Yury Norov --- drivers/tty/nozomi.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/tty/nozomi.c b/drivers/tty/nozomi.c index 02cd40147b3a..de0503247391 100644 --- a/drivers/tty/nozomi.c +++ b/drivers/tty/nozomi.c @@ -1220,9 +1220,8 @@ static irqreturn_t interrupt_handler(int irq, void *d= ev_id) exit_handler: spin_unlock(&dc->spin_mutex); =20 - for (a =3D 0; a < NOZOMI_MAX_PORTS; a++) - if (test_and_clear_bit(a, &dc->flip)) - tty_flip_buffer_push(&dc->port[a].port); + for_each_test_and_clear_bit(a, &dc->flip, NOZOMI_MAX_PORTS) + tty_flip_buffer_push(&dc->port[a].port); =20 return IRQ_HANDLED; none: --=20 2.40.1