From nobody Fri Dec 19 11:32:31 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2A7F8C10F07 for ; Sat, 9 Dec 2023 12:59:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230168AbjLIM7S (ORCPT ); Sat, 9 Dec 2023 07:59:18 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47246 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229538AbjLIM7P (ORCPT ); Sat, 9 Dec 2023 07:59:15 -0500 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04on2043.outbound.protection.outlook.com [40.107.7.43]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E87F010D8; Sat, 9 Dec 2023 04:59:21 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=j3nuZnDB1sbK/8slOWy24jbK1DynajwdiRaYGh1gzS/DRBJn1xTJs5yteHRfhMnN0O4qVBcJ+9Do9g6dcOMWnO5MXZTEJSn1xOZMRHtaPi3hxEZ7GfMb2dNFg8KAFk6OV0REAJI0bRM+Zlkz+0W02Pb3i8qAGDAq97a0dXU/ZZKi5IVpxBkdJcXIQWf8DDDJEYGpGe6xGxq5C8wI4DqQfwI1L/PDbA1gZsN4kLJ+o/k5WOZkqNwmJBF9vT3lvuhdFetJ3BXfoq8LbQOVJv53Vx6asdbWdYOZF7ZbltSPrpCzwugd2ZJIM8Bd+6IqZqaBE7eb2zssEoTMzDqlJZS4Kw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ui9KCTXid1xQ6I8QFDMz29kSlbNm7B3mfuhdJjPmypQ=; b=a1KpvBvo7wiqdirTWw3HoSCuFvEz+WFIQjDj3adVjGHFA5xXb3hrxZ8o6KQdweABRGTGL7u50GahQtBEz9RIuGeZsfmgiCN115I8iGbqitcnfI0qq6rJY8Yk2qOYSs1xdwAi9Rb2POTEQ6B8us1UQcBKxOPoWF3UEa6g1E0Un2Vwnch+y1Lt/wV76B/iwhjdArlRb6WNnXEU+jRkFdHQweK/3Ngi9yrymWk1tux6BJzmFoQ6iRVrkGN2hGjsQmPav0xBFMMcuc1saxET71fVW1yaim43zCipyW4rGotoal2xHwjEf+K32WqXQz1wtpaghXRHf9wOOXZzxcr1zBqsMQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=kunbus.com; dmarc=pass action=none header.from=kunbus.com; dkim=pass header.d=kunbus.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kunbus.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ui9KCTXid1xQ6I8QFDMz29kSlbNm7B3mfuhdJjPmypQ=; b=MfhZWO3FWbkxNtBrKbntGgThLZLgvtlBdJ3LsmIZgksnj0r3GG/s76PlMLB5eukAkAn2dyQ62qKGBWR+RvScdI3DQbqgOztYTAyOj6I1QRcoBEXhkDc43LfY159pUlSfxuVGR1ZXo7th/xM72DZBDB0CVNjQ/q4pKBFHIlyRmU4= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=kunbus.com; Received: from VI1P193MB0413.EURP193.PROD.OUTLOOK.COM (2603:10a6:803:4e::14) by PR3P193MB0555.EURP193.PROD.OUTLOOK.COM (2603:10a6:102:31::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7068.29; Sat, 9 Dec 2023 12:59:17 +0000 Received: from VI1P193MB0413.EURP193.PROD.OUTLOOK.COM ([fe80::653f:d0f3:e7f6:8c06]) by VI1P193MB0413.EURP193.PROD.OUTLOOK.COM ([fe80::653f:d0f3:e7f6:8c06%5]) with mapi id 15.20.7068.029; Sat, 9 Dec 2023 12:59:17 +0000 From: Lino Sanfilippo To: gregkh@linuxfoundation.org, jirislaby@kernel.org, ilpo.jarvinen@linux.intel.com Cc: u.kleine-koenig@pengutronix.de, shawnguo@kernel.org, s.hauer@pengutronix.de, mcoquelin.stm32@gmail.com, alexandre.torgue@foss.st.com, cniedermaier@dh-electronics.com, hugo@hugovil.com, linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, LinoSanfilippo@gmx.de, lukas@wunner.de, p.rosenberger@kunbus.com, Lino Sanfilippo , stable@vger.kernel.org Subject: [PATCH v5 1/7] serial: Do not hold the port lock when setting rx-during-tx GPIO Date: Sat, 9 Dec 2023 13:58:30 +0100 Message-ID: <20231209125836.16294-2-l.sanfilippo@kunbus.com> X-Mailer: git-send-email 2.42.0 In-Reply-To: <20231209125836.16294-1-l.sanfilippo@kunbus.com> References: <20231209125836.16294-1-l.sanfilippo@kunbus.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: FR3P281CA0070.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:4b::22) To VI1P193MB0413.EURP193.PROD.OUTLOOK.COM (2603:10a6:803:4e::14) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VI1P193MB0413:EE_|PR3P193MB0555:EE_ X-MS-Office365-Filtering-Correlation-Id: f07165ad-c521-41c0-72c8-08dbf8b6a69e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Fy7yyyM2iBJ81/YY1YEVoIB6yAqEAXTHB9SqJiN+zWrOmlRYTjsKGCDIMnTO7qlwNbngoeHUggAI7WrdFM9sJsyrw+EzZkDdcHsyuLZjniR5aekdCdVw+/osoCALTRBq+7I4sF7MKYE48hEIQL80BUFiNqNtyomAmqwUKq6m3LfUay8Dwe6GkP823kJuFNK67MpVrrwjQfmhzzhS6mbNpThvDvFFE9aVm2CKqiuY6UhWlEM05iUSbcg84GCn7XcG72awYZpwu7rfZLvqUXj9N+4Z7T9zt1PrIzZfA7KDPywUjY3p3QcsiXu2nlFxvgGGA0KdWKffGf084qpwRiGvUoDJxBMJw2NmOrr8celxwJvcmIB5CpgdplCJRP9IavcElkb2CtVcukQvhv9K2w6i4IPpzu4kBEnGtIO7EnDcYkc4aemJkuvX2VXelw6cM0fFjmD49KaOqYERtU/NCWphvvQIVPRcXrj1hyYWmahdb3Ay79KrV/fZ4WtzrxJdQOf1voEakuVZVcSI+kt9dInHesS8esTtf8tdqV/7cG+tqidAY764K35iGmiDcN4aLd0A X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1P193MB0413.EURP193.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230031)(39830400003)(366004)(376002)(396003)(346002)(136003)(230922051799003)(186009)(1800799012)(64100799003)(451199024)(2616005)(1076003)(478600001)(6506007)(6666004)(52116002)(6512007)(41300700001)(83380400001)(5660300002)(2906002)(4326008)(8676002)(8936002)(7416002)(6486002)(66946007)(316002)(66476007)(66556008)(38100700002)(86362001)(36756003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?QC3nGixn46mXECUwVXiCF0FJUfsIYc7NyQL4CvxsYwaa44V+ptxqWe4zTyTO?= =?us-ascii?Q?Ia86Tq0svO9IEelF2GHMjagNHafr+Hav9hC5b9YPcx9W2KVgyJ6BjDitna1+?= =?us-ascii?Q?zaN3WG3RtkerA3IG5fVxHl42V/By7C7bUDFNfWTRapmxxeweDai0nzu0/hMq?= =?us-ascii?Q?K6O8SPQDZMZVrWWPkjLx+jgpBAwaomDM4Cca62j872xt8B9tPfLB/GRmgHVN?= =?us-ascii?Q?I1z9KtJLccDQYvG7gWlTVNAZ9WKRQ7OoTWJ/TGFooM5GmurbFmYBiARE6OJI?= =?us-ascii?Q?jr0Dq00IaFr4ELy51oaL9b1Fm83NekBwn3hgNGRxVk5xy8zKT3cErAyjOyFU?= =?us-ascii?Q?K91JOiUFalFJ7gu0Pi7hvV8jZTeADtuNGvL8vMBPVPeyJHKCKocZBJRVxLyl?= =?us-ascii?Q?i8d5fee+1aXGwSlY4IiEB/JfkPD9/ghKybSWTmKubOM5cjk2qQAYMSZddVUx?= =?us-ascii?Q?CaqFwy2p5mcI6oOVnd+N7akAYub8XUTadsx/+mPxlaV1S3Li7HuHtxChR4OZ?= =?us-ascii?Q?bDIEBICWQav+1eWO90QLPMMoh+XTHupCvsBZYRM6VLffI73A5/PdtLtvnCqA?= =?us-ascii?Q?Uh6S3Wd/8XXunA8si2/LPEE1kiKLtL20rhwU2mK7TvQUrwXPoqC5dkHLeTtI?= =?us-ascii?Q?q9IQTOITZsdbqxz4E6CYbSkaXMrOguMiXCtF/MtWlQ1Gb2cdH2YI2Zo3zO+4?= =?us-ascii?Q?voYgGjMv+To7daQgRhtlrSGfDSAqd3OTgLnsvW0eTO7yuYtEIGJFsbLd3LhF?= =?us-ascii?Q?WtANL2ymdIF1jwCulcovEM2pT0eD498Z4lIFFzVtyM9rzP6Wjnc7N58q52fb?= =?us-ascii?Q?CL7ydFz6c2tpcdeLZcWzRurpxOnfKNXg0nJ7+0z7RuoyHXG3XzfWIwdL5Stz?= =?us-ascii?Q?86VxoRiF/hZ9tKD6i2dBXxmgdK5h1aS7G+dAYcx6CA7jQs7IuGjab5s1CzT3?= =?us-ascii?Q?hsw/Be8A937lkOAxkjzF4iGfWA83K0aWaVbueYEdq08a7v++o5AJV0HP4xow?= =?us-ascii?Q?FgPJVJE4IP1r6itLlXnZOb279KApv2rw+LXkOOADbg6zFMp3iX5H0WHhd+0V?= =?us-ascii?Q?oo9aa6TBtI2vtSduvR/xiqnxjV/sdMS515RQtPgxWSoY+5miZ7NLGrAagELl?= =?us-ascii?Q?2qo56rEB7zcCoDGtgXA7dHLgtDZrjWOS1HGzy5i4HCMxMeiQHrqzf6yIe9p4?= =?us-ascii?Q?vyDVrFCo1G2xzNKxvnqvB//yyque2kfCSjRhOiBN2SEN1uTKjyV1n+oXS1/k?= =?us-ascii?Q?UEEbr5NbdTNdJNRj4slR1IQuFFHS9O44+LZ+7tpvjWkYYzm+KYlMM+cMmhOG?= =?us-ascii?Q?wgtAR1Wx50vZEBAuFRUkF98df7zMHPmyp7eR++e2fHPRIOK92+RRz4JKF0q9?= =?us-ascii?Q?UICm3Vv91P+AoC5NZYQc2ZuOAu9ctaQwaFKNqA3a9GlrOD7tmqw5yRWtIclK?= =?us-ascii?Q?UQxGtD+TjCAayfs62RFNrh2g8TVquX+LloMYmUDUzJTF74tVDucnAPHOFuGY?= =?us-ascii?Q?03s0jnH32mIT9BIww1RXEUD+pC2/oKhwZA6p9Jt4jCjjv/tDN6zfX5pHOLKp?= =?us-ascii?Q?yRkXAWpT8uBLhwNRnOI/0BgElmuTv18lNwYOWoXSOUPTtw8AiK22hV6kR5xf?= =?us-ascii?Q?7WsNRQFw7R92Kb9Zie7Vzyl2VCNVdiaE6fEPpv34n84n?= X-OriginatorOrg: kunbus.com X-MS-Exchange-CrossTenant-Network-Message-Id: f07165ad-c521-41c0-72c8-08dbf8b6a69e X-MS-Exchange-CrossTenant-AuthSource: VI1P193MB0413.EURP193.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Dec 2023 12:59:16.7942 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: aaa4d814-e659-4b0a-9698-1c671f11520b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: /J16/FjfSkP2LSYuYnSYrW1IIbPsaqP9Qp1Bvv6OOpx2m9OTxJKUB+Gf5t2L/K/qMdyZo7SREo09Lw2wbU0K4g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3P193MB0555 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Both the imx and stm32 driver set the rx-during-tx GPIO in rs485_config(). Since this function is called with the port lock held, this can be an problem in case that setting the GPIO line can sleep (e.g. if a GPIO expander is used which is connected via SPI or I2C). Avoid this issue by moving the GPIO setting outside of the port lock into the serial core and thus making it a generic feature. Fixes: c54d48543689 ("serial: stm32: Add support for rs485 RX_DURING_TX out= put GPIO") Fixes: ca530cfa968c ("serial: imx: Add support for RS485 RX_DURING_TX outpu= t GPIO") Cc: Shawn Guo Cc: Sascha Hauer Cc: stable@vger.kernel.org Signed-off-by: Lino Sanfilippo Reviewed-by: Hugo Villeneuve Reviewed-by: Ilpo J=C3=A4rvinen --- drivers/tty/serial/imx.c | 4 ---- drivers/tty/serial/serial_core.c | 12 ++++++++++++ drivers/tty/serial/stm32-usart.c | 5 +---- 3 files changed, 13 insertions(+), 8 deletions(-) diff --git a/drivers/tty/serial/imx.c b/drivers/tty/serial/imx.c index 708b9852a575..9cffeb23112b 100644 --- a/drivers/tty/serial/imx.c +++ b/drivers/tty/serial/imx.c @@ -1943,10 +1943,6 @@ static int imx_uart_rs485_config(struct uart_port *p= ort, struct ktermios *termio rs485conf->flags & SER_RS485_RX_DURING_TX) imx_uart_start_rx(port); =20 - if (port->rs485_rx_during_tx_gpio) - gpiod_set_value_cansleep(port->rs485_rx_during_tx_gpio, - !!(rs485conf->flags & SER_RS485_RX_DURING_TX)); - return 0; } =20 diff --git a/drivers/tty/serial/serial_core.c b/drivers/tty/serial/serial_c= ore.c index f1348a509552..a0290a5fe8b3 100644 --- a/drivers/tty/serial/serial_core.c +++ b/drivers/tty/serial/serial_core.c @@ -1402,6 +1402,16 @@ static void uart_set_rs485_termination(struct uart_p= ort *port, !!(rs485->flags & SER_RS485_TERMINATE_BUS)); } =20 +static void uart_set_rs485_rx_during_tx(struct uart_port *port, + const struct serial_rs485 *rs485) +{ + if (!(rs485->flags & SER_RS485_ENABLED)) + return; + + gpiod_set_value_cansleep(port->rs485_rx_during_tx_gpio, + !!(rs485->flags & SER_RS485_RX_DURING_TX)); +} + static int uart_rs485_config(struct uart_port *port) { struct serial_rs485 *rs485 =3D &port->rs485; @@ -1413,6 +1423,7 @@ static int uart_rs485_config(struct uart_port *port) =20 uart_sanitize_serial_rs485(port, rs485); uart_set_rs485_termination(port, rs485); + uart_set_rs485_rx_during_tx(port, rs485); =20 uart_port_lock_irqsave(port, &flags); ret =3D port->rs485_config(port, NULL, rs485); @@ -1457,6 +1468,7 @@ static int uart_set_rs485_config(struct tty_struct *t= ty, struct uart_port *port, return ret; uart_sanitize_serial_rs485(port, &rs485); uart_set_rs485_termination(port, &rs485); + uart_set_rs485_rx_during_tx(port, &rs485); =20 uart_port_lock_irqsave(port, &flags); ret =3D port->rs485_config(port, &tty->termios, &rs485); diff --git a/drivers/tty/serial/stm32-usart.c b/drivers/tty/serial/stm32-us= art.c index 3048620315d6..ec9a72a5bea9 100644 --- a/drivers/tty/serial/stm32-usart.c +++ b/drivers/tty/serial/stm32-usart.c @@ -226,10 +226,7 @@ static int stm32_usart_config_rs485(struct uart_port *= port, struct ktermios *ter =20 stm32_usart_clr_bits(port, ofs->cr1, BIT(cfg->uart_enable_bit)); =20 - if (port->rs485_rx_during_tx_gpio) - gpiod_set_value_cansleep(port->rs485_rx_during_tx_gpio, - !!(rs485conf->flags & SER_RS485_RX_DURING_TX)); - else + if (!port->rs485_rx_during_tx_gpio) rs485conf->flags |=3D SER_RS485_RX_DURING_TX; =20 if (rs485conf->flags & SER_RS485_ENABLED) { --=20 2.42.0 From nobody Fri Dec 19 11:32:31 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 19A28C4167B for ; Sat, 9 Dec 2023 12:59:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230187AbjLIM7U (ORCPT ); Sat, 9 Dec 2023 07:59:20 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47254 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230149AbjLIM7R (ORCPT ); Sat, 9 Dec 2023 07:59:17 -0500 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04on2043.outbound.protection.outlook.com [40.107.7.43]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 601F610EF; Sat, 9 Dec 2023 04:59:23 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=km01yQ9yVNEYXOgIxCwmP1pzGCvvIGZUbzcX1hghw9EKddmQbhwA6OAfMXhmrsyo0fLjdTXgjgK26hdH+YBlJmtYdxk+CWm6M3T54kO/DtPeXMBRXYguo1oUsag89J5nf+TI/PzpxhbstA7QZ2GgnoF/7F72jwtFnK8slHS86OSItFrEd48VBTBeW2M916DeD3KJjQRw2r/GZ979sciXDAiCgrgKUylP76iVdabIF8SRVs0ezyp+l+zFC3qpICy+ycWQN/aL/11w4rMruofYLC2nSGqKRCIAFLDhFRNEth2cW/R6FLkKOTG4bulQMM48iquElULl6DjDmfZoNiNTBQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Z37oomI38hjFz0c5Y/ltYnUcrUN1/Aa6wnLuGYM+HyM=; b=S/Gx8k0hUVgVTUy8L1XMF33yckusKax+81Npge1f1C5SSQROHYMiYP8vCty80m3Wk4R27O89VSUeLwLKtaXsdxMC5APr/2ti35yvWNs0vDSSG7ouWdhnPiWxsbcUoO2dfNB/xLJsJKQxtDGT9mf/DJWP7GZ1kknMPG0qtkOktWtiE755/1SPxGQdD0DgYdg//etlLvubez7OJUCo75tqTb0JmigCZQbVGIASVrExssrGE+icgWsCbriZGA9lYgWoZ0zD0A/lBBm+03l0BpkD2kXbE/EJuKDjbE/KYWBf0DWZGvKbsgYK6/nkouFox57vzSdya0x4xPXG3vIGluzJ7w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=kunbus.com; dmarc=pass action=none header.from=kunbus.com; dkim=pass header.d=kunbus.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kunbus.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Z37oomI38hjFz0c5Y/ltYnUcrUN1/Aa6wnLuGYM+HyM=; b=iN/T9odSKbrEfaKHeSPoC7/9HENUKVQvDN3haM4euPFn/STMmcNr9XD+WfnPfyWuEkK1/qXjwvJ3E0xN+PsJQ7XLGLqbK9FD8ZUvK7IfbwzU1ZZYmvphN+vRB5ezrVYQ/hjaruydWZi+asRWEYYrl6oIFYCkEWWUVAOPkD+AZsU= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=kunbus.com; Received: from VI1P193MB0413.EURP193.PROD.OUTLOOK.COM (2603:10a6:803:4e::14) by PR3P193MB0555.EURP193.PROD.OUTLOOK.COM (2603:10a6:102:31::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7068.29; Sat, 9 Dec 2023 12:59:17 +0000 Received: from VI1P193MB0413.EURP193.PROD.OUTLOOK.COM ([fe80::653f:d0f3:e7f6:8c06]) by VI1P193MB0413.EURP193.PROD.OUTLOOK.COM ([fe80::653f:d0f3:e7f6:8c06%5]) with mapi id 15.20.7068.029; Sat, 9 Dec 2023 12:59:17 +0000 From: Lino Sanfilippo To: gregkh@linuxfoundation.org, jirislaby@kernel.org, ilpo.jarvinen@linux.intel.com Cc: u.kleine-koenig@pengutronix.de, shawnguo@kernel.org, s.hauer@pengutronix.de, mcoquelin.stm32@gmail.com, alexandre.torgue@foss.st.com, cniedermaier@dh-electronics.com, hugo@hugovil.com, linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, LinoSanfilippo@gmx.de, lukas@wunner.de, p.rosenberger@kunbus.com, Lino Sanfilippo , stable@vger.kernel.org Subject: [PATCH v5 2/7] serial: core: set missing supported flag for RX during TX GPIO Date: Sat, 9 Dec 2023 13:58:31 +0100 Message-ID: <20231209125836.16294-3-l.sanfilippo@kunbus.com> X-Mailer: git-send-email 2.42.0 In-Reply-To: <20231209125836.16294-1-l.sanfilippo@kunbus.com> References: <20231209125836.16294-1-l.sanfilippo@kunbus.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: FR3P281CA0070.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:4b::22) To VI1P193MB0413.EURP193.PROD.OUTLOOK.COM (2603:10a6:803:4e::14) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VI1P193MB0413:EE_|PR3P193MB0555:EE_ X-MS-Office365-Filtering-Correlation-Id: 9ce4499c-d4c4-4557-f7f8-08dbf8b6a704 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: C0XgYvWmPwYllDeKHmlBnCjqM5UJMnRmL00aS56ohJnCqDiVvMTW6EuLzvhkjwLwcO66rZJwfh+xypL9bWWQO9JrCavfIoMl5Qwks36STgjWCrOSn0CfJOcCD+W8bp3U6iF52WOXpTPc2ypyft15wYkqkl4isnixqMjq+ybE4VWB+5xZUVuTOKGHv9SE0l3wBXK7lDPZWgT+yJ+Oft7C2tXftRDCJv4Zuy3dwXldFTYPFvi1JS/pTTwxVuij3Qhh/LCdpDl9wbcInLLe1rB9A/nZOjT1P4V1X5z+3Kl1qkms2fcz4BEuwBt97obvGhHzpGYjKuzDekxgyJ5tryqKlj3yjvr6qH2+YoiPq7a7ulMj1o3fpp1ortGxYD4w44RVewy9DsQxbyJ35M4WABWP50abeR59QxzgG9UvB2iLg6COMyt6hQwRXpIS5XyTudGSn5SLSLllRtnrGi9KS/sO+CVWDphHb58YqSVp6WwnP5hm6UUQNsIQA2sO2Kd5r/oQ5OWRF0dka4nRXKRLNX5c368lkbr9nJi07dQ6omUo1OGh7fWeIyaWaIyW/u3L8Klh X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1P193MB0413.EURP193.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230031)(39830400003)(366004)(376002)(396003)(346002)(136003)(230922051799003)(186009)(1800799012)(64100799003)(451199024)(2616005)(1076003)(478600001)(6506007)(6666004)(52116002)(6512007)(41300700001)(5660300002)(2906002)(4326008)(8676002)(8936002)(7416002)(6486002)(66946007)(316002)(66476007)(66556008)(38100700002)(86362001)(36756003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?TRLhD6O3YSlL0LsJvVk8dvlaZgDaHZIwG/+Uv7aNRkgEa3SDyjfoIs/btba6?= =?us-ascii?Q?3Kauf+e1629sKe8IeiFebrsNTZRmuZfKLWytBOiO9nxBlqCJjpYz86WhvDMc?= =?us-ascii?Q?BfEan7LzRGsFJjj8Avk2cTtUw3wZ1oq57AMDGxg834FCs5hnW3klQnnw56FB?= =?us-ascii?Q?nZxKVbTwMFkPkC/D07M52VQ/kMEGPpzYJDhLHQVgd+yIrbhoX+Wg6dJrlvA4?= =?us-ascii?Q?chhNE6Ght/sp2LUf/YhJfFr8YwgtQ94+vnX4Fe34Mjsmh681xcnIdJ6QKGnW?= =?us-ascii?Q?t6lV0LQWtKgZgk6Cdai0EmjmdZu04YeajbvybtB++A6oZBx/6rrbg0l1EuFy?= =?us-ascii?Q?zndtWeNh3TEIxp5QV/geLLvtt5Eyvb7EFqAb0j1zSJjKejxLi0Ikye/OIxsj?= =?us-ascii?Q?5mXXTc388hKVjwi1afYGjhiJJDPyjjprWPlUZjJgWy1QPS77lP7B71CmHlPl?= =?us-ascii?Q?TcWSeiOEE3whhRmh2a9PvUFwLXDnqWBPM6lChzhgShhcw9W68YHG6FkYMMAy?= =?us-ascii?Q?kt9r5QvSQIOzoGrc0KDGDKDteVGFV1oOdhZu2SSF/hlNBAicnlArdoKd6y0P?= =?us-ascii?Q?+7Sj4zsowAl9ZGGXGH1CLxyZiT9Eu7Sxsk6e6HcsLKZjtycKvY0kU1BnqiQa?= =?us-ascii?Q?T3cDIZd5DBIRmEbtsMgoOQnlLbZvyDg5Pd1c5Yh8cqL1Jk03dN72AxBMTXIO?= =?us-ascii?Q?qODSmyLZo8F2tLgG9NlhjecdvDEDg4v9C2heZfYi9wn1F8n14op1ZMTL9iFh?= =?us-ascii?Q?Kvnql0+dyHhlS8fHA8p4CSvPiaPtaS8TnO0EKNwgXGWDlI92A9yJSFLUPpSn?= =?us-ascii?Q?dcom7vnwmY6ooaETwW7kqY//8ece7WjFix6NEJVNvrgMS3Ne4ueyHlD4FyuN?= =?us-ascii?Q?k7SWdtbHXHTTv4zm1f3eKWmgLEwy7k3kRiGEtLDrH0SCWXnpNFfGQBvbo50Y?= =?us-ascii?Q?OcuhAt1Vl74tmFJtW2G+J7yUMs0vEqbxDrs2xPfo7NPF67a8F2xWJMAPSXNQ?= =?us-ascii?Q?KXYLGFe6Gvj8ijf6pqfw0hvP7ApWoIP/srNmoVQb54zPoI95yp+wN7I5kg2q?= =?us-ascii?Q?Ld8sISqiAcsvbfMvbkbMD//F3uTSQ+8Lbtg/KlvSQW26DKvfRTgqUU+vZT2l?= =?us-ascii?Q?6oGbp0HU/JwWK/0wufjuJeWrlNZgt5KXY/A852s7dV4rtMFP6M+WNudcE9lW?= =?us-ascii?Q?L3VmkjVS/kUaTDRxXEuX0f8+amEV2WLSTH0ULXLQkrNGwjHDlDnrT84eRUZu?= =?us-ascii?Q?XOC2IOK7szL6LYo61QUE7xJPpY4eVPWWyX6GbQaTGnOlnMXeju1+8NiMbDBl?= =?us-ascii?Q?yq2wpQVOXZxFiC2485+oZtSuAoRATTreOgkAvaTcaT3LQOTrrk6T2SlC/A2r?= =?us-ascii?Q?vhFrqzKMh2bfH1VpSTvojXzWU96xV8rMvrtJnO9F6pI/ibCpHQeSWzxeXGK3?= =?us-ascii?Q?1D0+JKXELhQBTihzmisjiJ4Li/KzlsYxQUEJyi+9JR6FyWK1A31YeIb6T90B?= =?us-ascii?Q?kFzgFJjycB10OftLCLmRFntsmBu2ObeThAOsseEaDldGkWlIhqWyTz+PyIHF?= =?us-ascii?Q?UgRklHrVA04EBrxY32Qwn5au8BLMrFIZp7Musv1z80EnnuwWZEFKMHcsb8iG?= =?us-ascii?Q?gppmn0aTCwoPQTiVNW3yOD+cNUDec1LL0T7ejLZ0bBnl?= X-OriginatorOrg: kunbus.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9ce4499c-d4c4-4557-f7f8-08dbf8b6a704 X-MS-Exchange-CrossTenant-AuthSource: VI1P193MB0413.EURP193.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Dec 2023 12:59:17.4954 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: aaa4d814-e659-4b0a-9698-1c671f11520b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 6B7S8zfwk5RpG0mBIUuXnzWplIdW+QqoMgCI5sSAWQ3K7dusfTU80PsMI5s7MfLrhs6O4FoBH2ZjIuZf50ueHA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3P193MB0555 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" If the RS485 feature RX-during-TX is supported by means of a GPIO set the according supported flag. Otherwise setting this feature from userspace may not be possible, since in uart_sanitize_serial_rs485() the passed RS485 configuration is matched against the supported features and unsupported settings are thereby removed and thus take no effect. Cc: stable@vger.kernel.org Fixes: 163f080eb717 ("serial: core: Add option to output RS485 RX_DURING_TX= state via GPIO") Signed-off-by: Lino Sanfilippo Reviewed-by: Ilpo J=C3=A4rvinen --- drivers/tty/serial/serial_core.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/tty/serial/serial_core.c b/drivers/tty/serial/serial_c= ore.c index a0290a5fe8b3..c254e88c8452 100644 --- a/drivers/tty/serial/serial_core.c +++ b/drivers/tty/serial/serial_core.c @@ -3632,6 +3632,8 @@ int uart_get_rs485_mode(struct uart_port *port) if (IS_ERR(desc)) return dev_err_probe(dev, PTR_ERR(desc), "Cannot get rs485-rx-during-tx-= gpios\n"); port->rs485_rx_during_tx_gpio =3D desc; + if (port->rs485_rx_during_tx_gpio) + port->rs485_supported.flags |=3D SER_RS485_RX_DURING_TX; =20 return 0; } --=20 2.42.0 From nobody Fri Dec 19 11:32:31 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0CB1DC4167B for ; Sat, 9 Dec 2023 12:59:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230245AbjLIM70 (ORCPT ); Sat, 9 Dec 2023 07:59:26 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47258 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230171AbjLIM7S (ORCPT ); Sat, 9 Dec 2023 07:59:18 -0500 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04on2043.outbound.protection.outlook.com [40.107.7.43]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6BE7510D0; Sat, 9 Dec 2023 04:59:24 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Mnh5tw+jySzm6oFT4sY6kCzsSwiYJaEWmeOrFwWjUBzYVNm4mCD61wL0jJOlSz7TrqMPtHd+oIgq5CdJUEEEtcgREQNzzpjCpLMM3MNJJZlK1C0TiaxR6R9i6u1u4eN6P5JaVI5Eu//lYSlFyuuJWNLvVhcu4QzCkjdoHKXYtAPxiGXiD0rJgsucyT3RvZ9zGIOvR8Pjpm/V9rNQIeOKT9CXaZeJHkjT2bZvVrpeupYHbK+DVmCGgsVrWCyzdxFkWt4r7XtBvOvMx8O17TnDnp1QHC58jNniz0mqUeITr21Py6JKZyo6kZvG9N1e5r6UL1BwBwO2cXXKpgKUdYDxJw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=rszBlcOxsSoMrEwBQMjDWsnQP5LdeKunsCjYCVGKsZI=; b=SDviClzrvRMdpO26oUJc3bmup/5DGryqBtuAm6lpYzXpukr0no+bMhFMprT+FXmdTcG4ZcXORAMCZNCBe2zuCHu8IZ2zRKzYxdhAMZT3A6gNIdEA858BIwXk556pd4ZASyqwUiou6Z8zN0wfRitnzFNrqHzlBFyYgRBw4bz2TbZSx7dzZ9o0lC09bMAc9CD3X+//upmqJE3bSrn0fNB72Fgaf8zcpLJ+Qa63WMYNuq7hEBYxpcHnSwtZkvc+U0rAZS5Qk4DRBHS+sObEkW4CPkmbUaofz/umjyMiZardxzVyBXtOneUqiRDHkQx5D5MMduSc0OGILwpaGxVa4MMj4w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=kunbus.com; dmarc=pass action=none header.from=kunbus.com; dkim=pass header.d=kunbus.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kunbus.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rszBlcOxsSoMrEwBQMjDWsnQP5LdeKunsCjYCVGKsZI=; b=olbQ3ZIbNIjuMx5WQpe5/PDYoVSYDgZRoX4LDaDQEl+m5WL+sGpG8Y1xpLmEB3eIlNhBf5znH7hajF5y3WR01kndXgMxXBpEhfrpI5T7O7NoMBLkeCBQKRKb66EpZ9WzYvr3fuWGT2A7qwe/7C8K0oDjm/2hJdX0UQlBzCOrv7Y= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=kunbus.com; Received: from VI1P193MB0413.EURP193.PROD.OUTLOOK.COM (2603:10a6:803:4e::14) by PR3P193MB0555.EURP193.PROD.OUTLOOK.COM (2603:10a6:102:31::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7068.29; Sat, 9 Dec 2023 12:59:18 +0000 Received: from VI1P193MB0413.EURP193.PROD.OUTLOOK.COM ([fe80::653f:d0f3:e7f6:8c06]) by VI1P193MB0413.EURP193.PROD.OUTLOOK.COM ([fe80::653f:d0f3:e7f6:8c06%5]) with mapi id 15.20.7068.029; Sat, 9 Dec 2023 12:59:18 +0000 From: Lino Sanfilippo To: gregkh@linuxfoundation.org, jirislaby@kernel.org, ilpo.jarvinen@linux.intel.com Cc: u.kleine-koenig@pengutronix.de, shawnguo@kernel.org, s.hauer@pengutronix.de, mcoquelin.stm32@gmail.com, alexandre.torgue@foss.st.com, cniedermaier@dh-electronics.com, hugo@hugovil.com, linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, LinoSanfilippo@gmx.de, lukas@wunner.de, p.rosenberger@kunbus.com, Lino Sanfilippo , stable@vger.kernel.org Subject: [PATCH v5 3/7] serial: core: fix sanitizing check for RTS settings Date: Sat, 9 Dec 2023 13:58:32 +0100 Message-ID: <20231209125836.16294-4-l.sanfilippo@kunbus.com> X-Mailer: git-send-email 2.42.0 In-Reply-To: <20231209125836.16294-1-l.sanfilippo@kunbus.com> References: <20231209125836.16294-1-l.sanfilippo@kunbus.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: FR3P281CA0070.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:4b::22) To VI1P193MB0413.EURP193.PROD.OUTLOOK.COM (2603:10a6:803:4e::14) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VI1P193MB0413:EE_|PR3P193MB0555:EE_ X-MS-Office365-Filtering-Correlation-Id: 9d57188b-ef44-495d-a3e8-08dbf8b6a772 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: /0okGIZNCuW+G79mn4HXAjBdqq2xw1qZ8WiGyoRN3Mt/0BxSVrxCbOaqd7bwNRNnK12AmEmQNOsljQTqnasGKsf/z+HcIuNRThaCAwYN536MNBYoyp+ZpCE7SWJ+tlvBjv5m1hZYx/2u0ngZdUs+mun8jjfhuo4NuwX9r1Cn8OW5P6VSfJeRexvB6iZ5plhUfTUeEf9hogu/2Dp6RfNPYMyuVTGgDIjamTnmh2toNIOCGQY489dATAweKyerXT/3ZchfV7avHcKisFZUyfoRnqxefpWxXQmoif4TC1JQFKlNvuuT83R21bwL+2QggsWr9QTl3jZQFwkL4AwxtiWqcWj2M9BfvxNJi8GBPahYLdcWv+xzhktUZujmBYng1PiPhxeuApDhbifSgAPzDK85xmJDjTUCKZeh1vpLEo/6bsAKgnGuz+Pkpgo02MqN1eULQduapicXHHFTyc3yAmhaKT8/3JZ3O3HjE+uwiWr0AGq9MSWVBpXg2eyk9gyVRmLqsF/NeuvasjRz0Vwi8ZTkN2ndg61IyuCtctRfu99oaYl380dErnA8wQjsu8KrH1Lc X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1P193MB0413.EURP193.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230031)(39830400003)(366004)(376002)(396003)(346002)(136003)(230922051799003)(186009)(1800799012)(64100799003)(451199024)(2616005)(1076003)(478600001)(6506007)(6666004)(52116002)(6512007)(41300700001)(83380400001)(5660300002)(2906002)(4326008)(8676002)(8936002)(7416002)(6486002)(66946007)(316002)(66476007)(66556008)(38100700002)(86362001)(36756003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?MeJmEEn0eCJa0xvD9sIEdlNiNuUEZAznyl5t80GW/AdKkE2LGeMe5oDJhQyp?= =?us-ascii?Q?87jozw4uLR1hV4EMImPPa+aDM41SbJqsPSq2yubtjk16kYIaPlHnu4AJ8TJO?= =?us-ascii?Q?Oa+9JsWuODshFXdbKtDzDAFYjc0wHRm5/BR5TTeSJ19s9tUm9B9zYRJ4mQ0g?= =?us-ascii?Q?Z00P7VYJ64D6FxX6eDJn9REtRZEAJPF9kb+vkqYp0fKwNq09vw8qirfzzq2R?= =?us-ascii?Q?DiDMdlUPXwg6AEUqKWtzLeFpoduDXblKJ2wYnfVL2t89wNteCAQdUHVgu7K9?= =?us-ascii?Q?9GwkBdPAWpDB2mR0o+DKeA2+/e1ct2a+FikKBoaSewkmvTr3GEwWD9zrJjx/?= =?us-ascii?Q?NRq8lHaXiYMeBfsOp4ZSS+SZl/EkcYGSiNxOEZM6sWM0sENY3GxjE0K3l4rV?= =?us-ascii?Q?anoUK9T4P8MYzr6FdkgWKd+RDNV+4y5NxDdxTRdRIIWJERTQ+h2HoYvJoK1B?= =?us-ascii?Q?MntvuX70xbf7Ta+Yy0BEylvXF/W+tMXS0n3SPUbUjT0vkB5OE4nRD8Ms2K/0?= =?us-ascii?Q?s9UAjG8qozSX+6JK+mNT4WVchc+gDPz/cPvAX3ZqThyCCEd/xB7oU/VHdK2m?= =?us-ascii?Q?jrpvWnMPsCezooNpHC0KY2EnQjO/cX3kWj5gN86Vt8RPL/JebZS/Mc40g2Qq?= =?us-ascii?Q?Q6fOdytwtektkNfjZJXGB6/z8CC4unYwq1pLZUMQYBdcbxGLCXlV/Bdymgdk?= =?us-ascii?Q?iGJl+k+Hcuch5/4Xfr+cKRLKEkSJaHvbSU1Z7rvCKYi15hyHVJqS5kwHUP42?= =?us-ascii?Q?eOaZEtO0lxNsV4LI5Za5kMDftYHLOtecdYa+nwBGFHL3vE6cTtgPqlbwYlUu?= =?us-ascii?Q?VYXZ5kDObAYw7j8o+bJiWgb3fHmJnWMq+KvfDFBfGsrkDB8D66T1efDTzbao?= =?us-ascii?Q?EVPle8wKBLtqFlOKZmwFqXCJwnhUhVN3ncYrga2d5mZKCFNugiqaPCEtv9m4?= =?us-ascii?Q?NYp+7EkdngUBA9KEF8zvk7hfWAzPElEVGedKDKGJSPJG7uae0lLm1ZA220+d?= =?us-ascii?Q?kA9pzCLPUoPpWQGB9zIDcqVwi7zmDzW53O5JE227TIwDcQ92gd2OilZlr2Ia?= =?us-ascii?Q?ktK5B5DTWNHesDBRKPidKN+d8Qu/TYnXpmSgDO/zAzf4ynUO+JUG9JnF+J38?= =?us-ascii?Q?7jSQAWKG5IeV651+ojjCfqYRMPazXgkxnDkue4k2hqBoIgeTqqnq+7K4vulr?= =?us-ascii?Q?/ayjjyfzwxSuYkXISZ9tXr0lzcA0xrW9IiOe3rCFDgCHD6Ei79hWtkcedyfW?= =?us-ascii?Q?q83N76MwI/e4HSc0Md+NpAtEJLHs+blsE96R5vLWscHy9QvcGci4qRedTcmJ?= =?us-ascii?Q?3CFyiaJYgeaS4A+H+vFq9hOVYwrElO9rBm9jU4Fe4HXFaDuAiyir+sTTfHo7?= =?us-ascii?Q?9R06wbA2o8uwElqdB6eqK477ah2/vS2xRav8h5oOeQFCRVZu/U/qIHmvNV24?= =?us-ascii?Q?tjc/hOA7uVCWw3P/Ni8UHuK1d6UA+zR4Vv90SLCKabX5qYcmltl2rwmfJQMH?= =?us-ascii?Q?w/brm3KAHBLm0bhEqiD153Xkrd+wDlOmAc3GXMiEFhJ8CJiRhZ5806VIHVfq?= =?us-ascii?Q?ZvS0T/Ilmv7YgY8Wmajx9I7NbjC8hEgowIfjw8Fwooni5ps6Wqrixn5Ejr/t?= =?us-ascii?Q?jFSjsGeJtvc11FFjX3n4bJPTMsJuBFSyX72Awyxq8+ip?= X-OriginatorOrg: kunbus.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9d57188b-ef44-495d-a3e8-08dbf8b6a772 X-MS-Exchange-CrossTenant-AuthSource: VI1P193MB0413.EURP193.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Dec 2023 12:59:18.1827 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: aaa4d814-e659-4b0a-9698-1c671f11520b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: b7KnC4AAlMfVdYOXFMkvkC0b6q/1xncjkXubvUbluJ8UlfB5UjNLAu6z+WsZdOw6bLmMh3X9EipzSH5x8updEg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3P193MB0555 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Among other things uart_sanitize_serial_rs485() tests the sanity of the RTS settings in a RS485 configuration that has been passed by userspace. If RTS-on-send and RTS-after-send are both set or unset the configuration is adjusted and RTS-after-send is disabled and RTS-on-send enabled. This however makes only sense if both RTS modes are actually supported by the driver. With commit be2e2cb1d281 ("serial: Sanitize rs485_struct") the code does take the driver support into account but only checks if one of both RTS modes are supported. This may lead to the errorneous result of RTS-on-send being set even if only RTS-after-send is supported. Fix this by changing the implemented logic: First clear all unsupported flags in the RS485 configuration, then adjust an invalid RTS setting by taking into account which RTS mode is supported. Cc: stable@vger.kernel.org Fixes: be2e2cb1d281 ("serial: Sanitize rs485_struct") Signed-off-by: Lino Sanfilippo Reviewed-by: Ilpo J=C3=A4rvinen --- drivers/tty/serial/serial_core.c | 28 ++++++++++++++++++---------- 1 file changed, 18 insertions(+), 10 deletions(-) diff --git a/drivers/tty/serial/serial_core.c b/drivers/tty/serial/serial_c= ore.c index c254e88c8452..4eae1406cb6c 100644 --- a/drivers/tty/serial/serial_core.c +++ b/drivers/tty/serial/serial_core.c @@ -1371,19 +1371,27 @@ static void uart_sanitize_serial_rs485(struct uart_= port *port, struct serial_rs4 return; } =20 + rs485->flags &=3D supported_flags; + /* Pick sane settings if the user hasn't */ - if ((supported_flags & (SER_RS485_RTS_ON_SEND|SER_RS485_RTS_AFTER_SEND)) = && - !(rs485->flags & SER_RS485_RTS_ON_SEND) =3D=3D + if (!(rs485->flags & SER_RS485_RTS_ON_SEND) =3D=3D !(rs485->flags & SER_RS485_RTS_AFTER_SEND)) { - dev_warn_ratelimited(port->dev, - "%s (%d): invalid RTS setting, using RTS_ON_SEND instead\n", - port->name, port->line); - rs485->flags |=3D SER_RS485_RTS_ON_SEND; - rs485->flags &=3D ~SER_RS485_RTS_AFTER_SEND; - supported_flags |=3D SER_RS485_RTS_ON_SEND|SER_RS485_RTS_AFTER_SEND; - } + if (supported_flags & SER_RS485_RTS_ON_SEND) { + rs485->flags |=3D SER_RS485_RTS_ON_SEND; + rs485->flags &=3D ~SER_RS485_RTS_AFTER_SEND; =20 - rs485->flags &=3D supported_flags; + dev_warn_ratelimited(port->dev, + "%s (%d): invalid RTS setting, using RTS_ON_SEND instead\n", + port->name, port->line); + } else { + rs485->flags |=3D SER_RS485_RTS_AFTER_SEND; + rs485->flags &=3D ~SER_RS485_RTS_ON_SEND; + + dev_warn_ratelimited(port->dev, + "%s (%d): invalid RTS setting, using RTS_AFTER_SEND instead\n", + port->name, port->line); + } + } =20 uart_sanitize_serial_rs485_delays(port, rs485); =20 --=20 2.42.0 From nobody Fri Dec 19 11:32:31 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 094B2C4167B for ; Sat, 9 Dec 2023 12:59:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230189AbjLIM7a (ORCPT ); Sat, 9 Dec 2023 07:59:30 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47270 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230174AbjLIM7U (ORCPT ); Sat, 9 Dec 2023 07:59:20 -0500 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04on2043.outbound.protection.outlook.com [40.107.7.43]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B90F710D8; Sat, 9 Dec 2023 04:59:25 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DwGjeDt+HZ4pv0n0fE2VlrLzZcuz/qoqZrXMaTF9iZHStnKNSdLPxH6ARySb5Jw1jXkSvKNqtqVL3og30UtLQiMpyTQ5S2lTnj9NNN1PCNYP0Q2gvFufxcN7AsozpBE0kWr1+vNkBdhIpfRSV4s2lu/skq7xjBMqZvmrRiXnOAa3EkmarvtM/QuUSoWS6BSVFYtDlPZVx44n9ixPALjVhut12fKl2AhbwP6tdzEPiUNY+oTDrjiQxsHien23fC95KHM0cgR4SQyZpv0yRBYYIj58nKSfbj+CStqhNk4/xYqbgjQ7VmqsoBGXDLTsjTIME/bOlNb0VdoxQY9n/6II7w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=giTj5RrPHXa3a+Lx1xc7jw4vgGwf3+BKO1xkJ+5ZPDo=; b=JtaQAz+xe4nUuz2IFVNs/NueDn5wpxO0+pcEGL72H42K7nyAiOAWeMgDFlOlR5EjkOiXrvjYiX8f/OixVuQ7JBrj79ug+9f7A7znzZwP/n7l+J4e0ev59vRxuSloeyrl42e7mrrF7+ucG9Rf07jrvi5+HE9LkazlFX07o9+8nyupc70yb5Q+kLSGZMKxDvE7pQ6hFjhyYtjgAzfRYjRteYHMVZQPsyLUkn1DiCdROFItmJ4qN+Wfw5kyhsb2TLHv1dpdOzN2U8xR+GEodFZnE0zYo21BRhg0Wy524C7H04cxLPYbZJLMwfayVDdjRmy59/pm+jOfmrH7FSKftNfXgQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=kunbus.com; dmarc=pass action=none header.from=kunbus.com; dkim=pass header.d=kunbus.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kunbus.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=giTj5RrPHXa3a+Lx1xc7jw4vgGwf3+BKO1xkJ+5ZPDo=; b=IEZv6+qqSpeGVls0ymRynD9cbAk+3O6ET6NS9ugFaSnJiXkvzr3W7mkAwHr+fTIby2Qvp4bub0pj6OcqA67GHY+bpblQIX3eW3Ki6CJW7TgyVAMhCtIP7DLuti5Y5iuPdmc2knr/O1bhggwNR7Jc1aZ7SmmK9X9xk8wXMoAr6GU= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=kunbus.com; Received: from VI1P193MB0413.EURP193.PROD.OUTLOOK.COM (2603:10a6:803:4e::14) by PR3P193MB0555.EURP193.PROD.OUTLOOK.COM (2603:10a6:102:31::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7068.29; Sat, 9 Dec 2023 12:59:19 +0000 Received: from VI1P193MB0413.EURP193.PROD.OUTLOOK.COM ([fe80::653f:d0f3:e7f6:8c06]) by VI1P193MB0413.EURP193.PROD.OUTLOOK.COM ([fe80::653f:d0f3:e7f6:8c06%5]) with mapi id 15.20.7068.029; Sat, 9 Dec 2023 12:59:18 +0000 From: Lino Sanfilippo To: gregkh@linuxfoundation.org, jirislaby@kernel.org, ilpo.jarvinen@linux.intel.com Cc: u.kleine-koenig@pengutronix.de, shawnguo@kernel.org, s.hauer@pengutronix.de, mcoquelin.stm32@gmail.com, alexandre.torgue@foss.st.com, cniedermaier@dh-electronics.com, hugo@hugovil.com, linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, LinoSanfilippo@gmx.de, lukas@wunner.de, p.rosenberger@kunbus.com, Lino Sanfilippo , stable@vger.kernel.org Subject: [PATCH v5 4/7] serial: core: make sure RS485 cannot be enabled when it is not supported Date: Sat, 9 Dec 2023 13:58:33 +0100 Message-ID: <20231209125836.16294-5-l.sanfilippo@kunbus.com> X-Mailer: git-send-email 2.42.0 In-Reply-To: <20231209125836.16294-1-l.sanfilippo@kunbus.com> References: <20231209125836.16294-1-l.sanfilippo@kunbus.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: FR3P281CA0070.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:4b::22) To VI1P193MB0413.EURP193.PROD.OUTLOOK.COM (2603:10a6:803:4e::14) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VI1P193MB0413:EE_|PR3P193MB0555:EE_ X-MS-Office365-Filtering-Correlation-Id: 3f929983-ff7a-4f98-d96f-08dbf8b6a7e9 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: TMnn2UGZpEGMBSgFA+R7ZeE0qTIQJ9xMCvKxabWdl3GX60XEi8JslXdmWppGwzWy0YKL6bVNCCKiwjIlh/bKaMeavLj9vzgYnj+hO0jlIDTr2tyrul+g3H0+0bt5MOToxNTgLGpckrBHeXkbcshITa+wO2gzkvZ2/W/T977427HUP8O8wTtYW+oD4GtX03MUOV3ngl8LaZsaI9vZz1EE0uetJkM/0mow146VJLI6WeOCqMu+5m7I4UBhYjAb0wQQ3/iSKcZG4Tn/pzUazsafv4jscoWeiOVz5EaeNbrcTQwQb/cynlxXUB2nYhGcgjHNYafMrn82hA3PuynJ56Kt/thUBuuVnDZlMck6DRtLEHuGhG57tGBtUKD7P72zgcWtK3DqEnEqIk7NPokJzGVpEeh/KfCO8HShrR4r52wBNU9+XaE/cXf/suC36mpicbLBE50n1rnEzfz6pMRZsK21WQTLFPazkgT5n/gjibwkkxYRdaZDexwwbIAIi8eVnP6+tG6FCxJYE+Hp8KfS3ICp6xxW5bsGu7Qc/AJArD0qRyrHhtqcij9hzqyWyNqAgnwI X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1P193MB0413.EURP193.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230031)(39830400003)(366004)(376002)(396003)(346002)(136003)(230922051799003)(186009)(1800799012)(64100799003)(451199024)(2616005)(1076003)(478600001)(6506007)(6666004)(52116002)(6512007)(41300700001)(83380400001)(5660300002)(2906002)(4326008)(8676002)(8936002)(7416002)(6486002)(66946007)(316002)(66476007)(66556008)(38100700002)(86362001)(36756003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?/kb+AFq7Shdeot/IU9p+Hch3qin+YP1i3I8EbG+HDPp2fEC4HBqvwSqpPPQC?= =?us-ascii?Q?ulFsQcLY38c1eDzqD2z7XWR6hzkcITt+CmvshCoP7PkgHacBl4YNm2KoG4Bl?= =?us-ascii?Q?PQKBPVn3IARf7hC31bBOglc/DswB/4SY07i3Yjsa/sCm9BEvxEYcPT5HFzUN?= =?us-ascii?Q?6/mYCGyP48LoHi+3DOgYKEyI+1J/owkP25oaIuYJ0J0U6YzLqoA8bJg91JOr?= =?us-ascii?Q?6g2mEquE88EQ4KhldfqXwj0HHjj4XpJUQeUGopeyen52lk0WmE5t11Oyin9c?= =?us-ascii?Q?2wAW2kxVuMhb0ZFLTbXMxe1ttnuDevdFORuHPrz742t5BH8HRR7hGY3CpGEq?= =?us-ascii?Q?jtfiRum4eqcVzCFb6aShgiJhndwqHr0Z1k+i9D1zzkZyq5PAD5eg3pPYmtnT?= =?us-ascii?Q?n3+MsS3FzTFbN2shVuSva0XQc6j4Ds6Ojlk2frr8PsWuAd0sJMaCHn9DrmDK?= =?us-ascii?Q?5nmZWMJz+iOtgFj7iMNEGBAbnU609Y3rmX/sgfpWK7HgLaj1g3PPKmZNt3xU?= =?us-ascii?Q?aH2KWDodNzVtwhsG1yu26J9CszBM4CoYTGVlyQzGxN5ysjSZdl+t8z52gUjf?= =?us-ascii?Q?N39TDfYrw6kRsbTHHFqZDW7OdqVGEiY1XFfgmUWMeixhFxSvDqdBm73k9fTV?= =?us-ascii?Q?pLi+QNtIX3oPIybx3RNRRhWUuMnPz5GKNbtY+05mM32LEIlivdJxxCf9b8Mr?= =?us-ascii?Q?o7kATm/7jIaV+4U+I+0P9ekfx6cKOa3ob5OGZ9LPshY/pAbXzndWsICS1kQh?= =?us-ascii?Q?/w2qkuaFQwfkNo9xJORHTRwtJffXNzPBj+k6oLizx26VFKKpM+JaJvxhN2wj?= =?us-ascii?Q?83i9qHMwCqZy5mGrYeVsfHRF00X+bajhqJIL3fFTDSdN+CINeSV2DlvubAcH?= =?us-ascii?Q?Tvo0nJCt2Pi8u5Ku6/eqTZebwFZbEI5IuJsXxCwsy6QrdIUU/CaV4hY2MRC7?= =?us-ascii?Q?OeM0zsignp9NMOFJXPMkeIXd1GGfsBy8gDs13xbuJdGxIXFhpIOpuBOj0qj7?= =?us-ascii?Q?w9fA40TUW2RiHettgLI3Cy/6fVj7jIw2zC6xAi0kdP9iMgX4JReE2bttA1hu?= =?us-ascii?Q?xbn8Q/BmIBz8U2h2fsFgERLd6JO69W4N+per+y8MfeZI8rbUd9/zZN5+HiMu?= =?us-ascii?Q?FU9DP0FkO4Eh+ZaoyZ9AkovCka70CbVkyA+Vhxpy885HOgNRgrFa6hKUsoMO?= =?us-ascii?Q?Bmtr751qHWE6PnPfw6MQL2ft2cX80YqjeW0H+wMqy0dHm9twtzwxw8mZPb6V?= =?us-ascii?Q?Xq0O2WKB+mT/NuUPiqN1G5GWiiKUKL5p/m2vjGD5uSdKx2GT/LlERzELgrZb?= =?us-ascii?Q?i5Jm5GPMgUfQhsUTwdngQBfsUV5jff1lCmMMGP7a5mZnqi2G8EAjQm6eEv1y?= =?us-ascii?Q?LMvyzKVfF9xta3VFR0p8D6kPt2o8BYVrpHFuFA6WzILCGO1EPvujn8Nrnk63?= =?us-ascii?Q?CGdPP8lW5YbUMegb+kqxb1Y6osaAZu6xIDL7alCZu3tYiI8iTB3JOiy5cSYA?= =?us-ascii?Q?VcWP/o59BoqOBmUZzCqVqhG+1Z+cpxMVwpIeAB72AG0GFElWWtfUpLKoIFlc?= =?us-ascii?Q?Q22+g+huiHt7mUKdbbEf7QOl0C1sgirp3xs4cBGOqH8jGrFpCJDQTnQRov6I?= =?us-ascii?Q?9tztQzTDv3yqtuJRZROip7TDP/BcRGc6rrcgvBdTIREp?= X-OriginatorOrg: kunbus.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3f929983-ff7a-4f98-d96f-08dbf8b6a7e9 X-MS-Exchange-CrossTenant-AuthSource: VI1P193MB0413.EURP193.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Dec 2023 12:59:18.9258 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: aaa4d814-e659-4b0a-9698-1c671f11520b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: PZbWvp9aAfEst6+gLAp4bp7CQo0Iu/fWI+YPr/GECft0qxGPO+kyMdzvb4Jpo3ht9oA3swxB/F6ea3elCG+fqQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3P193MB0555 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Some uart drivers specify a rs485_config() function and then decide later to disable RS485 support for some reason (e.g. imx and ar933). In these cases userspace may be able to activate RS485 via TIOCSRS485 nevertheless, since in uart_set_rs485_config() an existing rs485_config() function indicates that RS485 is supported. Make sure that this is not longer possible by checking the uarts rs485_supported.flags instead and bailing out if SER_RS485_ENABLED is not set. Furthermore instead of returning an empty structure return -ENOTTY if the RS485 configuration is requested via TIOCGRS485 but RS485 is not supported. This has a small impact on userspace visibility but it is consistent with the -ENOTTY error for TIOCGRS485. Fixes: e849145e1fdd ("serial: ar933x: Fill in rs485_supported") Fixes: 55e18c6b6d42 ("serial: imx: Remove serial_rs485 sanitization") Cc: Shawn Guo Cc: Sascha Hauer Cc: stable@vger.kernel.org Signed-off-by: Lino Sanfilippo Reviewed-by: Ilpo J=C3=A4rvinen --- drivers/tty/serial/serial_core.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/tty/serial/serial_core.c b/drivers/tty/serial/serial_c= ore.c index 4eae1406cb6c..661074ab8edb 100644 --- a/drivers/tty/serial/serial_core.c +++ b/drivers/tty/serial/serial_core.c @@ -1448,6 +1448,9 @@ static int uart_get_rs485_config(struct uart_port *po= rt, unsigned long flags; struct serial_rs485 aux; =20 + if (!(port->rs485_supported.flags & SER_RS485_ENABLED)) + return -ENOTTY; + uart_port_lock_irqsave(port, &flags); aux =3D port->rs485; uart_port_unlock_irqrestore(port, flags); @@ -1465,7 +1468,7 @@ static int uart_set_rs485_config(struct tty_struct *t= ty, struct uart_port *port, int ret; unsigned long flags; =20 - if (!port->rs485_config) + if (!(port->rs485_supported.flags & SER_RS485_ENABLED)) return -ENOTTY; =20 if (copy_from_user(&rs485, rs485_user, sizeof(*rs485_user))) --=20 2.42.0 From nobody Fri Dec 19 11:32:31 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1CC48C4167B for ; Sat, 9 Dec 2023 12:59:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230284AbjLIM7h (ORCPT ); Sat, 9 Dec 2023 07:59:37 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47290 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230012AbjLIM7V (ORCPT ); Sat, 9 Dec 2023 07:59:21 -0500 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04on2043.outbound.protection.outlook.com [40.107.7.43]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4FC401700; Sat, 9 Dec 2023 04:59:27 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=eYKjBCdu/eGPMNX+fe+3/V5zgyrTSTpHBOQ1awwSPZ3tO9rXImITj6kBWkNaPiD0+eDpZjVFNHS09sn1tkjN+Bcc+WKgXAwOJ2j3ATOV8H8IBcOI4Zc/UOu6Pt1ywTjgiYO8JMjuPmrDHhP9hEqE1y46bnyjme9QPUe/yL2CAj1Us7haDFCF43oqNXSi7dex1pJkYPgnB7aPY2UF2EoEkPvBUbWWxL7Ruuzsizoaq7NC/WOoDd0gIf/esu6CMqDe82Xhkc5WvJNwUFFJvytLavypObC+fI+WV7Hby5/u0ExuPdZceZ4O9bBx7J6o/JNCr1KUO3BIrhIF3BWVlfd6oQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=qHmqorGPiqKU1kxDm9dkMnJf57dw2Nb8XZdG0MJ9jEw=; b=BpsXINK+GkGPWFRkBEJ1d1P6liWojs4EgrfcSQDtY3nsNJ5caDd3i6JbRwneCBbQWDF3+L7R3CixMGsoaqCZKcB8vkwm/3Oj1qfGLhaS/rxm1AioNVH3LCdeQjWpPOsH1c6+UmZjZSCu86i5uSRwc/hjrj94FDZAqJMYYFC0KUiNSTdb4RTSUk6qrk3Tf2qg+Gs+kdqdXp5aiePxzsV2dEr4bdGE2hRTss2KZUZWbRr8gRoAT7DDfHz80YouHt/67xaM3WlRUGmqVkG51GetylT4kEURHAcYJSrnqHIzW+f4DhFckXBS59p+ugkIZpaE9VS9Dqr+8ryVRwh7bkw4Zg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=kunbus.com; dmarc=pass action=none header.from=kunbus.com; dkim=pass header.d=kunbus.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kunbus.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=qHmqorGPiqKU1kxDm9dkMnJf57dw2Nb8XZdG0MJ9jEw=; b=QWQ8DxD9jvfp64kfnKa+DZdR0Fo8tOqDQjxFzMifPYs+9chnXBKuO2n7NAakWE3Vnk+WmwqXed8oYvVrlvxkdsvoSIJry6YM/5IR+CLKQiQo+xjFHq4pyLCCrHUGc9HNgjzvVSCV6AL9zGr/fs+1ulZvXxRlWGJ+d5WXvC+67XI= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=kunbus.com; Received: from VI1P193MB0413.EURP193.PROD.OUTLOOK.COM (2603:10a6:803:4e::14) by PR3P193MB0555.EURP193.PROD.OUTLOOK.COM (2603:10a6:102:31::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7068.29; Sat, 9 Dec 2023 12:59:19 +0000 Received: from VI1P193MB0413.EURP193.PROD.OUTLOOK.COM ([fe80::653f:d0f3:e7f6:8c06]) by VI1P193MB0413.EURP193.PROD.OUTLOOK.COM ([fe80::653f:d0f3:e7f6:8c06%5]) with mapi id 15.20.7068.029; Sat, 9 Dec 2023 12:59:19 +0000 From: Lino Sanfilippo To: gregkh@linuxfoundation.org, jirislaby@kernel.org, ilpo.jarvinen@linux.intel.com Cc: u.kleine-koenig@pengutronix.de, shawnguo@kernel.org, s.hauer@pengutronix.de, mcoquelin.stm32@gmail.com, alexandre.torgue@foss.st.com, cniedermaier@dh-electronics.com, hugo@hugovil.com, linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, LinoSanfilippo@gmx.de, lukas@wunner.de, p.rosenberger@kunbus.com, Lino Sanfilippo , stable@vger.kernel.org Subject: [PATCH v5 5/7] serial: core, imx: do not set RS485 enabled if it is not supported Date: Sat, 9 Dec 2023 13:58:34 +0100 Message-ID: <20231209125836.16294-6-l.sanfilippo@kunbus.com> X-Mailer: git-send-email 2.42.0 In-Reply-To: <20231209125836.16294-1-l.sanfilippo@kunbus.com> References: <20231209125836.16294-1-l.sanfilippo@kunbus.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: FR3P281CA0070.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:4b::22) To VI1P193MB0413.EURP193.PROD.OUTLOOK.COM (2603:10a6:803:4e::14) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VI1P193MB0413:EE_|PR3P193MB0555:EE_ X-MS-Office365-Filtering-Correlation-Id: fd583afb-b76f-49bd-9a10-08dbf8b6a84b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: LuWzlqxT404t32a5H3O7UTs/oIv7w3VLSgR+vV4JuYI4sbcX48eYcXlSk4iVdfqad25mW36LCl+0x8Z4lSenuEJEPvo0Wts3oXo7SiO4310M3egN8SJZzVwRHbwK0ugqwwt0QcU6ECS1OxMYz7ef2ONdlHgI79QtBjdzMSRY5+Pzv5xr/i39ipxFcYiEQMq9Vr0fHCP9d+oajmycb+RjTMhz/KNHXo7BRU2fRkWv4+nPy/+JGLvqLqfPJw74CepFljpxvqzOSElMK85PTavxjMbp3g4HvG0CPGzNoP+xvd6QpJRlDnN7ivmYXFfRQk8eSlrZ4pacsEKUTo7GTAMZxwh+pp+sCHqced8e2fsUYXcOsxkSlNaJ58hZj+UCyvbEO42AaJssYUNXhoWqxpcjVCnm3imT1EiAQJp3cH1HPmJ4rgPyxU5J8RwLOUhCHc8b5uL0XfiXCEd+8LOwK+p2Qr5P6sck43lcREoTQ6ORl+XcZuEvAOKhkUzrA9yprvv8F6x1XirZG0be7JNzW72SVNhpIcjG9rPtijgqs+MZDEkOQ5AgpotEJep3vinwWu2L X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1P193MB0413.EURP193.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230031)(39830400003)(366004)(376002)(396003)(346002)(136003)(230922051799003)(186009)(1800799012)(64100799003)(451199024)(2616005)(1076003)(478600001)(6506007)(6666004)(52116002)(6512007)(41300700001)(83380400001)(5660300002)(2906002)(4326008)(8676002)(8936002)(7416002)(6486002)(66946007)(316002)(66476007)(66556008)(38100700002)(86362001)(36756003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eC93VnJsZWtwVTdwaERPNEhLZnVVN2VIT3BhTGVhdkNqeGEzN0ZsOGIxQ3VC?= =?utf-8?B?UjU1M0JyRjBFRmlub1lYRWs5VVE2R0xVMHhpNlMwM3JDeThRVHRoamNoNUNl?= =?utf-8?B?a0FGTTJGZHhncTlCQlh3Y1FCRk5ldFozeXNyQ2Z5bXhCcVdKd3crYis4S3FT?= =?utf-8?B?N0Fpc0VtKzFGY2hESnlmeW1rOUd5VlB5UURwaGRtQStHV1VxT2Jxd3lQZDFq?= =?utf-8?B?N1FyVzhMYktKemlndlhOTGhxcE8wSDVOVlM1eHNNY1F0UVlyNjN6OFZPTTJx?= =?utf-8?B?aFl2SWpEbC9VQlFYNVlwWVlRZXZlSS9oUFJHRVFRaFlBRjVlaXkxQ1k2YWUx?= =?utf-8?B?T0p6RlJnOFp0czY4WjF6cmlERnBDZGxhdDdISnJLYWRRRUxzbHdhN29lUWtL?= =?utf-8?B?Sk83allPZEFwY3R0Um54QzEzSlB1TFlaWkcvWHZNRnBmcmE0d3JaSG1tcFIr?= =?utf-8?B?bThPTzd1YmdkM21xM1M4czc0VEFsV3NSL1NXMlZZMmgwVGlHWDdSejhwMGc4?= =?utf-8?B?QXBUZE52T2FZTTdyNzVlc2FmbWtzT0g1TVlCUE8wSitKdWVxN0NmandDWDBZ?= =?utf-8?B?RmoyMEdjeTJoK0xQK0tycmVWTEV1WTlQcmpGcnQ4MUVOSCtaR1k5VW40MS9u?= =?utf-8?B?OEswdzNYVWw5ZGgxcEh3ZExwRzlOK2JTZW9HbCtHcDVvbUVMbk55cVptWDNZ?= =?utf-8?B?K1JiTCtvZytoMHhORmU0VjVBTGZKbnZqUTJwYmwzMm1uTTl5SzFGcFQ5LzV3?= =?utf-8?B?Z1hUVnh5dzlzY1RmWmVZZ2x3Y3NIdFIwMnNPejRiamsvVEROTEFVOWZQakla?= =?utf-8?B?OGRUNXQ5WVk3SkJMSjFoazNhZHhWelp1WDVOSURRdnl3WVRzRUtKVVltem1h?= =?utf-8?B?em9MQ1o5TDRlM3ZZZ09FQUs1SGlZVk9RM0FnaUNqaTFpS1h3L0tXdHZWd3pU?= =?utf-8?B?SlE2ckg5SUFLT1BTVVdITkI1Q1RRVHFQVy8wWFJBcjN3eWVjNDJRV2Q2YU9F?= =?utf-8?B?NlFOeDYycFdESXoyaDR4V29leHVnUXdSUGk4bTJQVFJFRFdHTDFaM2NzT0Js?= =?utf-8?B?L3RZTkcyY0FPZ2ZtSytJMEZCUUFTaUFWWlRuUnZKU010Um11b3hiNnA0SWs0?= =?utf-8?B?dG5iUjBQYWg2ejRubmIyVUZwZzZzc0EyTGRGZGVwb0pjbTd5ZnZ2SGhkYjgv?= =?utf-8?B?Q2MyTEVvc1JDYnpsekNXZmNsbEhhMUJrcDMwV0RpTDdYZ2ZZbDVMWVIwRFFZ?= =?utf-8?B?T0g3ZWJYSFNaWDhjblBYb21LTElsVm16QTJVT3V1WGgzY3E1anFTd1RvSnhI?= =?utf-8?B?QWtjQVMxRkw4RVo1WUwrSVJNTGRuWEphajlBMnhrRWJBdktZenNEY3gwMG1T?= =?utf-8?B?S0NxaU5EZklaRGV6K0R4MDFYYzRvR0hZeFJiTVQ0MGRKVGVZTlhQVDZ2NVNy?= =?utf-8?B?Wndnclh6THBQVE9rQVV4T2ZINDBNYjJWYXB0cnVGMHJTY01KN2k5Wm54R3Zk?= =?utf-8?B?Tnd5UXo0Z0VuS2U0TmNoS0gyYld4NExnRE12ajBsUFNlTkxWeTM3azhJWGpW?= =?utf-8?B?U3Z0L1JDc1RpVmhiSmRobmY2d2dYVE5GZGtIVnU3WFJHTEJFaXFvb1ZmNW1n?= =?utf-8?B?blVPRnFnaENGQlh0QWRQRkJLOXExTHowSk9YT0JleVh3QVZEcXErcXE4K1V2?= =?utf-8?B?OUhqU05uWTdMdmR5cmRqa2NuSjU0bzhJZDQ1cEkzL1U1cG0vNFRTU2oxalE1?= =?utf-8?B?OEVYbDFsZ0xjSHJlc1ZxMGFPQUtSMzZLRStPVDV4Q2RsdnZMOVRla0pQbEFK?= =?utf-8?B?Y3JjWmlGWTN6Z2JtVUFBVzRkWEFMVHNzV2I5bGdHNVA2M1VINzBtWWtVei9S?= =?utf-8?B?VDZJWkRzeU1YaUhHR2dHQzk3WEFxWU5hME45VEpwSWVuNVpPUFNoTzNvZWU3?= =?utf-8?B?ZnZESVZTaFRhSUVIT200QjJ4M1hZTTFWaFN3ZWdhNEdrTmg1cXdSbkJCQ0Y4?= =?utf-8?B?TFB5clZPdDBueEE5aU9kZjZxVjVaY2YvZkR4cUhaNVV2aHNLS0dkcFNkdkV5?= =?utf-8?B?a1I1VDZJRVFLbytuaWZFbXFrTU1XRmRsTnRqVkgxbXB0bVgxclc3b2JjQlFO?= =?utf-8?B?Z3plc0FTTFFDREZiRmFJd05wZWY0R1RvdFZjVnNmMnoxVFBDN2h1eVMvMXI4?= =?utf-8?Q?3h6CrGm3CXM6B/MStZJYzZCCXa3j4zemLVnGjnOZiB4d?= X-OriginatorOrg: kunbus.com X-MS-Exchange-CrossTenant-Network-Message-Id: fd583afb-b76f-49bd-9a10-08dbf8b6a84b X-MS-Exchange-CrossTenant-AuthSource: VI1P193MB0413.EURP193.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Dec 2023 12:59:19.5497 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: aaa4d814-e659-4b0a-9698-1c671f11520b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: rMQLiMbnIIPC2Sll4u+t26Qb1EKC2d0xMOQtvD4hEonnn6q3SRuW7y7s5zoAHVrmu1dOrpxMGChWr685cgFnpg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3P193MB0555 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" If the imx driver cannot support RS485 it sets the ports rs485_supported structure to NULL. But it still calls uart_get_rs485_mode() which may set the RS485_ENABLED flag nevertheless. This may lead to an attempt to configure RS485 even if it is not supported when the flag is evaluated in uart_configure_port() at port startup. Avoid this by bailing out of uart_get_rs485_mode() if the RS485_ENABLED flag is not supported by the caller. With this fix a check for RTS availability is now obsolete in the imx driver, since it can not evaluate to true any more. Remove this check, too. Fixes: 00d7a00e2a6f ("serial: imx: Fill in rs485_supported") Cc: Shawn Guo Cc: Sascha Hauer Cc: stable@vger.kernel.org Suggested-by: Uwe Kleine-K=C3=B6nig Signed-off-by: Lino Sanfilippo --- drivers/tty/serial/imx.c | 4 ---- drivers/tty/serial/serial_core.c | 3 +++ 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/tty/serial/imx.c b/drivers/tty/serial/imx.c index 9cffeb23112b..98b78d360a74 100644 --- a/drivers/tty/serial/imx.c +++ b/drivers/tty/serial/imx.c @@ -2328,10 +2328,6 @@ static int imx_uart_probe(struct platform_device *pd= ev) return ret; } =20 - if (sport->port.rs485.flags & SER_RS485_ENABLED && - (!sport->have_rtscts && !sport->have_rtsgpio)) - dev_err(&pdev->dev, "no RTS control, disabling rs485\n"); - /* * If using the i.MX UART RTS/CTS control then the RTS (CTS_B) * signal cannot be set low during transmission in case the diff --git a/drivers/tty/serial/serial_core.c b/drivers/tty/serial/serial_c= ore.c index 661074ab8edb..b418952c03df 100644 --- a/drivers/tty/serial/serial_core.c +++ b/drivers/tty/serial/serial_core.c @@ -3593,6 +3593,9 @@ int uart_get_rs485_mode(struct uart_port *port) u32 rs485_delay[2]; int ret; =20 + if (!(port->rs485_supported.flags & SER_RS485_ENABLED)) + return 0; + ret =3D device_property_read_u32_array(dev, "rs485-rts-delay", rs485_delay, 2); if (!ret) { --=20 2.42.0 From nobody Fri Dec 19 11:32:31 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 16309C4167B for ; Sat, 9 Dec 2023 12:59:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230302AbjLIM7d (ORCPT ); Sat, 9 Dec 2023 07:59:33 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45058 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230204AbjLIM7Y (ORCPT ); Sat, 9 Dec 2023 07:59:24 -0500 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04on2043.outbound.protection.outlook.com [40.107.7.43]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E3BD41710; Sat, 9 Dec 2023 04:59:28 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ijlLalFUnd58B664TWlflMLEeLslyOH3d3otA/GuOO1LADVYwdJzpK/ThsU+KLCkh3bja++zbnbJOpqej2Bxf2AzJ/8LVBoZGm4RbGHgPl/C7TzUYWGIHH61LkImFxxeaUE+UDEU7cZBL/DqBHV45ASPo0IA6nb+BdHK6KvgdwwWPo/2m6BrTqJBfzRG+GrzvwqGRLllej+1SoC/mIUCg7WjPigjWmTFx7mP/9NbPuzqSX8J6n7dyiugDlB5ozAR+k1f2+voF2prT5Sv384h0+OlIz9mL+YEEU3qgj2zeRXOw2pEa4cYhhXx7ggmodC6VhAlVpJb0HL+4+NuSpOOuQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9sRBm8gY2tDiUYzcClFGE54s4heCXu5xxHjSH1pF67Q=; b=TugaFAE9ED7qPyWXPcQlfTlWcweypeRjV3wLXu4rj4LImE5CCYxWrRPpFnsbUglVolx1zxQt3C6WtTWA1I4dW6OssYXW0m9kHGTFr3Qs1CZ0k1EfjtHXmcZrwhdN5Hg6A8qSloWufIotdJBKaNDeYE+Hw7/wOaKOdKXt8e4UWW9RBoUh9YNIyzRhLfVFsQIfHSGzhhhUFEELmWunBXzNqlGPt5Em8XgzeHzUHJcqIre9sY9c3QX0fKKOYVVEZinaqxjBv32/uppGOM+EF1cwkep4OoJomBDYZVWnqEIttwEOjqYvyLI7FZURhCKVdo79EiLSSbOuYNAsLy6zd0+XGw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=kunbus.com; dmarc=pass action=none header.from=kunbus.com; dkim=pass header.d=kunbus.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kunbus.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9sRBm8gY2tDiUYzcClFGE54s4heCXu5xxHjSH1pF67Q=; b=qksT3Z4zN12YlmRmem2YRYEX1joJ5sDCl3xYn5KebEQdLop1ztYk7fCfWeOwFiKuyzBydh8fgkCfOM3bK9Jbq1AX67OyvXwY2Yckp5HAha2y66MsslKj5Q5fIqPtMDAEw4y3WtTuoi0SCeHTwMwd4PQdTqtuEiAWahjhhEoNu1M= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=kunbus.com; Received: from VI1P193MB0413.EURP193.PROD.OUTLOOK.COM (2603:10a6:803:4e::14) by PR3P193MB0555.EURP193.PROD.OUTLOOK.COM (2603:10a6:102:31::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7068.29; Sat, 9 Dec 2023 12:59:20 +0000 Received: from VI1P193MB0413.EURP193.PROD.OUTLOOK.COM ([fe80::653f:d0f3:e7f6:8c06]) by VI1P193MB0413.EURP193.PROD.OUTLOOK.COM ([fe80::653f:d0f3:e7f6:8c06%5]) with mapi id 15.20.7068.029; Sat, 9 Dec 2023 12:59:20 +0000 From: Lino Sanfilippo To: gregkh@linuxfoundation.org, jirislaby@kernel.org, ilpo.jarvinen@linux.intel.com Cc: u.kleine-koenig@pengutronix.de, shawnguo@kernel.org, s.hauer@pengutronix.de, mcoquelin.stm32@gmail.com, alexandre.torgue@foss.st.com, cniedermaier@dh-electronics.com, hugo@hugovil.com, linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, LinoSanfilippo@gmx.de, lukas@wunner.de, p.rosenberger@kunbus.com, Lino Sanfilippo , stable@vger.kernel.org Subject: [PATCH v5 6/7] serial: omap: do not override settings for RS485 support Date: Sat, 9 Dec 2023 13:58:35 +0100 Message-ID: <20231209125836.16294-7-l.sanfilippo@kunbus.com> X-Mailer: git-send-email 2.42.0 In-Reply-To: <20231209125836.16294-1-l.sanfilippo@kunbus.com> References: <20231209125836.16294-1-l.sanfilippo@kunbus.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: FR3P281CA0070.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:4b::22) To VI1P193MB0413.EURP193.PROD.OUTLOOK.COM (2603:10a6:803:4e::14) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VI1P193MB0413:EE_|PR3P193MB0555:EE_ X-MS-Office365-Filtering-Correlation-Id: 4b92f7cf-e711-4323-3316-08dbf8b6a8a6 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: uocdsEkqgHqFuSPW9Db0ig8290u2cJsSeIQ8+MdrJlNedicYd4ofc+vS+sHO9w5hlubaXkLiBEIM99yOCkKQbsYBGdesGqoWfZW2J2PCU1GLtpyQAmDeiGKpNV6XyXF1PKsmHqav3+pu3n/wBBhL199VtacrAZ6ofdLPBy7JarejIr55TatDv+Ai29dT311fwGn6XVvyadXwB4+f3mRS7IOml04l+bukE/QaJ9NoiRAJqkor0ofyncXHiC71UvLfGQCpNFsY9MXhyEJk/gCbCk7SbO0iJ/pTqon86oL+L5DRV8C2PZSKjXuyW9Wr1SUnMA2F+jKs4s+pa5CALCrix1YANjm2hwZKasb1vLMl2yL/AYidlKhEQwCE6s4ii3BqsWBBIIFM20Q7n8fPgHjKA50xjEqmzaSLbRGdwUalaAphcCRgnSX0/4+XvBWkshcqIEsvZ3kmoLl+K0WkNOlx6RD23rWMlbnBI0bITK7yBVlljvEL4yNrZBre+v0aW5dCef/TYhdY6usjmn8aK4w+NmpxE17T5ybG37wc8E1JWG1Acv+V7qwWEZyFKMi8Xd/+ X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1P193MB0413.EURP193.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230031)(39830400003)(366004)(376002)(396003)(346002)(136003)(230922051799003)(186009)(1800799012)(64100799003)(451199024)(2616005)(1076003)(478600001)(6506007)(6666004)(52116002)(6512007)(41300700001)(83380400001)(5660300002)(2906002)(4326008)(8676002)(8936002)(7416002)(6486002)(66946007)(316002)(66476007)(66556008)(38100700002)(86362001)(36756003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?jBF3AoWOhWizXLv9eydv7WNO1zPuQVG12NhpoN3RyxWyKCH3WraxafTSnOw7?= =?us-ascii?Q?D5wz+tKhwCHbDWALIaqCripH0IirovHsRrgW8ZJ+CLElo7u9d7vVvad7qfTn?= =?us-ascii?Q?IzmL3+bUtwt/Bg4nAKZRBYcbq/yWzm2Fq6qkTNjmG7j/E5JLfmujdAjBSSPy?= =?us-ascii?Q?9yVnYYDMK8qpuApr8HqLA1o77AtzToyZPtoYfeGYBjj7Ox3sTrs8zHzupJYE?= =?us-ascii?Q?/BfesAITyc7y0tGsB6zflNyQT8UAdeWAnTZUQyk9il9CKl6kKz4TkwhPlmzZ?= =?us-ascii?Q?7OsrTwcO2Enkx9mmCWeMBm3hYRQpGM5QaTDjYt4tyUZTD2oRhu6h6NZi5xF3?= =?us-ascii?Q?LULFf1X8GcvLF+RZaWCc18RM7ARLpUVy4RtfEN9Pj4vagXLIkOkUe0T57cAa?= =?us-ascii?Q?e7T+/4SzAy602IxhCXG5pPAbh6CQXXZW4J8YHCLHDAmcMXLl+v2uzSpSlIOY?= =?us-ascii?Q?C3ZpZ3DweSqfEAnBcEMjbXXAk8zs8pmAtpOdLByYz0ydQX1AoPqHDtfj3sRu?= =?us-ascii?Q?CNxoWegPZQCf0mYacLzK6Qsclcv76KX3AW2ihyeK/1S6x1hPEmNwl7AXWGpM?= =?us-ascii?Q?J2RZgydempLTSKCdE+e1Klu38DbtvqGBSk4j1yKY6wNMTXJNZFwEjgXabbjk?= =?us-ascii?Q?h+dxQ+MSuLp6vR/j4iYebm31rqTtSc/F4apmYLo7gdMz1FxxyP5PWgUJnTlF?= =?us-ascii?Q?Ah2aK6J36cBnpnRVEhr5BOxgRL62jLJaFNXjDYNHxL1IbN4gIp3q87zolNVl?= =?us-ascii?Q?gMtZmH+mZzHLVIFHDMO0rSjWL5WkP28C1r5W1t34QHBglITTYeW9dzGQ/MGk?= =?us-ascii?Q?S4SfsvL3GUpGxISQb6VTuGEst8OPbyKftcCYZSDtpDBp6n1X/Bssmbr+Q9Lc?= =?us-ascii?Q?MdOfN08NcmLLz+Xt19dNXgJTw8sFbmbcPCDKyQh72avuWUYYlqfrBg5y202S?= =?us-ascii?Q?8Ec5mDEbmdk5hej0C67QuAPRbvm0SQrxG7MK5ENhpx8XLNOMs7TGXmuS+60p?= =?us-ascii?Q?i6lk5hpozwpKFHbFF4mI7DM85t/CmxdOyO5DuzuXpeQsNQhxeF5StxxSYSUc?= =?us-ascii?Q?zGHTArhCHGHTwYBsMz6y8xM4BJSEB55ktMXKsBFTW6SmQyXbmFY38kYcKEVb?= =?us-ascii?Q?2Na/K6YAcHkmLtXpWdrDRnprgDAlGATMtTAoWcr97KTZif+InBNtTITp2z3m?= =?us-ascii?Q?ptgdhXKehD6iAFae9KDTuSGDnCjbIEKRzccfebs9JDpDxE4mC4+lBOxb0hoT?= =?us-ascii?Q?fdspydvq7kWl/8UJpu98KfE4ShuNbKTG3yEl67U9paah3NmCv/cUZ2zpEv7N?= =?us-ascii?Q?omw6LL/IzcOqHA5TRpwat9Sar3nu6FhMhDVKtG5SW1j//LxpSLnwKs/8AldN?= =?us-ascii?Q?1uvK9uyPfXAS8PAuV6pDcTS3QxtusaRpQkSZbScguIEWW5G4tWyEO9p0fYgX?= =?us-ascii?Q?tv/osyeJzO3QM76T2FdN8eH3ecRLWi2KVz/lipEGlSay2LV9/3CmCgCCbN0g?= =?us-ascii?Q?/1nfqJuyDWwJCG/zSA7YyJwoTJKlCvmwbljW9WglvrD3/IuTNEA6W96RF/m9?= =?us-ascii?Q?MKBOE5RFiusRPisXMlJCMzIEQDYih+RYpV/8UfOkzQsCDdULCQLc0LudCZ8c?= =?us-ascii?Q?tIN/YBySkSo2B9tBBKJtbLCNOvQV/qaT5d8DaiedLzjB?= X-OriginatorOrg: kunbus.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4b92f7cf-e711-4323-3316-08dbf8b6a8a6 X-MS-Exchange-CrossTenant-AuthSource: VI1P193MB0413.EURP193.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Dec 2023 12:59:20.1656 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: aaa4d814-e659-4b0a-9698-1c671f11520b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: p0C5MMCwIzJn5shFRgodHEu4/CkWsEMAgQyEPFNOdeHMsaKrSzYmgNQwozv/tZsd5d4fmpV7RKHEPUgB2wLvzw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3P193MB0555 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" In serial_omap_rs485() RS485 support may be deactivated due to a missing RTS GPIO. This is done by nullifying the ports rs485_supported struct. After that however the serial_omap_rs485_supported struct is assigned to the same structure unconditionally, which results in an unintended reactivation of RS485 support. Fix this by callling serial_omap_rs485() after the assignment of rs485_supported. Fixes: e2752ae3cfc9 ("serial: omap: Disallow RS-485 if rts-gpio is not spec= ified") Cc: stable@vger.kernel.org Signed-off-by: Lino Sanfilippo --- drivers/tty/serial/omap-serial.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/tty/serial/omap-serial.c b/drivers/tty/serial/omap-ser= ial.c index ad4c1c5d0a7f..d9b2936308c4 100644 --- a/drivers/tty/serial/omap-serial.c +++ b/drivers/tty/serial/omap-serial.c @@ -1604,10 +1604,6 @@ static int serial_omap_probe(struct platform_device = *pdev) dev_info(up->port.dev, "no wakeirq for uart%d\n", up->port.line); =20 - ret =3D serial_omap_probe_rs485(up, &pdev->dev); - if (ret < 0) - goto err_rs485; - sprintf(up->name, "OMAP UART%d", up->port.line); up->port.mapbase =3D mem->start; up->port.membase =3D base; @@ -1622,6 +1618,10 @@ static int serial_omap_probe(struct platform_device = *pdev) DEFAULT_CLK_SPEED); } =20 + ret =3D serial_omap_probe_rs485(up, &pdev->dev); + if (ret < 0) + goto err_rs485; + up->latency =3D PM_QOS_CPU_LATENCY_DEFAULT_VALUE; up->calc_latency =3D PM_QOS_CPU_LATENCY_DEFAULT_VALUE; cpu_latency_qos_add_request(&up->pm_qos_request, up->latency); --=20 2.42.0 From nobody Fri Dec 19 11:32:31 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D6B4DC4167B for ; Sat, 9 Dec 2023 12:59:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230388AbjLIM7l (ORCPT ); Sat, 9 Dec 2023 07:59:41 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45070 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230252AbjLIM7Z (ORCPT ); Sat, 9 Dec 2023 07:59:25 -0500 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04on2043.outbound.protection.outlook.com [40.107.7.43]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2DCB71724; Sat, 9 Dec 2023 04:59:30 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PGVldkkRPUKN9fDU3woKlupuoUDpVmI60cp6menB2RCXvO2hDF+NhgdGLfY/p2R13OqHjQGygQm+xQiRG2REbYWnVq/aaUYY+iQMq6Gji+cWJZ7Qvw3Cn9s1gYmjhA/BFi9y40ZfneXO5jqy3A8qpPCUnUTBX4xLbVlOPpzvVLj8rKrhkmVARHl5VMk3X8TJVA/m7EeU2F04PDV48tCDd0D72y/naEJZSRwzJznm3C8kHsbmAqiWKxqrhM3FcalGfckcvqJQa+1wWMAgxFLeDtaOAncG6jIANFSr13TzBX7DT+3Dpr7he7CROxQ26QyREAaonr0e9Kd96E9OIfGlBA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=CCBLbQLe3EP2f7hu3Tl5EQiwyecLdsnuvnoNW4MOtrQ=; b=Fwi/S4hdEVpgiDtN806+kDfa6X+4p6EBkB9WXKXueyHTh5ud70iRhp+xou6FNVCTQ+fjJrkg+NvPPzhUDD4vjY1oWVQ6072gSmpd6qSgv+e37z7s1n7J7+lDnsrlMcZIhq8k9isNDZqCgUCSu0HA9eJhRIFmfdZ2II1tjOTq8jKravLHZiqcB8UbjoHUXjzYdnst0bsMnFYC5CBmTdTEopSpxFiSqaBvmo0A68RuPk95zh2OcRNHwdN0oKLBIyYKHZbJpi8NKuyOr4iPDoTvJ4quombglmKjTr/LFrE3WgWHqCTW4s6CFg0ej+HkeDJ5jL64Ahg/HPoDCeab7S63IA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=kunbus.com; dmarc=pass action=none header.from=kunbus.com; dkim=pass header.d=kunbus.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kunbus.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=CCBLbQLe3EP2f7hu3Tl5EQiwyecLdsnuvnoNW4MOtrQ=; b=kimpEe5ZaxqTZLyzmHr8rBvqCP+1KPZWLa9ycVO0djZOW42oDoVha/oUxD3mODCeQKJdYa3QuYQBdN41kZj7jp/isMYL014imhFTXF3M3BqMk3qk5IifVDkWy11QncQNY+9TdQhepXMRbIec/lcwMxA6CsDuDt7CBWpyEzMpe5I= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=kunbus.com; Received: from VI1P193MB0413.EURP193.PROD.OUTLOOK.COM (2603:10a6:803:4e::14) by PR3P193MB0555.EURP193.PROD.OUTLOOK.COM (2603:10a6:102:31::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7068.29; Sat, 9 Dec 2023 12:59:20 +0000 Received: from VI1P193MB0413.EURP193.PROD.OUTLOOK.COM ([fe80::653f:d0f3:e7f6:8c06]) by VI1P193MB0413.EURP193.PROD.OUTLOOK.COM ([fe80::653f:d0f3:e7f6:8c06%5]) with mapi id 15.20.7068.029; Sat, 9 Dec 2023 12:59:20 +0000 From: Lino Sanfilippo To: gregkh@linuxfoundation.org, jirislaby@kernel.org, ilpo.jarvinen@linux.intel.com Cc: u.kleine-koenig@pengutronix.de, shawnguo@kernel.org, s.hauer@pengutronix.de, mcoquelin.stm32@gmail.com, alexandre.torgue@foss.st.com, cniedermaier@dh-electronics.com, hugo@hugovil.com, linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, LinoSanfilippo@gmx.de, lukas@wunner.de, p.rosenberger@kunbus.com, Lino Sanfilippo , stable@vger.kernel.org Subject: [PATCH v5 7/7] serial: 8250_exar: Set missing rs485_supported flag Date: Sat, 9 Dec 2023 13:58:36 +0100 Message-ID: <20231209125836.16294-8-l.sanfilippo@kunbus.com> X-Mailer: git-send-email 2.42.0 In-Reply-To: <20231209125836.16294-1-l.sanfilippo@kunbus.com> References: <20231209125836.16294-1-l.sanfilippo@kunbus.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: FR3P281CA0070.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:4b::22) To VI1P193MB0413.EURP193.PROD.OUTLOOK.COM (2603:10a6:803:4e::14) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VI1P193MB0413:EE_|PR3P193MB0555:EE_ X-MS-Office365-Filtering-Correlation-Id: d1e739ce-24e5-4821-f388-08dbf8b6a907 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: AOdQDXFfhLn82yElBF2NN57d/Ps8IlmMgi90v/OgrHeBwyXPgg4Wsae5jzyvwzgJvpJlKXVh5DsR9XGMOEm5Y4UW1m4doefPTZ9JssvkEDbAXzjYsmA7p2KKLmtvclxLOTI58QUKnk9UqIbqpvHmA0d36BCCBCVAud57RHnFXo8qK++9eU2wMqNe0LQdS9HD4breF53VDW3z78fN3NQZUIRBdA6s+7aHqQQ8J5wIYZDAT8cG4aFPCwDJ2W7bAZlfM7Wh//3sCSWBw0IWjduv48CyVpCM+HMKpOy6lNhhq3mWruIPNmG5HUpRxmHqwzSYNvWDAvjDcUkvaVDVGXaAeuHuPdJX6BblvDlmINNYCApW38mK5BMKmHP6cnkN6tbedl1S6VNznOLsekWX6UYfWOggU9QxvMy9rpYgIX0a+JcWU+UjXwrX8MgYz/GngovHhNZlhi7nzUc5k6Zr58K2zXPv9J5IltLGfQsG95O2hD+LozT1mtVFaok/xmplLywzrHEXY01SjeJxwYCa+K2cOGGhOZJjOm2WLVQDn//EoiRuNiJ2g4i38RPKNxiXVd9oRiPVkm/PIi1kgNQw+i1fVzDRjGl3JH95k/xEni/A9tRvGVkSksclKLHPTgj/YQ7a X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1P193MB0413.EURP193.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230031)(39830400003)(366004)(376002)(396003)(346002)(136003)(230922051799003)(230273577357003)(230173577357003)(186009)(1800799012)(64100799003)(451199024)(2616005)(1076003)(478600001)(6506007)(6666004)(52116002)(6512007)(41300700001)(83380400001)(5660300002)(2906002)(4326008)(8676002)(8936002)(7416002)(6486002)(66946007)(316002)(66476007)(66556008)(38100700002)(86362001)(36756003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Pdah+BdrJS/RxmI5EAukwsyKzXR/d122mSictOTuJ2IE0uMzKcGgYA2U86Hv?= =?us-ascii?Q?BQ7K+NXwX9EYpa+vuGtK1qEudr5QGGF1BxWUnGLlITsXC+AT+yW76tPpjEFp?= =?us-ascii?Q?tg+/Vbo7Dxqg2i43hzSCF4zpKr8FIJANkTDO6dYoJKoZHc1VFflBAH5cBYLN?= =?us-ascii?Q?pvrGJ2+9tPIl/AooaEXNJIKcPxrrPjZVrve3ATPdzK1A+pP/TnMLpNWWVFfY?= =?us-ascii?Q?IhT5nYXcMzi1S9vN1+s8Hz7teh/Fy4rJK++6zs2fS+7nNhn5aGRZat0Tpg3+?= =?us-ascii?Q?HDLZ3qkSI/zPCLEPIhMsAbDqpAjTeJQuUF+TnArVJ3IqeXyF3fDKZGLV1CWi?= =?us-ascii?Q?EpGlEFO9q1KDlNA1qAaHwaudZyxUrGuTyCHRknTVvWnuFquPRlKBtMSZACR0?= =?us-ascii?Q?6QZ9ZnWWoQmwgY1h2TEeTtKj6CsIuZeCb+CrIJ/xc1ORu++K3QKcJLvkbd27?= =?us-ascii?Q?0uCaYgRNjsOE0E0iWNsLzUCW+MhJLJk1aNPTNB0tEatmVhUD1uphARwQdwdY?= =?us-ascii?Q?KdAKVb/jskUCUo+zA1j+GZZMvlBpDjkSZpIuNMLxNb8cGFeOxqKEdrc0sq+f?= =?us-ascii?Q?bURz4T2HLF/u2BKGuDQPhf2XpEs1PeZWQaRL5aYQiK8uCPEg3yUIfQB+qO79?= =?us-ascii?Q?oL1yrz6xdWD9Bd6K3mGiupUkFuabHqAzmDWboxYkCVeUX2Ms6a3UKTfN8LNS?= =?us-ascii?Q?rcYYiOciYVcaaXvd8JDcT6pmwYf4gBdOSbMhogZDZ6eYMuObjj8nwmtmlfcS?= =?us-ascii?Q?S0I4W0Yf5daONlspPgZapdpzB5qABL5SuBR39flDwe0MAeQCJi8RbHQODPtX?= =?us-ascii?Q?Y4Mo4n5dI1MiMFfoq2I9ie78lfz/I2oMSJYhLKn81BHr51G4COkbtYAF0Krh?= =?us-ascii?Q?TuFzZCsv+GYjXfwdckbpY5GEc/6v186JSjdbyMQuNm+y/LRYeeAJXmDW+SPO?= =?us-ascii?Q?QJyiUpJ9gOZ1pKswa5JSmfYG3NtbHEvDYc2d8jNVxBGqSrUAw7rBrPK4Nrin?= =?us-ascii?Q?vh4ktvGFbVPKrgl0W4VI4AgehChP9wzyv9O1PWZyoNyyzjpgIOnjojhi7xc8?= =?us-ascii?Q?kjVnDuRar19aCeTakmxD+oDNdjIkaBWiIF+VsfVYnnvbHv4JBsHnFHupRcIm?= =?us-ascii?Q?2cziBg5A6hLcpB2PvoDRBQUQVe6OuWOzP9YORAmUxZ3ohWLzArhcMmwX9nh8?= =?us-ascii?Q?V0h936QdpIpHjBb3DyKzczciZJeg9KEFZALzsroU1FZI+xCCumRtYWmzGSv1?= =?us-ascii?Q?E+Foxn5yjGIEZq18+0OYLKFFxgI8cQ/dIWlOry5dzBoKElNAbEbPBFrAiQNs?= =?us-ascii?Q?REjNk1K9sd5CovgWEvYIupsna5vCEbx5Nhm48btCGBWdnlVYnq7SB/NRh3mN?= =?us-ascii?Q?x5BpwyO3Uwe1XVqnpz+wMFgrBhWuAPxkbqIAyaYeAcLG0YFbe4Kn+mZzhzKz?= =?us-ascii?Q?AtPGKhiu9CQvfg1dy/hfeteu1+oCENsZkkXPs8waOCcqi8y7hg26+OURwRsl?= =?us-ascii?Q?kjtX/s2oOi5CZYCzry/CyGBmF4uOEg7vp5RyQri4YZsRWDYNyQTGEY5zgEEt?= =?us-ascii?Q?zR7uy8ym8tWkMN6r/VMQqbfeTw5Jpynz3NphEy88+kPQ+e6JSPZfMdghklX9?= =?us-ascii?Q?NoZk11Hm6tAYR5vLawqPX4/+4KlnCqcxcYyqkMjm87Vq?= X-OriginatorOrg: kunbus.com X-MS-Exchange-CrossTenant-Network-Message-Id: d1e739ce-24e5-4821-f388-08dbf8b6a907 X-MS-Exchange-CrossTenant-AuthSource: VI1P193MB0413.EURP193.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Dec 2023 12:59:20.8152 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: aaa4d814-e659-4b0a-9698-1c671f11520b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: +AQG1+7gcjayBSpolyk4t+yUcyYNDMEHxnW/LEaU6W2hCxBx8E/2dJGtP0MHUhF4bkewy3Xvb65XAZa19nu/5Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3P193MB0555 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" The UART supports an auto-RTS mode in which the RTS pin is automatically activated during transmission. So mark this mode as being supported even if RTS is not controlled by the driver but the UART. Also the serial core expects now at least one of both modes rts-on-send or rts-after-send to be supported. This is since during sanitization unsupported flags are deleted from a RS485 configuration set by userspace. However if the configuration ends up with both flags unset, the core prints a warning since it considers such a configuration invalid (see uart_sanitize_serial_rs485()). Cc: stable@vger.kernel.org Signed-off-by: Lino Sanfilippo Reviewed-by: Ilpo J=C3=A4rvinen --- drivers/tty/serial/8250/8250_exar.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/tty/serial/8250/8250_exar.c b/drivers/tty/serial/8250/= 8250_exar.c index 6085d356ad86..23366f868ae3 100644 --- a/drivers/tty/serial/8250/8250_exar.c +++ b/drivers/tty/serial/8250/8250_exar.c @@ -480,7 +480,7 @@ static int sealevel_rs485_config(struct uart_port *port= , struct ktermios *termio } =20 static const struct serial_rs485 generic_rs485_supported =3D { - .flags =3D SER_RS485_ENABLED, + .flags =3D SER_RS485_ENABLED | SER_RS485_RTS_ON_SEND, }; =20 static const struct exar8250_platform exar8250_default_platform =3D { @@ -524,7 +524,8 @@ static int iot2040_rs485_config(struct uart_port *port,= struct ktermios *termios } =20 static const struct serial_rs485 iot2040_rs485_supported =3D { - .flags =3D SER_RS485_ENABLED | SER_RS485_RX_DURING_TX | SER_RS485_TERMINA= TE_BUS, + .flags =3D SER_RS485_ENABLED | SER_RS485_RTS_ON_SEND | + SER_RS485_RX_DURING_TX | SER_RS485_TERMINATE_BUS, }; =20 static const struct property_entry iot2040_gpio_properties[] =3D { --=20 2.42.0