From nobody Wed Dec 17 08:26:58 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 14A15C4167B for ; Thu, 7 Dec 2023 20:39:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1443951AbjLGUjW (ORCPT ); Thu, 7 Dec 2023 15:39:22 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51540 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1443923AbjLGUjE (ORCPT ); Thu, 7 Dec 2023 15:39:04 -0500 Received: from mail-yb1-xb2a.google.com (mail-yb1-xb2a.google.com [IPv6:2607:f8b0:4864:20::b2a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7038E171C for ; Thu, 7 Dec 2023 12:39:10 -0800 (PST) Received: by mail-yb1-xb2a.google.com with SMTP id 3f1490d57ef6-d9b9adaf291so1451425276.1 for ; Thu, 07 Dec 2023 12:39:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1701981549; x=1702586349; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=pqzdM1JWQlsu7k/N7xBtV+SLaOrDoqGHT+SByeHgWqU=; b=eY5ZlxwE1hSRnhfKQrV24Asbw4s4UPiuLDhy/aKiQj49IPXodCdeunRlPOLo8JMaNS 0sOZDG2WIyim06uB+hi66gsxpyUeTvD54SE4bmbRuXmd+NoY5u6nhCQ8fDp3MzVscJeo yeYN47pH4Ps72xWd99Ati6TWtoqQdXRumx7E87bOvaicaZN3zHH57z6vntgd7OH1mYCN wu/zTKXwAsesaT7cWruCDIBBQAUO7KIWg0gQqYlnc/QfXP3NZUFQz7bc/QuYC9ORBOtI +hcQOYNQawUsG4ritMFzpa4vahqVbji+eZGlYGrpNzJsdvZIerXZ1UI8t6hbnA7TUntL JbDQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701981549; x=1702586349; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=pqzdM1JWQlsu7k/N7xBtV+SLaOrDoqGHT+SByeHgWqU=; b=vpcs1v0z0/FZygKiJxF0wvIUoOjlqRwy0AlWhZ+qZ1TFHU3Hoh90+YSMX1eSubTzQm Au5oMIFx9yhyRmmfIXs3t2XrccelUV+a3CID56aGPxrXPx4udYKTyyMAqeNeYGu702s8 Zj3+tYvlb+BjLI3OSxOKeM484WZnEA7WSGJbMiiU/lrncljZ4tuiimQArVUHZqXC7ezQ CgH11Q3gGob3VDqQQxBeLjeBm2OwWceMuDIH4hnD78FFp18qslDH/BQLEqMCX3p3+jp4 lzRu5p+0EXBoor3e3HIehese4W8G+O1LbubLxCKM+kg8rICR6mv+ICiZUYEr8DCc/OOj UPFQ== X-Gm-Message-State: AOJu0YwW44dbQIJO67jJEUoQW9NKROrAv5NiP7h+BT+jv//EMcqmlskZ lcfKUTvXeb6hSxzwKVCK3XM= X-Google-Smtp-Source: AGHT+IH+tKfirfTfmD2dg4eYtMxnJm2/WGGr9CaK2O7JxG9U/sPfP1dhWUdUy23PTlCq/IILz+U1Tw== X-Received: by 2002:a25:c2c5:0:b0:db5:4cc0:68dd with SMTP id s188-20020a25c2c5000000b00db54cc068ddmr2565491ybf.21.1701981549533; Thu, 07 Dec 2023 12:39:09 -0800 (PST) Received: from localhost ([2601:344:8301:57f0:8f7f:efcd:5388:af4f]) by smtp.gmail.com with ESMTPSA id 186-20020a2505c3000000b00da0c49a588asm146925ybf.8.2023.12.07.12.39.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 Dec 2023 12:39:09 -0800 (PST) From: Yury Norov To: Andrew Morton , Thomas Gleixner , linux-kernel@vger.kernel.org Cc: Yury Norov , Ming Lei , Andy Shevchenko , Rasmus Villemoes Subject: [PATCH 5/6] lib/cgroup_cpus.c: don't zero cpumasks in group_cpus_evenly() on allocation Date: Thu, 7 Dec 2023 12:38:59 -0800 Message-Id: <20231207203900.859776-6-yury.norov@gmail.com> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20231207203900.859776-1-yury.norov@gmail.com> References: <20231207203900.859776-1-yury.norov@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" nmsk and npresmsk are both allocated with zalloc_cpumask_var(), but they are initialized by copying later in the code, and so may be allocated uninitialized. Signed-off-by: Yury Norov --- lib/group_cpus.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/group_cpus.c b/lib/group_cpus.c index cded3c8ea63b..c7fcd04c87bf 100644 --- a/lib/group_cpus.c +++ b/lib/group_cpus.c @@ -347,10 +347,10 @@ struct cpumask *group_cpus_evenly(unsigned int numgrp= s) int ret =3D -ENOMEM; struct cpumask *masks =3D NULL; =20 - if (!zalloc_cpumask_var(&nmsk, GFP_KERNEL)) + if (!alloc_cpumask_var(&nmsk, GFP_KERNEL)) return NULL; =20 - if (!zalloc_cpumask_var(&npresmsk, GFP_KERNEL)) + if (!alloc_cpumask_var(&npresmsk, GFP_KERNEL)) goto fail_nmsk; =20 node_to_cpumask =3D alloc_node_to_cpumask(); --=20 2.40.1