From nobody Fri Dec 19 09:31:25 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 060C9C4167B for ; Thu, 7 Dec 2023 08:21:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231557AbjLGIUy (ORCPT ); Thu, 7 Dec 2023 03:20:54 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37784 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231829AbjLGIUS (ORCPT ); Thu, 7 Dec 2023 03:20:18 -0500 Received: from szxga03-in.huawei.com (szxga03-in.huawei.com [45.249.212.189]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1D26A10DE; Thu, 7 Dec 2023 00:20:22 -0800 (PST) Received: from canpemm500009.china.huawei.com (unknown [172.30.72.55]) by szxga03-in.huawei.com (SkyGuard) with ESMTP id 4Sm6X82K1wz14LrL; Thu, 7 Dec 2023 16:15:20 +0800 (CST) Received: from localhost.localdomain (10.50.165.33) by canpemm500009.china.huawei.com (7.192.105.203) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Thu, 7 Dec 2023 16:20:19 +0800 From: Yicong Yang To: , , , , , , , , , , CC: , , , Subject: [PATCH 1/2] perf header: Fix one memory leakage in perf_event__fprintf_event_update() Date: Thu, 7 Dec 2023 16:16:34 +0800 Message-ID: <20231207081635.8427-2-yangyicong@huawei.com> X-Mailer: git-send-email 2.31.0 In-Reply-To: <20231207081635.8427-1-yangyicong@huawei.com> References: <20231207081635.8427-1-yangyicong@huawei.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Originating-IP: [10.50.165.33] X-ClientProxiedBy: dggems702-chm.china.huawei.com (10.3.19.179) To canpemm500009.china.huawei.com (7.192.105.203) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" From: Yicong Yang When dump the raw trace by `perf report -D` ASan reports a memory leakage in perf_event__fprintf_event_update(). It shows that we allocated a temporary cpumap for dumping the CPUs but doesn't release it and it's not used elsewhere. Fix this by free the cpumap after the dumping. Fixes: c853f9394b7b ("perf tools: Add perf_event__fprintf_event_update func= tion") Cc: Jiri Olsa Signed-off-by: Yicong Yang Acked-by: Namhyung Kim --- tools/perf/util/header.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/tools/perf/util/header.c b/tools/perf/util/header.c index e86b9439ffee..7190f39ccd13 100644 --- a/tools/perf/util/header.c +++ b/tools/perf/util/header.c @@ -4369,9 +4369,10 @@ size_t perf_event__fprintf_event_update(union perf_e= vent *event, FILE *fp) ret +=3D fprintf(fp, "... "); =20 map =3D cpu_map__new_data(&ev->cpus.cpus); - if (map) + if (map) { ret +=3D cpu_map__fprintf(map, fp); - else + perf_cpu_map__put(map); + } else ret +=3D fprintf(fp, "failed to get cpus\n"); break; default: --=20 2.24.0