From nobody Sun Dec 28 17:36:14 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0081CC4167B for ; Wed, 6 Dec 2023 23:04:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1379594AbjLFXDy (ORCPT ); Wed, 6 Dec 2023 18:03:54 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57978 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1379612AbjLFXDw (ORCPT ); Wed, 6 Dec 2023 18:03:52 -0500 Received: from wout4-smtp.messagingengine.com (wout4-smtp.messagingengine.com [64.147.123.20]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 82481D72 for ; Wed, 6 Dec 2023 15:03:57 -0800 (PST) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.west.internal (Postfix) with ESMTP id 879433200ABA; Wed, 6 Dec 2023 18:03:56 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Wed, 06 Dec 2023 18:03:57 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastmail.org; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm1; t=1701903836; x= 1701990236; bh=Ts4cLhYYzzok3kwgsMOTCxxx9gZzMOek+V++hFjm8cU=; b=S Av3A07SdHtRfyBIMQDtmao1jF8edpQDgM81AqugmQMg9GDU4qSjYLp+Q9C+0NNpr sJUKIeMI1vwu4iJyapBarXH9M2FBu8gGfSCwvBDkp1icDwGZfyaMSQZckT6x6ON9 BS0cUtWUEdCWTk9M4ufqoDMzM/19y48ZNcHJI5n4f3WZ1lqi4yhIW1M7W/Dxi0Ma XtmEbCjfYqqXtUX/9Fjng9oh0qO4ECqR8/6pq/v5mkyfZaFZGJ+CeE/J/k/PXwMM 82NZatDhI4KO9g3Hdf8so/7Ej8EW30uLLO9KiQ/5TSyhkvkOAR9k7Xx9iZiTE9lG LNkXlWuEXqnUjplXZq09A== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1701903836; x= 1701990236; bh=Ts4cLhYYzzok3kwgsMOTCxxx9gZzMOek+V++hFjm8cU=; b=H UGOS+RwixbYuXhQ1whIJBm+FYXIfbUldw6NvwBPWBz/36LcbLGKucjtPRvHetB1g 8THaHYJsRR2VlvGQOeIDEQHURA9wO451Ktq4lmZkL7cJM+MV5kyLTy7UKRqjBdRH RI19zYZJgtXtVs+iefTPLH/txLMz7m9yUD5oB4MWeF/l+DuUf7AUT/bn6eJ0XDRG iExoQ/07a+2eZgpKSIrTtnmzEjcmVlYyE4K9pYGzb/KVCGbwuQNZ2MwMd4flnfNM lphy+eY7zy+HhQMvxucBsPsqY1L9RMmYKgzx/Sk6VT4N+V9X0nfsrGxuCpgvbrzd uszCQcTaoJ23EPJe5ljkw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrudekuddgtdehucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefhvfevufffkffojghfggfgsedtke ertdertddtnecuhfhrohhmpefirghrhicutfhoohhkrghrugcuoehgrghrhihrohhokhgr rhgusehfrghsthhmrghilhdrohhrgheqnecuggftrfgrthhtvghrnhepkeeuvdffueduke egieeuffejhefgkeetfeehueelfeduuefgveellefhfefgjedvnecuvehluhhsthgvrhfu ihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepghgrrhihrhhoohhkrghrugesfh grshhtmhgrihhlrdhorhhg X-ME-Proxy: Feedback-ID: ifd194980:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 6 Dec 2023 18:03:55 -0500 (EST) From: Gary Rookard To: gregkh@linuxfoundation.org, philipp.g.hortmann@gmail.com Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Gary Rookard Subject: [PATCH 2/5] staging: rtl8192e: renamed variable bAMPDUEnable Date: Wed, 6 Dec 2023 18:04:01 -0500 Message-ID: <20231206230404.1721-3-garyrookard@fastmail.org> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20231206230404.1721-1-garyrookard@fastmail.org> References: <20231206230404.1721-1-garyrookard@fastmail.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Coding style issue, checkpatch Avoid CamelCase, rename it. bAMPDUEnable -> ampdu_enable Signed-off-by: Gary Rookard --- drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c | 2 +- drivers/staging/rtl8192e/rtl819x_HT.h | 2 +- drivers/staging/rtl8192e/rtl819x_HTProc.c | 4 ++-- drivers/staging/rtl8192e/rtllib.h | 2 +- drivers/staging/rtl8192e/rtllib_tx.c | 8 ++++---- 5 files changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c b/drivers/stagi= ng/rtl8192e/rtl8192e/r8192E_dev.c index 13e3f26279aa..fe48cc6b7132 100644 --- a/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c +++ b/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c @@ -883,7 +883,7 @@ void rtl92e_fill_tx_desc(struct net_device *dev, struc= t tx_desc *pdesc, pTxFwInfo->Short =3D _rtl92e_query_is_short(pTxFwInfo->TxHT, pTxFwInfo->TxRate, cb_desc); =20 - if (cb_desc->bAMPDUEnable) { + if (cb_desc->ampdu_enable) { pTxFwInfo->AllowAggregation =3D 1; pTxFwInfo->RxMF =3D cb_desc->ampdu_factor; pTxFwInfo->RxAMD =3D cb_desc->ampdu_density; diff --git a/drivers/staging/rtl8192e/rtl819x_HT.h b/drivers/staging/rtl819= 2e/rtl819x_HT.h index e02fa40262bd..7a3e36db849c 100644 --- a/drivers/staging/rtl8192e/rtl819x_HT.h +++ b/drivers/staging/rtl8192e/rtl819x_HT.h @@ -111,7 +111,7 @@ struct rt_hi_throughput { u16 amsdu_max_size; u8 bCurrent_AMSDU_Support; u16 nCurrent_AMSDU_MaxSize; - u8 bAMPDUEnable; + u8 ampdu_enable; u8 current_ampdu_enable; u8 AMPDU_Factor; u8 CurrentAMPDUFactor; diff --git a/drivers/staging/rtl8192e/rtl819x_HTProc.c b/drivers/staging/rt= l8192e/rtl819x_HTProc.c index b2f2e1c0cf6b..9841af15089f 100644 --- a/drivers/staging/rtl8192e/rtl819x_HTProc.c +++ b/drivers/staging/rtl8192e/rtl819x_HTProc.c @@ -84,7 +84,7 @@ void ht_update_default_setting(struct rtllib_device *ieee) ht_info->amsdu_max_size =3D 7935UL; ht_info->amsdu_support =3D 0; =20 - ht_info->bAMPDUEnable =3D 1; + ht_info->ampdu_enable =3D 1; ht_info->AMPDU_Factor =3D 2; ht_info->MPDU_Density =3D 0; =20 @@ -498,7 +498,7 @@ void HTOnAssocRsp(struct rtllib_device *ieee) else ht_info->nCurrent_AMSDU_MaxSize =3D ht_info->amsdu_max_size; =20 - ht_info->current_ampdu_enable =3D ht_info->bAMPDUEnable; + ht_info->current_ampdu_enable =3D ht_info->ampdu_enable; if (ieee->rtllib_ap_sec_type && (ieee->rtllib_ap_sec_type(ieee) & (SEC_ALG_WEP | SEC_ALG_TKIP))) { if ((ht_info->IOTPeer =3D=3D HT_IOT_PEER_ATHEROS) || diff --git a/drivers/staging/rtl8192e/rtllib.h b/drivers/staging/rtl8192e/r= tllib.h index 47da9b1a8682..6bad7d410075 100644 --- a/drivers/staging/rtl8192e/rtllib.h +++ b/drivers/staging/rtl8192e/rtllib.h @@ -118,7 +118,7 @@ struct cb_desc { u8 bUseShortGI:1; u8 bUseShortPreamble:1; u8 bTxEnableFwCalcDur:1; - u8 bAMPDUEnable:1; + u8 ampdu_enable:1; u8 bRTSSTBC:1; u8 RTSSC:1; =20 diff --git a/drivers/staging/rtl8192e/rtllib_tx.c b/drivers/staging/rtl8192= e/rtllib_tx.c index a79f9d8c9162..5a69f4c6d0c9 100644 --- a/drivers/staging/rtl8192e/rtllib_tx.c +++ b/drivers/staging/rtl8192e/rtllib_tx.c @@ -312,7 +312,7 @@ static void rtllib_tx_query_agg_cap(struct rtllib_devic= e *ieee, goto FORCED_AGG_SETTING; } if (ieee->iw_mode =3D=3D IW_MODE_INFRA) { - tcb_desc->bAMPDUEnable =3D true; + tcb_desc->ampdu_enable =3D true; tcb_desc->ampdu_factor =3D ht_info->CurrentAMPDUFactor; tcb_desc->ampdu_density =3D ht_info->current_mpdu_density; } @@ -323,13 +323,13 @@ static void rtllib_tx_query_agg_cap(struct rtllib_dev= ice *ieee, break; =20 case HT_AGG_FORCE_ENABLE: - tcb_desc->bAMPDUEnable =3D true; + tcb_desc->ampdu_enable =3D true; tcb_desc->ampdu_density =3D ht_info->forced_mpdu_density; tcb_desc->ampdu_factor =3D ht_info->forced_ampdu_factor; break; =20 case HT_AGG_FORCE_DISABLE: - tcb_desc->bAMPDUEnable =3D false; + tcb_desc->ampdu_enable =3D false; tcb_desc->ampdu_density =3D 0; tcb_desc->ampdu_factor =3D 0; break; @@ -454,7 +454,7 @@ static void rtllib_query_protectionmode(struct rtllib_d= evice *ieee, tcb_desc->bRTSEnable =3D true; break; } - if (tcb_desc->bAMPDUEnable) { + if (tcb_desc->ampdu_enable) { tcb_desc->rts_rate =3D MGN_24M; tcb_desc->bRTSEnable =3D false; break; --=20 2.41.0