From nobody Sun Dec 28 17:30:32 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 67A4BC4167B for ; Wed, 6 Dec 2023 18:46:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1379026AbjLFSqb (ORCPT ); Wed, 6 Dec 2023 13:46:31 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33688 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1378959AbjLFSq1 (ORCPT ); Wed, 6 Dec 2023 13:46:27 -0500 Received: from rcdn-iport-7.cisco.com (rcdn-iport-7.cisco.com [173.37.86.78]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 03837D4B; Wed, 6 Dec 2023 10:46:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=3476; q=dns/txt; s=iport; t=1701888393; x=1703097993; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=1blSdLSc5MRNsT3kyXGgtEsuUKKQB7cq0eoHCqAPBag=; b=klxgNVzwkslNd6b7J6Yco0JNB4dDjUzAa0Q5dQ3PNyZDOOTNLJR/sVHP Vidab4NDKcJ8z2j+XEtmX58PnWNSdlwTWVkNS71wK1Nfpw6A1YLwdgYUg 0m/Gpt1qINHisx+Ex+u19VSdoAcBczSIdFulGRZm5G2dN1jdher8DybPQ w=; X-CSE-ConnectionGUID: qob9WeB+TviveptvWWKb5Q== X-CSE-MsgGUID: 8sE5e74cSNupFZPllipsSg== X-IronPort-AV: E=Sophos;i="6.04,256,1695686400"; d="scan'208";a="155092269" Received: from alln-core-4.cisco.com ([173.36.13.137]) by rcdn-iport-7.cisco.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Dec 2023 18:46:32 +0000 Received: from localhost.cisco.com ([10.193.101.253]) (authenticated bits=0) by alln-core-4.cisco.com (8.15.2/8.15.2) with ESMTPSA id 3B6IkHCw010013 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Wed, 6 Dec 2023 18:46:31 GMT From: Karan Tilak Kumar To: sebaddel@cisco.com Cc: arulponn@cisco.com, djhawar@cisco.com, gcboffa@cisco.com, mkai2@cisco.com, satishkh@cisco.com, jejb@linux.ibm.com, martin.petersen@oracle.com, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, Karan Tilak Kumar Subject: [PATCH v5 02/13] scsi: fnic: Add and use fnic number Date: Wed, 6 Dec 2023 10:46:04 -0800 Message-Id: <20231206184615.878755-3-kartilak@cisco.com> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20231206184615.878755-1-kartilak@cisco.com> References: <20231206184615.878755-1-kartilak@cisco.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Authenticated-User: kartilak@cisco.com X-Outbound-SMTP-Client: 10.193.101.253, [10.193.101.253] X-Outbound-Node: alln-core-4.cisco.com Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Add fnic_num in fnic.h to identify fnic in a multi-fnic environment. Increment and set the fnic number during driver load in fnic_probe. Replace the host number with fnic number in debugfs. Reviewed-by: Sesidhar Baddela Reviewed-by: Arulprabhu Ponnusamy Signed-off-by: Karan Tilak Kumar --- Changes between v4 and v5: Incorporate review comments from Martin: Modify patch commits to include a "---" separator. Changes between v3 and v4: Incorporate review comments from Martin and Hannes: Undo the change to replace host number with fnic number in debugfs since kernel stack uses host number. Use ida_alloc to allocate ID for fnic number. --- drivers/scsi/fnic/fnic.h | 1 + drivers/scsi/fnic/fnic_main.c | 18 ++++++++++++++++-- 2 files changed, 17 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/fnic/fnic.h b/drivers/scsi/fnic/fnic.h index 93c68931a593..c6c549c633b1 100644 --- a/drivers/scsi/fnic/fnic.h +++ b/drivers/scsi/fnic/fnic.h @@ -216,6 +216,7 @@ struct fnic_event { =20 /* Per-instance private data structure */ struct fnic { + int fnic_num; struct fc_lport *lport; struct fcoe_ctlr ctlr; /* FIP FCoE controller structure */ struct vnic_dev_bar bar0; diff --git a/drivers/scsi/fnic/fnic_main.c b/drivers/scsi/fnic/fnic_main.c index 984bc5fc55e2..f989a5d7a229 100644 --- a/drivers/scsi/fnic/fnic_main.c +++ b/drivers/scsi/fnic/fnic_main.c @@ -39,6 +39,7 @@ static struct kmem_cache *fnic_sgl_cache[FNIC_SGL_NUM_CAC= HES]; static struct kmem_cache *fnic_io_req_cache; static LIST_HEAD(fnic_list); static DEFINE_SPINLOCK(fnic_list_lock); +static DEFINE_IDA(fnic_ida); =20 /* Supported devices by fnic module */ static struct pci_device_id fnic_id_table[] =3D { @@ -583,7 +584,8 @@ static int fnic_probe(struct pci_dev *pdev, const struc= t pci_device_id *ent) struct fc_lport *lp; struct fnic *fnic; mempool_t *pool; - int err; + int err =3D 0; + int fnic_id =3D 0; int i; unsigned long flags; =20 @@ -597,8 +599,16 @@ static int fnic_probe(struct pci_dev *pdev, const stru= ct pci_device_id *ent) err =3D -ENOMEM; goto err_out; } + host =3D lp->host; fnic =3D lport_priv(lp); + + fnic_id =3D ida_alloc(&fnic_ida, GFP_KERNEL); + if (fnic_id < 0) { + pr_err("Unable to alloc fnic ID\n"); + err =3D fnic_id; + goto err_out_ida_alloc; + } fnic->lport =3D lp; fnic->ctlr.lp =3D lp; =20 @@ -608,7 +618,7 @@ static int fnic_probe(struct pci_dev *pdev, const struc= t pci_device_id *ent) host->host_no); =20 host->transportt =3D fnic_fc_transport; - + fnic->fnic_num =3D fnic_id; fnic_stats_debugfs_init(fnic); =20 /* Setup PCI resources */ @@ -949,6 +959,8 @@ static int fnic_probe(struct pci_dev *pdev, const struc= t pci_device_id *ent) pci_disable_device(pdev); err_out_free_hba: fnic_stats_debugfs_remove(fnic); + ida_free(&fnic_ida, fnic->fnic_num); +err_out_ida_alloc: scsi_host_put(lp->host); err_out: return err; @@ -1029,6 +1041,7 @@ static void fnic_remove(struct pci_dev *pdev) fnic_iounmap(fnic); pci_release_regions(pdev); pci_disable_device(pdev); + ida_free(&fnic_ida, fnic->fnic_num); scsi_host_put(lp->host); } =20 @@ -1166,6 +1179,7 @@ static void __exit fnic_cleanup_module(void) fnic_trace_free(); fnic_fc_trace_free(); fnic_debugfs_terminate(); + ida_destroy(&fnic_ida); } =20 module_init(fnic_init_module); --=20 2.31.1