From nobody Tue Dec 16 23:57:02 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E765BC4167B for ; Wed, 6 Dec 2023 11:17:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1378209AbjLFLRr (ORCPT ); Wed, 6 Dec 2023 06:17:47 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60816 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1378155AbjLFLRg (ORCPT ); Wed, 6 Dec 2023 06:17:36 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4D831DE for ; Wed, 6 Dec 2023 03:17:42 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E2A45C433C9; Wed, 6 Dec 2023 11:17:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1701861462; bh=T2z/FCGOZTuZvMKsnWedFJwmDPaovLjYsoXHwnzGLm8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=E8Xs7Mf+yvYVbVgFDPG70M+BYfmM74f+VGjl4MWCtc9wpqmklDMyBPQLNQoo/jqGZ wprvZuPGoIlM/8o+g0+KK0EfcN8KljesIR4dFSekWdx+TV3aOlXusdZnSfrQ7dK7aL Jh5u3wAhwxHG4MDRhf++92RJWKxWxyLFIRf4DcUbC9f2LXn4x30UnqxUbzn6aK5V7r 2rVbuR2T6AulcvObV+gJVlSw+dmqvJ42djabqP6kuu8/xH59dlcdSykF7rM8WQ5d4L U2vrvWJBR+/+9wB9e5JI4ArtfubCotW7mXnykiWosnimjFnBszO7kNdn1wE662nJyT UQKYLLbdLcZgw== Received: from johan by xi.lan with local (Exim 4.96.2) (envelope-from ) id 1rApvA-0001wI-1w; Wed, 06 Dec 2023 12:18:28 +0100 From: Johan Hovold To: Lee Jones Cc: Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Andy Gross , Bjorn Andersson , Konrad Dybcio , linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, Johan Hovold , Krzysztof Kozlowski Subject: [PATCH v3 3/4] dt-bindings: mfd: hisilicon,hi6421-spmi-pmic: clean up example Date: Wed, 6 Dec 2023 12:17:53 +0100 Message-ID: <20231206111754.7410-4-johan+linaro@kernel.org> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20231206111754.7410-1-johan+linaro@kernel.org> References: <20231206111754.7410-1-johan+linaro@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" The SPMI PMIC sits on an SPMI bus which and has two address cells with no size. Clean up the example by adding a parent SPMI bus node with proper '#address-cells' and '#size-cells' properties, using a define for the second register value, dropping the unnecessary label and increasing the indentation to four spaces. Acked-by: Krzysztof Kozlowski Signed-off-by: Johan Hovold --- .../mfd/hisilicon,hi6421-spmi-pmic.yaml | 134 +++++++++--------- 1 file changed, 70 insertions(+), 64 deletions(-) diff --git a/Documentation/devicetree/bindings/mfd/hisilicon,hi6421-spmi-pm= ic.yaml b/Documentation/devicetree/bindings/mfd/hisilicon,hi6421-spmi-pmic.= yaml index 45cd6a613a91..6a824351834e 100644 --- a/Documentation/devicetree/bindings/mfd/hisilicon,hi6421-spmi-pmic.yaml +++ b/Documentation/devicetree/bindings/mfd/hisilicon,hi6421-spmi-pmic.yaml @@ -59,69 +59,75 @@ additionalProperties: false =20 examples: - | - - pmic: pmic@0 { - compatible =3D "hisilicon,hi6421v600-spmi"; - reg =3D <0 0>; - - #interrupt-cells =3D <2>; - interrupt-controller; - interrupt-parent =3D <&gpio28>; - interrupts =3D <0 0>; - - regulators { - ldo3: ldo3 { - regulator-name =3D "ldo3"; - regulator-min-microvolt =3D <1500000>; - regulator-max-microvolt =3D <2000000>; - regulator-boot-on; - }; - - ldo4: ldo4 { - regulator-name =3D "ldo4"; - regulator-min-microvolt =3D <1725000>; - regulator-max-microvolt =3D <1900000>; - regulator-boot-on; - }; - - ldo9: ldo9 { - regulator-name =3D "ldo9"; - regulator-min-microvolt =3D <1750000>; - regulator-max-microvolt =3D <3300000>; - regulator-boot-on; - }; - - ldo15: ldo15 { - regulator-name =3D "ldo15"; - regulator-min-microvolt =3D <1800000>; - regulator-max-microvolt =3D <3000000>; - regulator-always-on; - }; - - ldo16: ldo16 { - regulator-name =3D "ldo16"; - regulator-min-microvolt =3D <1800000>; - regulator-max-microvolt =3D <3000000>; - regulator-boot-on; - }; - - ldo17: ldo17 { - regulator-name =3D "ldo17"; - regulator-min-microvolt =3D <2500000>; - regulator-max-microvolt =3D <3300000>; - }; - - ldo33: ldo33 { - regulator-name =3D "ldo33"; - regulator-min-microvolt =3D <2500000>; - regulator-max-microvolt =3D <3300000>; - regulator-boot-on; - }; - - ldo34: ldo34 { - regulator-name =3D "ldo34"; - regulator-min-microvolt =3D <2600000>; - regulator-max-microvolt =3D <3300000>; + #include + + spmi { + #address-cells =3D <2>; + #size-cells =3D <0>; + + pmic@0 { + compatible =3D "hisilicon,hi6421v600-spmi"; + reg =3D <0 SPMI_USID>; + + #interrupt-cells =3D <2>; + interrupt-controller; + interrupt-parent =3D <&gpio28>; + interrupts =3D <0 0>; + + regulators { + ldo3 { + regulator-name =3D "ldo3"; + regulator-min-microvolt =3D <1500000>; + regulator-max-microvolt =3D <2000000>; + regulator-boot-on; + }; + + ldo4 { + regulator-name =3D "ldo4"; + regulator-min-microvolt =3D <1725000>; + regulator-max-microvolt =3D <1900000>; + regulator-boot-on; + }; + + ldo9 { + regulator-name =3D "ldo9"; + regulator-min-microvolt =3D <1750000>; + regulator-max-microvolt =3D <3300000>; + regulator-boot-on; + }; + + ldo15 { + regulator-name =3D "ldo15"; + regulator-min-microvolt =3D <1800000>; + regulator-max-microvolt =3D <3000000>; + regulator-always-on; + }; + + ldo16 { + regulator-name =3D "ldo16"; + regulator-min-microvolt =3D <1800000>; + regulator-max-microvolt =3D <3000000>; + regulator-boot-on; + }; + + ldo17 { + regulator-name =3D "ldo17"; + regulator-min-microvolt =3D <2500000>; + regulator-max-microvolt =3D <3300000>; + }; + + ldo33 { + regulator-name =3D "ldo33"; + regulator-min-microvolt =3D <2500000>; + regulator-max-microvolt =3D <3300000>; + regulator-boot-on; + }; + + ldo34 { + regulator-name =3D "ldo34"; + regulator-min-microvolt =3D <2600000>; + regulator-max-microvolt =3D <3300000>; + }; + }; }; - }; }; --=20 2.41.0