From nobody Thu Dec 18 08:28:07 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 73C58C10F04 for ; Wed, 6 Dec 2023 07:37:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1376727AbjLFHhT (ORCPT ); Wed, 6 Dec 2023 02:37:19 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41974 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229825AbjLFHhR (ORCPT ); Wed, 6 Dec 2023 02:37:17 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 831D7D44 for ; Tue, 5 Dec 2023 23:37:23 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 19C59C433C9; Wed, 6 Dec 2023 07:37:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1701848243; bh=ZDmoAy6WV6x6U4PKECQB462q+EjbB6bBRjNbii6C7fA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=A3KiKHVniZzYbU8D8vr744J7b2uywgMPYUR+NYQ6DcyhlD3V0fYP1CeaxrUx7VDMO fS4KSaoDurVYT0tzpiK+DFon2qU8eAhP0wJJJpGfaRZ33EkURpLM23eSWl+i8M6JF/ a3uFnM1AeZtr1RPKY15XNbbu38HVOhocc8i7MrtK88ecdVVg+LZdDd5SKUC5Ift1vh Ix+RtPFOXck+w782fYIgzP/BYW4ysFeqFSVRnDjcki/zODJJbj+I1V17qElzYC3Dsm etHUSVAkVg/Y98AiK1h9nSgKYNmvvML/4k/bOvTspgTsg0LCsLZVL+eSECn9yFT8qU Pj96PL3xbwoQg== From: "Jiri Slaby (SUSE)" To: gregkh@linuxfoundation.org Cc: linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org, "Jiri Slaby (SUSE)" Subject: [PATCH 01/27] tty: goldfish: use bool for is_write parameter Date: Wed, 6 Dec 2023 08:36:46 +0100 Message-ID: <20231206073712.17776-2-jirislaby@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20231206073712.17776-1-jirislaby@kernel.org> References: <20231206073712.17776-1-jirislaby@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" do_rw_io()'s is_write parameter is boolean, but typed int. Switch to the former, so that it's obvious. (And the two users too.) Signed-off-by: Jiri Slaby (SUSE) --- drivers/tty/goldfish.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/tty/goldfish.c b/drivers/tty/goldfish.c index dccf6c6c69c6..7ad7fa66cb27 100644 --- a/drivers/tty/goldfish.c +++ b/drivers/tty/goldfish.c @@ -53,7 +53,7 @@ static struct goldfish_tty *goldfish_ttys; static void do_rw_io(struct goldfish_tty *qtty, unsigned long address, unsigned int count, - int is_write) + bool is_write) { unsigned long irq_flags; void __iomem *base =3D qtty->base; @@ -76,7 +76,7 @@ static void do_rw_io(struct goldfish_tty *qtty, static void goldfish_tty_rw(struct goldfish_tty *qtty, unsigned long addr, unsigned int count, - int is_write) + bool is_write) { dma_addr_t dma_handle; enum dma_data_direction dma_dir; @@ -129,7 +129,7 @@ static void goldfish_tty_do_write(int line, const u8 *b= uf, unsigned int count) { struct goldfish_tty *qtty =3D &goldfish_ttys[line]; =20 - goldfish_tty_rw(qtty, (unsigned long)buf, count, 1); + goldfish_tty_rw(qtty, (unsigned long)buf, count, true); } =20 static irqreturn_t goldfish_tty_interrupt(int irq, void *dev_id) @@ -145,7 +145,7 @@ static irqreturn_t goldfish_tty_interrupt(int irq, void= *dev_id) =20 count =3D tty_prepare_flip_string(&qtty->port, &buf, count); =20 - goldfish_tty_rw(qtty, (unsigned long)buf, count, 0); + goldfish_tty_rw(qtty, (unsigned long)buf, count, false); =20 tty_flip_buffer_push(&qtty->port); return IRQ_HANDLED; --=20 2.43.0