From nobody Sun Dec 28 19:30:50 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D088CC4167B for ; Tue, 5 Dec 2023 16:49:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344941AbjLEQt1 (ORCPT ); Tue, 5 Dec 2023 11:49:27 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33630 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232198AbjLEQtY (ORCPT ); Tue, 5 Dec 2023 11:49:24 -0500 Received: from mail-yb1-xb4a.google.com (mail-yb1-xb4a.google.com [IPv6:2607:f8b0:4864:20::b4a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5FD7019F for ; Tue, 5 Dec 2023 08:49:30 -0800 (PST) Received: by mail-yb1-xb4a.google.com with SMTP id 3f1490d57ef6-db547d41413so3801803276.0 for ; Tue, 05 Dec 2023 08:49:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1701794969; x=1702399769; darn=vger.kernel.org; h=to:from:subject:mime-version:message-id:date:from:to:cc:subject :date:message-id:reply-to; bh=il/zOOk1ULaSp4c3ZKjwASqI7JmWGklotUwSmWlNxts=; b=MmthDo4GyoBmUhvDHGw72G01MDqlIvODa/hQIJaBYO9hgqqG53xzEtqM7gWzDs8U4N VdXtcO7F5Bm4sWPPbsXjwi85nRkOqiy4X7W5o4hXuksGEWZvuab5ApIi0lg3dllLzM3y /pFJ0yFA6vcJldgWu8d/Er50IQWisih7fMxW04E1+gA6tr9Dz6wRbfX7auCF1L+P5rWL ArWdVjJA1EfOlHQ/r8DQ/Zq/QFwvnQFOt9ROehJpW0P9D3dw0kSzhY6b/dwUYb62jQGj rLG/dcxCrKSO9vUodXOiOjhR1KdWQIlK5SeNWFSIbLMYlOUChqL3m1z24CEEM8/gI1jQ QF9Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701794969; x=1702399769; h=to:from:subject:mime-version:message-id:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=il/zOOk1ULaSp4c3ZKjwASqI7JmWGklotUwSmWlNxts=; b=c0GZoqOYCzGUit58kkhahMjw6oH5LAux7rkwCxFVBwJzxKGKgzQPaDBD+KOUVAzDCq 5L29tC491xTGrOasXRkNDg6yLCK7m85Jbs7LtRtLVsEgsXikyV/lP9L+8pGGqjiSU3SY uFyYqoJkhiLmugKUcMVurQYbrensMe4CmO7jb1HHVotHknXbkz8kYqChcLn12d6MvR+v VeYXXGDVFl/SXT/Y5+g4fAdyFlFF4S0R8DlWcZGnWcDCA61SW/8pk7NZEblCpIQ5HSwx CShQyaJZXYr2Vf2a68dw/9g7I7VyzbVI4vVrFgNlLrNiI37HbX/QoDXtUgk1ciYKjvFJ Uxfw== X-Gm-Message-State: AOJu0Yx24n0RJFDY/QcnSIiIzRCl0faFQdscWYhcyjxAqWitPqHtWp7h I2msJfSaJuR1VZ5BoFbptKmEsNT0jx4X X-Google-Smtp-Source: AGHT+IGoDtCBJ0f3p67GriPcyTyEC/v0B8VEJ3bmRMBIBhC7lrA/02mGuUcOOfRJOYzn2EGGrDTf4e+ilDDN X-Received: from irogers.svl.corp.google.com ([2620:15c:2a3:200:48b6:2578:1ca7:5287]) (user=irogers job=sendgmr) by 2002:a05:6902:51:b0:da3:b467:af07 with SMTP id m17-20020a056902005100b00da3b467af07mr60835ybh.2.1701794969538; Tue, 05 Dec 2023 08:49:29 -0800 (PST) Date: Tue, 5 Dec 2023 08:49:24 -0800 Message-Id: <20231205164924.835682-1-irogers@google.com> Mime-Version: 1.0 X-Mailer: git-send-email 2.43.0.rc2.451.g8631bc7472-goog Subject: [PATCH v1] perf test: Skip diff test if test_loop is missing From: Ian Rogers To: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Ian Rogers , Adrian Hunter , linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The diff test depends on finding the symbol test_loop in perf and will fail if perf has been stripped and no debug object is available. In that case, skip the test instead. Signed-off-by: Ian Rogers Tested-by: Adrian Hunter --- tools/perf/tests/shell/diff.sh | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/tools/perf/tests/shell/diff.sh b/tools/perf/tests/shell/diff.sh index 213185763688..14b87af88703 100755 --- a/tools/perf/tests/shell/diff.sh +++ b/tools/perf/tests/shell/diff.sh @@ -9,8 +9,15 @@ perfdata1=3D$(mktemp /tmp/__perf_test.perf.data.XXXXX) perfdata2=3D$(mktemp /tmp/__perf_test.perf.data.XXXXX) perfdata3=3D$(mktemp /tmp/__perf_test.perf.data.XXXXX) testprog=3D"perf test -w thloop" + +shelldir=3D$(dirname "$0") +# shellcheck source=3Dlib/perf_has_symbol.sh +. "${shelldir}"/lib/perf_has_symbol.sh + testsym=3D"test_loop" =20 +skip_test_missing_symbol ${testsym} + cleanup() { rm -rf "${perfdata1}" rm -rf "${perfdata1}".old --=20 2.43.0.rc2.451.g8631bc7472-goog