From nobody Sat Feb 7 23:55:21 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3FCCBC4167B for ; Tue, 5 Dec 2023 14:10:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345642AbjLEOKR (ORCPT ); Tue, 5 Dec 2023 09:10:17 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46214 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345587AbjLEOKQ (ORCPT ); Tue, 5 Dec 2023 09:10:16 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3BDFDB9 for ; Tue, 5 Dec 2023 06:10:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1701785421; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=zjpDU1pO5fL8Z2EU79m8w3lIjmII9ANV1M3MyIbt0ME=; b=AXzplE61wm0wc8yNrlCbxbSpHbVLySxPi78iZKby+0WCo0ihllR/JlQ/2jqtZHDqgv2ys8 heOvMEWC9tuTuaLKP5p6HK235MeLrAn/MX144leLPJjSb+F0KcVLIvWDhqCPxSKtztfo23 Lgyn3x78pvHOseVM2mqEMw4y4fLdMkE= Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-246-hAEfsowROliopZ5AVRFZjQ-1; Tue, 05 Dec 2023 09:09:30 -0500 X-MC-Unique: hAEfsowROliopZ5AVRFZjQ-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 6A21B1C06915; Tue, 5 Dec 2023 14:09:30 +0000 (UTC) Received: from prarit.bos.redhat.com (prarit2023-praritguest.khw1.lab.eng.bos.redhat.com [10.16.200.42]) by smtp.corp.redhat.com (Postfix) with ESMTP id ED5A22026F95; Tue, 5 Dec 2023 14:09:29 +0000 (UTC) From: Prarit Bhargava To: linux-kernel@vger.kernel.org Cc: Prarit Bhargava , Wim Van Sebroeck , Guenter Roeck , David Arcari , linux-watchdog@vger.kernel.org Subject: [PATCH] watchdog: Provide a better stop error message Date: Tue, 5 Dec 2023 09:09:16 -0500 Message-ID: <20231205140926.397956-1-prarit@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.4 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Provide a better stop error message for the case where the watchdog does not stop. CC: Wim Van Sebroeck CC: Guenter Roeck CC: David Arcari CC: linux-watchdog@vger.kernel.org Signed-off-by: Prarit Bhargava --- drivers/watchdog/watchdog_dev.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/watchdog/watchdog_dev.c b/drivers/watchdog/watchdog_de= v.c index 15df74e11a59..f0084bf7c750 100644 --- a/drivers/watchdog/watchdog_dev.c +++ b/drivers/watchdog/watchdog_dev.c @@ -965,7 +965,8 @@ static int watchdog_release(struct inode *inode, struct= file *file) =20 /* If the watchdog was not stopped, send a keepalive ping */ if (err < 0) { - pr_crit("watchdog%d: watchdog did not stop!\n", wdd->id); + pr_crit("watchdog%d is still active. Stop by [%s:%d] failed.\n", + wdd->id, current->comm, current->pid); watchdog_ping(wdd); } =20 --=20 2.43.0