From nobody Sun Dec 28 21:19:43 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 72B75C4167B for ; Tue, 5 Dec 2023 23:05:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346588AbjLEXFX (ORCPT ); Tue, 5 Dec 2023 18:05:23 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37948 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1346555AbjLEXFN (ORCPT ); Tue, 5 Dec 2023 18:05:13 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 880601AA for ; Tue, 5 Dec 2023 15:05:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1701817518; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=KP09DeLuYz+Og6dlZ9z2Kp7En1LOdjS8AGaZ+gDsxfo=; b=BHzUklufT9IgonPTwvPnuIUSY+DCd2KsQS7XnPWIE6/Kxyg96mCfkLmKsyoosqViwnSom9 FB0uLzWi+qAYXpOgm3C6opXngfdOma0YF9G2AivhFMLNbzFr6X+fcJlfuZoKz16J3IOASA RbUn1u4rn2cmTVx8KfMgw1ri+91m9Jk= Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-668-phLg7Ax2Ok-MdV-1fPvv9w-1; Tue, 05 Dec 2023 18:05:17 -0500 X-MC-Unique: phLg7Ax2Ok-MdV-1fPvv9w-1 Received: by mail-qt1-f198.google.com with SMTP id d75a77b69052e-423f436ed56so2318381cf.1 for ; Tue, 05 Dec 2023 15:05:16 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701817516; x=1702422316; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=KP09DeLuYz+Og6dlZ9z2Kp7En1LOdjS8AGaZ+gDsxfo=; b=b2JOkeR/aGrTiKt/eDxSWxR+XN+PA3H6xlv458gMXAgbrf8aVc5R8dgNVfbiM/bYnw iYFIxZODoqYchiD+fV+y8O3swexOdkRZZqw1BKwnC/Qm+/78aVWXiNdGK2uRrbz+jE9C Lsx128rx+QOFV7uVe0OzznKX+jGGEgyMSoqCWZoZwCdszOzV/8I5sYT9gDd4X54NbtrD T+JvdHp4bvWpL8/9LeH4QBLIzDzySyDTY3qefFYDGupzCi9JmmHhsMr39InNG9hNLgd/ +sYmGeFu1a/RDz20m1HDlecHLE2Xtv7hkwoq4PxTJFP2blnEgSgZE71st5OCV2WhFZ2U lROg== X-Gm-Message-State: AOJu0Yze3/1z9dMwP9nMJ3r1ZyTcMAopxicKDJegPD89Qu4d1PVhsBJz 2HhSU5UopX1FlgBkQk868A2VqQe/089QGZVJQeDJxS5Rt4Z7DrFR28gl36HsGnmk2dhw6RgUlwY CobF1qdS2Aw7DfJiNOsOQbU/J X-Received: by 2002:a05:622a:152:b0:425:4043:5f33 with SMTP id v18-20020a05622a015200b0042540435f33mr2451718qtw.113.1701817516311; Tue, 05 Dec 2023 15:05:16 -0800 (PST) X-Google-Smtp-Source: AGHT+IHoR/p1qLBUmIC26RDY0jJlDmdE0eOUVOk9yZxWq7JR6p+2pg3EgP1rRlHHZVJRhc5vwUPNdQ== X-Received: by 2002:a05:622a:152:b0:425:4043:5f33 with SMTP id v18-20020a05622a015200b0042540435f33mr2451705qtw.113.1701817516092; Tue, 05 Dec 2023 15:05:16 -0800 (PST) Received: from [192.168.1.164] ([2600:1700:1ff0:d0e0::47]) by smtp.gmail.com with ESMTPSA id df15-20020a05622a0ecf00b00423da75b0f4sm5504430qtb.71.2023.12.05.15.05.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Dec 2023 15:05:14 -0800 (PST) From: Andrew Halaney Date: Tue, 05 Dec 2023 17:05:11 -0600 Subject: [PATCH 3/3] soc: qcom: pmic_pdcharger_ulog: Fix hypothetical ulog request message endianess MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20231205-pmicpdcharger-ulog-fixups-v1-3-71c95162cb84@redhat.com> References: <20231205-pmicpdcharger-ulog-fixups-v1-0-71c95162cb84@redhat.com> In-Reply-To: <20231205-pmicpdcharger-ulog-fixups-v1-0-71c95162cb84@redhat.com> To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Dmitry Baryshkov , Neil Armstrong Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Andrew Halaney , kernel test robot X-Mailer: b4 0.12.3 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Sparse reports the following: % ARCH=3Darm64 CROSS_COMPILE=3Daarch64-linux-gnu- make C=3D2 W=3D1 driv= ers/soc/qcom/pmic_pdcharger_ulog.o ... CC drivers/soc/qcom/pmic_pdcharger_ulog.o CHECK drivers/soc/qcom/pmic_pdcharger_ulog.c drivers/soc/qcom/pmic_pdcharger_ulog.c:57:34: warning: incorrect type i= n initializer (different base types) drivers/soc/qcom/pmic_pdcharger_ulog.c:57:34: expected restricted __= le32 [usertype] owner drivers/soc/qcom/pmic_pdcharger_ulog.c:57:34: got int drivers/soc/qcom/pmic_pdcharger_ulog.c:58:33: warning: incorrect type i= n initializer (different base types) drivers/soc/qcom/pmic_pdcharger_ulog.c:58:33: expected restricted __= le32 [usertype] type drivers/soc/qcom/pmic_pdcharger_ulog.c:58:33: got int drivers/soc/qcom/pmic_pdcharger_ulog.c:59:35: warning: incorrect type i= n initializer (different base types) drivers/soc/qcom/pmic_pdcharger_ulog.c:59:35: expected restricted __= le32 [usertype] opcode drivers/soc/qcom/pmic_pdcharger_ulog.c:59:35: got int Let's deal with endianness conversion in the rare case this ever runs on a big-endian machine (and to quiet down sparse for this file). Reported-by: kernel test robot Closes: https://lore.kernel.org/oe-kbuild-all/202312060355.M0eJtq4X-lkp@int= el.com/ Fixes: 086fdb48bc65 ("soc: qcom: add ADSP PDCharger ULOG driver") Signed-off-by: Andrew Halaney Reviewed-by: Neil Armstrong --- drivers/soc/qcom/pmic_pdcharger_ulog.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/soc/qcom/pmic_pdcharger_ulog.c b/drivers/soc/qcom/pmic= _pdcharger_ulog.c index f1aaacf05005..238cd38589dc 100644 --- a/drivers/soc/qcom/pmic_pdcharger_ulog.c +++ b/drivers/soc/qcom/pmic_pdcharger_ulog.c @@ -54,9 +54,9 @@ static int pmic_pdcharger_ulog_request(struct pmic_pdchar= ger_ulog *pg) { struct get_ulog_req_msg req_msg =3D { .hdr =3D { - .owner =3D MSG_OWNER_CHG_ULOG, - .type =3D MSG_TYPE_REQ_RESP, - .opcode =3D GET_CHG_ULOG_REQ + .owner =3D cpu_to_le32(MSG_OWNER_CHG_ULOG), + .type =3D cpu_to_le32(MSG_TYPE_REQ_RESP), + .opcode =3D cpu_to_le32(GET_CHG_ULOG_REQ) }, .log_size =3D MAX_ULOG_SIZE }; --=20 2.43.0