From nobody Mon Dec 29 00:38:46 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3E16DC4167B for ; Mon, 4 Dec 2023 13:26:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235629AbjLDN0T (ORCPT ); Mon, 4 Dec 2023 08:26:19 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34232 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344478AbjLDNZ3 (ORCPT ); Mon, 4 Dec 2023 08:25:29 -0500 Received: from madras.collabora.co.uk (madras.collabora.co.uk [46.235.227.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8121C1BE1; Mon, 4 Dec 2023 05:24:30 -0800 (PST) Received: from benjamin-XPS-13-9310.. (ec2-34-240-57-77.eu-west-1.compute.amazonaws.com [34.240.57.77]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: benjamin.gaignard) by madras.collabora.co.uk (Postfix) with ESMTPSA id 9F272660737C; Mon, 4 Dec 2023 13:24:28 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1701696269; bh=6CSGRDiRO2lms0wmXZEstJJokqkWndIp5smKK5ehYIM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=kCooEnmkndIKQN0862GmZwqQIUBTkRANgsq1oGTjWto1LNmPYLRdTfup0Xe/IADHA XW6ubO67cr1Ol1bSKaZ0iWVwX4J3DerDiRTM3Qi/cDhtvyeGs2RDVmKGSdfH2euK64 N/C3juaKclp90MPs/e0oHYFfUuAi4/UCavpliPji0c6iPNf1des2X9QVf1L8TD4SdL 49kmO1YOK3+iQk7uh7j2BN1b1SU24T/JFfOkHami6tc4tQZvvc/DN8Ha9hBvx6j3JA pad2IELQ3EhvWhGBHlCH7N4yOt2O7+FcJJIDwemaR2Y75qX8Y1h9aUeqsBOElvahwX BxdUahsQ2IN5Q== From: Benjamin Gaignard To: hverkuil@xs4all.nl, mchehab@kernel.org, tfiga@chromium.org, m.szyprowski@samsung.com, matt.ranostay@konsulko.com Cc: linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, linux-staging@lists.linux.dev, kernel@collabora.com, Benjamin Gaignard Subject: [PATCH v2 34/36] media: saa7146: Fix misuse of min_buffers_needed field Date: Mon, 4 Dec 2023 14:23:21 +0100 Message-Id: <20231204132323.22811-35-benjamin.gaignard@collabora.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20231204132323.22811-1-benjamin.gaignard@collabora.com> References: <20231204132323.22811-1-benjamin.gaignard@collabora.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" 'min_buffers_needed' is suppose to be used to indicate the number of buffers needed by DMA engine to start streaming. saa7146 driver doesn't use DMA engine and just want to specify the minimum number of buffers to allocate when calling VIDIOC_REQBUFS. That 'min_reqbufs_allocation' field purpose so use it. Signed-off-by: Benjamin Gaignard --- drivers/media/common/saa7146/saa7146_fops.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/common/saa7146/saa7146_fops.c b/drivers/media/co= mmon/saa7146/saa7146_fops.c index 79214459387a..db4d725a05d4 100644 --- a/drivers/media/common/saa7146/saa7146_fops.c +++ b/drivers/media/common/saa7146/saa7146_fops.c @@ -387,7 +387,7 @@ int saa7146_register_device(struct video_device *vfd, s= truct saa7146_dev *dev, q->gfp_flags =3D __GFP_DMA32; q->buf_struct_size =3D sizeof(struct saa7146_buf); q->lock =3D &dev->v4l2_lock; - q->min_buffers_needed =3D 2; + q->min_reqbufs_allocation =3D 2; q->dev =3D &dev->pci->dev; err =3D vb2_queue_init(q); if (err) --=20 2.39.2