From nobody Sun Dec 28 23:18:35 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 13BEBC4167B for ; Mon, 4 Dec 2023 10:01:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231150AbjLDKAy (ORCPT ); Mon, 4 Dec 2023 05:00:54 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35082 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229526AbjLDKAu (ORCPT ); Mon, 4 Dec 2023 05:00:50 -0500 Received: from mail-ej1-x635.google.com (mail-ej1-x635.google.com [IPv6:2a00:1450:4864:20::635]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 691C9E5 for ; Mon, 4 Dec 2023 02:00:55 -0800 (PST) Received: by mail-ej1-x635.google.com with SMTP id a640c23a62f3a-a1975fe7befso438033666b.2 for ; Mon, 04 Dec 2023 02:00:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1701684054; x=1702288854; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=ci3vPfK43+K4niO6uFBbC2o2Y2UUChnmCN7Lkz2+0dU=; b=rHbBN9lLXSLbv+2gC4JFRHmM8dJ1gVYjataw2jQLl+NFrTwfdjJqEte0QL7pJzOdZx tTGIvmnVQt+beRS/ZLd8x0spHXlkb2TuWn5+pVUirxSbOznhREopS5CdfdAPK6G9NUbO vw7eH3u9Ol1ALsBDn3gruqCvaWZHz1gKlgxDtBT0IYduP2HxebFYbKFmS/x7XuNeeYiz wbTlHfNyqaeDlvH4oWnndTdhw1Wb29AMx01DFmOIGnd4oZGdLuvxTYtUOU48dKkepveX HfD2BDwzPz2lL/0Jy1NZasRJ8jhrPsoZi4kdsd9aTwsDm73wajX8rwNByMiJPxpcqIUa k5Sw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701684054; x=1702288854; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ci3vPfK43+K4niO6uFBbC2o2Y2UUChnmCN7Lkz2+0dU=; b=JKKyoYTPWpfpXDRutOk//M1KNk52W8r5PB/X/dnd1KSW8NV3Nz9lS8nvD6kUIB4mgT 22s1jiC4Gb3gU+XLZM5Os+SekTxUQEijLJSYMzIEM+1JszJfWApDOo9BA5FZIDFWkD95 xRCJqe1HGuSG2rsbyc2IvavNHfh+f0rTTH1COpM/fKnq/09soHlOQ9We/UIXMF7BI83U sxJ5C32I9/O8Lvcr4XZV9+gVkvve00uLSxelE+BgS6N+uv7g15VP3vK13tt1f2a5gNpR 59RsXNecK5fOn2R4Oea3m5g+0bvJ3E4uPe6srzjkxHyUvLG1QyKFtKH4fKn6mUffSUqQ fm0A== X-Gm-Message-State: AOJu0YxiKhG7IsAmm1tO+YmtLCE1weUMTNrDLBehbe6ns5Zx8qOsbvP2 7ql6DWJ98vzmzOTh1mfvleqgPg== X-Google-Smtp-Source: AGHT+IEYIliWeQynvKc93LC5+E03Aal9KlNobNkzWPdTJmmKwTqYABXRJ1BhSR0RaHAZc0hqoDtJYg== X-Received: by 2002:a17:906:3f17:b0:9be:7b67:1674 with SMTP id c23-20020a1709063f1700b009be7b671674mr3140130ejj.3.1701684053242; Mon, 04 Dec 2023 02:00:53 -0800 (PST) Received: from krzk-bin.. ([178.197.223.109]) by smtp.gmail.com with ESMTPSA id z21-20020a170906715500b00a1185ad53c6sm5108123ejj.199.2023.12.04.02.00.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 Dec 2023 02:00:52 -0800 (PST) From: Krzysztof Kozlowski To: Srinivas Kandagatla , Banajit Goswami , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , alsa-devel@alsa-project.org, linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH] ASoC: qcom: Fix trivial code style issues Date: Mon, 4 Dec 2023 11:00:48 +0100 Message-Id: <20231204100048.211800-1-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Fix few trivial code style issues, pointed out by checkpatch, so they do not get copied to new code (when old code is used as template): WARNING: Prefer "GPL" over "GPL v2" - see commit bf7fbeeae6db ("module: C= ure the MODULE_LICENSE "GPL" vs. "GPL v2" bogosity") WARNING: function definition argument 'struct platform_device *' should a= lso have an identifier name ERROR: code indent should use tabs where possible WARNING: please, no spaces at the start of a line WARNING: Missing a blank line after declarations WARNING: unnecessary whitespace before a quoted newline Signed-off-by: Krzysztof Kozlowski --- sound/soc/qcom/apq8016_sbc.c | 2 +- sound/soc/qcom/apq8096.c | 2 +- sound/soc/qcom/common.c | 2 +- sound/soc/qcom/lpass-apq8016.c | 2 +- sound/soc/qcom/lpass-cpu.c | 2 +- sound/soc/qcom/lpass-hdmi.c | 2 +- sound/soc/qcom/lpass-ipq806x.c | 2 +- sound/soc/qcom/lpass-platform.c | 2 +- sound/soc/qcom/lpass-sc7180.c | 2 +- sound/soc/qcom/lpass.h | 2 +- sound/soc/qcom/qdsp6/q6afe.c | 8 ++++---- sound/soc/qcom/qdsp6/q6apm-dai.c | 4 ++-- sound/soc/qcom/qdsp6/q6asm.h | 20 ++++++++++---------- sound/soc/qcom/qdsp6/topology.c | 3 ++- sound/soc/qcom/sc7180.c | 2 +- sound/soc/qcom/sc8280xp.c | 2 +- sound/soc/qcom/sdm845.c | 2 +- sound/soc/qcom/sdw.c | 2 +- sound/soc/qcom/sm8250.c | 2 +- sound/soc/qcom/storm.c | 2 +- 20 files changed, 34 insertions(+), 33 deletions(-) diff --git a/sound/soc/qcom/apq8016_sbc.c b/sound/soc/qcom/apq8016_sbc.c index efbdbb4dd753..4834a56eaa88 100644 --- a/sound/soc/qcom/apq8016_sbc.c +++ b/sound/soc/qcom/apq8016_sbc.c @@ -344,4 +344,4 @@ module_platform_driver(apq8016_sbc_platform_driver); =20 MODULE_AUTHOR("Srinivas Kandagatla state =3D Q6APM_STREAM_STOPPED; break; case APM_CLIENT_EVENT_DATA_WRITE_DONE: - spin_lock_irqsave(&prtd->lock, flags); + spin_lock_irqsave(&prtd->lock, flags); prtd->pos +=3D prtd->pcm_count; spin_unlock_irqrestore(&prtd->lock, flags); snd_pcm_period_elapsed(substream); @@ -143,7 +143,7 @@ static void event_handler(uint32_t opcode, uint32_t tok= en, uint32_t *payload, vo =20 break; case APM_CLIENT_EVENT_DATA_READ_DONE: - spin_lock_irqsave(&prtd->lock, flags); + spin_lock_irqsave(&prtd->lock, flags); prtd->pos +=3D prtd->pcm_count; spin_unlock_irqrestore(&prtd->lock, flags); snd_pcm_period_elapsed(substream); diff --git a/sound/soc/qcom/qdsp6/q6asm.h b/sound/soc/qcom/qdsp6/q6asm.h index 0103d8dae5da..519e1b3a3f7c 100644 --- a/sound/soc/qcom/qdsp6/q6asm.h +++ b/sound/soc/qcom/qdsp6/q6asm.h @@ -35,16 +35,16 @@ enum { #define ASM_LAST_BUFFER_FLAG BIT(30) =20 struct q6asm_flac_cfg { - u32 sample_rate; - u32 ext_sample_rate; - u32 min_frame_size; - u32 max_frame_size; - u16 stream_info_present; - u16 min_blk_size; - u16 max_blk_size; - u16 ch_cfg; - u16 sample_size; - u16 md5_sum; + u32 sample_rate; + u32 ext_sample_rate; + u32 min_frame_size; + u32 max_frame_size; + u16 stream_info_present; + u16 min_blk_size; + u16 max_blk_size; + u16 ch_cfg; + u16 sample_size; + u16 md5_sum; }; =20 struct q6asm_wma_cfg { diff --git a/sound/soc/qcom/qdsp6/topology.c b/sound/soc/qcom/qdsp6/topolog= y.c index 130b22a34fb3..70572c83e101 100644 --- a/sound/soc/qcom/qdsp6/topology.c +++ b/sound/soc/qcom/qdsp6/topology.c @@ -545,6 +545,7 @@ static struct audioreach_module *audioreach_parse_commo= n_tokens(struct q6apm *ap =20 if (mod) { int pn, id =3D 0; + mod->module_id =3D module_id; mod->max_ip_port =3D max_ip_port; mod->max_op_port =3D max_op_port; @@ -1271,7 +1272,7 @@ int audioreach_tplg_init(struct snd_soc_component *co= mponent) =20 ret =3D request_firmware(&fw, tplg_fw_name, dev); if (ret < 0) { - dev_err(dev, "tplg firmware loading %s failed %d \n", tplg_fw_name, ret); + dev_err(dev, "tplg firmware loading %s failed %d\n", tplg_fw_name, ret); goto err; } =20 diff --git a/sound/soc/qcom/sc7180.c b/sound/soc/qcom/sc7180.c index b0320a74d508..a15f385ede45 100644 --- a/sound/soc/qcom/sc7180.c +++ b/sound/soc/qcom/sc7180.c @@ -578,4 +578,4 @@ static struct platform_driver sc7180_snd_driver =3D { module_platform_driver(sc7180_snd_driver); =20 MODULE_DESCRIPTION("sc7180 ASoC Machine Driver"); -MODULE_LICENSE("GPL v2"); +MODULE_LICENSE("GPL"); diff --git a/sound/soc/qcom/sc8280xp.c b/sound/soc/qcom/sc8280xp.c index 7c20b25ba3de..7c5a81681a2a 100644 --- a/sound/soc/qcom/sc8280xp.c +++ b/sound/soc/qcom/sc8280xp.c @@ -168,4 +168,4 @@ static struct platform_driver snd_sc8280xp_driver =3D { module_platform_driver(snd_sc8280xp_driver); MODULE_AUTHOR("Srinivas Kandagatla