From nobody Fri Dec 19 00:16:46 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5B84FC4167B for ; Sat, 2 Dec 2023 09:47:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232358AbjLBJrH (ORCPT ); Sat, 2 Dec 2023 04:47:07 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38606 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232310AbjLBJrF (ORCPT ); Sat, 2 Dec 2023 04:47:05 -0500 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.11]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D5BC5181; Sat, 2 Dec 2023 01:47:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1701510432; x=1733046432; h=from:to:cc:subject:date:message-id:in-reply-to: references; bh=zgOH3vLMDlIUcyJqzB7ENWd/3UPYCaFUNvwD3NOa7Mg=; b=kTCuUk0jF3Cet0kEc1nT9o6WBuMhdOP176iSHOBk3UCAA0fNXah5apdy MqtYogUNLf78NWVGbQ2frnCPgpngNy17SrYzTh8lkwU6nKKZC+EVP/Ime 6r+ZsgqT3zOZ2idF3yzkhjjiwCabX+fXcqC6iXQrayh3Dp/XhO2l3zjN9 E2bMkb3VIEg0p/j/bKgZBIx56dCAhdhLvNxJDQynsBB5rnKHN+j34R5Us 2z6ZAKjpXTDEpzSwiFG0Xnt/IojXPengQylXDhoeJDd8MZ8cr5HVDB4nQ QOkIdRa13YL80aNUV00PTkVx5XyjWaagoNJdaXr0qH8melomxngcGRSZu g==; X-IronPort-AV: E=McAfee;i="6600,9927,10911"; a="474342" X-IronPort-AV: E=Sophos;i="6.04,245,1695711600"; d="scan'208";a="474342" Received: from orviesa001.jf.intel.com ([10.64.159.141]) by orvoesa103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Dec 2023 01:47:11 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.04,245,1695711600"; d="scan'208";a="18037347" Received: from yzhao56-desk.sh.intel.com ([10.239.159.62]) by smtpauth.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Dec 2023 01:47:08 -0800 From: Yan Zhao To: iommu@lists.linux.dev, kvm@vger.kernel.org, linux-kernel@vger.kernel.org Cc: alex.williamson@redhat.com, jgg@nvidia.com, pbonzini@redhat.com, seanjc@google.com, joro@8bytes.org, will@kernel.org, robin.murphy@arm.com, kevin.tian@intel.com, baolu.lu@linux.intel.com, dwmw2@infradead.org, yi.l.liu@intel.com, Yan Zhao Subject: [RFC PATCH 07/42] KVM: Forward page fault requests to arch specific code for exported TDP Date: Sat, 2 Dec 2023 17:18:12 +0800 Message-Id: <20231202091812.13830-1-yan.y.zhao@intel.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20231202091211.13376-1-yan.y.zhao@intel.com> References: <20231202091211.13376-1-yan.y.zhao@intel.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Implement .fault op of KVM TDP FD object and pass page fault requests from importers of KVM TDP FD to KVM arch specific code. Since the thread for importers to call .fault op is not vCPU thread and could be a kernel thread, thread "mm" is checked and kthread_use_mm() are called when necessary. Signed-off-by: Yan Zhao --- include/linux/kvm_host.h | 9 +++++++++ virt/kvm/tdp_fd.c | 28 +++++++++++++++++++++++++++- 2 files changed, 36 insertions(+), 1 deletion(-) diff --git a/include/linux/kvm_host.h b/include/linux/kvm_host.h index f73d32eef8833..b76919eec9b72 100644 --- a/include/linux/kvm_host.h +++ b/include/linux/kvm_host.h @@ -2346,6 +2346,8 @@ struct kvm_exported_tdp { #ifdef __KVM_HAVE_ARCH_EXPORTED_TDP int kvm_arch_exported_tdp_init(struct kvm *kvm, struct kvm_exported_tdp *t= dp); void kvm_arch_exported_tdp_destroy(struct kvm_exported_tdp *tdp); +int kvm_arch_fault_exported_tdp(struct kvm_exported_tdp *tdp, unsigned lon= g gfn, + struct kvm_tdp_fault_type type); #else static inline int kvm_arch_exported_tdp_init(struct kvm *kvm, struct kvm_exported_tdp *tdp) @@ -2355,6 +2357,13 @@ static inline int kvm_arch_exported_tdp_init(struct = kvm *kvm, static inline void kvm_arch_exported_tdp_destroy(struct kvm_exported_tdp *= tdp) { } + +static inline int kvm_arch_fault_exported_tdp(struct kvm_exported_tdp *tdp, + unsigned long gfn, + struct kvm_tdp_fault_type type) +{ + return -EOPNOTSUPP; +} #endif /* __KVM_HAVE_ARCH_EXPORTED_TDP */ =20 #endif /* CONFIG_HAVE_KVM_EXPORTED_TDP */ diff --git a/virt/kvm/tdp_fd.c b/virt/kvm/tdp_fd.c index 3271da1a4b2c1..02c9066391ebe 100644 --- a/virt/kvm/tdp_fd.c +++ b/virt/kvm/tdp_fd.c @@ -223,7 +223,33 @@ static void *kvm_tdp_get_metadata(struct kvm_tdp_fd *t= dp_fd) static int kvm_tdp_fault(struct kvm_tdp_fd *tdp_fd, struct mm_struct *mm, unsigned long gfn, struct kvm_tdp_fault_type type) { - return -EOPNOTSUPP; + bool kthread =3D current->mm =3D=3D NULL; + int ret =3D -EINVAL; + + if (!tdp_fd || !tdp_fd->priv || !tdp_fd->priv->kvm) + return -EINVAL; + + if (!type.read && !type.write && !type.exec) + return -EINVAL; + + if (!mm || tdp_fd->priv->kvm->mm !=3D mm) + return -EINVAL; + + if (!mmget_not_zero(mm)) + return -EPERM; + + if (kthread) + kthread_use_mm(mm); + else if (current->mm !=3D mm) + goto out; + + ret =3D kvm_arch_fault_exported_tdp(tdp_fd->priv, gfn, type); + + if (kthread) + kthread_unuse_mm(mm); +out: + mmput(mm); + return ret; } =20 static const struct kvm_exported_tdp_ops exported_tdp_ops =3D { --=20 2.17.1