From nobody Fri Dec 19 00:21:37 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 30667C4167B for ; Fri, 1 Dec 2023 17:22:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229843AbjLARWk (ORCPT ); Fri, 1 Dec 2023 12:22:40 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58438 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229890AbjLARWc (ORCPT ); Fri, 1 Dec 2023 12:22:32 -0500 Received: from mail-pf1-x44a.google.com (mail-pf1-x44a.google.com [IPv6:2607:f8b0:4864:20::44a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3BC0C198 for ; Fri, 1 Dec 2023 09:22:38 -0800 (PST) Received: by mail-pf1-x44a.google.com with SMTP id d2e1a72fcca58-6cddc344b98so3088122b3a.3 for ; Fri, 01 Dec 2023 09:22:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1701451358; x=1702056158; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=5toQfm61AxoDXcHH2HxdKHhT1Jhp0yKNSM0cF/gdzkI=; b=XJ7RDV8gXbnF1z27UPPj/XTXUqF9FROQcVuGqGs/T35Sa7nSQ8/3L3ZeVA5I/eIA+c xNTE90J1AhoQUhent4qaotvTStqMmFSB0bVleXILgq9YpTeFEa5Zhl/prKUaBTUM5I93 +7Qik/jtsINvzF9D9YCmeTIuw7rJGCb5xSGbf4vpnNbOmj0ceEldpf5sASFMyQvgWlly G7r64vG9IrrVevUVd528YvBIqsjjSg1dR043IEA/swJBy/AXRIAS8PkBBydfh0J8VJrV 3CEw+GER+hCm4qIwXfp9X8xAh02SPQGzfdL0EI4VHin6CXr4pqWK07DO4q6AVzGSdzMq 2BuA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701451358; x=1702056158; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=5toQfm61AxoDXcHH2HxdKHhT1Jhp0yKNSM0cF/gdzkI=; b=F+2uqcicpbHoElpyI133sS4dPrHTszAwEcnx2RDbwTgU0tDYX8qMhg+pof8iUoLp+e jdyXITOvaMI0zUxnlhnXyeenTRGNRBUXYs+BoSwROFBhASnkJelmy6hf485x+js2c7NJ IH0bqTst1m0K2vA2Edn6AdHp5cyhc8Ef5OryebSa5TGloMytr23FrEbvuEtIopZVXUYA nI/GI2lY5nhGww2ROZbkXMVb3r/tJ5R154FurPIUjjJQmi0vzCvv+Ds010YdO2ZtZM8/ v5/ezAozmY5OtpTBEnOPzKoQ6EbCtr8/kuNhuq7nfQNtxpYKo4cMO/Iv3Hq6jF5Yfy9E Jyww== X-Gm-Message-State: AOJu0YyRyyOFNjf/kUznBdeKMYM7h5fBDFJvX2efJ+Xe7ScVHjmY1a7k AA+D23KlKVPpposkQeHGlLmbzu0LVFqfYw== X-Google-Smtp-Source: AGHT+IFP/gsG/lerEEDvVYFpMGdlc1rxmXtWWEkLfAZ21X9HZUO53NHr0O+qW03ZYFMUPzd4YffSjhH5v1lNyw== X-Received: from xllamas.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:5070]) (user=cmllamas job=sendgmr) by 2002:a05:6a00:3a03:b0:6cd:810:3875 with SMTP id fj3-20020a056a003a0300b006cd08103875mr4820906pfb.5.1701451357594; Fri, 01 Dec 2023 09:22:37 -0800 (PST) Date: Fri, 1 Dec 2023 17:21:31 +0000 In-Reply-To: <20231201172212.1813387-1-cmllamas@google.com> Mime-Version: 1.0 References: <20231201172212.1813387-1-cmllamas@google.com> X-Mailer: git-send-email 2.43.0.rc2.451.g8631bc7472-goog Message-ID: <20231201172212.1813387-3-cmllamas@google.com> Subject: [PATCH v2 02/28] binder: fix use-after-free in shinker's callback From: Carlos Llamas To: Greg Kroah-Hartman , "=?UTF-8?q?Arve=20Hj=C3=B8nnev=C3=A5g?=" , Todd Kjos , Martijn Coenen , Joel Fernandes , Christian Brauner , Carlos Llamas , Suren Baghdasaryan , Michal Hocko , Andrew Morton , Matthew Wilcox , Vlastimil Babka , "Kirill A. Shutemov" Cc: linux-kernel@vger.kernel.org, kernel-team@android.com, stable@vger.kernel.org, Liam Howlett , Minchan Kim , Alice Ryhl Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The mmap read lock is used during the shrinker's callback, which means that using alloc->vma pointer isn't safe as it can race with munmap(). As of commit dd2283f2605e ("mm: mmap: zap pages with read mmap_sem in munmap") the mmap lock is downgraded after the vma has been isolated. I was able to reproduce this issue by manually adding some delays and triggering page reclaiming through the shrinker's debug sysfs. The following KASAN report confirms the UAF: =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D BUG: KASAN: slab-use-after-free in zap_page_range_single+0x470/0x4b8 Read of size 8 at addr ffff356ed50e50f0 by task bash/478 CPU: 1 PID: 478 Comm: bash Not tainted 6.6.0-rc5-00055-g1c8b86a3799f-dirt= y #70 Hardware name: linux,dummy-virt (DT) Call trace: zap_page_range_single+0x470/0x4b8 binder_alloc_free_page+0x608/0xadc __list_lru_walk_one+0x130/0x3b0 list_lru_walk_node+0xc4/0x22c binder_shrink_scan+0x108/0x1dc shrinker_debugfs_scan_write+0x2b4/0x500 full_proxy_write+0xd4/0x140 vfs_write+0x1ac/0x758 ksys_write+0xf0/0x1dc __arm64_sys_write+0x6c/0x9c Allocated by task 492: kmem_cache_alloc+0x130/0x368 vm_area_alloc+0x2c/0x190 mmap_region+0x258/0x18bc do_mmap+0x694/0xa60 vm_mmap_pgoff+0x170/0x29c ksys_mmap_pgoff+0x290/0x3a0 __arm64_sys_mmap+0xcc/0x144 Freed by task 491: kmem_cache_free+0x17c/0x3c8 vm_area_free_rcu_cb+0x74/0x98 rcu_core+0xa38/0x26d4 rcu_core_si+0x10/0x1c __do_softirq+0x2fc/0xd24 Last potentially related work creation: __call_rcu_common.constprop.0+0x6c/0xba0 call_rcu+0x10/0x1c vm_area_free+0x18/0x24 remove_vma+0xe4/0x118 do_vmi_align_munmap.isra.0+0x718/0xb5c do_vmi_munmap+0xdc/0x1fc __vm_munmap+0x10c/0x278 __arm64_sys_munmap+0x58/0x7c Fix this issue by performing instead a vma_lookup() which will fail to find the vma that was isolated before the mmap lock downgrade. Note that this option has better performance than upgrading to a mmap write lock which would increase contention. Plus, mmap_write_trylock() has been recently removed anyway. Fixes: dd2283f2605e ("mm: mmap: zap pages with read mmap_sem in munmap") Cc: stable@vger.kernel.org Cc: Liam Howlett Cc: Minchan Kim Reviewed-by: Alice Ryhl Signed-off-by: Carlos Llamas --- drivers/android/binder_alloc.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/android/binder_alloc.c b/drivers/android/binder_alloc.c index 138f6d43d13b..9d2eff70c3ba 100644 --- a/drivers/android/binder_alloc.c +++ b/drivers/android/binder_alloc.c @@ -1005,7 +1005,9 @@ enum lru_status binder_alloc_free_page(struct list_he= ad *item, goto err_mmget; if (!mmap_read_trylock(mm)) goto err_mmap_read_lock_failed; - vma =3D binder_alloc_get_vma(alloc); + vma =3D vma_lookup(mm, page_addr); + if (vma && vma !=3D binder_alloc_get_vma(alloc)) + goto err_invalid_vma; =20 list_lru_isolate(lru, item); spin_unlock(lock); @@ -1031,6 +1033,8 @@ enum lru_status binder_alloc_free_page(struct list_he= ad *item, mutex_unlock(&alloc->mutex); return LRU_REMOVED_RETRY; =20 +err_invalid_vma: + mmap_read_unlock(mm); err_mmap_read_lock_failed: mmput_async(mm); err_mmget: --=20 2.43.0.rc2.451.g8631bc7472-goog