From nobody Fri Dec 19 00:21:57 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 53AB3C4167B for ; Fri, 1 Dec 2023 17:24:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1379026AbjLARYP (ORCPT ); Fri, 1 Dec 2023 12:24:15 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56964 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1379175AbjLARXo (ORCPT ); Fri, 1 Dec 2023 12:23:44 -0500 Received: from mail-pf1-x449.google.com (mail-pf1-x449.google.com [IPv6:2607:f8b0:4864:20::449]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F22B8D67 for ; Fri, 1 Dec 2023 09:23:14 -0800 (PST) Received: by mail-pf1-x449.google.com with SMTP id d2e1a72fcca58-6cdce35ba97so2290093b3a.1 for ; Fri, 01 Dec 2023 09:23:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1701451394; x=1702056194; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=QR9ctGv6DD/cqnUAnvJkNGQFqKISSIWTJ6FZIk1lfN4=; b=wCbM/KSaVwi7PC7GtldqNVElZrfj1iPzjGR1U+YLPcdsVRh95S6QRJC3MLzvV1nWLz 25cx73QUO7eNj+/r1lKLQnP6dCj03xr+0WoD5AFtWY/L4BHTE+oCVZSrgo/rsA2sJ/Ar xAOw+j/CPPqOdqOqV1mKPwpVtXdzjzVhOfYJW3j83hBniuo+FbnphVAJCQS0N9Gqbut4 9MGgmoxyNhed9EgnSy/TVHeUzvl9WhqWO0UrQLuqF7X2Q5BNLsGSshEUOYIqG0nwiJ4W kr8n45DN881EUNHA3cL1UdHPS5PzMK2biTdMuY+UAgF3sVfQPo/INA/UK3P7sKZAM8i0 tSxg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701451394; x=1702056194; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=QR9ctGv6DD/cqnUAnvJkNGQFqKISSIWTJ6FZIk1lfN4=; b=Lh1nokrCchsNWqlFsrbVHx2DSNdM5DHLa2zRdCRsEG3POuw1wbdfxP6C665EK39OCt 0EzQrCScrjudrSx3W471/4gRMEnpwtOEq8+eheygBQS5olpKdeLWwZu/up3afJvbb3zR Su+WCUIYbA5G2UDAkCGvVeTL0fQj9yDL25Vao9j/Wu5me7gfphW2okwXm5OoSN20LZFx LFoZH2ApDBNHxMcyIhzSNOEWn2/l1X5U93dbuuyKVoBDMf10U+NcPjZdqD5iYfGwCEjV 0is1F5ZsrcS0fdcxiOxwLHXcJl04+yGhK7pbm0rAyzOl0pgRaOoW8+z0YhyfqNj7V3sp YDTw== X-Gm-Message-State: AOJu0YyLxKLu5b0FsZb/KGg8PKT+yoJ6qD4eADGhEpZbC38y+WdmPdpn +CE5SH/a96qN1QJnPtEvoptIXLwIU3d+1Q== X-Google-Smtp-Source: AGHT+IEexwbU8eN6740SghoQkSxMhFv/B/1u51ES3uwG8/KHafMGFnD86hKF60W+Rzj1qsnFaJzcX5jfs7xDAQ== X-Received: from xllamas.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:5070]) (user=cmllamas job=sendgmr) by 2002:a05:6a00:179a:b0:6cd:dda3:4a5e with SMTP id s26-20020a056a00179a00b006cddda34a5emr1443775pfg.0.1701451394219; Fri, 01 Dec 2023 09:23:14 -0800 (PST) Date: Fri, 1 Dec 2023 17:21:47 +0000 In-Reply-To: <20231201172212.1813387-1-cmllamas@google.com> Mime-Version: 1.0 References: <20231201172212.1813387-1-cmllamas@google.com> X-Mailer: git-send-email 2.43.0.rc2.451.g8631bc7472-goog Message-ID: <20231201172212.1813387-19-cmllamas@google.com> Subject: [PATCH v2 18/28] binder: initialize lru pages in mmap callback From: Carlos Llamas To: Greg Kroah-Hartman , "=?UTF-8?q?Arve=20Hj=C3=B8nnev=C3=A5g?=" , Todd Kjos , Martijn Coenen , Joel Fernandes , Christian Brauner , Carlos Llamas , Suren Baghdasaryan Cc: linux-kernel@vger.kernel.org, kernel-team@android.com, Alice Ryhl Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Rather than repeatedly initializing some of the binder_lru_page members during binder_alloc_new_buf(), perform this initialization just once in binder_alloc_mmap_handler(), after the pages have been created. Reviewed-by: Alice Ryhl Signed-off-by: Carlos Llamas --- drivers/android/binder_alloc.c | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/drivers/android/binder_alloc.c b/drivers/android/binder_alloc.c index 86f4929a55d5..25efdbb2ad5d 100644 --- a/drivers/android/binder_alloc.c +++ b/drivers/android/binder_alloc.c @@ -274,9 +274,6 @@ static int binder_allocate_page_range(struct binder_all= oc *alloc, =20 trace_binder_alloc_page_start(alloc, index); =20 - page->alloc =3D alloc; - INIT_LIST_HEAD(&page->lru); - ret =3D binder_install_single_page(alloc, page, page_addr); if (ret) { binder_free_page_range(alloc, start, page_addr); @@ -798,9 +795,9 @@ void binder_alloc_free_buf(struct binder_alloc *alloc, int binder_alloc_mmap_handler(struct binder_alloc *alloc, struct vm_area_struct *vma) { - int ret; - const char *failure_string; struct binder_buffer *buffer; + const char *failure_string; + int ret, i; =20 if (unlikely(vma->vm_mm !=3D alloc->mm)) { ret =3D -EINVAL; @@ -829,6 +826,11 @@ int binder_alloc_mmap_handler(struct binder_alloc *all= oc, goto err_alloc_pages_failed; } =20 + for (i =3D 0; i < alloc->buffer_size / PAGE_SIZE; i++) { + alloc->pages[i].alloc =3D alloc; + INIT_LIST_HEAD(&alloc->pages[i].lru); + } + buffer =3D kzalloc(sizeof(*buffer), GFP_KERNEL); if (!buffer) { ret =3D -ENOMEM; --=20 2.43.0.rc2.451.g8631bc7472-goog