From nobody Fri Dec 19 00:21:58 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6480CC07E97 for ; Fri, 1 Dec 2023 17:24:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1379031AbjLARXv (ORCPT ); Fri, 1 Dec 2023 12:23:51 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56636 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1378918AbjLARXW (ORCPT ); Fri, 1 Dec 2023 12:23:22 -0500 Received: from mail-yw1-x1149.google.com (mail-yw1-x1149.google.com [IPv6:2607:f8b0:4864:20::1149]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3EAFE213F for ; Fri, 1 Dec 2023 09:23:06 -0800 (PST) Received: by mail-yw1-x1149.google.com with SMTP id 00721157ae682-5d351694be7so36187377b3.3 for ; Fri, 01 Dec 2023 09:23:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1701451385; x=1702056185; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=1KXql4wc+B0IDfmvDFaObCPkY77Q514P/MmfpNkLzgI=; b=M+bqfT9T8evUTZ1pFdI4N6i5T8Xk0Zvwi5VEVhZOnXvtp3ZL0wTXPKHNzSBoIAq5/q 5DCGCb/RjZULPDqEMP8vj6m7qtuOhxrdE11Em1ztze1+Dxl2yc3jJX6zl6H0WbQHIbO9 DOxSE6DI7Gxh90UycdWhWcGfDxyKQXN5Yx3lgSG8t7X52Lu+Ai48ietxlK3lEHFNgTHU fhj1l6Vvxkg3flyT/H4J9WxwgjSF4xG179FTUMbbCNRtVXHTGsxFCtSLHSfvCDg5c5Ux PMd5prU7KXP7fIk16smzFUDo+F6I7QwZz84TXx72l+mLdNIZzSxk83GjAqyHrXx8Eiep pN5A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701451385; x=1702056185; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=1KXql4wc+B0IDfmvDFaObCPkY77Q514P/MmfpNkLzgI=; b=K7gtA0Odg8kbEhrEX7XPa9aN5BLImXycoDKkx0kWBfG/jRtjvoWPvKkqRvWCPkGTn8 N3BL8hL2IRpAAC+/sbVFLGCDdFFsQdTIhtLWGCGfCzx9Vi9IK4GHd9CQdoz+smlmHfZO hki+QMjHB69LLHzCcrEct4xfA0QmnxhX+eLQlZqYC24wkSjTdRcP/L8q3TZmDiaCHrkM 13VMT4t/5/h5DVjY0EFhkj6SsC7MNrvqwSI7XTj3uJZV7RP1QI0YL9exy9uWhNuoH65j beN1cNbGQHnqnr+gdSLW5Xv8FWoRwobmSJm40P3Yhb19/lF/Rtm0XG78zFsETfqTumBx NCPw== X-Gm-Message-State: AOJu0Ywr3Ma0AyGepxtQpxM9hdJK4Uu0wP60HAqNrb+hIzBhB252ZS4V sXr3w9r4NE63Qc9DQ5BfbUNq/oo0AC2wGg== X-Google-Smtp-Source: AGHT+IFhseDzf0QLmLKgkUTC0f58HJNz0EaZSlWzIkg1xf1J6ybgpA+ysszFrIFqvmXlBO38X34s0f5h4tUb6g== X-Received: from xllamas.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:5070]) (user=cmllamas job=sendgmr) by 2002:a05:690c:2d06:b0:5d4:1e95:1e8a with SMTP id eq6-20020a05690c2d0600b005d41e951e8amr83602ywb.4.1701451385313; Fri, 01 Dec 2023 09:23:05 -0800 (PST) Date: Fri, 1 Dec 2023 17:21:43 +0000 In-Reply-To: <20231201172212.1813387-1-cmllamas@google.com> Mime-Version: 1.0 References: <20231201172212.1813387-1-cmllamas@google.com> X-Mailer: git-send-email 2.43.0.rc2.451.g8631bc7472-goog Message-ID: <20231201172212.1813387-15-cmllamas@google.com> Subject: [PATCH v2 14/28] binder: relocate low space calculation From: Carlos Llamas To: Greg Kroah-Hartman , "=?UTF-8?q?Arve=20Hj=C3=B8nnev=C3=A5g?=" , Todd Kjos , Martijn Coenen , Joel Fernandes , Christian Brauner , Carlos Llamas , Suren Baghdasaryan Cc: linux-kernel@vger.kernel.org, kernel-team@android.com, Alice Ryhl Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Move the low async space calculation to debug_low_async_space_locked(). This logic not only fits better here but also offloads some of the many tasks currently done in binder_alloc_new_buf_locked(). No functional change in this patch. Reviewed-by: Alice Ryhl Signed-off-by: Carlos Llamas --- drivers/android/binder_alloc.c | 21 +++++++++++---------- 1 file changed, 11 insertions(+), 10 deletions(-) diff --git a/drivers/android/binder_alloc.c b/drivers/android/binder_alloc.c index 3dca7b199246..167ee6f871dc 100644 --- a/drivers/android/binder_alloc.c +++ b/drivers/android/binder_alloc.c @@ -371,6 +371,15 @@ static bool debug_low_async_space_locked(struct binder= _alloc *alloc) size_t num_buffers =3D 0; struct rb_node *n; =20 + /* + * Only start detecting spammers once we have less than 20% of async + * space left (which is less than 10% of total buffer size). + */ + if (alloc->free_async_space >=3D alloc->buffer_size / 10) { + alloc->oneway_spam_detected =3D false; + return false; + } + for (n =3D rb_first(&alloc->allocated_buffers); n !=3D NULL; n =3D rb_next(n)) { buffer =3D rb_entry(n, struct binder_buffer, rb_node); @@ -491,16 +500,8 @@ static struct binder_buffer *binder_alloc_new_buf_lock= ed( binder_alloc_debug(BINDER_DEBUG_BUFFER_ALLOC_ASYNC, "%d: binder_alloc_buf size %zd async free %zd\n", alloc->pid, size, alloc->free_async_space); - if (alloc->free_async_space < alloc->buffer_size / 10) { - /* - * Start detecting spammers once we have less than 20% - * of async space left (which is less than 10% of total - * buffer size). - */ - buffer->oneway_spam_suspect =3D debug_low_async_space_locked(alloc); - } else { - alloc->oneway_spam_detected =3D false; - } + if (debug_low_async_space_locked(alloc)) + buffer->oneway_spam_suspect =3D true; } =20 return buffer; --=20 2.43.0.rc2.451.g8631bc7472-goog