From nobody Fri Dec 19 00:21:17 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E89F1C10F04 for ; Fri, 1 Dec 2023 16:38:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1378852AbjLAQhy (ORCPT ); Fri, 1 Dec 2023 11:37:54 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34574 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1378604AbjLAQha (ORCPT ); Fri, 1 Dec 2023 11:37:30 -0500 Received: from relay6-d.mail.gandi.net (relay6-d.mail.gandi.net [217.70.183.198]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AED881986; Fri, 1 Dec 2023 08:37:25 -0800 (PST) Received: by mail.gandi.net (Postfix) with ESMTPSA id 37CBEC0011; Fri, 1 Dec 2023 16:37:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1701448644; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=qP/8ocJ/dqKsRX12Co8UhuKkpSAILqQvsIAG4JFJivY=; b=HV8EfGS9wM/gOZEFEKMlraKNu+2YD9V7H4ldYc8vosNV28+YFXs73h5JIYoNsOeSDf8u2W ksDAF5Rp5nf2e4hOOSWH9a+dnizwnvAGYbIEjygeAwSLPOer7olFQmTICbyoZNKQ761XIu Y27AW0SWZav3FUqchfQUpA571ysXXhfOlg5YZfV1ixTh8qh2HFWELNTK771UZtxrb2HORi 20691dNwP23xU9rZs/NH/baBiryYSnmhYJdM0WichEzpYORMG+cutfvBKhTZlOhU8Ts2rp sEaMQJaryhauKnsmun3liC6ZuXgKKZPmTkw107rkWlGNNLKGFr646aFXdrwz1g== From: Maxime Chevallier To: davem@davemloft.net Cc: Maxime Chevallier , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, thomas.petazzoni@bootlin.com, Andrew Lunn , Jakub Kicinski , Eric Dumazet , Paolo Abeni , Russell King , linux-arm-kernel@lists.infradead.org, Christophe Leroy , Herve Codina , Florian Fainelli , Heiner Kallweit , Vladimir Oltean , =?UTF-8?q?K=C3=B6ry=20Maincent?= , Jesse Brandeburg , Jonathan Corbet , =?UTF-8?q?Marek=20Beh=C3=BAn?= , Piergiorgio Beruto , Oleksij Rempel , =?UTF-8?q?Nicol=C3=B2=20Veronese?= Subject: [RFC PATCH net-next v3 12/13] net: ethtool: strset: Allow querying phy stats by index Date: Fri, 1 Dec 2023 17:37:02 +0100 Message-ID: <20231201163704.1306431-13-maxime.chevallier@bootlin.com> X-Mailer: git-send-email 2.42.0 In-Reply-To: <20231201163704.1306431-1-maxime.chevallier@bootlin.com> References: <20231201163704.1306431-1-maxime.chevallier@bootlin.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-GND-Sasl: maxime.chevallier@bootlin.com Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" The ETH_SS_PHY_STATS command gets PHY statistics. Use the phydev pointer from the ethnl request to allow query phy stats from each PHY on the link. Signed-off-by: Maxime Chevallier --- V3: No changes V2: New patch net/ethtool/strset.c | 15 ++++++++------- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/net/ethtool/strset.c b/net/ethtool/strset.c index c678b484a079..70c00631c51f 100644 --- a/net/ethtool/strset.c +++ b/net/ethtool/strset.c @@ -233,17 +233,18 @@ static void strset_cleanup_data(struct ethnl_reply_da= ta *reply_base) } =20 static int strset_prepare_set(struct strset_info *info, struct net_device = *dev, - unsigned int id, bool counts_only) + struct phy_device *phydev, unsigned int id, + bool counts_only) { const struct ethtool_phy_ops *phy_ops =3D ethtool_phy_ops; const struct ethtool_ops *ops =3D dev->ethtool_ops; void *strings; int count, ret; =20 - if (id =3D=3D ETH_SS_PHY_STATS && dev->phydev && + if (id =3D=3D ETH_SS_PHY_STATS && phydev && !ops->get_ethtool_phy_stats && phy_ops && phy_ops->get_sset_count) - ret =3D phy_ops->get_sset_count(dev->phydev); + ret =3D phy_ops->get_sset_count(phydev); else if (ops->get_sset_count && ops->get_strings) ret =3D ops->get_sset_count(dev, id); else @@ -258,10 +259,10 @@ static int strset_prepare_set(struct strset_info *inf= o, struct net_device *dev, strings =3D kcalloc(count, ETH_GSTRING_LEN, GFP_KERNEL); if (!strings) return -ENOMEM; - if (id =3D=3D ETH_SS_PHY_STATS && dev->phydev && + if (id =3D=3D ETH_SS_PHY_STATS && phydev && !ops->get_ethtool_phy_stats && phy_ops && phy_ops->get_strings) - phy_ops->get_strings(dev->phydev, strings); + phy_ops->get_strings(phydev, strings); else ops->get_strings(dev, id, strings); info->strings =3D strings; @@ -305,8 +306,8 @@ static int strset_prepare_data(const struct ethnl_req_i= nfo *req_base, !data->sets[i].per_dev) continue; =20 - ret =3D strset_prepare_set(&data->sets[i], dev, i, - req_info->counts_only); + ret =3D strset_prepare_set(&data->sets[i], dev, req_base->phydev, + i, req_info->counts_only); if (ret < 0) goto err_ops; } --=20 2.42.0