From nobody Fri Dec 19 00:21:15 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 903FDC10F04 for ; Fri, 1 Dec 2023 16:38:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1378814AbjLAQhw (ORCPT ); Fri, 1 Dec 2023 11:37:52 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55474 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1378448AbjLAQh3 (ORCPT ); Fri, 1 Dec 2023 11:37:29 -0500 Received: from relay6-d.mail.gandi.net (relay6-d.mail.gandi.net [217.70.183.198]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 74B21173A; Fri, 1 Dec 2023 08:37:24 -0800 (PST) Received: by mail.gandi.net (Postfix) with ESMTPSA id E913EC000E; Fri, 1 Dec 2023 16:37:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1701448643; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=IrIqVHTv4OFpjH8swPAPtlm1OVsBZBIxDm7JNwM2hes=; b=DowcDovDfXhbCr83jjB6+e7vCvtHLWw+3yqvIj8oZU1U0KnCUh8eJ6SZcQv1B80liC7gQ4 VnIikbXDRGHTlL/9OIYmyydIer/u5RE8jXn+MPtZ96JT0ROkwyAjy87cGAfWTmtbPmAzgZ SkZ2hjw5KQS+rbXvQLZzG2uTuevCsaWMj1kApe609ZFEyJp2T9tTes0lAI/PJS0w3VY1jT 7sFcU5hqDulKniBa3Z93qCjqFWrusADdrMNHUEWgSzYWO9Wl3nKZx0C9F7KrjWnqNXrhxS J7Q3oRa+nZC0l4LgqafpwL2DywD3wPRM/QEpWfrsWGW3FKJYjEws4sN8/I5ELg== From: Maxime Chevallier To: davem@davemloft.net Cc: Maxime Chevallier , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, thomas.petazzoni@bootlin.com, Andrew Lunn , Jakub Kicinski , Eric Dumazet , Paolo Abeni , Russell King , linux-arm-kernel@lists.infradead.org, Christophe Leroy , Herve Codina , Florian Fainelli , Heiner Kallweit , Vladimir Oltean , =?UTF-8?q?K=C3=B6ry=20Maincent?= , Jesse Brandeburg , Jonathan Corbet , =?UTF-8?q?Marek=20Beh=C3=BAn?= , Piergiorgio Beruto , Oleksij Rempel , =?UTF-8?q?Nicol=C3=B2=20Veronese?= Subject: [RFC PATCH net-next v3 11/13] net: ethtool: cable-test: Target the command to the requested PHY Date: Fri, 1 Dec 2023 17:37:01 +0100 Message-ID: <20231201163704.1306431-12-maxime.chevallier@bootlin.com> X-Mailer: git-send-email 2.42.0 In-Reply-To: <20231201163704.1306431-1-maxime.chevallier@bootlin.com> References: <20231201163704.1306431-1-maxime.chevallier@bootlin.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-GND-Sasl: maxime.chevallier@bootlin.com Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Cable testing is a PHY-specific command. Instead of targeting the command towards dev->phydev, use the request to pick the targeted PHY. Signed-off-by: Maxime Chevallier --- V3: No changes V2: New patch net/ethtool/cabletest.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/net/ethtool/cabletest.c b/net/ethtool/cabletest.c index 06a151165c31..6b00d0800f23 100644 --- a/net/ethtool/cabletest.c +++ b/net/ethtool/cabletest.c @@ -69,7 +69,7 @@ int ethnl_act_cable_test(struct sk_buff *skb, struct genl= _info *info) return ret; =20 dev =3D req_info.dev; - if (!dev->phydev) { + if (!req_info.phydev) { ret =3D -EOPNOTSUPP; goto out_dev_put; } @@ -85,12 +85,12 @@ int ethnl_act_cable_test(struct sk_buff *skb, struct ge= nl_info *info) if (ret < 0) goto out_rtnl; =20 - ret =3D ops->start_cable_test(dev->phydev, info->extack); + ret =3D ops->start_cable_test(req_info.phydev, info->extack); =20 ethnl_ops_complete(dev); =20 if (!ret) - ethnl_cable_test_started(dev->phydev, + ethnl_cable_test_started(req_info.phydev, ETHTOOL_MSG_CABLE_TEST_NTF); =20 out_rtnl: @@ -321,7 +321,7 @@ int ethnl_act_cable_test_tdr(struct sk_buff *skb, struc= t genl_info *info) return ret; =20 dev =3D req_info.dev; - if (!dev->phydev) { + if (!req_info.phydev) { ret =3D -EOPNOTSUPP; goto out_dev_put; } @@ -342,12 +342,12 @@ int ethnl_act_cable_test_tdr(struct sk_buff *skb, str= uct genl_info *info) if (ret < 0) goto out_rtnl; =20 - ret =3D ops->start_cable_test_tdr(dev->phydev, info->extack, &cfg); + ret =3D ops->start_cable_test_tdr(req_info.phydev, info->extack, &cfg); =20 ethnl_ops_complete(dev); =20 if (!ret) - ethnl_cable_test_started(dev->phydev, + ethnl_cable_test_started(req_info.phydev, ETHTOOL_MSG_CABLE_TEST_TDR_NTF); =20 out_rtnl: --=20 2.42.0