From nobody Fri Dec 19 00:22:51 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D533BC07E97 for ; Fri, 1 Dec 2023 15:14:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1379391AbjLAPOp (ORCPT ); Fri, 1 Dec 2023 10:14:45 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50898 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1379370AbjLAPOl (ORCPT ); Fri, 1 Dec 2023 10:14:41 -0500 Received: from mail-pf1-x432.google.com (mail-pf1-x432.google.com [IPv6:2607:f8b0:4864:20::432]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BBA7F10E4 for ; Fri, 1 Dec 2023 07:14:46 -0800 (PST) Received: by mail-pf1-x432.google.com with SMTP id d2e1a72fcca58-6cdcef8b400so2183706b3a.1 for ; Fri, 01 Dec 2023 07:14:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1701443686; x=1702048486; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=beKD8U42oVG/LPkYMpuiHwtdIQIz07SaBd5mVxpojp4=; b=GsWDNJ7hcVWO7R7fS8kXZDkRU2GrEiO8pQAEWP2PXr3Rt4UdOhlW6LDNwy6zg/1uu3 w9Ty/ny+sn9lQKWroXzOJi5eqAUP2ZfVQNWql/Rb5mHejSMIdCUC1mSmgGODT1DVnRFk pnhuTLXsyNXcRxt5/4dJ3PYZtu4zgo1U+DJpmz3NL5navh0bAxkxUEGWBBpuqlgN8AF5 DPCcILbCCojk+mDxDBv+bUQaUk6pTuRL1ImtnS5C4kwexq6o8uz4R9kxuf134WZKhXGj sbm73cOkgsE2fuFoFg8vk/o57wWBfgeAdKC4t8s8mQ4f/MwwaCMIGWLnoboOCB9Xt/If l2kg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701443686; x=1702048486; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=beKD8U42oVG/LPkYMpuiHwtdIQIz07SaBd5mVxpojp4=; b=WQ2hfvsLJiQNnFRIJ1q9a7SH2bHyzYoqacus4wabh1PPQ3JR5jsLz8dY9XtolGOSY1 SMdWMi8fHhoEINtn39Nm+v1LjW12LHVrJ7YVqNxQv6DN0t4Ky54L4QfkNdRsXY8lhM+6 9s6mJR9yLMfW10oKLt1lE+nOXQpRpdZA2paTy+I+SO3+qYCnKtvSG1a3mV6BR++sio7Q UgSEvcGWRkk0Y0zG+FC1BqPaLt23ovdgdkvQL5phUDEKbPUfJa+KTQ59VUUyaAgG/XJ6 Q133r9ziO4Vm9A28Uvu17imdeeKj4Mjjp+K+wba3PBWFMnBQR7KG4kBuPv+lSSItI1Iy +4OQ== X-Gm-Message-State: AOJu0YxdUz+Huae/RKT7ScoFXU8CLjUjKyMZfQRE+zWlRdQZm5NNvgLA mK7FaYRZ5dK1vyqDIKDLcLAu X-Google-Smtp-Source: AGHT+IEI1gQxHgxIVFSXBW3Lr4VkCQKmvityUZ3YN6dTPUUdQJ6TYB6K3ddDoLazcxETDunDTEe2MA== X-Received: by 2002:a05:6a20:9712:b0:187:9f15:bfc7 with SMTP id hr18-20020a056a20971200b001879f15bfc7mr22594590pzc.27.1701443681635; Fri, 01 Dec 2023 07:14:41 -0800 (PST) Received: from localhost.localdomain ([117.213.98.226]) by smtp.gmail.com with ESMTPSA id s14-20020a65644e000000b00578afd8e012sm2765824pgv.92.2023.12.01.07.14.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Dec 2023 07:14:41 -0800 (PST) From: Manivannan Sadhasivam To: martin.petersen@oracle.com, jejb@linux.ibm.com Cc: andersson@kernel.org, konrad.dybcio@linaro.org, linux-arm-msm@vger.kernel.org, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, quic_cang@quicinc.com, Manivannan Sadhasivam Subject: [PATCH 04/13] scsi: ufs: qcom: Remove superfluous variable assignments Date: Fri, 1 Dec 2023 20:44:08 +0530 Message-Id: <20231201151417.65500-5-manivannan.sadhasivam@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20231201151417.65500-1-manivannan.sadhasivam@linaro.org> References: <20231201151417.65500-1-manivannan.sadhasivam@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" There are many instances where the variable assignments are not needed. Remove them. Signed-off-by: Manivannan Sadhasivam Reviewed-by: Andrew Halaney --- drivers/ufs/host/ufs-qcom.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/ufs/host/ufs-qcom.c b/drivers/ufs/host/ufs-qcom.c index 778df0a9c65e..dc93b1c5ca74 100644 --- a/drivers/ufs/host/ufs-qcom.c +++ b/drivers/ufs/host/ufs-qcom.c @@ -219,7 +219,7 @@ static int ufs_qcom_enable_lane_clks(struct ufs_qcom_ho= st *host) =20 static int ufs_qcom_init_lane_clks(struct ufs_qcom_host *host) { - int err =3D 0; + int err; struct device *dev =3D host->hba->dev; =20 if (has_acpi_companion(dev)) @@ -237,7 +237,7 @@ static int ufs_qcom_init_lane_clks(struct ufs_qcom_host= *host) static int ufs_qcom_check_hibern8(struct ufs_hba *hba) { int err; - u32 tx_fsm_val =3D 0; + u32 tx_fsm_val; unsigned long timeout =3D jiffies + msecs_to_jiffies(HBRN8_POLL_TOUT_MS); =20 do { @@ -292,9 +292,9 @@ static void ufs_qcom_select_unipro_mode(struct ufs_qcom= _host *host) */ static int ufs_qcom_host_reset(struct ufs_hba *hba) { - int ret =3D 0; + int ret; struct ufs_qcom_host *host =3D ufshcd_get_variant(hba); - bool reenable_intr =3D false; + bool reenable_intr; =20 if (!host->core_reset) { dev_warn(hba->dev, "%s: reset control not set\n", __func__); @@ -417,7 +417,7 @@ static int ufs_qcom_hce_enable_notify(struct ufs_hba *h= ba, enum ufs_notify_change_status status) { struct ufs_qcom_host *host =3D ufshcd_get_variant(hba); - int err =3D 0; + int err; =20 switch (status) { case PRE_CHANGE: @@ -463,7 +463,7 @@ static int ufs_qcom_cfg_timers(struct ufs_hba *hba, u32= gear, u32 core_clk_period_in_ns; u32 tx_clk_cycles_per_us =3D 0; unsigned long core_clk_rate =3D 0; - u32 core_clk_cycles_per_us =3D 0; + u32 core_clk_cycles_per_us; =20 static u32 pwm_fr_table[][2] =3D { {UFS_PWM_G1, 0x1}, @@ -1418,7 +1418,7 @@ static int ufs_qcom_clk_scale_notify(struct ufs_hba *= hba, bool scale_up, enum ufs_notify_change_status status) { struct ufs_qcom_host *host =3D ufshcd_get_variant(hba); - int err =3D 0; + int err; =20 /* check the host controller state before sending hibern8 cmd */ if (!ufshcd_is_hba_active(hba)) @@ -1689,7 +1689,7 @@ static int ufs_qcom_mcq_config_resource(struct ufs_hb= a *hba) struct platform_device *pdev =3D to_platform_device(hba->dev); struct ufshcd_res_info *res; struct resource *res_mem, *res_mcq; - int i, ret =3D 0; + int i, ret; =20 memcpy(hba->res, ufs_res_info, sizeof(ufs_res_info)); =20 --=20 2.25.1