From nobody Tue Dec 16 16:41:22 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CF19DC4167B for ; Fri, 1 Dec 2023 14:25:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1379166AbjLAOZF (ORCPT ); Fri, 1 Dec 2023 09:25:05 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52558 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1379143AbjLAOZD (ORCPT ); Fri, 1 Dec 2023 09:25:03 -0500 Received: from gloria.sntech.de (gloria.sntech.de [185.11.138.130]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 911E610F4; Fri, 1 Dec 2023 06:25:08 -0800 (PST) Received: from i53875b61.versanet.de ([83.135.91.97] helo=phil.lan) by gloria.sntech.de with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1r94Rs-0000PA-CQ; Fri, 01 Dec 2023 15:24:56 +0100 From: Heiko Stuebner To: andrew@lunn.ch, hkallweit1@gmail.com Cc: linux@armlinux.org.uk, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, quentin.schulz@theobroma-systems.com, heiko@sntech.de, Heiko Stuebner Subject: [PATCH] net: mdio: enable optional clock when registering a phy from devicetree Date: Fri, 1 Dec 2023 15:24:53 +0100 Message-Id: <20231201142453.324697-1-heiko@sntech.de> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" From: Heiko Stuebner The ethernet-phy binding (now) specifys that phys can declare a clock supply. Phy driver itself will handle this when probing the phy-driver. But there is a gap when trying to detect phys, because the mdio-bus needs to talk to the phy to get its phy-id. Using actual phy-ids in the dt like compatible =3D "ethernet-phy-id0022.1640", "ethernet-phy-ieee802.3-c22"; of course circumvents this, but in turn hard-codes the phy. With boards often having multiple phy options and the mdio-bus being able to actually probe devices, this feels like a step back. So check for the existence of a phy-clock per the -dtbinding in the of_mdiobus_register_phy() and enable the clock around the fwnode_mdiobus_register_phy() call which tries to determine the phy-id. Signed-off-by: Heiko Stuebner --- drivers/net/mdio/of_mdio.c | 34 +++++++++++++++++++++++++++++++++- 1 file changed, 33 insertions(+), 1 deletion(-) diff --git a/drivers/net/mdio/of_mdio.c b/drivers/net/mdio/of_mdio.c index 64ebcb6d235c..895b12849b23 100644 --- a/drivers/net/mdio/of_mdio.c +++ b/drivers/net/mdio/of_mdio.c @@ -8,6 +8,7 @@ * out of the OpenFirmware device tree and using it to populate an mii_bus. */ =20 +#include #include #include #include @@ -15,6 +16,7 @@ #include #include #include +#include #include #include #include @@ -46,7 +48,37 @@ EXPORT_SYMBOL(of_mdiobus_phy_device_register); static int of_mdiobus_register_phy(struct mii_bus *mdio, struct device_node *child, u32 addr) { - return fwnode_mdiobus_register_phy(mdio, of_fwnode_handle(child), addr); + struct clk *clk =3D NULL; + int ret; + + /* ethernet-phy binding specifies a maximum of 1 clock */ + if (of_clk_get_parent_count(child) =3D=3D 1) { + clk =3D of_clk_get(child, 0); + if (IS_ERR(clk)) { + if (PTR_ERR(clk) !=3D -ENOENT) + return dev_err_probe(&mdio->dev, PTR_ERR(clk), + "Could not get defined clock for MDIO device at address %u\n", + addr); + + clk =3D NULL; + } + } + + ret =3D clk_prepare_enable(clk); + if (ret < 0) { + clk_put(clk); + dev_err(&mdio->dev, + "Could not enable clock for MDIO device at address %u: %d\n", + addr, ret); + return ret; + } + + ret =3D fwnode_mdiobus_register_phy(mdio, of_fwnode_handle(child), addr); + + clk_disable_unprepare(clk); + clk_put(clk); + + return ret; } =20 static int of_mdiobus_register_device(struct mii_bus *mdio, --=20 2.39.2