From nobody Wed Dec 17 00:14:53 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2EAEEC4167B for ; Thu, 30 Nov 2023 16:22:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231934AbjK3QWL (ORCPT ); Thu, 30 Nov 2023 11:22:11 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48032 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231949AbjK3QV7 (ORCPT ); Thu, 30 Nov 2023 11:21:59 -0500 Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.20]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6FD85131; Thu, 30 Nov 2023 08:22:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1701361325; x=1732897325; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=bXoVezPhVWKfoB3JGdgSXzPzDzpsCHhdUMolTMlscIk=; b=Zq/Y39JfsSeJYxpFxFiHPGtupQT8jPxyiyLRxywhw6TIlwpqMM5KuBXa 12Qc95vP2U4dRt4nbzFjkc0cRjb3pQLo448DA1lrQ7Ea3Xe8tKTjWDuPZ coStaEqSu/Q4SQrQP7DP8GVhlwMOuzJ4QmPE//5qcgkgFkfxnd4OGI+W6 8AhksZI3RVHkS1IIxOp4RXhUhqNXLrVRhPvVOZeV9y5Dtq6Zgrg6OT8cc 9Sty2fCBh9aBhYt/Rr/j6HdnqIGGM9/McXEI4b3oZMu4N3rNSQ5/OPzCE PAyhA7EVmuThhLRpkttwQAuv5CAjReMJOwd+BAcQuviF03xUvE7BQhXhl A==; X-IronPort-AV: E=McAfee;i="6600,9927,10910"; a="383744636" X-IronPort-AV: E=Sophos;i="6.04,239,1695711600"; d="scan'208";a="383744636" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Nov 2023 08:22:04 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10910"; a="803758703" X-IronPort-AV: E=Sophos;i="6.04,239,1695711600"; d="scan'208";a="803758703" Received: from p12ill20yoongsia.png.intel.com ([10.88.227.28]) by orsmga001.jf.intel.com with ESMTP; 30 Nov 2023 08:21:55 -0800 From: Song Yoong Siang To: "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Jonathan Corbet , Bjorn Topel , Magnus Karlsson , Maciej Fijalkowski , Jonathan Lemon , Alexei Starovoitov , Daniel Borkmann , Jesper Dangaard Brouer , John Fastabend , Stanislav Fomichev , Lorenzo Bianconi , Tariq Toukan , Willem de Bruijn , Maxime Coquelin , Andrii Nakryiko , Mykola Lysenko , Martin KaFai Lau , Song Liu , Yonghong Song , KP Singh , Hao Luo , Jiri Olsa , Shuah Khan , Alexandre Torgue , Jose Abreu Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, bpf@vger.kernel.org, xdp-hints@xdp-project.net, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kselftest@vger.kernel.org, Song Yoong Siang Subject: [PATCH bpf-next 3/3] selftests/bpf: Add launch time to xdp_hw_metadata Date: Fri, 1 Dec 2023 00:20:28 +0800 Message-Id: <20231130162028.852006-4-yoong.siang.song@intel.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20231130162028.852006-1-yoong.siang.song@intel.com> References: <20231130162028.852006-1-yoong.siang.song@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" This patch adds launch time support to xdp_hw_metadata. User can configure the delta of HW launch time to HW RX-time by using "-l" argument. This patch is tested with stmmac on Intel Tiger Lake platform. Refer to result below, the delta between pre-determined launch time and actual transmit time is around 24 us. $ sudo ./xdp_hw_metadata enp0s30f4 ... xsk_ring_cons__peek: 1 0x55fcb80ce7a8: rx_desc[0]->addr=3D80100 addr=3D80100 comp_addr=3D80100 EoP No rx_hash err=3D-95 HW RX-time: 1677764507059055964 (sec:1677764507.0591) delta to User RX-ti= me sec:0.0002 (237.548 usec) XDP RX-time: 1677764507059280741 (sec:1677764507.0593) delta to User RX-t= ime sec:0.0000 (12.771 usec) 0x55fcb80ce7a8: ping-pong with csum=3D5619 (want 8626) csum_start=3D34 csum= _offset=3D6 HW RX-time: 1677764507059055964 (sec:1677764507.0591) delta to HW Launch-= time sec:1.0000 (1000000.000 usec) 0x55fcb80ce7a8: complete tx idx=3D0 addr=3D18 HW Launch-time: 1677764508059055964 (sec:1677764508.0591) delta to HW TX-= complete-time sec:0.0000 (24.235 usec) HW TX-complete-time: 1677764508059080199 (sec:1677764508.0591) delta to U= ser TX-complete-time sec:0.0054 (5423.263 usec) XDP RX-time: 1677764507059280741 (sec:1677764507.0593) delta to User TX-c= omplete-time sec:1.0052 (1005222.721 usec) HW RX-time: 1677764507059055964 (sec:1677764507.0591) delta to HW TX-comp= lete-time sec:1.0000 (1000024.235 usec) 0x55fcb80ce7a8: complete rx idx=3D128 addr=3D80100 $ sudo ./xdp_hw_metadata enp0s30f4 -l 10000000 ... xsk_ring_cons__peek: 1 0x5626d54de7a8: rx_desc[0]->addr=3D80100 addr=3D80100 comp_addr=3D80100 EoP No rx_hash err=3D-95 HW RX-time: 1677764655807717783 (sec:1677764655.8077) delta to User RX-ti= me sec:0.0002 (240.571 usec) XDP RX-time: 1677764655807942983 (sec:1677764655.8079) delta to User RX-t= ime sec:0.0000 (15.371 usec) 0x5626d54de7a8: ping-pong with csum=3D5619 (want 8626) csum_start=3D34 csum= _offset=3D6 HW RX-time: 1677764655807717783 (sec:1677764655.8077) delta to HW Launch-= time sec:0.0100 (10000.000 usec) 0x5626d54de7a8: complete tx idx=3D0 addr=3D18 HW Launch-time: 1677764655817717783 (sec:1677764655.8177) delta to HW TX-= complete-time sec:0.0000 (23.965 usec) HW TX-complete-time: 1677764655817741748 (sec:1677764655.8177) delta to U= ser TX-complete-time sec:0.0003 (291.792 usec) XDP RX-time: 1677764655807942983 (sec:1677764655.8079) delta to User TX-c= omplete-time sec:0.0101 (10090.557 usec) HW RX-time: 1677764655807717783 (sec:1677764655.8077) delta to HW TX-comp= lete-time sec:0.0100 (10023.965 usec) 0x5626d54de7a8: complete rx idx=3D128 addr=3D80100 Signed-off-by: Song Yoong Siang --- tools/testing/selftests/bpf/xdp_hw_metadata.c | 18 +++++++++++++++++- 1 file changed, 17 insertions(+), 1 deletion(-) diff --git a/tools/testing/selftests/bpf/xdp_hw_metadata.c b/tools/testing/= selftests/bpf/xdp_hw_metadata.c index 3291625ba4fb..ff1b2e5b0fce 100644 --- a/tools/testing/selftests/bpf/xdp_hw_metadata.c +++ b/tools/testing/selftests/bpf/xdp_hw_metadata.c @@ -13,6 +13,7 @@ * - UDP 9091 packets trigger TX reply * - TX HW timestamp is requested and reported back upon completion * - TX checksum is requested + * - HW launch time is set for transmission */ =20 #include @@ -61,6 +62,8 @@ int rxq; bool skip_tx; __u64 last_hw_rx_timestamp; __u64 last_xdp_rx_timestamp; +__u64 last_launch_time; +__u64 launch_time_offset =3D 1000000000; /* 1 second */ =20 void test__fail(void) { /* for network_helpers.c */ } =20 @@ -274,6 +277,8 @@ static bool complete_tx(struct xsk *xsk, clockid_t cloc= k_id) if (meta->completion.tx_timestamp) { __u64 ref_tstamp =3D gettime(clock_id); =20 + print_tstamp_delta("HW Launch-time", "HW TX-complete-time", + last_launch_time, meta->completion.tx_timestamp); print_tstamp_delta("HW TX-complete-time", "User TX-complete-time", meta->completion.tx_timestamp, ref_tstamp); print_tstamp_delta("XDP RX-time", "User TX-complete-time", @@ -371,6 +376,13 @@ static void ping_pong(struct xsk *xsk, void *rx_packet= , clockid_t clock_id) xsk, ntohs(udph->check), ntohs(want_csum), meta->request.csum_start, meta->request.csum_offset); =20 + /* Set launch time at launch_time_offset ns later than HW Rx-time */ + meta->flags |=3D XDP_TXMD_FLAGS_LAUNCH_TIME; + last_launch_time =3D last_hw_rx_timestamp + launch_time_offset; + meta->request.launch_time =3D last_launch_time; + print_tstamp_delta("HW RX-time", "HW Launch-time", + last_hw_rx_timestamp, meta->request.launch_time); + memcpy(data, rx_packet, len); /* don't share umem chunk for simplicity */ tx_desc->options |=3D XDP_TX_METADATA; tx_desc->len =3D len; @@ -595,6 +607,7 @@ static void print_usage(void) " -h Display this help and exit\n\n" " -m Enable multi-buffer XDP for larger MTU\n" " -r Don't generate AF_XDP reply (rx metadata only)\n" + " -l Delta of HW launch time to HW RX-time in ns (default: 1s)\n" "Generate test packets on the other machine with:\n" " echo -n xdp | nc -u -q1 9091\n"; =20 @@ -605,7 +618,7 @@ static void read_args(int argc, char *argv[]) { int opt; =20 - while ((opt =3D getopt(argc, argv, "chmr")) !=3D -1) { + while ((opt =3D getopt(argc, argv, "chmrl:")) !=3D -1) { switch (opt) { case 'c': bind_flags &=3D ~XDP_USE_NEED_WAKEUP; @@ -621,6 +634,9 @@ static void read_args(int argc, char *argv[]) case 'r': skip_tx =3D true; break; + case 'l': + launch_time_offset =3D atoll(optarg); + break; case '?': if (isprint(optopt)) fprintf(stderr, "Unknown option: -%c\n", optopt); --=20 2.34.1