From nobody Wed Dec 17 05:52:27 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B3E57C4167B for ; Wed, 29 Nov 2023 13:47:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233595AbjK2NrZ (ORCPT ); Wed, 29 Nov 2023 08:47:25 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43660 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230445AbjK2NrX (ORCPT ); Wed, 29 Nov 2023 08:47:23 -0500 Received: from m15.mail.163.com (m15.mail.163.com [45.254.50.220]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 0239B19A; Wed, 29 Nov 2023 05:47:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:Subject:Date:Message-Id; bh=JYC5B10TWRchyHN96t T3YdbL8clZjtk6DHRMYsmi0FU=; b=hUbws6al1txBXOAkqAlg5bnYsvI364QoXN IfYGq7lJj3BGPXzQWwpy2Xfbok1hfV7Ig4amVik8uo6dBcOVYx5j1QX37ZCQTzaR NcCRs0HTglMB2buZmsEhfaSEregIS7JUJ5RVfUfk2L9hpl8x4Oi6CtE5at+nnnuM 8ny92SM8k= Received: from localhost.localdomain (unknown [39.144.190.126]) by zwqz-smtp-mta-g0-2 (Coremail) with SMTP id _____wDXnxTnQGdlILsMCg--.42572S2; Wed, 29 Nov 2023 21:47:21 +0800 (CST) From: Haoran Liu To: sre@kernel.org Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, Haoran Liu Subject: [PATCH] [power/reset] qnap-poweroff: Add error handling Date: Wed, 29 Nov 2023 05:47:16 -0800 Message-Id: <20231129134716.34161-1-liuhaoran14@163.com> X-Mailer: git-send-email 2.17.1 X-CM-TRANSID: _____wDXnxTnQGdlILsMCg--.42572S2 X-Coremail-Antispam: 1Uf129KBjvdXoWrKw4UAr13Zw4rCrWfXr1xuFg_yoWDurc_W3 4fX34xXan7Kr1kCFsakF47ZrWxCF92vFn3Xr4IqFyfC345Ww1DJrWqqr17Ja4kX34UCrWD GFZ8Xr43CF1fZjkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUvcSsGvfC2KfnxnUUI43ZEXa7sRK73kUUUUUU== X-Originating-IP: [39.144.190.126] X-CM-SenderInfo: xolxxtxrud0iqu6rljoofrz/xtbBcgc3gletj5TR4QABsQ Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" This patch introduces error handling for the of_match_node call in the qnap_power_off_probe function within drivers/power/reset/qnap-poweroff.c. Previously, there was no check for a null return value from of_match_node, which could lead to improper behavior if the device tree matching failed. Signed-off-by: Haoran Liu --- drivers/power/reset/qnap-poweroff.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/power/reset/qnap-poweroff.c b/drivers/power/reset/qnap= -poweroff.c index 0ddf7f25f7b8..bc0b547211d6 100644 --- a/drivers/power/reset/qnap-poweroff.c +++ b/drivers/power/reset/qnap-poweroff.c @@ -77,6 +77,11 @@ static int qnap_power_off_probe(struct platform_device *= pdev) =20 const struct of_device_id *match =3D of_match_node(qnap_power_off_of_match_table, np); + if (!match) { + dev_err(&pdev->dev, "No matching device found\n"); + return -ENODEV; + } + cfg =3D match->data; =20 res =3D platform_get_resource(pdev, IORESOURCE_MEM, 0); --=20 2.17.1