From nobody Wed Dec 17 05:51:55 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DE071C4167B for ; Wed, 29 Nov 2023 12:41:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233030AbjK2MlH (ORCPT ); Wed, 29 Nov 2023 07:41:07 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57232 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230094AbjK2MlF (ORCPT ); Wed, 29 Nov 2023 07:41:05 -0500 Received: from m15.mail.163.com (m15.mail.163.com [45.254.50.220]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id B5DF610D4 for ; Wed, 29 Nov 2023 04:41:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:Subject:Date:Message-Id; bh=C9pbxi/4On2uizg/mt LqDiesLQ/rTQR6z5ASO0iY7R0=; b=Vu9/fmZupquMIwiW9wtZ+ZCmEhKvfb74BT aAAjJYGPvsjHI9qlV2PnqrM9oBqnakGouNzht8XhdvO0SaxDObuxIlwrWk/+4Nli IZB29FSVePhhuy1xynHDMrL/ZnOegX7jAeygF20XopG26bClC+u7EUA0PaiC6hfD sJQ4piNLo= Received: from localhost.localdomain (unknown [39.144.190.126]) by zwqz-smtp-mta-g2-1 (Coremail) with SMTP id _____wDX1o5NMWdlf2UAEQ--.41802S2; Wed, 29 Nov 2023 20:40:46 +0800 (CST) From: Haoran Liu To: vkoul@kernel.org Cc: kishon@kernel.org, linux-phy@lists.infradead.org, linux-kernel@vger.kernel.org, Haoran Liu Subject: [PATCH] [phy/renesas] phy-rcar-gen2: Add error handling Date: Wed, 29 Nov 2023 04:40:43 -0800 Message-Id: <20231129124043.33526-1-liuhaoran14@163.com> X-Mailer: git-send-email 2.17.1 X-CM-TRANSID: _____wDX1o5NMWdlf2UAEQ--.41802S2 X-Coremail-Antispam: 1Uf129KBjvJXoWxJrW5uF13Aw43Cr4DAr4fKrg_yoW8GrWkpF WkGaySyrW8JFsrtrZxtr45ZFn0kw4xK343tFW3Ka4fZF1UAr909a4a9a4YvF1Ygr4vyF4Y qr18tFykAF1UZF7anT9S1TB71UUUUUUqnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDUYxBIdaVFxhVjvjDU0xZFpf9x0JUOeOdUUUUU= X-Originating-IP: [39.144.190.126] X-CM-SenderInfo: xolxxtxrud0iqu6rljoofrz/1tbiwg83glc6610M6QAAsG Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" This patch introduces error handling for the clk_prepare_enable call in the rcar_gen2_phy_init function within drivers/phy/renesas/phy-rcar-gen2.c. Previously, the function lacked appropriate handling for potential failures of clk_prepare_enable, which could lead to instability if the clock preparation failed. Signed-off-by: Haoran Liu --- drivers/phy/renesas/phy-rcar-gen2.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/phy/renesas/phy-rcar-gen2.c b/drivers/phy/renesas/phy-= rcar-gen2.c index 507435af2656..c84eeaf1f607 100644 --- a/drivers/phy/renesas/phy-rcar-gen2.c +++ b/drivers/phy/renesas/phy-rcar-gen2.c @@ -80,6 +80,7 @@ static int rcar_gen2_phy_init(struct phy *p) struct rcar_gen2_phy_driver *drv =3D channel->drv; unsigned long flags; u32 ugctrl2; + int ret; =20 /* * Try to acquire exclusive access to PHY. The first driver calling @@ -90,7 +91,11 @@ static int rcar_gen2_phy_init(struct phy *p) if (cmpxchg(&channel->selected_phy, -1, phy->number) !=3D -1) return -EBUSY; =20 - clk_prepare_enable(drv->clk); + ret =3D clk_prepare_enable(drv->clk); + if (ret) { + dev_err(&p->dev, "Failed to enable clock: %d\n", ret); + return ret; + } =20 spin_lock_irqsave(&drv->lock, flags); ugctrl2 =3D readl(drv->base + USBHS_UGCTRL2); --=20 2.17.1