From nobody Wed Dec 17 07:32:35 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DCA34C07E97 for ; Wed, 29 Nov 2023 09:42:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229816AbjK2JmG (ORCPT ); Wed, 29 Nov 2023 04:42:06 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52452 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229453AbjK2JmE (ORCPT ); Wed, 29 Nov 2023 04:42:04 -0500 Received: from cmccmta2.chinamobile.com (cmccmta6.chinamobile.com [111.22.67.139]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id C958A1999; Wed, 29 Nov 2023 01:42:06 -0800 (PST) X-RM-TagInfo: emlType=0 X-RM-SPAM-FLAG: 00000000 Received: from spf.mail.chinamobile.com (unknown[10.188.0.87]) by rmmx-syy-dmz-app05-12005 (RichMail) with SMTP id 2ee565670766cd0-3c572; Wed, 29 Nov 2023 17:42:04 +0800 (CST) X-RM-TRANSID: 2ee565670766cd0-3c572 X-RM-TagInfo: emlType=0 X-RM-SPAM-FLAG: 00000000 Received: from localhost.localdomain.localdomain (unknown[10.54.5.252]) by rmsmtp-syy-appsvr07-12007 (RichMail) with SMTP id 2ee76567076b191-69aba; Wed, 29 Nov 2023 17:42:04 +0800 (CST) X-RM-TRANSID: 2ee76567076b191-69aba From: zhaimingbing To: Namhyung Kim , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , Sean Christopherson , Li Dong Cc: linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, zhaimingbing Subject: [PATCH] perf help:Fail check on dynamic allocation Date: Wed, 29 Nov 2023 17:42:02 +0800 Message-Id: <20231129094202.11500-1-zhaimingbing@cmss.chinamobile.com> X-Mailer: git-send-email 2.33.0 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Return error if dynamic allocation failed. Signed-off-by: zhaimingbing --- tools/perf/builtin-help.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/tools/perf/builtin-help.c b/tools/perf/builtin-help.c index b2a368ae2..ca05cc795 100644 --- a/tools/perf/builtin-help.c +++ b/tools/perf/builtin-help.c @@ -196,6 +196,11 @@ static void add_man_viewer(const char *name) while (*p) p =3D &((*p)->next); *p =3D zalloc(sizeof(**p) + len + 1); + if(!*p) { + pr_err("Failed to zalloc man viewer list\n"); + return ; + } + strcpy((*p)->name, name); } =20 @@ -211,6 +216,10 @@ static void do_add_man_viewer_info(const char *name, const char *value) { struct man_viewer_info_list *new =3D zalloc(sizeof(*new) + len + 1); + if(!new) { + pr_err("Failed to zalloc man viewer info list\n"); + return ; + } =20 strncpy(new->name, name, len); new->info =3D strdup(value); --=20 2.33.0