From nobody Mon Dec 29 11:15:16 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A39A6C4167B for ; Wed, 29 Nov 2023 06:02:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1377006AbjK2GCS (ORCPT ); Wed, 29 Nov 2023 01:02:18 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52828 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1377000AbjK2GCN (ORCPT ); Wed, 29 Nov 2023 01:02:13 -0500 Received: from mail-yw1-x114a.google.com (mail-yw1-x114a.google.com [IPv6:2607:f8b0:4864:20::114a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 24F4819B7 for ; Tue, 28 Nov 2023 22:02:18 -0800 (PST) Received: by mail-yw1-x114a.google.com with SMTP id 00721157ae682-5d1ed4b268dso18150737b3.0 for ; Tue, 28 Nov 2023 22:02:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1701237737; x=1701842537; darn=vger.kernel.org; h=to:from:subject:references:mime-version:message-id:in-reply-to:date :from:to:cc:subject:date:message-id:reply-to; bh=6thajjQRkz+HkHW7D3sSCmpzEeB477d5Mr+y0iQJVzs=; b=kX7c6gCvFHw5an55jNpK+MCu0n06UnFZxpirz/t1R5a+0/qU6FHchFYK0P3WAbTCNe 7jCpy0TUz3XvRTvuxNSDzEe6NHfQvoroF07Bf2C49yGQuXLSvgmYoLKq0qeXUYC3cEgD niQMAV1yT7yxf9enxT5SYiFJwaJx8O81E1dJfadtGep4iH6fMzCC5zfduJBLOH0te26/ eqiqV62q0rHdJj3IQCVbYLlhxcO3Sl5b2kChwLyJx9Cyd79ycy6KwxoMbH27JBFNvY9T 3M4kxZX/x2AHpOHW3yYE1ehG4/zjlra1zTcMRZlrBaTbzPUPC/lOJ6BXBcpdvkZkmCR5 GYBg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701237737; x=1701842537; h=to:from:subject:references:mime-version:message-id:in-reply-to:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=6thajjQRkz+HkHW7D3sSCmpzEeB477d5Mr+y0iQJVzs=; b=iLiYuliM1hGzZpoZCD5WLBIWUNqv/tivAT6pyuXEVc2wrQ6+0NbBO0zJEFY/ESbnwR yFYkrgHY4vU5XKWXk+kpZb6Vl/6NumlCjCl/kWs5tyJw4FvU6dfrdbln85nm1FIqMsgv srTJMMsoS2by7BvTLPDQJJBO6WsfCFccaMxWg+sIiLjBlN2YIFOUB51cazyUanokEqQV zzpF6CkezKDn2ig6xJ5oaP7+/g2NEtF0Fw1BpDTNWrWK5WyaF5Cp7R+1bJhELjjSYaN1 F8BziOJ0+7qAJTp/VbYgriYGyNBWcIAVObu9Wl8Q/csrSkYGZcb/zJgGdP6ly1OvsXsY YDJQ== X-Gm-Message-State: AOJu0YwqJKNQLdS9D0G3QOjO3Zjy4P20XkmwqDp4k6n2IEr0B67cEjQB AHMfndb2qzWeEcl4+UXPcTFDq5HO2tjk X-Google-Smtp-Source: AGHT+IHStCf02eR5Z7G2oMb+qjaqd+bye5wyKkPORIP+SdC4EPzelKmD6TjLiarOMrn6W9b9mIBoWBllGFGX X-Received: from irogers.svl.corp.google.com ([2620:15c:2a3:200:763b:80fa:23ca:96f8]) (user=irogers job=sendgmr) by 2002:a05:690c:2e8a:b0:5ce:dff:f7a1 with SMTP id eu10-20020a05690c2e8a00b005ce0dfff7a1mr482531ywb.9.1701237737183; Tue, 28 Nov 2023 22:02:17 -0800 (PST) Date: Tue, 28 Nov 2023 22:01:58 -0800 In-Reply-To: <20231129060211.1890454-1-irogers@google.com> Message-Id: <20231129060211.1890454-2-irogers@google.com> Mime-Version: 1.0 References: <20231129060211.1890454-1-irogers@google.com> X-Mailer: git-send-email 2.43.0.rc1.413.gea7ed67945-goog Subject: [PATCH v1 01/14] libperf cpumap: Rename perf_cpu_map__dummy_new From: Ian Rogers To: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Ian Rogers , Adrian Hunter , Suzuki K Poulose , Mike Leach , James Clark , Leo Yan , John Garry , Will Deacon , Thomas Gleixner , Darren Hart , Davidlohr Bueso , "=?UTF-8?q?Andr=C3=A9=20Almeida?=" , Kan Liang , K Prateek Nayak , Sean Christopherson , Paolo Bonzini , Kajol Jain , Athira Rajeev , Andrew Jones , Alexandre Ghiti , Atish Patra , "Steinar H. Gunderson" , Yang Jihong , Yang Li , Changbin Du , Sandipan Das , Ravi Bangoria , Paran Lee , Nick Desaulniers , Huacai Chen , Yanteng Si , linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org, bpf@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Rename perf_cpu_map__dummy_new to perf_cpu_map__new_any_cpu to better indicate this is creating a CPU map for the perf_event_open "any" CPU case. Signed-off-by: Ian Rogers Reviewed-by: James Clark --- tools/lib/perf/Documentation/libperf.txt | 2 +- tools/lib/perf/cpumap.c | 4 ++-- tools/lib/perf/evsel.c | 2 +- tools/lib/perf/include/perf/cpumap.h | 4 ++-- tools/lib/perf/libperf.map | 2 +- tools/lib/perf/tests/test-cpumap.c | 2 +- tools/lib/perf/tests/test-evlist.c | 2 +- tools/perf/tests/cpumap.c | 2 +- tools/perf/tests/sw-clock.c | 2 +- tools/perf/tests/task-exit.c | 2 +- tools/perf/util/evlist.c | 2 +- tools/perf/util/evsel.c | 2 +- 12 files changed, 14 insertions(+), 14 deletions(-) diff --git a/tools/lib/perf/Documentation/libperf.txt b/tools/lib/perf/Docu= mentation/libperf.txt index a8f1a237931b..a256a26598b0 100644 --- a/tools/lib/perf/Documentation/libperf.txt +++ b/tools/lib/perf/Documentation/libperf.txt @@ -37,7 +37,7 @@ SYNOPSIS =20 struct perf_cpu_map; =20 - struct perf_cpu_map *perf_cpu_map__dummy_new(void); + struct perf_cpu_map *perf_cpu_map__new_any_cpu(void); struct perf_cpu_map *perf_cpu_map__new(const char *cpu_list); struct perf_cpu_map *perf_cpu_map__read(FILE *file); struct perf_cpu_map *perf_cpu_map__get(struct perf_cpu_map *map); diff --git a/tools/lib/perf/cpumap.c b/tools/lib/perf/cpumap.c index 2a5a29217374..2bd6aba3d8c9 100644 --- a/tools/lib/perf/cpumap.c +++ b/tools/lib/perf/cpumap.c @@ -27,7 +27,7 @@ struct perf_cpu_map *perf_cpu_map__alloc(int nr_cpus) return result; } =20 -struct perf_cpu_map *perf_cpu_map__dummy_new(void) +struct perf_cpu_map *perf_cpu_map__new_any_cpu(void) { struct perf_cpu_map *cpus =3D perf_cpu_map__alloc(1); =20 @@ -271,7 +271,7 @@ struct perf_cpu_map *perf_cpu_map__new(const char *cpu_= list) else if (*cpu_list !=3D '\0') cpus =3D cpu_map__default_new(); else - cpus =3D perf_cpu_map__dummy_new(); + cpus =3D perf_cpu_map__new_any_cpu(); invalid: free(tmp_cpus); out: diff --git a/tools/lib/perf/evsel.c b/tools/lib/perf/evsel.c index 8b51b008a81f..c07160953224 100644 --- a/tools/lib/perf/evsel.c +++ b/tools/lib/perf/evsel.c @@ -120,7 +120,7 @@ int perf_evsel__open(struct perf_evsel *evsel, struct p= erf_cpu_map *cpus, static struct perf_cpu_map *empty_cpu_map; =20 if (empty_cpu_map =3D=3D NULL) { - empty_cpu_map =3D perf_cpu_map__dummy_new(); + empty_cpu_map =3D perf_cpu_map__new_any_cpu(); if (empty_cpu_map =3D=3D NULL) return -ENOMEM; } diff --git a/tools/lib/perf/include/perf/cpumap.h b/tools/lib/perf/include/= perf/cpumap.h index e38d859a384d..d0bf218ada11 100644 --- a/tools/lib/perf/include/perf/cpumap.h +++ b/tools/lib/perf/include/perf/cpumap.h @@ -19,9 +19,9 @@ struct perf_cache { struct perf_cpu_map; =20 /** - * perf_cpu_map__dummy_new - a map with a singular "any CPU"/dummy -1 valu= e. + * perf_cpu_map__new_any_cpu - a map with a singular "any CPU"/dummy -1 va= lue. */ -LIBPERF_API struct perf_cpu_map *perf_cpu_map__dummy_new(void); +LIBPERF_API struct perf_cpu_map *perf_cpu_map__new_any_cpu(void); LIBPERF_API struct perf_cpu_map *perf_cpu_map__default_new(void); LIBPERF_API struct perf_cpu_map *perf_cpu_map__new(const char *cpu_list); LIBPERF_API struct perf_cpu_map *perf_cpu_map__read(FILE *file); diff --git a/tools/lib/perf/libperf.map b/tools/lib/perf/libperf.map index 190b56ae923a..a8ff64baea3e 100644 --- a/tools/lib/perf/libperf.map +++ b/tools/lib/perf/libperf.map @@ -1,7 +1,7 @@ LIBPERF_0.0.1 { global: libperf_init; - perf_cpu_map__dummy_new; + perf_cpu_map__new_any_cpu; perf_cpu_map__default_new; perf_cpu_map__get; perf_cpu_map__put; diff --git a/tools/lib/perf/tests/test-cpumap.c b/tools/lib/perf/tests/test= -cpumap.c index 87b0510a556f..2c359bdb951e 100644 --- a/tools/lib/perf/tests/test-cpumap.c +++ b/tools/lib/perf/tests/test-cpumap.c @@ -21,7 +21,7 @@ int test_cpumap(int argc, char **argv) =20 libperf_init(libperf_print); =20 - cpus =3D perf_cpu_map__dummy_new(); + cpus =3D perf_cpu_map__new_any_cpu(); if (!cpus) return -1; =20 diff --git a/tools/lib/perf/tests/test-evlist.c b/tools/lib/perf/tests/test= -evlist.c index ed616fc19b4f..ab63878bacb9 100644 --- a/tools/lib/perf/tests/test-evlist.c +++ b/tools/lib/perf/tests/test-evlist.c @@ -261,7 +261,7 @@ static int test_mmap_thread(void) threads =3D perf_thread_map__new_dummy(); __T("failed to create threads", threads); =20 - cpus =3D perf_cpu_map__dummy_new(); + cpus =3D perf_cpu_map__new_any_cpu(); __T("failed to create cpus", cpus); =20 perf_thread_map__set_pid(threads, 0, pid); diff --git a/tools/perf/tests/cpumap.c b/tools/perf/tests/cpumap.c index 7730fc2ab40b..bd8e396f3e57 100644 --- a/tools/perf/tests/cpumap.c +++ b/tools/perf/tests/cpumap.c @@ -213,7 +213,7 @@ static int test__cpu_map_intersect(struct test_suite *t= est __maybe_unused, =20 static int test__cpu_map_equal(struct test_suite *test __maybe_unused, int= subtest __maybe_unused) { - struct perf_cpu_map *any =3D perf_cpu_map__dummy_new(); + struct perf_cpu_map *any =3D perf_cpu_map__new_any_cpu(); struct perf_cpu_map *one =3D perf_cpu_map__new("1"); struct perf_cpu_map *two =3D perf_cpu_map__new("2"); struct perf_cpu_map *empty =3D perf_cpu_map__intersect(one, two); diff --git a/tools/perf/tests/sw-clock.c b/tools/perf/tests/sw-clock.c index 4d7493fa0105..290716783ac6 100644 --- a/tools/perf/tests/sw-clock.c +++ b/tools/perf/tests/sw-clock.c @@ -62,7 +62,7 @@ static int __test__sw_clock_freq(enum perf_sw_ids clock_i= d) } evlist__add(evlist, evsel); =20 - cpus =3D perf_cpu_map__dummy_new(); + cpus =3D perf_cpu_map__new_any_cpu(); threads =3D thread_map__new_by_tid(getpid()); if (!cpus || !threads) { err =3D -ENOMEM; diff --git a/tools/perf/tests/task-exit.c b/tools/perf/tests/task-exit.c index 968dddde6dda..d33d0952025c 100644 --- a/tools/perf/tests/task-exit.c +++ b/tools/perf/tests/task-exit.c @@ -70,7 +70,7 @@ static int test__task_exit(struct test_suite *test __mayb= e_unused, int subtest _ * evlist__prepare_workload we'll fill in the only thread * we're monitoring, the one forked there. */ - cpus =3D perf_cpu_map__dummy_new(); + cpus =3D perf_cpu_map__new_any_cpu(); threads =3D thread_map__new_by_tid(-1); if (!cpus || !threads) { err =3D -ENOMEM; diff --git a/tools/perf/util/evlist.c b/tools/perf/util/evlist.c index e36da58522ef..ff7f85ded89d 100644 --- a/tools/perf/util/evlist.c +++ b/tools/perf/util/evlist.c @@ -1056,7 +1056,7 @@ int evlist__create_maps(struct evlist *evlist, struct= target *target) return -1; =20 if (target__uses_dummy_map(target)) - cpus =3D perf_cpu_map__dummy_new(); + cpus =3D perf_cpu_map__new_any_cpu(); else cpus =3D perf_cpu_map__new(target->cpu_list); =20 diff --git a/tools/perf/util/evsel.c b/tools/perf/util/evsel.c index a5da74e3a517..76ef3ab488a2 100644 --- a/tools/perf/util/evsel.c +++ b/tools/perf/util/evsel.c @@ -1801,7 +1801,7 @@ static int __evsel__prepare_open(struct evsel *evsel,= struct perf_cpu_map *cpus, =20 if (cpus =3D=3D NULL) { if (empty_cpu_map =3D=3D NULL) { - empty_cpu_map =3D perf_cpu_map__dummy_new(); + empty_cpu_map =3D perf_cpu_map__new_any_cpu(); if (empty_cpu_map =3D=3D NULL) return -ENOMEM; } --=20 2.43.0.rc1.413.gea7ed67945-goog