From nobody Mon Dec 29 11:21:16 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BFEF9C4167B for ; Wed, 29 Nov 2023 05:45:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234871AbjK2Foy (ORCPT ); Wed, 29 Nov 2023 00:44:54 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55828 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1376976AbjK2Fop (ORCPT ); Wed, 29 Nov 2023 00:44:45 -0500 Received: from rtits2.realtek.com.tw (rtits2.realtek.com [211.75.126.72]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E683C1BC2; Tue, 28 Nov 2023 21:44:50 -0800 (PST) X-SpamFilter-By: ArmorX SpamTrap 5.78 with qID 3AT5ibAK32554704, This message is accepted by code: ctloc85258 Received: from mail.realtek.com (rtexh36505.realtek.com.tw[172.21.6.25]) by rtits2.realtek.com.tw (8.15.2/2.95/5.92) with ESMTPS id 3AT5ibAK32554704 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 29 Nov 2023 13:44:37 +0800 Received: from RTEXMBS03.realtek.com.tw (172.21.6.96) by RTEXH36505.realtek.com.tw (172.21.6.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.32; Wed, 29 Nov 2023 13:44:37 +0800 Received: from james-bs01.realtek.com.tw (172.21.190.247) by RTEXMBS03.realtek.com.tw (172.21.6.96) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.7; Wed, 29 Nov 2023 13:44:36 +0800 From: James Tai To: Thomas Gleixner , Marc Zyngier , "Rob Herring" , Krzysztof Kozlowski , Conor Dooley , James Tai CC: , , "kernel test robot" Subject: [PATCH v3 4/6] irqchip: Introduce RTD1319D support using the Realtek common interrupt controller driver Date: Wed, 29 Nov 2023 13:43:37 +0800 Message-ID: <20231129054339.3054202-5-james.tai@realtek.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20231129054339.3054202-1-james.tai@realtek.com> References: <20231129054339.3054202-1-james.tai@realtek.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Originating-IP: [172.21.190.247] X-ClientProxiedBy: RTEXH36506.realtek.com.tw (172.21.6.27) To RTEXMBS03.realtek.com.tw (172.21.6.96) X-KSE-ServerInfo: RTEXMBS03.realtek.com.tw, 9 X-KSE-AntiSpam-Interceptor-Info: fallback X-KSE-Antivirus-Interceptor-Info: fallback X-KSE-AntiSpam-Interceptor-Info: fallback X-KSE-ServerInfo: RTEXH36505.realtek.com.tw, 9 X-KSE-AntiSpam-Interceptor-Info: fallback X-KSE-Antivirus-Interceptor-Info: fallback X-KSE-AntiSpam-Interceptor-Info: fallback Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Add support for the RTD1319D platform. Reported-by: kernel test robot Closes: https://lore.kernel.org/oe-kbuild-all/202311061137.FRpoKwcm-lkp@int= el.com/ CC: Thomas Gleixner CC: Marc Zyngier CC: linux-kernel@vger.kernel.org Signed-off-by: James Tai --- v2 to v3 change: - Unchanged v1 to v2 change: - Resolved kernel test robot build warnings - Replaced magic number with macro - Fixed code style issues drivers/irqchip/Kconfig | 6 + drivers/irqchip/Makefile | 1 + drivers/irqchip/irq-realtek-rtd1319d.c | 227 +++++++++++++++++++++++++ 3 files changed, 234 insertions(+) create mode 100644 drivers/irqchip/irq-realtek-rtd1319d.c diff --git a/drivers/irqchip/Kconfig b/drivers/irqchip/Kconfig index 05856ce885fa..c6552c513442 100644 --- a/drivers/irqchip/Kconfig +++ b/drivers/irqchip/Kconfig @@ -228,6 +228,12 @@ config REALTEK_RTD1319_INTC help Support for Realtek RTD1319 Interrupt Controller. =20 +config REALTEK_RTD1319D_INTC + tristate "Realtek RTD1319D interrupt controller" + select REALTEK_DHC_INTC + help + Support for Realtek RTD1319D Interrupt Controller. + config RENESAS_INTC_IRQPIN bool "Renesas INTC External IRQ Pin Support" if COMPILE_TEST select IRQ_DOMAIN diff --git a/drivers/irqchip/Makefile b/drivers/irqchip/Makefile index 6a2650b0a924..c8adaed4c1b2 100644 --- a/drivers/irqchip/Makefile +++ b/drivers/irqchip/Makefile @@ -49,6 +49,7 @@ obj-$(CONFIG_JCORE_AIC) +=3D irq-jcore-aic.o obj-$(CONFIG_RDA_INTC) +=3D irq-rda-intc.o obj-$(CONFIG_REALTEK_DHC_INTC) +=3D irq-realtek-intc-common.o obj-$(CONFIG_REALTEK_RTD1319_INTC) +=3D irq-realtek-rtd1319.o +obj-$(CONFIG_REALTEK_RTD1319D_INTC) +=3D irq-realtek-rtd1319d.o obj-$(CONFIG_RENESAS_INTC_IRQPIN) +=3D irq-renesas-intc-irqpin.o obj-$(CONFIG_RENESAS_IRQC) +=3D irq-renesas-irqc.o obj-$(CONFIG_RENESAS_RZA1_IRQC) +=3D irq-renesas-rza1.o diff --git a/drivers/irqchip/irq-realtek-rtd1319d.c b/drivers/irqchip/irq-r= ealtek-rtd1319d.c new file mode 100644 index 000000000000..2d4bd6230e17 --- /dev/null +++ b/drivers/irqchip/irq-realtek-rtd1319d.c @@ -0,0 +1,227 @@ +// SPDX-License-Identifier: (GPL-2.0-or-later OR BSD-2-Clause) +/* + * Realtek RTD1319D interrupt controller driver + * + * Copyright (c) 2023 Realtek Semiconductor Corporation + */ + +#include +#include +#include +#include +#include + +#include "irq-realtek-intc-common.h" + +#define ISO_NMI_WDT_MASK 0x08008090 +#define ISO_NORMAL_MASK 0xf7ff7f6e +#define MISC_NORMAL_MASK 0xffe0ded6 +#define MISC_UART1_MASK 0x00000028 +#define MISC_UART2_MASK 0x00002100 + +#define ISO_ISR_EN_OFFSET 0x40 +#define ISO_ISR_OFFSET 0 +#define ISO_ISR_UMSK_OFFSET 0x4 +#define MISC_ISR_EN_OFFSET 0x80 +#define MISC_ISR_OFFSET 0xc +#define MISC_ISR_UMSK_OFFSET 0x8 + +enum rtd1319d_iso_isr_bits { + RTD1319D_ISO_ISR_TC3_SHIFT =3D 1, + RTD1319D_ISO_ISR_UR0_SHIFT =3D 2, + RTD1319D_ISO_ISR_LSADC0_SHIFT =3D 3, + RTD1319D_ISO_ISR_WDOG1_NMI_SHIFT =3D 4, + RTD1319D_ISO_ISR_IRDA_SHIFT =3D 5, + RTD1319D_ISO_ISR_SPI1_SHIFT =3D 6, + RTD1319D_ISO_ISR_WDOG2_NMI_SHIFT =3D 7, + RTD1319D_ISO_ISR_I2C0_SHIFT =3D 8, + RTD1319D_ISO_ISR_TC4_SHIFT =3D 9, + RTD1319D_ISO_ISR_TC7_SHIFT =3D 10, + RTD1319D_ISO_ISR_I2C1_SHIFT =3D 11, + RTD1319D_ISO_ISR_HIFI_WAKEUP_SHIFT =3D 14, + RTD1319D_ISO_ISR_WDOG4_NMI_SHIFT =3D 15, + RTD1319D_ISO_ISR_TC8_SHIFT =3D 16, + RTD1319D_ISO_ISR_VFD_SHIFT =3D 17, + RTD1319D_ISO_ISR_VTC_SHIFT =3D 18, + RTD1319D_ISO_ISR_GPIOA_SHIFT =3D 19, + RTD1319D_ISO_ISR_GPIODA_SHIFT =3D 20, + RTD1319D_ISO_ISR_ISO_MISC_SHIFT =3D 21, + RTD1319D_ISO_ISR_CBUS_SHIFT =3D 22, + RTD1319D_ISO_ISR_ETN_SHIFT =3D 23, + RTD1319D_ISO_ISR_USB_HOST_SHIFT =3D 24, + RTD1319D_ISO_ISR_USB_U3_DRD_SHIFT =3D 25, + RTD1319D_ISO_ISR_USB_U2_DRD_SHIFT =3D 26, + RTD1319D_ISO_ISR_WDOG3_NMI_SHIFT =3D 27, + RTD1319D_ISO_ISR_PORB_HV_CEN_SHIFT =3D 28, + RTD1319D_ISO_ISR_PORB_DV_CEN_SHIFT =3D 29, + RTD1319D_ISO_ISR_PORB_AV_CEN_SHIFT =3D 30, + RTD1319D_ISO_ISR_I2C1_REQ_SHIFT =3D 31, +}; + +static const u32 rtd1319d_iso_isr_to_scpu_int_en_mask[32] =3D { + [RTD1319D_ISO_ISR_SPI1_SHIFT] =3D BIT(1), + [RTD1319D_ISO_ISR_UR0_SHIFT] =3D BIT(2), + [RTD1319D_ISO_ISR_LSADC0_SHIFT] =3D BIT(3), + [RTD1319D_ISO_ISR_IRDA_SHIFT] =3D BIT(5), + [RTD1319D_ISO_ISR_I2C0_SHIFT] =3D BIT(8), + [RTD1319D_ISO_ISR_I2C1_SHIFT] =3D BIT(11), + [RTD1319D_ISO_ISR_VFD_SHIFT] =3D BIT(17), + [RTD1319D_ISO_ISR_GPIOA_SHIFT] =3D BIT(19), + [RTD1319D_ISO_ISR_GPIODA_SHIFT] =3D BIT(20), + [RTD1319D_ISO_ISR_PORB_HV_CEN_SHIFT] =3D BIT(28), + [RTD1319D_ISO_ISR_PORB_DV_CEN_SHIFT] =3D BIT(29), + [RTD1319D_ISO_ISR_PORB_AV_CEN_SHIFT] =3D BIT(30), + [RTD1319D_ISO_ISR_I2C1_REQ_SHIFT] =3D BIT(31), + [RTD1319D_ISO_ISR_WDOG1_NMI_SHIFT] =3D IRQ_ALWAYS_ENABLED, + [RTD1319D_ISO_ISR_WDOG2_NMI_SHIFT] =3D IRQ_ALWAYS_ENABLED, + [RTD1319D_ISO_ISR_WDOG3_NMI_SHIFT] =3D IRQ_ALWAYS_ENABLED, + [RTD1319D_ISO_ISR_WDOG4_NMI_SHIFT] =3D IRQ_ALWAYS_ENABLED, +}; + +enum rtd1319d_misc_isr_bits { + RTD1319D_ISR_UR1_SHIFT =3D 3, + RTD1319D_ISR_TC5_SHIFT =3D 4, + RTD1319D_ISR_UR1_TO_SHIFT =3D 5, + RTD1319D_ISR_TC0_SHIFT =3D 6, + RTD1319D_ISR_TC1_SHIFT =3D 7, + RTD1319D_ISR_UR2_SHIFT =3D 8, + RTD1319D_ISR_UR2_TO_SHIFT =3D 13, + RTD1319D_ISR_I2C5_SHIFT =3D 14, + RTD1319D_ISR_I2C4_SHIFT =3D 15, + RTD1319D_ISR_DRTC_HSEC_SHIFT =3D 16, + RTD1319D_ISR_DRTC_MIN_SHIFT =3D 17, + RTD1319D_ISR_DRTC_HOUR_SHIFT =3D 18, + RTD1319D_ISR_DRTC_DATE_SHIFT =3D 19, + RTD1319D_ISR_DRTC_ALARM_SHIFT =3D 20, + RTD1319D_ISR_I2C3_SHIFT =3D 23, + RTD1319D_ISR_SC0_SHIFT =3D 24, + RTD1319D_ISR_SC1_SHIFT =3D 25, + RTD1319D_ISR_SPI_SHIFT =3D 27, + RTD1319D_ISR_FAN_SHIFT =3D 29, +}; + +static const u32 rtd1319d_misc_isr_to_scpu_int_en_mask[32] =3D { + [RTD1319D_ISR_UR1_SHIFT] =3D BIT(3), + [RTD1319D_ISR_UR1_TO_SHIFT] =3D BIT(5), + [RTD1319D_ISR_UR2_TO_SHIFT] =3D BIT(6), + [RTD1319D_ISR_UR2_SHIFT] =3D BIT(7), + [RTD1319D_ISR_I2C5_SHIFT] =3D BIT(14), + [RTD1319D_ISR_I2C4_SHIFT] =3D BIT(15), + [RTD1319D_ISR_DRTC_HSEC_SHIFT] =3D BIT(16), + [RTD1319D_ISR_DRTC_MIN_SHIFT] =3D BIT(17), + [RTD1319D_ISR_DRTC_HOUR_SHIFT] =3D BIT(18), + [RTD1319D_ISR_DRTC_DATE_SHIFT] =3D BIT(19), + [RTD1319D_ISR_DRTC_ALARM_SHIFT] =3D BIT(20), + [RTD1319D_ISR_SC0_SHIFT] =3D BIT(24), + [RTD1319D_ISR_SC1_SHIFT] =3D BIT(25), + [RTD1319D_ISR_SPI_SHIFT] =3D BIT(27), + [RTD1319D_ISR_I2C3_SHIFT] =3D BIT(28), + [RTD1319D_ISR_FAN_SHIFT] =3D BIT(29), +}; + +static struct realtek_intc_subset_cfg rtd1319d_intc_iso_cfgs[] =3D { + { ISO_NORMAL_MASK, }, + { ISO_NMI_WDT_MASK, }, +}; + +static const struct realtek_intc_info rtd1319d_intc_iso_info =3D { + .isr_offset =3D ISO_ISR_OFFSET, + .umsk_isr_offset =3D ISO_ISR_UMSK_OFFSET, + .scpu_int_en_offset =3D ISO_ISR_EN_OFFSET, + .isr_to_scpu_int_en_mask =3D rtd1319d_iso_isr_to_scpu_int_en_mask, + .cfg =3D rtd1319d_intc_iso_cfgs, + .cfg_num =3D ARRAY_SIZE(rtd1319d_intc_iso_cfgs), +}; + +static struct realtek_intc_subset_cfg rtd1319d_intc_misc_cfgs[] =3D { + { MISC_NORMAL_MASK, }, + { MISC_UART1_MASK, }, + { MISC_UART2_MASK, }, +}; + +static const struct realtek_intc_info rtd1319d_intc_misc_info =3D { + .isr_offset =3D MISC_ISR_OFFSET, + .umsk_isr_offset =3D MISC_ISR_UMSK_OFFSET, + .scpu_int_en_offset =3D MISC_ISR_EN_OFFSET, + .isr_to_scpu_int_en_mask =3D rtd1319d_misc_isr_to_scpu_int_en_mask, + .cfg =3D rtd1319d_intc_misc_cfgs, + .cfg_num =3D ARRAY_SIZE(rtd1319d_intc_misc_cfgs), +}; + +static const struct of_device_id realtek_intc_rtd1319d_dt_matches[] =3D { + { + .compatible =3D "realtek,rtd1319d-intc-iso", + .data =3D &rtd1319d_intc_iso_info, + }, { + .compatible =3D "realtek,rtd1319d-intc-misc", + .data =3D &rtd1319d_intc_misc_info, + }, + { /* sentinel */ } +}; + +static int realtek_intc_rtd1319d_suspend(struct device *dev) +{ + struct realtek_intc_data *data =3D dev_get_drvdata(dev); + const struct realtek_intc_info *info =3D data->info; + + data->saved_en =3D readl(data->base + info->scpu_int_en_offset); + + writel(DISABLE_INTC, data->base + info->scpu_int_en_offset); + writel(CLEAN_INTC_STATUS, data->base + info->umsk_isr_offset); + writel(CLEAN_INTC_STATUS, data->base + info->isr_offset); + + return 0; +} + +static int realtek_intc_rtd1319d_resume(struct device *dev) +{ + struct realtek_intc_data *data =3D dev_get_drvdata(dev); + const struct realtek_intc_info *info =3D data->info; + + writel(CLEAN_INTC_STATUS, data->base + info->umsk_isr_offset); + writel(CLEAN_INTC_STATUS, data->base + info->isr_offset); + writel(data->saved_en, data->base + info->scpu_int_en_offset); + + return 0; +} + +static const struct dev_pm_ops realtek_intc_rtd1319d_pm_ops =3D { + .suspend_noirq =3D realtek_intc_rtd1319d_suspend, + .resume_noirq =3D realtek_intc_rtd1319d_resume, +}; + +static int rtd1319d_intc_probe(struct platform_device *pdev) +{ + const struct realtek_intc_info *info; + + info =3D of_device_get_match_data(&pdev->dev); + if (!info) + return -EINVAL; + + return realtek_intc_probe(pdev, info); +} + +static struct platform_driver realtek_intc_rtd1319d_driver =3D { + .probe =3D rtd1319d_intc_probe, + .driver =3D { + .name =3D "realtek_intc_rtd1319d", + .of_match_table =3D realtek_intc_rtd1319d_dt_matches, + .suppress_bind_attrs =3D true, + .pm =3D &realtek_intc_rtd1319d_pm_ops, + }, +}; + +static int __init realtek_intc_rtd1319d_init(void) +{ + return platform_driver_register(&realtek_intc_rtd1319d_driver); +} +core_initcall(realtek_intc_rtd1319d_init); + +static void __exit realtek_intc_rtd1319d_exit(void) +{ + platform_driver_unregister(&realtek_intc_rtd1319d_driver); +} +module_exit(realtek_intc_rtd1319d_exit); + +MODULE_LICENSE("GPL"); +MODULE_DESCRIPTION("Realtek RTD1319D Interrupt Controller Driver"); --=20 2.25.1